René's URL Explorer Experiment


Title: bpo-40334: Correctly generate C parser when assigned var is None by isidentical · Pull Request #20296 · python/cpython · GitHub

Open Graph Title: bpo-40334: Correctly generate C parser when assigned var is None by isidentical · Pull Request #20296 · python/cpython

X Title: bpo-40334: Correctly generate C parser when assigned var is None by isidentical · Pull Request #20296 · python/cpython

Description: When there are 2 negative lookaheads in a same rule, let's say !"(" blabla "," !")", there will the 2 FunctionCall's where assigned value is None. Currently when the add_var is called the first one will be ignored (since it will be returned as same from dedupe because there aren't any None named variables in locals, but when the second lookahead's var is sent to dedupe it will be returned as None_1 and this wont be ignored by the declaration generator in the visit_Alt. This patch adds an explicit check to add_var to distinguish whether if there is a variable or not. https://bugs.python.org/issue40334

Open Graph Description: When there are 2 negative lookaheads in a same rule, let's say !"(" blabla "," !")", there will the 2 FunctionCall's where assigned value is None. Currently wh...

X Description: When there are 2 negative lookaheads in a same rule, let's say !"(" blabla "," !")", there will the 2 FunctionCall's where assi...

Opengraph URL: https://github.com/python/cpython/pull/20296

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cfef041c-f280-c563-9842-1d387e334478
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5E8:2CBE2A:1A42F87:24C3018:696A504B
html-safe-noncec8f9e35709fedaff563e418c91e175d2c5193e35f46e02fa486c02b0e4a3afb1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUU4OjJDQkUyQToxQTQyRjg3OjI0QzMwMTg6Njk2QTUwNEIiLCJ2aXNpdG9yX2lkIjoiOTA5MDI3NDYyNzA3MjcwODY4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca9a6ca07776ab255b98756a5dafa10d78eeba831a0cdc6dc44b0d7e336758b70
hovercard-subject-tagpull_request:421518466
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20296/files
twitter:imagehttps://avatars.githubusercontent.com/u/47358913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/47358913?s=400&v=4
og:image:altWhen there are 2 negative lookaheads in a same rule, let's say !"(" blabla "," !")", there will the 2 FunctionCall's where assigned value is None. Currently wh...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20296/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20296%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20296%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20296/files
Reloadhttps://github.com/python/cpython/pull/20296/files
Reloadhttps://github.com/python/cpython/pull/20296/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20296/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20296/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
isidentical:bpo-40334-multiple-lookaheadhttps://github.com/isidentical/cpython/tree/bpo-40334-multiple-lookahead
Conversation 13 https://github.com/python/cpython/pull/20296
Commits 3 https://github.com/python/cpython/pull/20296/commits
Checks 0 https://github.com/python/cpython/pull/20296/checks
Files changed https://github.com/python/cpython/pull/20296/files
Please reload this pagehttps://github.com/python/cpython/pull/20296/files
bpo-40334: Correctly generate C parser when assigned var is None https://github.com/python/cpython/pull/20296/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/20296/files
91c1bfe bpo-40334: Correctly generate C parser when assigned var is None isidentical May 21, 2020 https://github.com/python/cpython/pull/20296/commits/91c1bfe26515ef859ac7aa5f0f8f8f433ecf913a
5440280 add test isidentical May 21, 2020 https://github.com/python/cpython/pull/20296/commits/54402805c2e1ff5dc3cc98c90f06563fd54a2247
41dfb6f Revert "add test" isidentical May 21, 2020 https://github.com/python/cpython/pull/20296/commits/41dfb6f424d64e411c424a710a49dc6bb5e3326a
Clear filters https://github.com/python/cpython/pull/20296/files
Please reload this pagehttps://github.com/python/cpython/pull/20296/files
Please reload this pagehttps://github.com/python/cpython/pull/20296/files
Tools/peg_generator/pegen/c_generator.pyhttps://github.com/python/cpython/pull/20296/files#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0
View file https://github.com/isidentical/cpython/blob/41dfb6f424d64e411c424a710a49dc6bb5e3326a/Tools/peg_generator/pegen/c_generator.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20296/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20296/files#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.