René's URL Explorer Experiment


Title: bpo-40334: Produce better error messages for non-parenthesized genexps by lysnikolaou · Pull Request #20153 · python/cpython · GitHub

Open Graph Title: bpo-40334: Produce better error messages for non-parenthesized genexps by lysnikolaou · Pull Request #20153 · python/cpython

X Title: bpo-40334: Produce better error messages for non-parenthesized genexps by lysnikolaou · Pull Request #20153 · python/cpython

Description: The error message, generated for non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the first argument in the call. Now, even on inputs like f(a, b, c for c in d, e), the correct error message gets produced. PS Last one with this bpo number. Promise! https://bugs.python.org/issue40334

Open Graph Description: The error message, generated for non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the first argu...

X Description: The error message, generated for non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the first ...

Opengraph URL: https://github.com/python/cpython/pull/20153

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0404b4e3-50ca-4175-d565-0b203331c03b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8B8:6F7C:1896A6:201D00:696B3509
html-safe-nonced9fe5f14e3585a9f82d1fdb07e37d578fa448d9c66a9539ddde8a8eb0256ebcd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEI4OjZGN0M6MTg5NkE2OjIwMUQwMDo2OTZCMzUwOSIsInZpc2l0b3JfaWQiOiI3NTI3ODg0NDUyNDMyMzkzNDgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac89825ee1702fd789cd4a2e662b30437f03074765ba18dbe49f202b0fc71403f7
hovercard-subject-tagpull_request:419129479
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20153/files
twitter:imagehttps://avatars.githubusercontent.com/u/20306270?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20306270?s=400&v=4
og:image:altThe error message, generated for non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the first argu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20153/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20153%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20153%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20153/files
Reloadhttps://github.com/python/cpython/pull/20153/files
Reloadhttps://github.com/python/cpython/pull/20153/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20153/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20153/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
lysnikolaou:nonparen-genxphttps://github.com/lysnikolaou/cpython/tree/nonparen-genxp
Conversation 9 https://github.com/python/cpython/pull/20153
Commits 5 https://github.com/python/cpython/pull/20153/commits
Checks 0 https://github.com/python/cpython/pull/20153/checks
Files changed https://github.com/python/cpython/pull/20153/files
Please reload this pagehttps://github.com/python/cpython/pull/20153/files
bpo-40334: Produce better error messages for non-parenthesized genexps https://github.com/python/cpython/pull/20153/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/20153/files
b049755 bpo-40334: Produce better error messages for non-parenthesized genexps lysnikolaou May 17, 2020 https://github.com/python/cpython/pull/20153/commits/b0497554d873fc80372a67ecf620a808eae8520a
c545e5f Fix RAISE_SYNTAX_ERROR_KNOWN_LOCATION macro lysnikolaou May 17, 2020 https://github.com/python/cpython/pull/20153/commits/c545e5f6c691f317f4b54d08348e4a423ca75c20
9b8b22d Fix bug lysnikolaou May 17, 2020 https://github.com/python/cpython/pull/20153/commits/9b8b22ddbeedbbd663e1066f0bc24c12d86191c8
ed64876 Generate correct error message for generator expression following lysnikolaou May 18, 2020 https://github.com/python/cpython/pull/20153/commits/ed6487671ea081799142e4b9abf4f70c502440c4
4c888e7 Merge branch 'master' into nonparen-genxp lysnikolaou May 18, 2020 https://github.com/python/cpython/pull/20153/commits/4c888e7f632bdf8f63d160c4a59372df42d389bb
Clear filters https://github.com/python/cpython/pull/20153/files
Please reload this pagehttps://github.com/python/cpython/pull/20153/files
Please reload this pagehttps://github.com/python/cpython/pull/20153/files
python.gram https://github.com/python/cpython/pull/20153/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
test_syntax.py https://github.com/python/cpython/pull/20153/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
parse.c https://github.com/python/cpython/pull/20153/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
pegen.c https://github.com/python/cpython/pull/20153/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
pegen.h https://github.com/python/cpython/pull/20153/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Grammar/python.gramhttps://github.com/python/cpython/pull/20153/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
View file https://github.com/lysnikolaou/cpython/blob/4c888e7f632bdf8f63d160c4a59372df42d389bb/Grammar/python.gram
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20153/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20153/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/20153/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
Lib/test/test_syntax.pyhttps://github.com/python/cpython/pull/20153/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
View file https://github.com/lysnikolaou/cpython/blob/4c888e7f632bdf8f63d160c4a59372df42d389bb/Lib/test/test_syntax.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20153/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20153/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/pull/20153/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
Parser/pegen/parse.chttps://github.com/python/cpython/pull/20153/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
View file https://github.com/lysnikolaou/cpython/blob/4c888e7f632bdf8f63d160c4a59372df42d389bb/Parser/pegen/parse.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20153/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20153/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/pull/20153/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/pull/20153/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/pull/20153/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/20153/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
View file https://github.com/lysnikolaou/cpython/blob/4c888e7f632bdf8f63d160c4a59372df42d389bb/Parser/pegen/pegen.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20153/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20153/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/20153/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
View file https://github.com/lysnikolaou/cpython/blob/4c888e7f632bdf8f63d160c4a59372df42d389bb/Parser/pegen/pegen.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20153/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20153/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/20153/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/20153/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/20153/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.