| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:32907de7-2980-80c3-9ec2-d400b20fe7c8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AEFE:29E881:355196:4A1EDF:696A44DB |
| html-safe-nonce | 2fdf01a88e883d36ef93f077cdfd537f3479873f313f84dfbd141eb78b68a763 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUZFOjI5RTg4MTozNTUxOTY6NEExRURGOjY5NkE0NERCIiwidmlzaXRvcl9pZCI6IjM3ODc1NDE0NzAzNjkxNzA2NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 02b0819b6ad809c7e793faae6b5d98d7c3473f97e3961718b8369e0a63da6846 |
| hovercard-subject-tag | pull_request:418580480 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/20106/files |
| twitter:image | https://avatars.githubusercontent.com/u/20306270?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/20306270?s=400&v=4 |
| og:image:alt | The following error messages get produced:
cannot delete ... for invalid del targets
cannot assign to ... for invalid targets in for and with
statements
Additionally a few cuts were added in vari... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/20106/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20106%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20106%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/20106/files |
| Reload | https://github.com/python/cpython/pull/20106/files |
| Reload | https://github.com/python/cpython/pull/20106/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/20106/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/20106/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| pablogsal | https://github.com/pablogsal |
| python:master | https://github.com/python/cpython/tree/master |
| lysnikolaou:targets-errors | https://github.com/lysnikolaou/cpython/tree/targets-errors |
|
Conversation
42
| https://github.com/python/cpython/pull/20106 |
|
Commits
24
| https://github.com/python/cpython/pull/20106/commits |
|
Checks
0
| https://github.com/python/cpython/pull/20106/checks |
|
Files changed
| https://github.com/python/cpython/pull/20106/files |
| Please reload this page | https://github.com/python/cpython/pull/20106/files |
|
bpo-40334: Produce better error messages on invalid targets
| https://github.com/python/cpython/pull/20106/files#top |
|
Show all changes
24 commits
| https://github.com/python/cpython/pull/20106/files |
|
0dfaa22
bpo-40334: Produce better error messages on invalid targets
lysnikolaou May 15, 2020
| https://github.com/python/cpython/pull/20106/commits/0dfaa2252cfa9794bebd8bb5c48aadf783795a73 |
|
d4a9dd6
Fix test_exceptions
lysnikolaou May 15, 2020
| https://github.com/python/cpython/pull/20106/commits/d4a9dd681fe5f298807734667cc490d5007debff |
|
72a1339
📜🤖 Added by blurb_it.
blurb-it[bot] May 15, 2020
| https://github.com/python/cpython/pull/20106/commits/72a133922009f2f79a9c7f8e4543a452ec1d9d1d |
|
1b6cf0b
Produce the same error messages with the old parser for with and for …
lysnikolaou May 15, 2020
| https://github.com/python/cpython/pull/20106/commits/1b6cf0b327f024dc53ab548bbfb2bca55064c31c |
|
1ad3819
Add invalid_group rule
lysnikolaou May 15, 2020
| https://github.com/python/cpython/pull/20106/commits/1ad3819b21c8b29a1203eb11332b293bb2467067 |
|
6f30315
Update Grammar/python.gram
lysnikolaou May 16, 2020
| https://github.com/python/cpython/pull/20106/commits/6f30315741e04ad672e126fcd6366a6e81f4d2df |
|
f750aba
Update Parser/pegen/pegen.c
lysnikolaou May 16, 2020
| https://github.com/python/cpython/pull/20106/commits/f750aba1aee1a32c7000e7bac761dbbc468a5750 |
|
132178f
Address Guido's feedback
lysnikolaou May 16, 2020
| https://github.com/python/cpython/pull/20106/commits/132178ffe1308ddc78431e529863a91d7da7058e |
|
17cc4bc
Inline _PyPegen_get_invalid_for_target
lysnikolaou May 17, 2020
| https://github.com/python/cpython/pull/20106/commits/17cc4bcd2827897b6408cd7613a1fb3898bda6a2 |
|
def0f3d
Revert inlining
lysnikolaou May 17, 2020
| https://github.com/python/cpython/pull/20106/commits/def0f3d7aee446785d773aac566921464d76b9e4 |
|
ee3524b
Merge remote-tracking branch 'upstream/master' into targets-errors
pablogsal May 17, 2020
| https://github.com/python/cpython/pull/20106/commits/ee3524b5bbf8efbb21ce767bb70e5447f5b39fab |
|
4959a12
Fix searching for invalid for targets, by visiting Compare nodes in _…
lysnikolaou May 17, 2020
| https://github.com/python/cpython/pull/20106/commits/4959a12d71c95f23451c18c8ce235a96e203729d |
|
dd1d8c8
Call RAISE_SYNTAX_ERROR instead of returning NULL, when no invalid fo…
lysnikolaou May 17, 2020
| https://github.com/python/cpython/pull/20106/commits/dd1d8c82d318e5d98978324c49fcbfb85cbcf0c2 |
|
24d63fb
Merge branch 'master' into targets-errors
lysnikolaou May 18, 2020
| https://github.com/python/cpython/pull/20106/commits/24d63fb4148a0b30298d032f208aba44ee65aada |
|
c1cf8e6
Replace is_del and is_for args with an enum
lysnikolaou May 18, 2020
| https://github.com/python/cpython/pull/20106/commits/c1cf8e63562999fe2ad8fac6a327e04c49f17aef |
|
06798ff
Only return an invalid target, when the comparison is an In comparison
lysnikolaou May 20, 2020
| https://github.com/python/cpython/pull/20106/commits/06798ff0df60a912781be56a008b390409db9724 |
|
ef7fe3a
Fix bug
lysnikolaou May 20, 2020
| https://github.com/python/cpython/pull/20106/commits/ef7fe3afb4d922e02e87d9a41e8e1d4d76815a35 |
|
efabcc9
Merge branch 'master' into targets-errors
lysnikolaou May 23, 2020
| https://github.com/python/cpython/pull/20106/commits/efabcc9164954067406e23b9be4708f3a828ee4a |
|
6d41c55
Merge branch 'master' into targets-errors
lysnikolaou May 26, 2020
| https://github.com/python/cpython/pull/20106/commits/6d41c5582d3dfca82de1008ab67e3982c821a4b7 |
|
82486c1
Minor refactoring
lysnikolaou May 26, 2020
| https://github.com/python/cpython/pull/20106/commits/82486c1ca9618075ea0dfa65e034fb09997590c1 |
|
705d55b
Merge branch 'master' into targets-errors
lysnikolaou Jun 10, 2020
| https://github.com/python/cpython/pull/20106/commits/705d55b98453792138a9748fa1da763dfcfc7656 |
|
f0f934d
Merge branch 'master' into targets-errors
lysnikolaou Jun 10, 2020
| https://github.com/python/cpython/pull/20106/commits/f0f934dc1a47166bd2b6810a2bb0db0d0d70bfda |
|
ede107e
Merge branch 'master' into targets-errors
lysnikolaou Jun 18, 2020
| https://github.com/python/cpython/pull/20106/commits/ede107e1faa4a75fae477af10074931c061cff11 |
|
55b5327
Add CHECK* checks to GET_INVALID_*TARGET macros
lysnikolaou Jun 18, 2020
| https://github.com/python/cpython/pull/20106/commits/55b53270bf73e45d2ef1cf6fac8e652e137e2a9b |
|
Clear filters
| https://github.com/python/cpython/pull/20106/files |
| Please reload this page | https://github.com/python/cpython/pull/20106/files |
| Please reload this page | https://github.com/python/cpython/pull/20106/files |
|
python.gram
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
test_exceptions.py
| https://github.com/python/cpython/pull/20106/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
|
test_syntax.py
| https://github.com/python/cpython/pull/20106/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f |
|
parser.c
| https://github.com/python/cpython/pull/20106/files#diff-6d39440cedc67d1ce7a0586bfb6ecb8483803448a9c93f3fae3ad0e2260e29f7 |
|
pegen.c
| https://github.com/python/cpython/pull/20106/files#diff-ec9a9d08c5b1d518997db0f5b4795c528a41efc35507d6c2a384eee43f047cb7 |
|
pegen.h
| https://github.com/python/cpython/pull/20106/files#diff-5803bf7cd8fdced0a7448e74074f36018f2206ab77ad13dc7451b1948b950852 |
| Grammar/python.gram | https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
View file
| https://github.com/lysnikolaou/cpython/blob/55b53270bf73e45d2ef1cf6fac8e652e137e2a9b/Grammar/python.gram |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/20106/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
| Please reload this page | https://github.com/python/cpython/pull/20106/files |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
|
| https://github.com/python/cpython/pull/20106/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b |
| Lib/test/test_exceptions.py | https://github.com/python/cpython/pull/20106/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
|
View file
| https://github.com/lysnikolaou/cpython/blob/55b53270bf73e45d2ef1cf6fac8e652e137e2a9b/Lib/test/test_exceptions.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/20106/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/20106/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
|
| https://github.com/python/cpython/pull/20106/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
| Lib/test/test_syntax.py | https://github.com/python/cpython/pull/20106/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f |
|
View file
| https://github.com/lysnikolaou/cpython/blob/55b53270bf73e45d2ef1cf6fac8e652e137e2a9b/Lib/test/test_syntax.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/20106/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/20106/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f |
|
| https://github.com/python/cpython/pull/20106/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f |
|
| https://github.com/python/cpython/pull/20106/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f |
|
| https://github.com/python/cpython/pull/20106/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f |
| Please reload this page | https://github.com/python/cpython/pull/20106/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |