René's URL Explorer Experiment


Title: bpo-40334: Produce better error messages on invalid targets by lysnikolaou · Pull Request #20106 · python/cpython · GitHub

Open Graph Title: bpo-40334: Produce better error messages on invalid targets by lysnikolaou · Pull Request #20106 · python/cpython

X Title: bpo-40334: Produce better error messages on invalid targets by lysnikolaou · Pull Request #20106 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The following error messages get produced: cannot delete ... for invalid del targets cannot assign to ... for invalid targets in for and with statements Additionally a few cuts were added in vari...

X Description: The following error messages get produced: cannot delete ... for invalid del targets cannot assign to ... for invalid targets in for and with statements Additionally a few cuts were added in vari...

Opengraph URL: https://github.com/python/cpython/pull/20106

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:3c10b6c6-cf11-b18d-7224-21943a9cedb5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCF6:20C85F:7AC9BF:A7199F:6969DC47
html-safe-nonce69157fbc22dd2152a48d893c343d2577d820716f8be2aaa6c13ef110a7a2e2dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0Y2OjIwQzg1Rjo3QUM5QkY6QTcxOTlGOjY5NjlEQzQ3IiwidmlzaXRvcl9pZCI6IjE5MzM1MjI3NzU4MTIyMDE1NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac25e78b968e25c402bf96de3e900dd52a6ce17731141f49a35676bf2e9e892358
hovercard-subject-tagpull_request:418580480
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20106/commits
twitter:imagehttps://opengraph.githubassets.com/35258a890054872ece7f61d1fef4dd9ad5ccbdd04447474abfa1d45e18b2f214/python/cpython/pull/20106
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/35258a890054872ece7f61d1fef4dd9ad5ccbdd04447474abfa1d45e18b2f214/python/cpython/pull/20106
og:image:altThe following error messages get produced: cannot delete ... for invalid del targets cannot assign to ... for invalid targets in for and with statements Additionally a few cuts were added in vari...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelysnikolaou
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20106/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20106%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20106%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20106/commits
Reloadhttps://github.com/python/cpython/pull/20106/commits
Reloadhttps://github.com/python/cpython/pull/20106/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20106/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20106/commits
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
lysnikolaou:targets-errorshttps://github.com/lysnikolaou/cpython/tree/targets-errors
Conversationhttps://github.com/python/cpython/pull/20106
Commits24 (24)https://github.com/python/cpython/pull/20106/commits
Checkshttps://github.com/python/cpython/pull/20106/checks
Files changedhttps://github.com/python/cpython/pull/20106/files
bpo-40334: Produce better error messages on invalid targetshttps://github.com/python/cpython/pull/20106/commits#top
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
lysnikolaou:targets-errorshttps://github.com/lysnikolaou/cpython/tree/targets-errors
bpo-40334: Produce better error messages on invalid targetshttps://github.com/python/cpython/pull/20106/commits/0dfaa2252cfa9794bebd8bb5c48aadf783795a73
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
0dfaa22https://github.com/python/cpython/pull/20106/commits/0dfaa2252cfa9794bebd8bb5c48aadf783795a73
https://github.com/python/cpython/tree/0dfaa2252cfa9794bebd8bb5c48aadf783795a73
Fix test_exceptionshttps://github.com/python/cpython/pull/20106/commits/d4a9dd681fe5f298807734667cc490d5007debff
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
d4a9dd6https://github.com/python/cpython/pull/20106/commits/d4a9dd681fe5f298807734667cc490d5007debff
https://github.com/python/cpython/tree/d4a9dd681fe5f298807734667cc490d5007debff
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/20106/commits/72a133922009f2f79a9c7f8e4543a452ec1d9d1d
https://github.com/apps/blurb-it
blurb-it[bot]https://github.com/python/cpython/commits?author=blurb-it%5Bbot%5D
72a1339https://github.com/python/cpython/pull/20106/commits/72a133922009f2f79a9c7f8e4543a452ec1d9d1d
https://github.com/python/cpython/tree/72a133922009f2f79a9c7f8e4543a452ec1d9d1d
Produce the same error messages with the old parser for with and for targetshttps://github.com/python/cpython/pull/20106/commits/1b6cf0b327f024dc53ab548bbfb2bca55064c31c
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
1b6cf0bhttps://github.com/python/cpython/pull/20106/commits/1b6cf0b327f024dc53ab548bbfb2bca55064c31c
https://github.com/python/cpython/tree/1b6cf0b327f024dc53ab548bbfb2bca55064c31c
Add invalid_group rulehttps://github.com/python/cpython/pull/20106/commits/1ad3819b21c8b29a1203eb11332b293bb2467067
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
1ad3819https://github.com/python/cpython/pull/20106/commits/1ad3819b21c8b29a1203eb11332b293bb2467067
https://github.com/python/cpython/tree/1ad3819b21c8b29a1203eb11332b293bb2467067
Update Grammar/python.gramhttps://github.com/python/cpython/pull/20106/commits/6f30315741e04ad672e126fcd6366a6e81f4d2df
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
6f30315https://github.com/python/cpython/pull/20106/commits/6f30315741e04ad672e126fcd6366a6e81f4d2df
https://github.com/python/cpython/tree/6f30315741e04ad672e126fcd6366a6e81f4d2df
Update Parser/pegen/pegen.chttps://github.com/python/cpython/pull/20106/commits/f750aba1aee1a32c7000e7bac761dbbc468a5750
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
f750abahttps://github.com/python/cpython/pull/20106/commits/f750aba1aee1a32c7000e7bac761dbbc468a5750
https://github.com/python/cpython/tree/f750aba1aee1a32c7000e7bac761dbbc468a5750
Address Guido's feedbackhttps://github.com/python/cpython/pull/20106/commits/132178ffe1308ddc78431e529863a91d7da7058e
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
132178fhttps://github.com/python/cpython/pull/20106/commits/132178ffe1308ddc78431e529863a91d7da7058e
https://github.com/python/cpython/tree/132178ffe1308ddc78431e529863a91d7da7058e
Inline _PyPegen_get_invalid_for_targethttps://github.com/python/cpython/pull/20106/commits/17cc4bcd2827897b6408cd7613a1fb3898bda6a2
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
17cc4bchttps://github.com/python/cpython/pull/20106/commits/17cc4bcd2827897b6408cd7613a1fb3898bda6a2
https://github.com/python/cpython/tree/17cc4bcd2827897b6408cd7613a1fb3898bda6a2
Revert inlininghttps://github.com/python/cpython/pull/20106/commits/def0f3d7aee446785d773aac566921464d76b9e4
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
def0f3dhttps://github.com/python/cpython/pull/20106/commits/def0f3d7aee446785d773aac566921464d76b9e4
https://github.com/python/cpython/tree/def0f3d7aee446785d773aac566921464d76b9e4
Merge remote-tracking branch 'upstream/master' into targets-errorshttps://github.com/python/cpython/pull/20106/commits/ee3524b5bbf8efbb21ce767bb70e5447f5b39fab
https://github.com/pablogsal
pablogsalhttps://github.com/python/cpython/commits?author=pablogsal
ee3524bhttps://github.com/python/cpython/pull/20106/commits/ee3524b5bbf8efbb21ce767bb70e5447f5b39fab
https://github.com/python/cpython/tree/ee3524b5bbf8efbb21ce767bb70e5447f5b39fab
Fix searching for invalid for targets, by visiting Compare nodes in _PyPegen_get_invalid_targethttps://github.com/python/cpython/pull/20106/commits/4959a12d71c95f23451c18c8ce235a96e203729d
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
4959a12https://github.com/python/cpython/pull/20106/commits/4959a12d71c95f23451c18c8ce235a96e203729d
https://github.com/python/cpython/tree/4959a12d71c95f23451c18c8ce235a96e203729d
Call RAISE_SYNTAX_ERROR instead of returning NULL, when no invalid for target was foundhttps://github.com/python/cpython/pull/20106/commits/dd1d8c82d318e5d98978324c49fcbfb85cbcf0c2
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
dd1d8c8https://github.com/python/cpython/pull/20106/commits/dd1d8c82d318e5d98978324c49fcbfb85cbcf0c2
https://github.com/python/cpython/tree/dd1d8c82d318e5d98978324c49fcbfb85cbcf0c2
Merge branch 'master' into targets-errorshttps://github.com/python/cpython/pull/20106/commits/24d63fb4148a0b30298d032f208aba44ee65aada
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
24d63fbhttps://github.com/python/cpython/pull/20106/commits/24d63fb4148a0b30298d032f208aba44ee65aada
https://github.com/python/cpython/tree/24d63fb4148a0b30298d032f208aba44ee65aada
Replace is_del and is_for args with an enumhttps://github.com/python/cpython/pull/20106/commits/c1cf8e63562999fe2ad8fac6a327e04c49f17aef
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
c1cf8e6https://github.com/python/cpython/pull/20106/commits/c1cf8e63562999fe2ad8fac6a327e04c49f17aef
https://github.com/python/cpython/tree/c1cf8e63562999fe2ad8fac6a327e04c49f17aef
Only return an invalid target, when the comparison is an In comparisonhttps://github.com/python/cpython/pull/20106/commits/06798ff0df60a912781be56a008b390409db9724
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
06798ffhttps://github.com/python/cpython/pull/20106/commits/06798ff0df60a912781be56a008b390409db9724
https://github.com/python/cpython/tree/06798ff0df60a912781be56a008b390409db9724
Fix bughttps://github.com/python/cpython/pull/20106/commits/ef7fe3afb4d922e02e87d9a41e8e1d4d76815a35
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
ef7fe3ahttps://github.com/python/cpython/pull/20106/commits/ef7fe3afb4d922e02e87d9a41e8e1d4d76815a35
https://github.com/python/cpython/tree/ef7fe3afb4d922e02e87d9a41e8e1d4d76815a35
Merge branch 'master' into targets-errorshttps://github.com/python/cpython/pull/20106/commits/efabcc9164954067406e23b9be4708f3a828ee4a
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
efabcc9https://github.com/python/cpython/pull/20106/commits/efabcc9164954067406e23b9be4708f3a828ee4a
https://github.com/python/cpython/tree/efabcc9164954067406e23b9be4708f3a828ee4a
Merge branch 'master' into targets-errorshttps://github.com/python/cpython/pull/20106/commits/6d41c5582d3dfca82de1008ab67e3982c821a4b7
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
6d41c55https://github.com/python/cpython/pull/20106/commits/6d41c5582d3dfca82de1008ab67e3982c821a4b7
https://github.com/python/cpython/tree/6d41c5582d3dfca82de1008ab67e3982c821a4b7
Minor refactoringhttps://github.com/python/cpython/pull/20106/commits/82486c1ca9618075ea0dfa65e034fb09997590c1
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
82486c1https://github.com/python/cpython/pull/20106/commits/82486c1ca9618075ea0dfa65e034fb09997590c1
https://github.com/python/cpython/tree/82486c1ca9618075ea0dfa65e034fb09997590c1
Merge branch 'master' into targets-errorshttps://github.com/python/cpython/pull/20106/commits/705d55b98453792138a9748fa1da763dfcfc7656
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
705d55bhttps://github.com/python/cpython/pull/20106/commits/705d55b98453792138a9748fa1da763dfcfc7656
https://github.com/python/cpython/tree/705d55b98453792138a9748fa1da763dfcfc7656
Merge branch 'master' into targets-errorshttps://github.com/python/cpython/pull/20106/commits/f0f934dc1a47166bd2b6810a2bb0db0d0d70bfda
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
f0f934dhttps://github.com/python/cpython/pull/20106/commits/f0f934dc1a47166bd2b6810a2bb0db0d0d70bfda
https://github.com/python/cpython/tree/f0f934dc1a47166bd2b6810a2bb0db0d0d70bfda
Merge branch 'master' into targets-errorshttps://github.com/python/cpython/pull/20106/commits/ede107e1faa4a75fae477af10074931c061cff11
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
ede107ehttps://github.com/python/cpython/pull/20106/commits/ede107e1faa4a75fae477af10074931c061cff11
https://github.com/python/cpython/tree/ede107e1faa4a75fae477af10074931c061cff11
Add CHECK* checks to GET_INVALID_*TARGET macroshttps://github.com/python/cpython/pull/20106/commits/55b53270bf73e45d2ef1cf6fac8e652e137e2a9b
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/python/cpython/commits?author=lysnikolaou
55b5327https://github.com/python/cpython/pull/20106/commits/55b53270bf73e45d2ef1cf6fac8e652e137e2a9b
https://github.com/python/cpython/tree/55b53270bf73e45d2ef1cf6fac8e652e137e2a9b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.