René's URL Explorer Experiment


Title: bpo-40334: Always show the caret on SyntaxErrors by lysnikolaou · Pull Request #20050 · python/cpython · GitHub

Open Graph Title: bpo-40334: Always show the caret on SyntaxErrors by lysnikolaou · Pull Request #20050 · python/cpython

X Title: bpo-40334: Always show the caret on SyntaxErrors by lysnikolaou · Pull Request #20050 · python/cpython

Description: This PR fixes SyntaxError locations, when the caret is not displayed, by doing the following: col_number always gets set to the location of the offending node/expr. Introduce a new function _PyPegen_raise_error_known_location, which can be called, when an arbitrary lineno/col_offset needs to be passed. This function then gets used in the grammar (through some new macros and inline functions) so that SyntaxError locations of the new parser match that of the old. Closes we-like-parsers#126. https://bugs.python.org/issue40334

Open Graph Description: This PR fixes SyntaxError locations, when the caret is not displayed, by doing the following: col_number always gets set to the location of the offending node/expr. Introduce a new function _PyPeg...

X Description: This PR fixes SyntaxError locations, when the caret is not displayed, by doing the following: col_number always gets set to the location of the offending node/expr. Introduce a new function _PyPeg...

Opengraph URL: https://github.com/python/cpython/pull/20050

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:126b6ab6-456b-cdc0-24d8-7cd1f66a85e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD408:23CB5E:48C647:670783:696A5023
html-safe-nonce3c1be81461619f15b2aead6a50a3331a1874a5ae625f4468851fc0d6cc50ad69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDA4OjIzQ0I1RTo0OEM2NDc6NjcwNzgzOjY5NkE1MDIzIiwidmlzaXRvcl9pZCI6IjE2OTUyMTkyODU2NDc1NzcxMjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac25fb6c5da7c02b8ae8d1007e72dc30f9b1108ce15053c5139e8d4a5b871fd020
hovercard-subject-tagpull_request:416432748
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20050/files
twitter:imagehttps://avatars.githubusercontent.com/u/20306270?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20306270?s=400&v=4
og:image:altThis PR fixes SyntaxError locations, when the caret is not displayed, by doing the following: col_number always gets set to the location of the offending node/expr. Introduce a new function _PyPeg...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20050/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20050%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20050%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20050/files
Reloadhttps://github.com/python/cpython/pull/20050/files
Reloadhttps://github.com/python/cpython/pull/20050/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20050/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20050/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
lysnikolaou:syntaxerror-col-offsethttps://github.com/lysnikolaou/cpython/tree/syntaxerror-col-offset
Conversation 14 https://github.com/python/cpython/pull/20050
Commits 3 https://github.com/python/cpython/pull/20050/commits
Checks 0 https://github.com/python/cpython/pull/20050/checks
Files changed https://github.com/python/cpython/pull/20050/files
Please reload this pagehttps://github.com/python/cpython/pull/20050/files
bpo-40334: Always show the caret on SyntaxErrors https://github.com/python/cpython/pull/20050/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/20050/files
5bbd43e bpo-40334: Fix SyntaxError locations when the caret is not displayed lysnikolaou May 12, 2020 https://github.com/python/cpython/pull/20050/commits/5bbd43ef43e756c9bb936815b64d254e896b99b6
60b761a Fix test_cmd_line_script; caret is always displayed on file input lysnikolaou May 12, 2020 https://github.com/python/cpython/pull/20050/commits/60b761a4953afc07b5527c5f8dc6327ab95bb426
929175f Address feedback and always display the caret lysnikolaou May 12, 2020 https://github.com/python/cpython/pull/20050/commits/929175fc5339095e7fb65fb1429e200a382a2696
Clear filters https://github.com/python/cpython/pull/20050/files
Please reload this pagehttps://github.com/python/cpython/pull/20050/files
Please reload this pagehttps://github.com/python/cpython/pull/20050/files
python.gram https://github.com/python/cpython/pull/20050/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
test_exceptions.py https://github.com/python/cpython/pull/20050/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
parse.c https://github.com/python/cpython/pull/20050/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
pegen.c https://github.com/python/cpython/pull/20050/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
pegen.h https://github.com/python/cpython/pull/20050/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Grammar/python.gramhttps://github.com/python/cpython/pull/20050/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
View file https://github.com/lysnikolaou/cpython/blob/929175fc5339095e7fb65fb1429e200a382a2696/Grammar/python.gram
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20050/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20050/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/20050/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
Lib/test/test_exceptions.pyhttps://github.com/python/cpython/pull/20050/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
View file https://github.com/lysnikolaou/cpython/blob/929175fc5339095e7fb65fb1429e200a382a2696/Lib/test/test_exceptions.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20050/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20050/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
https://github.com/python/cpython/pull/20050/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
Please reload this pagehttps://github.com/python/cpython/pull/20050/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.