| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8deec1ee-2b0a-2646-9175-dd08b3019feb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B76C:AF3E4:3501BA:46F252:6A5B2394 |
| html-safe-nonce | 77af6c5e83f9c824b4e20ae991eb1faa172655d3c0048c9eed1792ee22f59e47 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzZDOkFGM0U0OjM1MDFCQTo0NkYyNTI6NkE1QjIzOTQiLCJ2aXNpdG9yX2lkIjoiMTA4MTU1NTE3MDE1OTY5ODgzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2dede5b03daea26ba48770ddcc05c37b2bbb35851e696434babb591b07794725 |
| hovercard-subject-tag | pull_request:414704523 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19979/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c1e75373b0ae4ee1d18ab80619f0e7a2f1d5b1bbfdebbda773ee23aee59c5d7f/python/cpython/pull/19979 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c1e75373b0ae4ee1d18ab80619f0e7a2f1d5b1bbfdebbda773ee23aee59c5d7f/python/cpython/pull/19979 |
| og:image:alt | This adds a msg argument to Future.cancel() and Task.cancel().
(The C implementation is currently working and tests are added, but I still need to do the pure Python implementation.)
https://bugs.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjerdonek |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/19979#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19979 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19979 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/19979 |
| Reload | https://github.com/python/cpython/pull/19979 |
| Reload | https://github.com/python/cpython/pull/19979 |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| cjerdonek | https://github.com/cjerdonek |
| python:master | https://github.com/python/cpython/tree/master |
| cjerdonek:issue-31033-cancel-msg | https://github.com/cjerdonek/cpython/tree/issue-31033-cancel-msg |
| Conversation | https://github.com/python/cpython/pull/19979 |
| Commits8 (8) | https://github.com/python/cpython/pull/19979/commits |
| Checks | https://github.com/python/cpython/pull/19979/checks |
| Files changed | https://github.com/python/cpython/pull/19979/files |
| bpo-31033: Add a msg argument to Future.cancel() and Task.cancel() | https://github.com/python/cpython/pull/19979#top |
| cjerdonek | https://github.com/cjerdonek |
| python:master | https://github.com/python/cpython/tree/master |
| cjerdonek:issue-31033-cancel-msg | https://github.com/cjerdonek/cpython/tree/issue-31033-cancel-msg |
|
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| May 7, 2020 | https://github.com/python/cpython/pull/19979#issue-614079556 |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
| https://bugs.python.org/issue31033 | https://bugs.python.org/issue31033 |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| 1st1 | https://github.com/1st1 |
| asvetlov | https://github.com/asvetlov |
| code owners | https://github.com/python/cpython/blob/8963a7f1f84a05412178b56629508b660d38861b/.github/CODEOWNERS#L8 |
| May 7, 2020 13:57 | https://github.com/python/cpython/pull/19979#event-3313025356 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| May 7, 2020 | https://github.com/python/cpython/pull/19979#event-3313025566 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 7, 2020 | https://github.com/python/cpython/pull/19979#event-3313025759 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| force-pushed | https://github.com/python/cpython/compare/67ba96fa906118d4840a02044fdbb3dd93aeb6ea..de9f8b1c74f47138ffe20a52fbd113d41d197659 |
| 67ba96f | https://github.com/python/cpython/commit/67ba96fa906118d4840a02044fdbb3dd93aeb6ea |
| de9f8b1 | https://github.com/python/cpython/commit/de9f8b1c74f47138ffe20a52fbd113d41d197659 |
|
Compare
| https://github.com/python/cpython/compare/67ba96fa906118d4840a02044fdbb3dd93aeb6ea..de9f8b1c74f47138ffe20a52fbd113d41d197659 |
| May 7, 2020 20:38 | https://github.com/python/cpython/pull/19979#event-3314572889 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| May 7, 2020 | https://github.com/python/cpython/pull/19979#event-3314579206 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| force-pushed | https://github.com/python/cpython/compare/ff02c76255c239885ce3861749b1c78fc6e43fe6..6a21d746659d76a72036e56a2b8425787fa913ee |
| ff02c76 | https://github.com/python/cpython/commit/ff02c76255c239885ce3861749b1c78fc6e43fe6 |
| 6a21d74 | https://github.com/python/cpython/commit/6a21d746659d76a72036e56a2b8425787fa913ee |
|
Compare
| https://github.com/python/cpython/compare/ff02c76255c239885ce3861749b1c78fc6e43fe6..6a21d746659d76a72036e56a2b8425787fa913ee |
| May 8, 2020 12:43 | https://github.com/python/cpython/pull/19979#event-3316812727 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
|
May 13, 2020
| https://github.com/python/cpython/pull/19979#pullrequestreview-411216609 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19979/files |
| Lib/asyncio/futures.py | https://github.com/python/cpython/pull/19979/files#diff-1450afcb4b859bcfe9f8f7b73ca91c40ff470cbae484d81c5315b97c86b25653 |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
|
May 13, 2020
| https://github.com/python/cpython/pull/19979#ref-pullrequest-613235311 |
|
bpo-31033: Make traceback for cancelled asyncio tasks more useful
#19951
| https://github.com/python/cpython/pull/19951 |
| cjerdonek | https://github.com/cjerdonek |
| May 14, 2020 16:45 | https://github.com/python/cpython/pull/19979#commits-pushed-0ed5e4e |
|
| https://github.com/cjerdonek |
| Add argument clinic changes. | https://github.com/python/cpython/pull/19979/commits/0ed5e4eb5ba8aa504ae7b5962d4503b6106bf654 |
| 0ed5e4e | https://github.com/python/cpython/pull/19979/commits/0ed5e4eb5ba8aa504ae7b5962d4503b6106bf654 |
|
| https://github.com/cjerdonek |
| Add failing tests. | https://github.com/python/cpython/pull/19979/commits/5c8489f337225a066b057b18ce9b23b6c18d29aa |
| 5c8489f | https://github.com/python/cpython/pull/19979/commits/5c8489f337225a066b057b18ce9b23b6c18d29aa |
|
| https://github.com/cjerdonek |
| Add C implementation. | https://github.com/python/cpython/pull/19979/commits/58a2257bd925b858afa00047fd478780d6f2cbea |
| 58a2257 | https://github.com/python/cpython/pull/19979/commits/58a2257bd925b858afa00047fd478780d6f2cbea |
|
| https://github.com/cjerdonek |
| Add pure Python implementation. | https://github.com/python/cpython/pull/19979/commits/86e13df23403fc5cefbd36a8f39a9a32615f4d68 |
| 86e13df | https://github.com/python/cpython/pull/19979/commits/86e13df23403fc5cefbd36a8f39a9a32615f4d68 |
|
| https://github.com/cjerdonek |
| Add docs and NEWS entry. | https://github.com/python/cpython/pull/19979/commits/403baa28f49019a7c948a68f6d3882580f40dee5 |
| 403baa2 | https://github.com/python/cpython/pull/19979/commits/403baa28f49019a7c948a68f6d3882580f40dee5 |
|
| https://github.com/cjerdonek |
| Make None msg result in no arguments. | https://github.com/python/cpython/pull/19979/commits/6b133a2bc74d1211a7038b205d9d939a8c4e15c2 |
| 6b133a2 | https://github.com/python/cpython/pull/19979/commits/6b133a2bc74d1211a7038b205d9d939a8c4e15c2 |
|
| https://github.com/cjerdonek |
| Test the getter and setter. | https://github.com/python/cpython/pull/19979/commits/a0434c9c0cb22da504be23aa1402b3197d5f0d83 |
| a0434c9 | https://github.com/python/cpython/pull/19979/commits/a0434c9c0cb22da504be23aa1402b3197d5f0d83 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| force-pushed | https://github.com/python/cpython/compare/6a21d746659d76a72036e56a2b8425787fa913ee..50cf2a896940e47fc746f9c26403d9452e65e760 |
| 6a21d74 | https://github.com/python/cpython/commit/6a21d746659d76a72036e56a2b8425787fa913ee |
| 50cf2a8 | https://github.com/python/cpython/commit/50cf2a896940e47fc746f9c26403d9452e65e760 |
|
Compare
| https://github.com/python/cpython/compare/6a21d746659d76a72036e56a2b8425787fa913ee..50cf2a896940e47fc746f9c26403d9452e65e760 |
| May 15, 2020 00:46 | https://github.com/python/cpython/pull/19979#event-3338924970 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| May 15, 2020 | https://github.com/python/cpython/pull/19979#issuecomment-628970807 |
| @1st1 | https://github.com/1st1 |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| force-pushed | https://github.com/python/cpython/compare/50cf2a896940e47fc746f9c26403d9452e65e760..22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
| 50cf2a8 | https://github.com/python/cpython/commit/50cf2a896940e47fc746f9c26403d9452e65e760 |
| 22a54cc | https://github.com/python/cpython/commit/22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
|
Compare
| https://github.com/python/cpython/compare/50cf2a896940e47fc746f9c26403d9452e65e760..22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
| May 15, 2020 01:34 | https://github.com/python/cpython/pull/19979#event-3339004215 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| May 15, 2020 | https://github.com/python/cpython/pull/19979#issuecomment-628973819 |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
|
| https://github.com/cjerdonek |
| Remove the _create_cancelled_error() helper function. | https://github.com/python/cpython/pull/19979/commits/22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
| 22a54cc | https://github.com/python/cpython/pull/19979/commits/22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
|
May 15, 2020
| https://github.com/python/cpython/pull/19979#pullrequestreview-412942558 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19979/files/22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
| Modules/_asynciomodule.c | https://github.com/python/cpython/pull/19979/files/22a54cc448747b7e6d0ee57b5c4cc93d2aead540#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01 |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
|
May 15, 2020
| https://github.com/python/cpython/pull/19979#pullrequestreview-413004355 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19979/files/22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
| 1st1 | https://github.com/1st1 |
| https://github.com/python/cpython/pull/19979#pullrequestreview-413004355 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 15, 2020 | https://github.com/python/cpython/pull/19979#event-3342874684 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| May 15, 2020 | https://github.com/python/cpython/pull/19979#event-3342874689 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| 1ce5841 | https://github.com/python/cpython/commit/1ce5841eca6d96b1b1e8c213d04f2e92b1619bb5 |
| May 15, 2020 | https://github.com/python/cpython/pull/19979#event-3342994835 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| May 15, 2020 | https://github.com/python/cpython/pull/19979#event-3342994907 |
| https://github.com/cjerdonek |
| cjerdonek | https://github.com/cjerdonek |
| May 15, 2020 23:55 | https://github.com/python/cpython/pull/19979#event-3342994946 |
| arturoescaip | https://github.com/arturoescaip |
|
May 24, 2020
| https://github.com/python/cpython/pull/19979#ref-commit-7654bbb |
|
| https://github.com/cjerdonek |
|
| https://github.com/arturoescaip |
| bpo-31033: Add a msg argument to Future.cancel() and Task.cancel() ( | https://github.com/arturoescaip/cpython/commit/7654bbb04a1a7b663299ec8eb16e89ee35d6fc64 |
| p… | https://github.com/python/cpython/pull/19979 |
| 7654bbb | https://github.com/arturoescaip/cpython/commit/7654bbb04a1a7b663299ec8eb16e89ee35d6fc64 |
| …ythonGH-19979 | https://github.com/python/cpython/pull/19979 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19979 |
|
| https://github.com/1st1 |
|
1st1
| https://github.com/1st1 |
|
| https://github.com/python/cpython/pull/19979/files/22a54cc448747b7e6d0ee57b5c4cc93d2aead540 |
|
| https://github.com/asvetlov |
|
asvetlov
| https://github.com/asvetlov |
| Please reload this page | https://github.com/python/cpython/pull/19979 |
|
| https://github.com/cjerdonek |
|
| https://github.com/1st1 |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |