| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f34a1c9f-ced0-69df-19ef-5289293cc2cf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86FA:CC59B:1CF8D0:28573A:696A63DA |
| html-safe-nonce | b3e3c02b74870bd435fab7ab59f4a495d5fc8bd8d9b5f0d5dbcdd0c3721da990 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkZBOkNDNTlCOjFDRjhEMDoyODU3M0E6Njk2QTYzREEiLCJ2aXNpdG9yX2lkIjoiMTE1NjA0NDE2NjY0Mjk1MTEzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 79c930234f257ddd8398cf2e0bb931d065ef83d0d1096467fd2593bfa5487caa |
| hovercard-subject-tag | pull_request:414368104 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/19970/files |
| twitter:image | https://avatars.githubusercontent.com/u/1623689?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1623689?s=400&v=4 |
| og:image:alt | Includes code and docs. The tests are forthcoming.
https://bugs.python.org/issue40541 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/19970/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19970%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19970%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/19970/files |
| Reload | https://github.com/python/cpython/pull/19970/files |
| Reload | https://github.com/python/cpython/pull/19970/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/19970/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/19970/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| rhettinger | https://github.com/rhettinger |
| python:master | https://github.com/python/cpython/tree/master |
| rhettinger:random_weighted_sample | https://github.com/rhettinger/cpython/tree/random_weighted_sample |
|
Conversation
8
| https://github.com/python/cpython/pull/19970 |
|
Commits
10
| https://github.com/python/cpython/pull/19970/commits |
|
Checks
0
| https://github.com/python/cpython/pull/19970/checks |
|
Files changed
| https://github.com/python/cpython/pull/19970/files |
| Please reload this page | https://github.com/python/cpython/pull/19970/files |
|
bpo-40541: Add optional *counts* parameter to random.sample()
| https://github.com/python/cpython/pull/19970/files#top |
|
Show all changes
10 commits
| https://github.com/python/cpython/pull/19970/files |
|
4ad778b
Add weights to random.sample()
rhettinger May 6, 2020
| https://github.com/python/cpython/pull/19970/commits/4ad778b996f0c014ff3f15fa2feb14b547965830 |
|
eaed7b3
Add docs
rhettinger May 6, 2020
| https://github.com/python/cpython/pull/19970/commits/eaed7b3bab73a37f98eb750ef6f1091cd537c7b3 |
|
787ec38
Add blurb
rhettinger May 6, 2020
| https://github.com/python/cpython/pull/19970/commits/787ec385813cad625025e8c5a8922a0870994dea |
|
ab6b380
Add tests
rhettinger May 6, 2020
| https://github.com/python/cpython/pull/19970/commits/ab6b380d020bf7c5d7b6521711bb425295701de0 |
|
ea5e42e
Update Doc/library/random.rst
rhettinger May 6, 2020
| https://github.com/python/cpython/pull/19970/commits/ea5e42ee089a8a0536fc5b95ca48ffab645d1853 |
|
672f739
Add exact equidistribution test
rhettinger May 7, 2020
| https://github.com/python/cpython/pull/19970/commits/672f739050b398b806a798eb598fa2eace391790 |
|
556582d
Earlier test for zero total weight
rhettinger May 7, 2020
| https://github.com/python/cpython/pull/19970/commits/556582d25bacb12b5a7c013a898679a51d88c625 |
|
4fb554a
Change parameter name from "weights" to "counts". Add another test.
rhettinger May 7, 2020
| https://github.com/python/cpython/pull/19970/commits/4fb554a50aa7c2ddd0e2a724eafec6fa92ed5df3 |
|
55e948e
Sync-up docstring with the main docs
rhettinger May 7, 2020
| https://github.com/python/cpython/pull/19970/commits/55e948e61b96a280e913617d3d2f5f87df442795 |
|
1f36ad3
Fix typo and improve formatting
rhettinger May 8, 2020
| https://github.com/python/cpython/pull/19970/commits/1f36ad3c5f2a793eb4c67ac8e5685ce66f764413 |
|
Clear filters
| https://github.com/python/cpython/pull/19970/files |
| Please reload this page | https://github.com/python/cpython/pull/19970/files |
| Please reload this page | https://github.com/python/cpython/pull/19970/files |
|
random.rst
| https://github.com/python/cpython/pull/19970/files#diff-487697e65cad630537366129288e300806c018e1ec7613cd35909e6db5299794 |
|
random.py
| https://github.com/python/cpython/pull/19970/files#diff-851cf2d8d99b6d8dee26acc31319431dce51dbe26e3e56494d9b4c45edd8e11f |
|
test_random.py
| https://github.com/python/cpython/pull/19970/files#diff-aaebf638f7ed6fb71bd1b82f18d5ef343db5b52137304a86fdcd1dd176e9eda9 |
|
2020-05-06-15-36-47.bpo-40541.LlYghL.rst
| https://github.com/python/cpython/pull/19970/files#diff-a721960eac40fbbf525ed3c695aa7b4af62a78442ce1dfe07d968337c9c22f2a |
| Doc/library/random.rst | https://github.com/python/cpython/pull/19970/files#diff-487697e65cad630537366129288e300806c018e1ec7613cd35909e6db5299794 |
|
View file
| https://github.com/rhettinger/cpython/blob/1f36ad3c5f2a793eb4c67ac8e5685ce66f764413/Doc/library/random.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/19970/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/19970/files#diff-487697e65cad630537366129288e300806c018e1ec7613cd35909e6db5299794 |
|
| https://github.com/python/cpython/pull/19970/files#diff-487697e65cad630537366129288e300806c018e1ec7613cd35909e6db5299794 |
|
| https://github.com/python/cpython/pull/19970/files#diff-487697e65cad630537366129288e300806c018e1ec7613cd35909e6db5299794 |
|
| https://github.com/python/cpython/pull/19970/files#diff-487697e65cad630537366129288e300806c018e1ec7613cd35909e6db5299794 |
|
| https://github.com/python/cpython/pull/19970/files#diff-487697e65cad630537366129288e300806c018e1ec7613cd35909e6db5299794 |
| Lib/random.py | https://github.com/python/cpython/pull/19970/files#diff-851cf2d8d99b6d8dee26acc31319431dce51dbe26e3e56494d9b4c45edd8e11f |
|
View file
| https://github.com/rhettinger/cpython/blob/1f36ad3c5f2a793eb4c67ac8e5685ce66f764413/Lib/random.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/19970/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/19970/files#diff-851cf2d8d99b6d8dee26acc31319431dce51dbe26e3e56494d9b4c45edd8e11f |
|
| https://github.com/python/cpython/pull/19970/files#diff-851cf2d8d99b6d8dee26acc31319431dce51dbe26e3e56494d9b4c45edd8e11f |
|
| https://github.com/python/cpython/pull/19970/files#diff-851cf2d8d99b6d8dee26acc31319431dce51dbe26e3e56494d9b4c45edd8e11f |
|
| https://github.com/python/cpython/pull/19970/files#diff-851cf2d8d99b6d8dee26acc31319431dce51dbe26e3e56494d9b4c45edd8e11f |
|
| https://github.com/python/cpython/pull/19970/files#diff-851cf2d8d99b6d8dee26acc31319431dce51dbe26e3e56494d9b4c45edd8e11f |
| Lib/test/test_random.py | https://github.com/python/cpython/pull/19970/files#diff-aaebf638f7ed6fb71bd1b82f18d5ef343db5b52137304a86fdcd1dd176e9eda9 |
|
View file
| https://github.com/rhettinger/cpython/blob/1f36ad3c5f2a793eb4c67ac8e5685ce66f764413/Lib/test/test_random.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/19970/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/19970/files#diff-aaebf638f7ed6fb71bd1b82f18d5ef343db5b52137304a86fdcd1dd176e9eda9 |
|
| https://github.com/python/cpython/pull/19970/files#diff-aaebf638f7ed6fb71bd1b82f18d5ef343db5b52137304a86fdcd1dd176e9eda9 |
|
| https://github.com/python/cpython/pull/19970/files#diff-aaebf638f7ed6fb71bd1b82f18d5ef343db5b52137304a86fdcd1dd176e9eda9 |
|
| https://github.com/python/cpython/pull/19970/files#diff-aaebf638f7ed6fb71bd1b82f18d5ef343db5b52137304a86fdcd1dd176e9eda9 |
| Misc/NEWS.d/next/Library/2020-05-06-15-36-47.bpo-40541.LlYghL.rst | https://github.com/python/cpython/pull/19970/files#diff-a721960eac40fbbf525ed3c695aa7b4af62a78442ce1dfe07d968337c9c22f2a |
|
View file
| https://github.com/rhettinger/cpython/blob/1f36ad3c5f2a793eb4c67ac8e5685ce66f764413/Misc/NEWS.d/next/Library/2020-05-06-15-36-47.bpo-40541.LlYghL.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/19970/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |