René's URL Explorer Experiment


Title: bpo-40334: Fix error location upon parsing an invalid string literal by lysnikolaou · Pull Request #19962 · python/cpython · GitHub

Open Graph Title: bpo-40334: Fix error location upon parsing an invalid string literal by lysnikolaou · Pull Request #19962 · python/cpython

X Title: bpo-40334: Fix error location upon parsing an invalid string literal by lysnikolaou · Pull Request #19962 · python/cpython

Description: When parsing a string with an invalid escape, the old parser used to point to the beginning of the invalid string. This PR changes the new parser to match that behavior, since it's currently pointing to the end of the string (or to be more precise, to the beginning of the next token). Closes we-like-parsers#64. https://bugs.python.org/issue40334

Open Graph Description: When parsing a string with an invalid escape, the old parser used to point to the beginning of the invalid string. This PR changes the new parser to match that behavior, since it's currently po...

X Description: When parsing a string with an invalid escape, the old parser used to point to the beginning of the invalid string. This PR changes the new parser to match that behavior, since it's currentl...

Opengraph URL: https://github.com/python/cpython/pull/19962

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b7d1372a-d5db-0943-d950-e709566729cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CC0:29B8E2:815A22:B3CDCF:696A8092
html-safe-nonce4eb1d4bad242686d4d0616e92793517e3f3c0c45e2ec7b9e50b9b6c01bc3582b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0MwOjI5QjhFMjo4MTVBMjI6QjNDRENGOjY5NkE4MDkyIiwidmlzaXRvcl9pZCI6IjQyMDcxNDUwOTQ5OTAxNjgyMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd93b8ff3aa54901e75f2bab896f234e397bb76f44708cd0f253a95488885dc05
hovercard-subject-tagpull_request:414198071
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/19962/files
twitter:imagehttps://avatars.githubusercontent.com/u/20306270?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20306270?s=400&v=4
og:image:altWhen parsing a string with an invalid escape, the old parser used to point to the beginning of the invalid string. This PR changes the new parser to match that behavior, since it's currently po...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19962/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19962%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19962%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19962/files
Reloadhttps://github.com/python/cpython/pull/19962/files
Reloadhttps://github.com/python/cpython/pull/19962/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
lysnikolaou:invalid-string-literalhttps://github.com/lysnikolaou/cpython/tree/invalid-string-literal
Conversation 16 https://github.com/python/cpython/pull/19962
Commits 5 https://github.com/python/cpython/pull/19962/commits
Checks 0 https://github.com/python/cpython/pull/19962/checks
Files changed https://github.com/python/cpython/pull/19962/files
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
bpo-40334: Fix error location upon parsing an invalid string literal https://github.com/python/cpython/pull/19962/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/19962/files
8300034 bpo-40334: Fix error location upon parsing an invalid string literal lysnikolaou May 6, 2020 https://github.com/python/cpython/pull/19962/commits/8300034fbf60249e8d62a85d3a5d0d531347a248
938f8e1 Update test_cmd_line_script as well lysnikolaou May 6, 2020 https://github.com/python/cpython/pull/19962/commits/938f8e1a589bcf5051a795e8de359d4ddaa9c998
8b5f2e8 Call PyBytes_AsString in _PyPegen_parsestr instead of _PyPegen_concat… lysnikolaou May 6, 2020 https://github.com/python/cpython/pull/19962/commits/8b5f2e8258b835cfed1b39fc5dd77686c6bf0e54
86b88a3 Add a new field `known_err_token` to the `Parser` struct that has lysnikolaou May 6, 2020 https://github.com/python/cpython/pull/19962/commits/86b88a31d233eaf76cf28d7b73a1c0492fdd0cd3
532a6c2 Add assertion for column number lysnikolaou May 6, 2020 https://github.com/python/cpython/pull/19962/commits/532a6c2d388be75cb19c899672f85d1879c54de1
Clear filters https://github.com/python/cpython/pull/19962/files
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
test_cmd_line_script.py https://github.com/python/cpython/pull/19962/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
test_string_literals.py https://github.com/python/cpython/pull/19962/files#diff-b567718564bb8a8959e12f446da67320d794f782f643b74e8b8ddfdae939f966
parse_string.c https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
parse_string.h https://github.com/python/cpython/pull/19962/files#diff-256905cb95fabe95f08dc722645339072038eb26a9f46dcb048cbca804af81c9
pegen.c https://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
pegen.h https://github.com/python/cpython/pull/19962/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Lib/test/test_cmd_line_script.pyhttps://github.com/python/cpython/pull/19962/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
View file https://github.com/lysnikolaou/cpython/blob/532a6c2d388be75cb19c899672f85d1879c54de1/Lib/test/test_cmd_line_script.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19962/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
https://github.com/python/cpython/pull/19962/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
Lib/test/test_string_literals.pyhttps://github.com/python/cpython/pull/19962/files#diff-b567718564bb8a8959e12f446da67320d794f782f643b74e8b8ddfdae939f966
View file https://github.com/lysnikolaou/cpython/blob/532a6c2d388be75cb19c899672f85d1879c54de1/Lib/test/test_string_literals.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19962/files#diff-b567718564bb8a8959e12f446da67320d794f782f643b74e8b8ddfdae939f966
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
https://github.com/python/cpython/pull/19962/files#diff-b567718564bb8a8959e12f446da67320d794f782f643b74e8b8ddfdae939f966
https://github.com/python/cpython/pull/19962/files#diff-b567718564bb8a8959e12f446da67320d794f782f643b74e8b8ddfdae939f966
Parser/pegen/parse_string.chttps://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
View file https://github.com/lysnikolaou/cpython/blob/532a6c2d388be75cb19c899672f85d1879c54de1/Parser/pegen/parse_string.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
https://github.com/python/cpython/pull/19962/files#diff-b7b034bfd57248d132cb27d4834cb65d679a5467a99641fc8ae9daa741ef2e58
Parser/pegen/parse_string.hhttps://github.com/python/cpython/pull/19962/files#diff-256905cb95fabe95f08dc722645339072038eb26a9f46dcb048cbca804af81c9
View file https://github.com/lysnikolaou/cpython/blob/532a6c2d388be75cb19c899672f85d1879c54de1/Parser/pegen/parse_string.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19962/files#diff-256905cb95fabe95f08dc722645339072038eb26a9f46dcb048cbca804af81c9
https://github.com/python/cpython/pull/19962/files#diff-256905cb95fabe95f08dc722645339072038eb26a9f46dcb048cbca804af81c9
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
View file https://github.com/lysnikolaou/cpython/blob/532a6c2d388be75cb19c899672f85d1879c54de1/Parser/pegen/pegen.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19962/files
https://github.com/python/cpython/pull/19962/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/19962/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
View file https://github.com/lysnikolaou/cpython/blob/532a6c2d388be75cb19c899672f85d1879c54de1/Parser/pegen/pegen.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19962/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/19962/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.