René's URL Explorer Experiment


Title: bpo-30594: Fix spurious DECREF in newPySSLSocket by njsmith · Pull Request #1992 · python/cpython · GitHub

Open Graph Title: bpo-30594: Fix spurious DECREF in newPySSLSocket by njsmith · Pull Request #1992 · python/cpython

X Title: bpo-30594: Fix spurious DECREF in newPySSLSocket by njsmith · Pull Request #1992 · python/cpython

Description: In newPySSLSocket, it sets up the new 'self' object, which among other things owns a reference to the parent SSLContext in 'self->ctx'. It then tries to idna-decode the given server_hostname, and i...

Open Graph Description: In newPySSLSocket, it sets up the new 'self' object, which among other things owns a reference to the parent SSLContext in 'self->ctx'. It then tries to idna-decode the given ser...

X Description: In newPySSLSocket, it sets up the new 'self' object, which among other things owns a reference to the parent SSLContext in 'self->ctx'. It then tries to idna-...

Opengraph URL: https://github.com/python/cpython/pull/1992

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5ba68f4c-f132-0516-b9dc-6ae3145af235
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB82E:301463:6D02B8:8E8B58:696B4907
html-safe-nonce5b8b56aea66cea6153298a4ef5db1382123d2186b5e15ea2a1465882b150f76a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODJFOjMwMTQ2Mzo2RDAyQjg6OEU4QjU4OjY5NkI0OTA3IiwidmlzaXRvcl9pZCI6IjMxMjAyMzc0MTgxMTE1MTg5ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccf37ade5bfbb8ecfeed5b0009f0bdda90d55fd48ef9282cf1a3958e5ed47b448
hovercard-subject-tagpull_request:124574345
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/1992/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e3b1be112022162aa705df3faa2d54d3f0b14c7826e5761dc3ad6dec38519594/python/cpython/pull/1992
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e3b1be112022162aa705df3faa2d54d3f0b14c7826e5761dc3ad6dec38519594/python/cpython/pull/1992
og:image:altIn newPySSLSocket, it sets up the new 'self' object, which among other things owns a reference to the parent SSLContext in 'self->ctx'. It then tries to idna-decode the given ser...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenjsmith
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1992#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1992
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1992
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1992
Reloadhttps://github.com/python/cpython/pull/1992
Reloadhttps://github.com/python/cpython/pull/1992
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1992
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/1992
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/1992#issue-comment-box
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
njsmith:ref-sink-in-newPySSLSockethttps://github.com/njsmith/cpython/tree/ref-sink-in-newPySSLSocket
bpo-30594: Fix spurious DECREF in newPySSLSocket https://github.com/python/cpython/pull/1992#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
njsmith:ref-sink-in-newPySSLSockethttps://github.com/njsmith/cpython/tree/ref-sink-in-newPySSLSocket
Conversation 6 https://github.com/python/cpython/pull/1992
Commits 1 https://github.com/python/cpython/pull/1992/commits
Checks 0 https://github.com/python/cpython/pull/1992/checks
Files changed https://github.com/python/cpython/pull/1992/files
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jun 8, 2017https://github.com/python/cpython/pull/1992#issue-234421447
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/njsmith
Fix spurious DECREF in newPySSLSockethttps://github.com/python/cpython/pull/1992/commits/1fd3e5745a4e6666ed8c91dd207693dbb482d578
1fd3e57https://github.com/python/cpython/pull/1992/commits/1fd3e5745a4e6666ed8c91dd207693dbb482d578
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jun 8, 2017https://github.com/python/cpython/pull/1992#event-1114897302
https://github.com/mention-bot
mention-bothttps://github.com/mention-bot
Jun 8, 2017https://github.com/python/cpython/pull/1992#issuecomment-307008893
@njsmithhttps://github.com/njsmith
@vadmiumhttps://github.com/vadmium
@tiranhttps://github.com/tiran
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jun 8, 2017https://github.com/python/cpython/pull/1992#event-1114900239
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jun 8, 2017https://github.com/python/cpython/pull/1992#issuecomment-307010305
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 8, 2017 https://github.com/python/cpython/pull/1992#pullrequestreview-42800434
View reviewed changes https://github.com/python/cpython/pull/1992/files/1fd3e5745a4e6666ed8c91dd207693dbb482d578
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
needs backport to 2.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%202.7%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Jun 8, 2017https://github.com/python/cpython/pull/1992#event-1114907958
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
65ece7chttps://github.com/python/cpython/commit/65ece7ca2366308fa91a39a8dfa255e6bdce3cca
Jun 8, 2017https://github.com/python/cpython/pull/1992#event-1114913126
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 8, 2017https://github.com/python/cpython/pull/1992#issuecomment-307024778
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/njsmith
njsmithhttps://github.com/njsmith
June 8, 2017 08:38https://github.com/python/cpython/pull/1992#event-1115073564
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jun 8, 2017https://github.com/python/cpython/pull/1992#issuecomment-307038530
@Haypohttps://github.com/Haypo
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jun 8, 2017https://github.com/python/cpython/pull/1992#issuecomment-307038732
Please reload this pagehttps://github.com/python/cpython/pull/1992
njsmithhttps://github.com/njsmith
Jun 8, 2017 https://github.com/python/cpython/pull/1992#ref-commit-4c88dc6
https://github.com/njsmith
[3.6] bpo-30594: Fixed refcounting in newPySSLSocket (https://github.com/njsmith/cpython/commit/4c88dc68bd58e64e3d975d84f9d6a1c58f42faa2
pythonGH-1992https://github.com/python/cpython/pull/1992
)https://github.com/njsmith/cpython/commit/4c88dc68bd58e64e3d975d84f9d6a1c58f42faa2
4c88dc6https://github.com/njsmith/cpython/commit/4c88dc68bd58e64e3d975d84f9d6a1c58f42faa2
65ece7chttps://github.com/njsmith/cpython/commit/65ece7ca2366308fa91a39a8dfa255e6bdce3cca
njsmithhttps://github.com/njsmith
Jun 8, 2017 https://github.com/python/cpython/pull/1992#ref-commit-6156071
https://github.com/njsmith
[3.5] bpo-30594: Fixed refcounting in newPySSLSocket (https://github.com/njsmith/cpython/commit/61560719572adf4144d3228b1689535b6161f378
pythonGH-1992https://github.com/python/cpython/pull/1992
)https://github.com/njsmith/cpython/commit/61560719572adf4144d3228b1689535b6161f378
6156071https://github.com/njsmith/cpython/commit/61560719572adf4144d3228b1689535b6161f378
65ece7chttps://github.com/njsmith/cpython/commit/65ece7ca2366308fa91a39a8dfa255e6bdce3cca
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 8, 2017https://github.com/python/cpython/pull/1992#issuecomment-307059036
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
needs backport to 2.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%202.7%22
Jun 8, 2017https://github.com/python/cpython/pull/1992#event-1115208210
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 8, 2017https://github.com/python/cpython/pull/1992#issuecomment-307066427
@njsmithhttps://github.com/njsmith
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jun 8, 2017 https://github.com/python/cpython/pull/1992#ref-pullrequest-234489920
bpo-30594: Add a test for bad IDNA in ssl server_hostname #1997 https://github.com/python/cpython/pull/1997
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 8, 2017 https://github.com/python/cpython/pull/1992#ref-commit-854f7ba
https://github.com/njsmith
https://github.com/serhiy-storchaka
[3.6]https://github.com/python/cpython/commit/854f7ba1d5cbb6a42511beae66c8dbe34f2cbcd3
bpo-30594https://bugs.python.org/issue?@action=redirect&bpo=30594
: Fixed refcounting in newPySSLSocket (https://github.com/python/cpython/commit/854f7ba1d5cbb6a42511beae66c8dbe34f2cbcd3
GH-1992https://github.com/python/cpython/pull/1992
) (https://github.com/python/cpython/commit/854f7ba1d5cbb6a42511beae66c8dbe34f2cbcd3
#1994https://github.com/python/cpython/pull/1994
)https://github.com/python/cpython/commit/854f7ba1d5cbb6a42511beae66c8dbe34f2cbcd3
854f7bahttps://github.com/python/cpython/commit/854f7ba1d5cbb6a42511beae66c8dbe34f2cbcd3
65ece7chttps://github.com/python/cpython/commit/65ece7ca2366308fa91a39a8dfa255e6bdce3cca
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 8, 2017 https://github.com/python/cpython/pull/1992#ref-commit-54ba41e
https://github.com/njsmith
https://github.com/serhiy-storchaka
[3.5]https://github.com/python/cpython/commit/54ba41ecc5711f89841342c5f9dd555ee13404b5
bpo-30594https://bugs.python.org/issue?@action=redirect&bpo=30594
: Fixed refcounting in newPySSLSocket (https://github.com/python/cpython/commit/54ba41ecc5711f89841342c5f9dd555ee13404b5
GH-1992https://github.com/python/cpython/pull/1992
) (https://github.com/python/cpython/commit/54ba41ecc5711f89841342c5f9dd555ee13404b5
#1993https://github.com/python/cpython/pull/1993
)https://github.com/python/cpython/commit/54ba41ecc5711f89841342c5f9dd555ee13404b5
54ba41ehttps://github.com/python/cpython/commit/54ba41ecc5711f89841342c5f9dd555ee13404b5
65ece7chttps://github.com/python/cpython/commit/65ece7ca2366308fa91a39a8dfa255e6bdce3cca
njsmithhttps://github.com/njsmith
Jun 9, 2017 https://github.com/python/cpython/pull/1992#ref-commit-a30411e
https://github.com/njsmith
Add a test for bad IDNA in ssl server_hostnamehttps://github.com/njsmith/cpython/commit/a30411e8fa8c55a6ba276c2b12418a4d90b55afc
a30411ehttps://github.com/njsmith/cpython/commit/a30411e8fa8c55a6ba276c2b12418a4d90b55afc
python#1992 (comment)https://github.com/python/cpython/pull/1992#issuecomment-307024778
vstinnerhttps://github.com/vstinner
Jun 9, 2017 https://github.com/python/cpython/pull/1992#ref-commit-59fdf0f
https://github.com/njsmith
https://github.com/vstinner
Add a test for bad IDNA in ssl server_hostname (https://github.com/python/cpython/commit/59fdf0f3ba0469f5ee45eee59cc166411fbe0b75
#1997https://github.com/python/cpython/pull/1997
)https://github.com/python/cpython/commit/59fdf0f3ba0469f5ee45eee59cc166411fbe0b75
59fdf0fhttps://github.com/python/cpython/commit/59fdf0f3ba0469f5ee45eee59cc166411fbe0b75
#1992 (comment)https://github.com/python/cpython/pull/1992#issuecomment-307024778
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
needs backport to 3.5 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.5%22
Jun 17, 2017https://github.com/python/cpython/pull/1992#event-1127718470
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1992
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/1992/files/1fd3e5745a4e6666ed8c91dd207693dbb482d578
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/1992
https://github.com/njsmith
https://github.com/mention-bot
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.