René's URL Explorer Experiment


Title: bpo-40503: Add tests and implementation for ZoneInfo by pganssle · Pull Request #19909 · python/cpython · GitHub

Open Graph Title: bpo-40503: Add tests and implementation for ZoneInfo by pganssle · Pull Request #19909 · python/cpython

X Title: bpo-40503: Add tests and implementation for ZoneInfo by pganssle · Pull Request #19909 · python/cpython

Description: This PR brings in the tests, C and pure Python implementations for the zoneinfo module, as specified in PEP 615. Migrating this over from the reference implementation. For the sake of keeping the review somewhat tightly scoped (HAH) it does not cover: What's new entry. (#20006) Docs (#20006) The compile-time configuration of TZPATH (#20034) (Moved to this PR) Those will come in later / separate PRs. https://bugs.python.org/issue40503

Open Graph Description: This PR brings in the tests, C and pure Python implementations for the zoneinfo module, as specified in PEP 615. Migrating this over from the reference implementation. For the sake of keeping the r...

X Description: This PR brings in the tests, C and pure Python implementations for the zoneinfo module, as specified in PEP 615. Migrating this over from the reference implementation. For the sake of keeping the r...

Opengraph URL: https://github.com/python/cpython/pull/19909

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2b52866a-d242-ca44-a0ee-30a0934f0fe9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB350:2AEA36:1615452:1D61493:696AE25B
html-safe-noncecadbc27257c400735df6a3ea6c1b4d32cbcb3cb7394d07fa2230d6816b84fb3d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzUwOjJBRUEzNjoxNjE1NDUyOjFENjE0OTM6Njk2QUUyNUIiLCJ2aXNpdG9yX2lkIjoiNzEwMjUzNTIzOTYwNjEzMzMzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf0fcf564c57152f0822dba483bcc930f3211b496121b1afc3fffcb8d6dd2ed2d
hovercard-subject-tagpull_request:413124562
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/19909/files
twitter:imagehttps://avatars.githubusercontent.com/u/1377457?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1377457?s=400&v=4
og:image:altThis PR brings in the tests, C and pure Python implementations for the zoneinfo module, as specified in PEP 615. Migrating this over from the reference implementation. For the sake of keeping the r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d84d50b3c75fa36755c3cf392edbc09e626f979
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19909/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19909%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19909%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19909/files
Reloadhttps://github.com/python/cpython/pull/19909/files
Reloadhttps://github.com/python/cpython/pull/19909/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
pganssle:zoneinfohttps://github.com/pganssle/cpython/tree/zoneinfo
Conversation 61 https://github.com/python/cpython/pull/19909
Commits 1 https://github.com/python/cpython/pull/19909/commits
Checks 0 https://github.com/python/cpython/pull/19909/checks
Files changed https://github.com/python/cpython/pull/19909/files
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
bpo-40503: Add tests and implementation for ZoneInfo https://github.com/python/cpython/pull/19909/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/19909/files
ac56fcc PEP 615: Tests and implementation for zoneinfo pganssle May 4, 2020 https://github.com/python/cpython/pull/19909/commits/ac56fcc66f984401799df6ea350bf16b548e742c
Clear filters https://github.com/python/cpython/pull/19909/files
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
coverage.yml https://github.com/python/cpython/pull/19909/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6
.travis.yml https://github.com/python/cpython/pull/19909/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
sysconfig.py https://github.com/python/cpython/pull/19909/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
__init__.py https://github.com/python/cpython/pull/19909/files#diff-ecf61220c35621e1538f61ef5e3786dd84a42277547cadd5c724af38856c15d5
__main__.py https://github.com/python/cpython/pull/19909/files#diff-0ab2b47979810ca2eb2fa73bf356ee90b1001f3150bfb16af2eb8894e2b6e379
_support.py https://github.com/python/cpython/pull/19909/files#diff-6d8eb8caaa60243b61cc3bbb9caaca7c60853484d0334ffdbb9d098a0ede5393
update_test_data.py https://github.com/python/cpython/pull/19909/files#diff-eb7e8062001e862c7837033fb5b2a646e4887573c21356d6ee51210d6b7d9084
zoneinfo_data.json https://github.com/python/cpython/pull/19909/files#diff-91c2b1e18ae8ee25ab7049b2e39d845cd9a3834ece5c9e168cd4b9523965d54e
test_zoneinfo.py https://github.com/python/cpython/pull/19909/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
__init__.py https://github.com/python/cpython/pull/19909/files#diff-c7298da2106c218558bc977d838c09e493f2ccfd001079c06f08c6e32b72ce7a
_common.py https://github.com/python/cpython/pull/19909/files#diff-03c596e93affd3c7363e98d4067a67525c747d3113f2613a93bea65fd47903b4
_tzpath.py https://github.com/python/cpython/pull/19909/files#diff-385dd8af6e4760591da43aba1b1b48dfe6b97f1f742016f4c6f7db48cb02af35
_zoneinfo.py https://github.com/python/cpython/pull/19909/files#diff-7c5f7d13590c56bce99efe1cd8d9692be0953d9adf1aee20b24e4192e7d42280
Makefile.pre.in https://github.com/python/cpython/pull/19909/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
requirements-test.txt https://github.com/python/cpython/pull/19909/files#diff-f15d4c83a73ed75571e0cc65cf29175535bfa957f7f112639817c8ecbd3358e1
Setup https://github.com/python/cpython/pull/19909/files#diff-54b4e964e44dd7cf194c63f73a4b01d68cc670e72018d895003b48709c7e88db
_zoneinfo.c https://github.com/python/cpython/pull/19909/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
_zoneinfo.vcxproj https://github.com/python/cpython/pull/19909/files#diff-c955b92443a891a51fd955dfb0d6888f16aa3e9ec929fd7a881b9a1b1fb6d59d
_zoneinfo.vcxproj.filters https://github.com/python/cpython/pull/19909/files#diff-61f3dae32b3e6682a29bde2019accd2b39c1ed1d5eb79e03301bd1c14df55f61
lib.pyproj https://github.com/python/cpython/pull/19909/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b
pcbuild.proj https://github.com/python/cpython/pull/19909/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
pcbuild.sln https://github.com/python/cpython/pull/19909/files#diff-0ea7ec57310c8f7a74b3bb79e5cd3ee907d47909fb68b7b46e5d257793bdd3bc
readme.txt https://github.com/python/cpython/pull/19909/files#diff-e6deaad53af223df046ace0e4295072ce19c77c172783d29f023fd6912e15fc1
lib_files.wxs https://github.com/python/cpython/pull/19909/files#diff-26115511cc004fd83fde0fa4e7fe691a99ccdd351aa7b7ec2a8079444e962cce
configure https://github.com/python/cpython/pull/19909/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.ac https://github.com/python/cpython/pull/19909/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
setup.py https://github.com/python/cpython/pull/19909/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
.github/workflows/coverage.ymlhttps://github.com/python/cpython/pull/19909/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6
View file https://github.com/pganssle/cpython/blob/ac56fcc66f984401799df6ea350bf16b548e742c/.github/workflows/coverage.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19909/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19909/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6
pgansslehttps://github.com/pganssle
May 12, 2020https://github.com/python/cpython/pull/19909/files#r424067235
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
imported commenthttps://github.com/python/cpython/pull/20034#discussion_r424021474
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
https://github.com/python/cpython/pull/19909/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6
.travis.ymlhttps://github.com/python/cpython/pull/19909/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
View file https://github.com/pganssle/cpython/blob/ac56fcc66f984401799df6ea350bf16b548e742c/.travis.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19909/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19909/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
https://github.com/python/cpython/pull/19909/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
Lib/sysconfig.pyhttps://github.com/python/cpython/pull/19909/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
View file https://github.com/pganssle/cpython/blob/ac56fcc66f984401799df6ea350bf16b548e742c/Lib/sysconfig.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19909/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19909/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
https://github.com/python/cpython/pull/19909/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
Lib/test/test_zoneinfo/__init__.pyhttps://github.com/python/cpython/pull/19909/files#diff-ecf61220c35621e1538f61ef5e3786dd84a42277547cadd5c724af38856c15d5
View file https://github.com/pganssle/cpython/blob/ac56fcc66f984401799df6ea350bf16b548e742c/Lib/test/test_zoneinfo/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19909/{{ revealButtonHref }}
vstinnerhttps://github.com/vstinner
May 14, 2020https://github.com/python/cpython/pull/19909/files#r425258362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
pgansslehttps://github.com/pganssle
May 14, 2020https://github.com/python/cpython/pull/19909/files#r425272588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
vstinnerhttps://github.com/vstinner
May 14, 2020https://github.com/python/cpython/pull/19909/files#r425275521
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
Lib/test/test_zoneinfo/__main__.pyhttps://github.com/python/cpython/pull/19909/files#diff-0ab2b47979810ca2eb2fa73bf356ee90b1001f3150bfb16af2eb8894e2b6e379
View file https://github.com/pganssle/cpython/blob/ac56fcc66f984401799df6ea350bf16b548e742c/Lib/test/test_zoneinfo/__main__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19909/{{ revealButtonHref }}
Lib/test/test_zoneinfo/_support.pyhttps://github.com/python/cpython/pull/19909/files#diff-6d8eb8caaa60243b61cc3bbb9caaca7c60853484d0334ffdbb9d098a0ede5393
View file https://github.com/pganssle/cpython/blob/ac56fcc66f984401799df6ea350bf16b548e742c/Lib/test/test_zoneinfo/_support.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19909/{{ revealButtonHref }}
Lib/test/test_zoneinfo/data/update_test_data.pyhttps://github.com/python/cpython/pull/19909/files#diff-eb7e8062001e862c7837033fb5b2a646e4887573c21356d6ee51210d6b7d9084
View file https://github.com/pganssle/cpython/blob/ac56fcc66f984401799df6ea350bf16b548e742c/Lib/test/test_zoneinfo/data/update_test_data.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19909/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/19909/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.