René's URL Explorer Experiment


Title: bpo-29587: Enable implicit exception chaining with gen.throw() by cjerdonek · Pull Request #19823 · python/cpython · GitHub

Open Graph Title: bpo-29587: Enable implicit exception chaining with gen.throw() by cjerdonek · Pull Request #19823 · python/cpython

X Title: bpo-29587: Enable implicit exception chaining with gen.throw() by cjerdonek · Pull Request #19823 · python/cpython

Description: This is a new version of PR #19811 to sort out the buildbot failures. It enables implicit exception chaining when calling generator.throw(exc) by setting exc.__context__. https://bugs.python.org/i...

Open Graph Description: This is a new version of PR #19811 to sort out the buildbot failures. It enables implicit exception chaining when calling generator.throw(exc) by setting exc.__context__. https://bugs.python.org/i...

X Description: This is a new version of PR #19811 to sort out the buildbot failures. It enables implicit exception chaining when calling generator.throw(exc) by setting exc.__context__. https://bugs.python.org/i...

Opengraph URL: https://github.com/python/cpython/pull/19823

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e5b467c4-16a0-cebb-053a-7741668f8445
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88C4:26177F:649E32:80D86F:696B11EC
html-safe-nonce01840b99d1b4513ab13326cb055f9634a76a3759b5580818d13f51bf21a2eff2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEM0OjI2MTc3Rjo2NDlFMzI6ODBEODZGOjY5NkIxMUVDIiwidmlzaXRvcl9pZCI6IjQzNDgxMTY5MTY3NjEyMDMxODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac59b21e043fef06f60a9ed158aa84c59d86ab592ef976d043eb00fe8fb891659e
hovercard-subject-tagpull_request:411853075
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19823/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf3953bbc1628526bd75356a2abcb104b55e6ca4a5e9f4d80ff561059a04f2af/python/cpython/pull/19823
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf3953bbc1628526bd75356a2abcb104b55e6ca4a5e9f4d80ff561059a04f2af/python/cpython/pull/19823
og:image:altThis is a new version of PR #19811 to sort out the buildbot failures. It enables implicit exception chaining when calling generator.throw(exc) by setting exc.__context__. https://bugs.python.org/i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjerdonek
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19823#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19823
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19823
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19823
Reloadhttps://github.com/python/cpython/pull/19823
Reloadhttps://github.com/python/cpython/pull/19823
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19823
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/19823
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/19823#issue-comment-box
cjerdonekhttps://github.com/cjerdonek
python:masterhttps://github.com/python/cpython/tree/master
cjerdonek:fix-issue-29587-2https://github.com/cjerdonek/cpython/tree/fix-issue-29587-2
bpo-29587: Enable implicit exception chaining with gen.throw() https://github.com/python/cpython/pull/19823#top
cjerdonekhttps://github.com/cjerdonek
python:masterhttps://github.com/python/cpython/tree/master
cjerdonek:fix-issue-29587-2https://github.com/cjerdonek/cpython/tree/fix-issue-29587-2
Conversation 14 https://github.com/python/cpython/pull/19823
Commits 4 https://github.com/python/cpython/pull/19823/commits
Checks 0 https://github.com/python/cpython/pull/19823/checks
Files changed https://github.com/python/cpython/pull/19823/files
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
Apr 30, 2020https://github.com/python/cpython/pull/19823#issue-610406816
Please reload this pagehttps://github.com/python/cpython/pull/19823
#19811https://github.com/python/cpython/pull/19811
https://bugs.python.org/issue29587https://bugs.python.org/issue29587
Please reload this pagehttps://github.com/python/cpython/pull/19823
cjerdonekhttps://github.com/cjerdonek
April 30, 2020 14:38https://github.com/python/cpython/pull/19823#commits-pushed-e757c76
https://github.com/cjerdonek
Add a failing test for issue 29587.https://github.com/python/cpython/pull/19823/commits/e757c76589d927e25c1202ef2482a1cfd0757fba
e757c76https://github.com/python/cpython/pull/19823/commits/e757c76589d927e25c1202ef2482a1cfd0757fba
https://github.com/cjerdonek
bpo-29587: set exc.__context__ when calling gen.throw() (https://github.com/python/cpython/pull/19823/commits/57597f2738c7fe09d0a716dca72bd8feb66f447e
pythonGH-19811https://github.com/python/cpython/pull/19811
)https://github.com/python/cpython/pull/19823/commits/57597f2738c7fe09d0a716dca72bd8feb66f447e
57597f2https://github.com/python/cpython/pull/19823/commits/57597f2738c7fe09d0a716dca72bd8feb66f447e
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
1st1https://github.com/1st1
code ownerhttps://github.com/python/cpython/blob/3c7f9db85095952821f9d106dd874f75662ce7ec/.github/CODEOWNERS#L12
April 30, 2020 21:43https://github.com/python/cpython/pull/19823#event-3291463140
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 30, 2020https://github.com/python/cpython/pull/19823#event-3291463266
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 30, 2020https://github.com/python/cpython/pull/19823#event-3291463405
https://github.com/1st1
1st1https://github.com/1st1
Apr 30, 2020 https://github.com/python/cpython/pull/19823#pullrequestreview-403911424
View reviewed changes https://github.com/python/cpython/pull/19823/files/57597f2738c7fe09d0a716dca72bd8feb66f447e
Objects/genobject.chttps://github.com/python/cpython/pull/19823/files/57597f2738c7fe09d0a716dca72bd8feb66f447e#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2020 https://github.com/python/cpython/pull/19823#pullrequestreview-403913493
View reviewed changes https://github.com/python/cpython/pull/19823/files/57597f2738c7fe09d0a716dca72bd8feb66f447e
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/19823#pullrequestreview-403913493
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 30, 2020https://github.com/python/cpython/pull/19823#event-3291545102
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 30, 2020https://github.com/python/cpython/pull/19823#issuecomment-622144062
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Apr 30, 2020https://github.com/python/cpython/pull/19823#event-3291545137
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
Apr 30, 2020https://github.com/python/cpython/pull/19823#issuecomment-622149783
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Apr 30, 2020https://github.com/python/cpython/pull/19823#event-3291636641
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2020https://github.com/python/cpython/pull/19823#event-3291637448
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
April 30, 2020 22:49https://github.com/python/cpython/pull/19823#event-3291638651
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2020https://github.com/python/cpython/pull/19823#issuecomment-622159808
Please reload this pagehttps://github.com/python/cpython/pull/19823
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
Apr 30, 2020https://github.com/python/cpython/pull/19823#issuecomment-622160153
Please reload this pagehttps://github.com/python/cpython/pull/19823
cjerdonekhttps://github.com/cjerdonek
May 1, 2020 01:09https://github.com/python/cpython/pull/19823#commits-pushed-c321731
https://github.com/cjerdonek
Wrap the long line.https://github.com/python/cpython/pull/19823/commits/c321731d95c121e76e377812ba522ad268476519
c321731https://github.com/python/cpython/pull/19823/commits/c321731d95c121e76e377812ba522ad268476519
https://github.com/cjerdonek
Address the CI failures on Fedora, etc.https://github.com/python/cpython/pull/19823/commits/1bf33096f1b0c658801c1b16efc2d15d93d85109
1bf3309https://github.com/python/cpython/pull/19823/commits/1bf33096f1b0c658801c1b16efc2d15d93d85109
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
May 1, 2020https://github.com/python/cpython/pull/19823#issuecomment-622303508
Please reload this pagehttps://github.com/python/cpython/pull/19823
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
May 1, 2020https://github.com/python/cpython/pull/19823#event-3292607440
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
May 1, 2020 08:43https://github.com/python/cpython/pull/19823#event-3292607850
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
May 1, 2020https://github.com/python/cpython/pull/19823#event-3292608310
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
May 1, 2020https://github.com/python/cpython/pull/19823#issuecomment-622305005
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
May 1, 2020https://github.com/python/cpython/pull/19823#event-3292615901
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 1, 2020https://github.com/python/cpython/pull/19823#issuecomment-622305018
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
vstinnerhttps://github.com/vstinner
May 1, 2020 08:47https://github.com/python/cpython/pull/19823#event-3292616008
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 1, 2020 https://github.com/python/cpython/pull/19823#pullrequestreview-404141613
View reviewed changes https://github.com/python/cpython/pull/19823/files/1bf33096f1b0c658801c1b16efc2d15d93d85109
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/19823#pullrequestreview-404141613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
May 1, 2020https://github.com/python/cpython/pull/19823#event-3293084403
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
May 1, 2020https://github.com/python/cpython/pull/19823#issuecomment-622389998
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
0204726https://github.com/python/cpython/commit/02047265eb83a43ba18cc7fee81756f1a1a1f968
May 2, 2020https://github.com/python/cpython/pull/19823#event-3294859206
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 2, 2020https://github.com/python/cpython/pull/19823#issuecomment-622647478
@cjerdonekhttps://github.com/cjerdonek
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 2, 2020https://github.com/python/cpython/pull/19823#event-3294859254
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
May 2, 2020 01:16https://github.com/python/cpython/pull/19823#event-3294861376
bpo-29587: Enable exception chaining for gen.throw() with "yield from" #19858 https://github.com/python/cpython/pull/19858
bpo-29587: Add another test for the gen.throw() exception chain fix #19859 https://github.com/python/cpython/pull/19859
bpo-29587: Remove the exc_value NULL check in _gen_throw() #19877 https://github.com/python/cpython/pull/19877
cjerdonekhttps://github.com/cjerdonek
May 3, 2020 https://github.com/python/cpython/pull/19823#ref-commit-21893fb
https://github.com/cjerdonek
bpo-29587https://bugs.python.org/issue?@action=redirect&bpo=29587
: allow chaining NULL exceptions in _gen_throw() (https://github.com/python/cpython/commit/21893fbb74e8fde2931fbed9b511e2a41362b1ab
GH-19877https://github.com/python/cpython/pull/19877
)https://github.com/python/cpython/commit/21893fbb74e8fde2931fbed9b511e2a41362b1ab
21893fbhttps://github.com/python/cpython/commit/21893fbb74e8fde2931fbed9b511e2a41362b1ab
GH-19823https://github.com/python/cpython/pull/19823
https://github.com/cjerdonek
cjerdonekhttps://github.com/cjerdonek
May 3, 2020https://github.com/python/cpython/pull/19823#issuecomment-623069564
#19877https://github.com/python/cpython/pull/19877
21893fbhttps://github.com/python/cpython/commit/21893fbb74e8fde2931fbed9b511e2a41362b1ab
Please reload this pagehttps://github.com/python/cpython/pull/19823
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19823
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/python/cpython/pull/19823/files/57597f2738c7fe09d0a716dca72bd8feb66f447e
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/19823/files/1bf33096f1b0c658801c1b16efc2d15d93d85109
Please reload this pagehttps://github.com/python/cpython/pull/19823
https://github.com/cjerdonek
https://github.com/bedevere-bot
https://github.com/vstinner
https://github.com/1st1
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.