René's URL Explorer Experiment


Title: bpo-30587: Adds signature checking for mock autospec object method calls by claudiubelu · Pull Request #1982 · python/cpython · GitHub

Open Graph Title: bpo-30587: Adds signature checking for mock autospec object method calls by claudiubelu · Pull Request #1982 · python/cpython

X Title: bpo-30587: Adds signature checking for mock autospec object method calls by claudiubelu · Pull Request #1982 · python/cpython

Description: Mock can accept an spec object / class as argument, making sure that accessing attributes that do not exist in the spec will cause an AttributeError to be raised, but there is no guarantee that the spec's methods signatures are respected in any way. This creates the possibility to have faulty code with passing unit tests and assertions. Example: import mock class Something(object): def foo(self, a, b, c, d): pass m = mock.Mock(spec=Something) m.foo() Adds the autospec argument to Mock, and its mock_add_spec method. Passes the spec's attribute with the same name to the child mock (spec-ing the child), if the mock's autospec is True. Sets _mock_check_sig if the given spec is callable. Adds unit tests to validate the fact that the autospec method signatures are respected. https://bugs.python.org/issue30587

Open Graph Description: Mock can accept an spec object / class as argument, making sure that accessing attributes that do not exist in the spec will cause an AttributeError to be raised, but there is no guarantee that the...

X Description: Mock can accept an spec object / class as argument, making sure that accessing attributes that do not exist in the spec will cause an AttributeError to be raised, but there is no guarantee that the...

Opengraph URL: https://github.com/python/cpython/pull/1982

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:314a8bc3-4aaa-28d1-20bf-0f0197c80012
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B76:ED992:12AD9F1:1B16A08:6A58AB22
html-safe-nonce88023a61604531aa06bf8605e0b4c4eb5e3f6068195f2904c0eccc75bfd9d84b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qjc2OkVEOTkyOjEyQUQ5RjE6MUIxNkEwODo2QTU4QUIyMiIsInZpc2l0b3JfaWQiOiIxNTQ0Mjg4NjY3Mzg4MzkwMTc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaefb362135d424871f33b01b2b88e7aa5690b3acd590f82fb1d1841c8eb0cf62
hovercard-subject-tagpull_request:124400638
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/1982/files
twitter:imagehttps://avatars.githubusercontent.com/u/1552519?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1552519?s=400&v=4
og:image:altMock can accept an spec object / class as argument, making sure that accessing attributes that do not exist in the spec will cause an AttributeError to be raised, but there is no guarantee that the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d699f0c51c1f58938601870a21967b74eaad94d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1982/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1982%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1982%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1982/files
Reloadhttps://github.com/python/cpython/pull/1982/files
Reloadhttps://github.com/python/cpython/pull/1982/files
Please reload this pagehttps://github.com/python/cpython/pull/1982/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1982/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
claudiubeluhttps://github.com/claudiubelu
python:mainhttps://github.com/python/cpython/tree/main
claudiubelu:mock-add-autospechttps://github.com/claudiubelu/cpython/tree/mock-add-autospec
Conversation 17 https://github.com/python/cpython/pull/1982
Commits 4 https://github.com/python/cpython/pull/1982/commits
Checks 0 https://github.com/python/cpython/pull/1982/checks
Files changed https://github.com/python/cpython/pull/1982/files
Please reload this pagehttps://github.com/python/cpython/pull/1982/files
bpo-30587: Adds signature checking for mock autospec object method calls https://github.com/python/cpython/pull/1982/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/1982/files
13f993d bpo-30587: Adds signature checking for mock autospec object method calls claudiubelu Jun 7, 2017 https://github.com/python/cpython/pull/1982/commits/13f993dfb81cad9279d0037b8ab148f841ea103a
2aa359d Merge branch 'main' into mock-add-autospec arhadthedev Feb 5, 2023 https://github.com/python/cpython/pull/1982/commits/2aa359d4919d132fef6080842e0932a6a10125b1
2e5cbc5 Fix a merge error arhadthedev Feb 5, 2023 https://github.com/python/cpython/pull/1982/commits/2e5cbc5e3d4ef5308b4fea487031b8e512af16f6
4ecd60a Merge branch 'main' into mock-add-autospec sobolevn Mar 22, 2023 https://github.com/python/cpython/pull/1982/commits/4ecd60aef8f1813ed3356f2e7e60efb5cfe40594
Clear filters https://github.com/python/cpython/pull/1982/files
Please reload this pagehttps://github.com/python/cpython/pull/1982/files
Please reload this pagehttps://github.com/python/cpython/pull/1982/files
testmock.py https://github.com/python/cpython/pull/1982/files#diff-d12618c7a76d3adce8e582c45197c1c334dcf7ead6a5cdbfdc78ecd1482cded2
mock.py https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
2017-11-20-06-36-00.bpo-30587.1SsAy9.rst https://github.com/python/cpython/pull/1982/files#diff-f4c22a30c05b696c5d13f084d4e77d40481a805b73c111dee79c6460209a3c23
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L623
Lib/test/test_unittest/testmock/testmock.pyhttps://github.com/python/cpython/pull/1982/files#diff-d12618c7a76d3adce8e582c45197c1c334dcf7ead6a5cdbfdc78ecd1482cded2
View file https://github.com/claudiubelu/cpython/blob/4ecd60aef8f1813ed3356f2e7e60efb5cfe40594/Lib/test/test_unittest/testmock/testmock.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1982/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1982/files#diff-d12618c7a76d3adce8e582c45197c1c334dcf7ead6a5cdbfdc78ecd1482cded2
https://github.com/python/cpython/pull/1982/files#diff-d12618c7a76d3adce8e582c45197c1c334dcf7ead6a5cdbfdc78ecd1482cded2
https://github.com/python/cpython/pull/1982/files#diff-d12618c7a76d3adce8e582c45197c1c334dcf7ead6a5cdbfdc78ecd1482cded2
https://github.com/python/cpython/pull/1982/files#diff-d12618c7a76d3adce8e582c45197c1c334dcf7ead6a5cdbfdc78ecd1482cded2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L622
Lib/unittest/mock.pyhttps://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
View file https://github.com/claudiubelu/cpython/blob/4ecd60aef8f1813ed3356f2e7e60efb5cfe40594/Lib/unittest/mock.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1982/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/1982/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
Misc/NEWS.d/next/Library/2017-11-20-06-36-00.bpo-30587.1SsAy9.rsthttps://github.com/python/cpython/pull/1982/files#diff-f4c22a30c05b696c5d13f084d4e77d40481a805b73c111dee79c6460209a3c23
View file https://github.com/claudiubelu/cpython/blob/4ecd60aef8f1813ed3356f2e7e60efb5cfe40594/Misc/NEWS.d/next/Library/2017-11-20-06-36-00.bpo-30587.1SsAy9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1982/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.