René's URL Explorer Experiment


Title: bpo-40334: Improve column offsets for thrown syntax errors by Pegen by isidentical · Pull Request #19782 · python/cpython · GitHub

Open Graph Title: bpo-40334: Improve column offsets for thrown syntax errors by Pegen by isidentical · Pull Request #19782 · python/cpython

X Title: bpo-40334: Improve column offsets for thrown syntax errors by Pegen by isidentical · Pull Request #19782 · python/cpython

Description: I've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility with the old parser. https://bugs.python.org/issue40334

Open Graph Description: I've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility wit...

X Description: I've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibi...

Opengraph URL: https://github.com/python/cpython/pull/19782

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bb03fb0c-049c-1907-5e88-b9bbe21cf08c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE1A:210DE3:23654A:322448:696A416B
html-safe-nonce0853dc6f8bd612a00ab1dc8f89eb2b3db5063180faf91fc7dca6b8684e25725a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTFBOjIxMERFMzoyMzY1NEE6MzIyNDQ4OjY5NkE0MTZCIiwidmlzaXRvcl9pZCI6IjU1NzExNDA1NTU0NTA3NjE1ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac79f428cfde4b8921f8b7da01ac94a6168b9b20003ff774f72c2ec68f734dd3e6
hovercard-subject-tagpull_request:410440974
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/19782/files
twitter:imagehttps://avatars.githubusercontent.com/u/47358913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/47358913?s=400&v=4
og:image:altI've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility wit...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19782/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19782%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19782%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19782/files
Reloadhttps://github.com/python/cpython/pull/19782/files
Reloadhttps://github.com/python/cpython/pull/19782/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19782/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/19782/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
isidentical:bpo-40344https://github.com/isidentical/cpython/tree/bpo-40344
Conversation 23 https://github.com/python/cpython/pull/19782
Commits 4 https://github.com/python/cpython/pull/19782/commits
Checks 0 https://github.com/python/cpython/pull/19782/checks
Files changed https://github.com/python/cpython/pull/19782/files
Please reload this pagehttps://github.com/python/cpython/pull/19782/files
bpo-40334: Improve column offsets for thrown syntax errors by Pegen https://github.com/python/cpython/pull/19782/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/19782/files
70307d5 bpo-40334: Improve column offsets for thrown syntax errors by Pegen isidentical Apr 29, 2020 https://github.com/python/cpython/pull/19782/commits/70307d5db0e78b97c71d24e6a473607aff519b23
e6af059 Dont give column offset on decode errors isidentical Apr 29, 2020 https://github.com/python/cpython/pull/19782/commits/e6af0593eb7496d18653b43dc0ddf7e461f85338
d955590 no_col_offset => with_col_number, whitespace isidentical Apr 29, 2020 https://github.com/python/cpython/pull/19782/commits/d9555909702bf70e88068567a3cf4a2ad79f2070
ba11a58 Use RAISE_SYNTAX_ERROR instead directly using _PyPegen_raise_error isidentical May 1, 2020 https://github.com/python/cpython/pull/19782/commits/ba11a58f77e1618e31610db9ba8a515e89814b89
Clear filters https://github.com/python/cpython/pull/19782/files
Please reload this pagehttps://github.com/python/cpython/pull/19782/files
Please reload this pagehttps://github.com/python/cpython/pull/19782/files
python.gram https://github.com/python/cpython/pull/19782/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
test_cmd_line_script.py https://github.com/python/cpython/pull/19782/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
test_exceptions.py https://github.com/python/cpython/pull/19782/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
parse.c https://github.com/python/cpython/pull/19782/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
pegen.c https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
pegen.h https://github.com/python/cpython/pull/19782/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Grammar/python.gramhttps://github.com/python/cpython/pull/19782/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
View file https://github.com/isidentical/cpython/blob/ba11a58f77e1618e31610db9ba8a515e89814b89/Grammar/python.gram
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19782/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19782/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/19782/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
Lib/test/test_cmd_line_script.pyhttps://github.com/python/cpython/pull/19782/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
View file https://github.com/isidentical/cpython/blob/ba11a58f77e1618e31610db9ba8a515e89814b89/Lib/test/test_cmd_line_script.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19782/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19782/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
https://github.com/python/cpython/pull/19782/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
https://github.com/python/cpython/pull/19782/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
https://github.com/python/cpython/pull/19782/files#diff-c69c5c4fe60c0f6e7d6b899735e3671397db217175cdf3f4906087d84664e4fd
Lib/test/test_exceptions.pyhttps://github.com/python/cpython/pull/19782/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
View file https://github.com/isidentical/cpython/blob/ba11a58f77e1618e31610db9ba8a515e89814b89/Lib/test/test_exceptions.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19782/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19782/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
https://github.com/python/cpython/pull/19782/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
https://github.com/python/cpython/pull/19782/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
https://github.com/python/cpython/pull/19782/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f
Parser/pegen/parse.chttps://github.com/python/cpython/pull/19782/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
View file https://github.com/isidentical/cpython/blob/ba11a58f77e1618e31610db9ba8a515e89814b89/Parser/pegen/parse.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19782/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19782/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/pull/19782/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
View file https://github.com/isidentical/cpython/blob/ba11a58f77e1618e31610db9ba8a515e89814b89/Parser/pegen/pegen.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19782/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19782/files
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/19782/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
View file https://github.com/isidentical/cpython/blob/ba11a58f77e1618e31610db9ba8a515e89814b89/Parser/pegen/pegen.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19782/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19782/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/19782/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/19782/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/19782/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.