René's URL Explorer Experiment


Title: bpo-40334: Improve column offsets for thrown syntax errors by Pegen by isidentical · Pull Request #19782 · python/cpython · GitHub

Open Graph Title: bpo-40334: Improve column offsets for thrown syntax errors by Pegen by isidentical · Pull Request #19782 · python/cpython

X Title: bpo-40334: Improve column offsets for thrown syntax errors by Pegen by isidentical · Pull Request #19782 · python/cpython

Description: I've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility with the ol...

Open Graph Description: I've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility wit...

X Description: I've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibi...

Opengraph URL: https://github.com/python/cpython/pull/19782

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c68278a9-ae0c-7ab3-1a08-35a1c63fc82c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB83A:30AAB2:20BB77:2C5F5D:6969D02A
html-safe-nonce67a0dd92d3669dc80d24c582d31d0cb111eb9c763f5ef4b0a83389f64dabcc8b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODNBOjMwQUFCMjoyMEJCNzc6MkM1RjVEOjY5NjlEMDJBIiwidmlzaXRvcl9pZCI6IjI1NDc1MjQ5MjI0MjE5MjM4ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac38361e74e300e729b0da2c7cc88d7be2cbafbf04d35e1e11c744407869dd06f4
hovercard-subject-tagpull_request:410440974
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19782/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2ae383d12085212bc3433b44a108f059acac53c1d914d06f7c12b321098bd4d5/python/cpython/pull/19782
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2ae383d12085212bc3433b44a108f059acac53c1d914d06f7c12b321098bd4d5/python/cpython/pull/19782
og:image:altI've been trying to figure out a good way to handle ast.c errors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility wit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameisidentical
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19782#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19782
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19782
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19782
Reloadhttps://github.com/python/cpython/pull/19782
Reloadhttps://github.com/python/cpython/pull/19782
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19782
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/19782
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/19782#issue-comment-box
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
isidentical:bpo-40344https://github.com/isidentical/cpython/tree/bpo-40344
bpo-40334: Improve column offsets for thrown syntax errors by Pegen https://github.com/python/cpython/pull/19782#top
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
isidentical:bpo-40344https://github.com/isidentical/cpython/tree/bpo-40344
Conversation 23 https://github.com/python/cpython/pull/19782
Commits 4 https://github.com/python/cpython/pull/19782/commits
Checks 0 https://github.com/python/cpython/pull/19782/checks
Files changed https://github.com/python/cpython/pull/19782/files
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Apr 29, 2020https://github.com/python/cpython/pull/19782#issue-608716399
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://bugs.python.org/issue40334https://bugs.python.org/issue40334
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
pablogsalhttps://github.com/pablogsal
code ownerhttps://github.com/python/cpython/blob/703647732359200c54f1d2e695cc3a06b9a96c9a/.github/CODEOWNERS#L77
April 29, 2020 01:29https://github.com/python/cpython/pull/19782#event-3282702908
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 29, 2020https://github.com/python/cpython/pull/19782#event-3282702988
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 29, 2020https://github.com/python/cpython/pull/19782#event-3282703035
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 29, 2020https://github.com/python/cpython/pull/19782#event-3282703295
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Apr 29, 2020https://github.com/python/cpython/pull/19782#event-3282711086
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
force-pushedhttps://github.com/python/cpython/compare/ec3cce833cf6131819b88ba4158a7fdbf834d290..35044468bffae541669fa9848cca5ac7ea5f7c51
ec3cce8https://github.com/python/cpython/commit/ec3cce833cf6131819b88ba4158a7fdbf834d290
3504446https://github.com/python/cpython/commit/35044468bffae541669fa9848cca5ac7ea5f7c51
Compare https://github.com/python/cpython/compare/ec3cce833cf6131819b88ba4158a7fdbf834d290..35044468bffae541669fa9848cca5ac7ea5f7c51
April 29, 2020 01:52https://github.com/python/cpython/pull/19782#event-3282736357
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
lysnikolaouhttps://github.com/lysnikolaou
April 29, 2020 05:22https://github.com/python/cpython/pull/19782#event-3283044430
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020 https://github.com/python/cpython/pull/19782#pullrequestreview-402520603
View reviewed changes https://github.com/python/cpython/pull/19782/files
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020 https://github.com/python/cpython/pull/19782#pullrequestreview-402523212
View reviewed changes https://github.com/python/cpython/pull/19782/files
lysnikolaouhttps://github.com/lysnikolaou
https://github.com/python/cpython/pull/19782#pullrequestreview-402523212
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@isidenticalhttps://github.com/isidentical
Please reload this pagehttps://github.com/python/cpython/pull/19782
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19782
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19782
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19782
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19782/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19782
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/19782/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020 https://github.com/python/cpython/pull/19782#pullrequestreview-402589740
View reviewed changes https://github.com/python/cpython/pull/19782/files
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 29, 2020https://github.com/python/cpython/pull/19782#event-3284224231
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 1, 2020https://github.com/python/cpython/pull/19782#issuecomment-622232194
@isidenticalhttps://github.com/isidentical
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 1, 2020 https://github.com/python/cpython/pull/19782#pullrequestreview-404005858
View reviewed changes https://github.com/python/cpython/pull/19782/files
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 1, 2020https://github.com/python/cpython/pull/19782#event-3292127766
isidenticalhttps://github.com/isidentical
May 1, 2020 13:44https://github.com/python/cpython/pull/19782#commits-pushed-70307d5
https://github.com/isidentical
bpo-40334: Improve column offsets for thrown syntax errors by Pegenhttps://github.com/python/cpython/pull/19782/commits/70307d5db0e78b97c71d24e6a473607aff519b23
70307d5https://github.com/python/cpython/pull/19782/commits/70307d5db0e78b97c71d24e6a473607aff519b23
https://github.com/isidentical
Dont give column offset on decode errorshttps://github.com/python/cpython/pull/19782/commits/e6af0593eb7496d18653b43dc0ddf7e461f85338
e6af059https://github.com/python/cpython/pull/19782/commits/e6af0593eb7496d18653b43dc0ddf7e461f85338
https://github.com/isidentical
no_col_offset => with_col_number, whitespacehttps://github.com/python/cpython/pull/19782/commits/d9555909702bf70e88068567a3cf4a2ad79f2070
d955590https://github.com/python/cpython/pull/19782/commits/d9555909702bf70e88068567a3cf4a2ad79f2070
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
force-pushedhttps://github.com/python/cpython/compare/b8314946cf35ca36e51654c5d60341cb293d159c..d9555909702bf70e88068567a3cf4a2ad79f2070
b831494https://github.com/python/cpython/commit/b8314946cf35ca36e51654c5d60341cb293d159c
d955590https://github.com/python/cpython/commit/d9555909702bf70e88068567a3cf4a2ad79f2070
Compare https://github.com/python/cpython/compare/b8314946cf35ca36e51654c5d60341cb293d159c..d9555909702bf70e88068567a3cf4a2ad79f2070
May 1, 2020 10:46https://github.com/python/cpython/pull/19782#event-3292857945
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
May 1, 2020https://github.com/python/cpython/pull/19782#issuecomment-622340716
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 1, 2020https://github.com/python/cpython/pull/19782#issuecomment-622344644
Please reload this pagehttps://github.com/python/cpython/pull/19782
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 1, 2020https://github.com/python/cpython/pull/19782#issuecomment-622354030
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 1, 2020https://github.com/python/cpython/pull/19782#event-3292948161
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 1, 2020https://github.com/python/cpython/pull/19782#event-3292948214
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 1, 2020https://github.com/python/cpython/pull/19782#issuecomment-622359056
Please reload this pagehttps://github.com/python/cpython/pull/19782
@isidenticalhttps://github.com/isidentical
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/isidentical
Use RAISE_SYNTAX_ERROR instead directly using _PyPegen_raise_errorhttps://github.com/python/cpython/pull/19782/commits/ba11a58f77e1618e31610db9ba8a515e89814b89
ba11a58https://github.com/python/cpython/pull/19782/commits/ba11a58f77e1618e31610db9ba8a515e89814b89
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
May 1, 2020https://github.com/python/cpython/pull/19782#issuecomment-622361158
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
76c1b4dhttps://github.com/python/cpython/commit/76c1b4d5c5a610c09943e1ee7ae18f1957804730
May 1, 2020https://github.com/python/cpython/pull/19782#event-3293145162
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 1, 2020https://github.com/python/cpython/pull/19782#event-3293145266
Wrong column for invalid string prefix we-like-parsers/cpython#121 https://github.com/we-like-parsers/cpython/issues/121
Should we report col offset in some tokenizer errors? we-like-parsers/cpython#110 https://github.com/we-like-parsers/cpython/issues/110
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
May 11, 2020 https://github.com/python/cpython/pull/19782#ref-issue-615438672
Implementation of RAISE_SYNTAX_ERROR_NO_COL_OFFSET seems incorrect we-like-parsers/cpython#126 https://github.com/we-like-parsers/cpython/issues/126
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19782
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/19782/files/b8314946cf35ca36e51654c5d60341cb293d159c
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/python/cpython/pull/19782/files/b8314946cf35ca36e51654c5d60341cb293d159c
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/19782
https://github.com/isidentical
https://github.com/gvanrossum
https://github.com/pablogsal
https://github.com/lysnikolaou
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.