René's URL Explorer Experiment


Title: bpo-40334: Support type comments by gvanrossum · Pull Request #19780 · python/cpython · GitHub

Open Graph Title: bpo-40334: Support type comments by gvanrossum · Pull Request #19780 · python/cpython

X Title: bpo-40334: Support type comments by gvanrossum · Pull Request #19780 · python/cpython

Description: This implements full support for # type: comments, # type: ignore comments, and the func_type parsing mode for ast.parse() and compile(). Closes we-like-parsers#95 https://bugs.pyth...

Open Graph Description: This implements full support for # type: <type> comments, # type: ignore <stuff> comments, and the func_type parsing mode for ast.parse() and compile(). Closes we-like-parsers#95 https...

X Description: This implements full support for # type: &lt;type&gt; comments, # type: ignore &lt;stuff&gt; comments, and the func_type parsing mode for ast.parse() and compile(). Closes we-like-p...

Opengraph URL: https://github.com/python/cpython/pull/19780

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:759403e3-bdaa-5970-7aec-bf383d36702e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE76E:1E9341:12EBB47:1A19D61:6969FC01
html-safe-nonce9cee24a7b87dfdfbbfd6357aaeabc3e8ff4ee1c77509084d5a475d75b0131876
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzZFOjFFOTM0MToxMkVCQjQ3OjFBMTlENjE6Njk2OUZDMDEiLCJ2aXNpdG9yX2lkIjoiMTY3NzYxNjk0NjMwMDQ1MTg0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca41db2ef6a3ac89b4854bd8382ab941927b6693e42a1f884e63224c8d7efc395
hovercard-subject-tagpull_request:410425068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19780/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aa23ba61ab9321113097594b429d0bf73f59173df9bd542813f8b643b5cffcdd/python/cpython/pull/19780
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa23ba61ab9321113097594b429d0bf73f59173df9bd542813f8b643b5cffcdd/python/cpython/pull/19780
og:image:altThis implements full support for # type: <type> comments, # type: ignore <stuff> comments, and the func_type parsing mode for ast.parse() and compile(). Closes we-like-parsers#95 https...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegvanrossum
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19780#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19780
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19780
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19780
Reloadhttps://github.com/python/cpython/pull/19780
Reloadhttps://github.com/python/cpython/pull/19780
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19780
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/19780
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/19780#issue-comment-box
gvanrossumhttps://github.com/gvanrossum
masterhttps://github.com/python/cpython/tree/master
type-commentshttps://github.com/python/cpython/tree/type-comments
bpo-40334: Support type comments https://github.com/python/cpython/pull/19780#top
gvanrossumhttps://github.com/gvanrossum
masterhttps://github.com/python/cpython/tree/master
type-commentshttps://github.com/python/cpython/tree/type-comments
Conversation 36 https://github.com/python/cpython/pull/19780
Commits 12 https://github.com/python/cpython/pull/19780/commits
Checks 0 https://github.com/python/cpython/pull/19780/checks
Files changed https://github.com/python/cpython/pull/19780/files
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020https://github.com/python/cpython/pull/19780#issue-608694881
Please reload this pagehttps://github.com/python/cpython/pull/19780
we-like-parsers#95https://github.com/we-like-parsers/cpython/issues/95
https://bugs.python.org/issue40334https://bugs.python.org/issue40334
Please reload this pagehttps://github.com/python/cpython/pull/19780
gvanrossumhttps://github.com/gvanrossum
April 28, 2020 08:47https://github.com/python/cpython/pull/19780#commits-pushed-e17bb92
https://github.com/gvanrossum
First steps towards supporting type commentshttps://github.com/python/cpython/pull/19780/commits/e17bb92f6a49864ee99ad04c2e7dee8ca0e874a0
e17bb92https://github.com/python/cpython/pull/19780/commits/e17bb92f6a49864ee99ad04c2e7dee8ca0e874a0
https://github.com/gvanrossum
Support func_type_input in new parserhttps://github.com/python/cpython/pull/19780/commits/2e4126ca4b1f7bfa1c0f7b267869a6afa96382bc
2e4126chttps://github.com/python/cpython/pull/19780/commits/2e4126ca4b1f7bfa1c0f7b267869a6afa96382bc
https://github.com/gvanrossum
Support '# type: ignore 'https://github.com/python/cpython/pull/19780/commits/7b446fbe888d520dee3e28542776ccc909137be1
7b446fbhttps://github.com/python/cpython/pull/19780/commits/7b446fbe888d520dee3e28542776ccc909137be1
https://github.com/gvanrossum
Support per-argument type comments ('long form')https://github.com/python/cpython/pull/19780/commits/ed95a14898d5c56c0c6303ceede7d3c10ba5c7fc
ed95a14https://github.com/python/cpython/pull/19780/commits/ed95a14898d5c56c0c6303ceede7d3c10ba5c7fc
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
pablogsalhttps://github.com/pablogsal
code ownerhttps://github.com/python/cpython/blob/49f70db83e2c62ad06805927f53f6c3e8f4b798e/.github/CODEOWNERS#L77
April 29, 2020 00:18https://github.com/python/cpython/pull/19780#event-3282586239
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 29, 2020https://github.com/python/cpython/pull/19780#event-3282586352
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 29, 2020https://github.com/python/cpython/pull/19780#event-3282586459
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
April 29, 2020 00:18https://github.com/python/cpython/pull/19780#event-3282586811
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020https://github.com/python/cpython/pull/19780#event-3282588684
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 29, 2020https://github.com/python/cpython/pull/19780#event-3282590544
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020https://github.com/python/cpython/pull/19780#issuecomment-620923981
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020https://github.com/python/cpython/pull/19780#event-3282615988
https://github.com/gvanrossum
Fix segfault in long-form argument type commentshttps://github.com/python/cpython/pull/19780/commits/acb69b369b73669741a95cb4827bf379271c0adc
acb69b3https://github.com/python/cpython/pull/19780/commits/acb69b369b73669741a95cb4827bf379271c0adc
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020https://github.com/python/cpython/pull/19780#issuecomment-620979340
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020 https://github.com/python/cpython/pull/19780#ref-issue-609096223
Supporting feature_version=... we-like-parsers/cpython#124 https://github.com/we-like-parsers/cpython/issues/124
https://github.com/gvanrossum
Fix failing test_ast by refactoring param ruleshttps://github.com/python/cpython/pull/19780/commits/1e8f7fd6edaecbdb4e30d6edb44424f8d9258000
1e8f7fdhttps://github.com/python/cpython/pull/19780/commits/1e8f7fd6edaecbdb4e30d6edb44424f8d9258000
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
April 29, 2020 16:00https://github.com/python/cpython/pull/19780#event-3285313060
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020https://github.com/python/cpython/pull/19780#issuecomment-621340386
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
lysnikolaouhttps://github.com/lysnikolaou
April 29, 2020 17:05https://github.com/python/cpython/pull/19780#event-3285578741
https://github.com/gvanrossum
Merge remote-tracking branch 'origin/master' into type-commentshttps://github.com/python/cpython/pull/19780/commits/da253f3a72bb14d21e4c2d6114d2058f92831aaf
da253f3https://github.com/python/cpython/pull/19780/commits/da253f3a72bb14d21e4c2d6114d2058f92831aaf
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-402895939
View reviewed changes https://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf
lysnikolaouhttps://github.com/lysnikolaou
https://github.com/python/cpython/pull/19780#pullrequestreview-402895939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
Grammar/python.gramhttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
Please reload this pagehttps://github.com/python/cpython/pull/19780
Grammar/python.gramhttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
Please reload this pagehttps://github.com/python/cpython/pull/19780
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19780
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19780
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19780
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Please reload this pagehttps://github.com/python/cpython/pull/19780
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020https://github.com/python/cpython/pull/19780#issuecomment-621403060
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020https://github.com/python/cpython/pull/19780#issuecomment-621412539
Please reload this pagehttps://github.com/python/cpython/pull/19780
gvanrossumhttps://github.com/gvanrossum
April 29, 2020 12:31https://github.com/python/cpython/pull/19780#commits-pushed-86d9f69
https://github.com/gvanrossum
Fix bug in add_type_comment()https://github.com/python/cpython/pull/19780/commits/86d9f6957f462837bc77d925099cdcf5f2ee82da
86d9f69https://github.com/python/cpython/pull/19780/commits/86d9f6957f462837bc77d925099cdcf5f2ee82da
https://github.com/gvanrossum
Suggestions from code reviewhttps://github.com/python/cpython/pull/19780/commits/c8a2888e5d7f5a337fdd8b3b0ebb34d919c68d50
c8a2888https://github.com/python/cpython/pull/19780/commits/c8a2888e5d7f5a337fdd8b3b0ebb34d919c68d50
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 29, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-403002458
View reviewed changes https://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/19780#pullrequestreview-403002458
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
Please reload this pagehttps://github.com/python/cpython/pull/19780
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-403098231
View reviewed changes https://github.com/python/cpython/pull/19780/files/86d9f6957f462837bc77d925099cdcf5f2ee82da
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19780/files/da253f3a72bb14d21e4c2d6114d2058f92831aaf..86d9f6957f462837bc77d925099cdcf5f2ee82da#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020https://github.com/python/cpython/pull/19780#discussion_r417661271
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 29, 2020https://github.com/python/cpython/pull/19780#issuecomment-621524510
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-403120498
View reviewed changes https://github.com/python/cpython/pull/19780/files/c8a2888e5d7f5a337fdd8b3b0ebb34d919c68d50
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19780/files/c8a2888e5d7f5a337fdd8b3b0ebb34d919c68d50#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020https://github.com/python/cpython/pull/19780#discussion_r417681166
Please reload this pagehttps://github.com/python/cpython/pull/19780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-403121376
View reviewed changes https://github.com/python/cpython/pull/19780/files/c8a2888e5d7f5a337fdd8b3b0ebb34d919c68d50
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/19780/files/c8a2888e5d7f5a337fdd8b3b0ebb34d919c68d50#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020https://github.com/python/cpython/pull/19780#discussion_r417681874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020https://github.com/python/cpython/pull/19780#issuecomment-621535157
Please reload this pagehttps://github.com/python/cpython/pull/19780
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 30, 2020https://github.com/python/cpython/pull/19780#issuecomment-621568257
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
Refactoring some things in response to reviewhttps://github.com/python/cpython/pull/19780/commits/fd2794ba2ff959e2fb1cb98e8b1f1beecf9f98e3
fd2794bhttps://github.com/python/cpython/pull/19780/commits/fd2794ba2ff959e2fb1cb98e8b1f1beecf9f98e3
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-403425138
View reviewed changes https://github.com/python/cpython/pull/19780/files/fd2794ba2ff959e2fb1cb98e8b1f1beecf9f98e3
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/19780/files/c8a2888e5d7f5a337fdd8b3b0ebb34d919c68d50..fd2794ba2ff959e2fb1cb98e8b1f1beecf9f98e3#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020https://github.com/python/cpython/pull/19780#discussion_r417936045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
gvanrossumhttps://github.com/gvanrossum
Apr 30, 2020https://github.com/python/cpython/pull/19780#discussion_r418106078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
More thorough error checks in NEW_TYPE_COMMENThttps://github.com/python/cpython/pull/19780/commits/d081578207a9a61a158501a41d81975dfa1e365c
d081578https://github.com/python/cpython/pull/19780/commits/d081578207a9a61a158501a41d81975dfa1e365c
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-403677258
View reviewed changes https://github.com/python/cpython/pull/19780/files/d081578207a9a61a158501a41d81975dfa1e365c
lysnikolaouhttps://github.com/lysnikolaou
https://github.com/python/cpython/pull/19780#pullrequestreview-403677258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
Grammar/python.gramhttps://github.com/python/cpython/pull/19780/files/d081578207a9a61a158501a41d81975dfa1e365c#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020https://github.com/python/cpython/pull/19780#discussion_r418131314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
Add CHECK() around _PyPegen_seq_append_to_end() callhttps://github.com/python/cpython/pull/19780/commits/fecd8e89615371813bd01440155ac47ff7342220
fecd8e8https://github.com/python/cpython/pull/19780/commits/fecd8e89615371813bd01440155ac47ff7342220
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 30, 2020https://github.com/python/cpython/pull/19780#issuecomment-622008116
@lysnikolaouhttps://github.com/lysnikolaou
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Apr 30, 2020 https://github.com/python/cpython/pull/19780#pullrequestreview-403791560
View reviewed changes https://github.com/python/cpython/pull/19780/files/fecd8e89615371813bd01440155ac47ff7342220
lysnikolaouhttps://github.com/lysnikolaou
https://github.com/python/cpython/pull/19780#pullrequestreview-403791560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
c001c09https://github.com/python/cpython/commit/c001c09e9059ba04bc088349cd87a1374dc0754f
Apr 30, 2020https://github.com/python/cpython/pull/19780#event-3290958002
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
April 30, 2020 19:12https://github.com/python/cpython/pull/19780#event-3290958150
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 30, 2020https://github.com/python/cpython/pull/19780#event-3290958227
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
May 1, 2020https://github.com/python/cpython/pull/19780#issuecomment-622185316
Please reload this pagehttps://github.com/python/cpython/pull/19780
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 1, 2020 https://github.com/python/cpython/pull/19780#ref-pullrequest-610522982
bpo-40334: Ensure that tok->type_comments is set on every path #19828 https://github.com/python/cpython/pull/19828
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 1, 2020https://github.com/python/cpython/pull/19780#issuecomment-622221719
#19828https://github.com/python/cpython/pull/19828
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 4, 2020https://github.com/python/cpython/pull/19780#issuecomment-623251021
#19894https://github.com/python/cpython/pull/19894
Please reload this pagehttps://github.com/python/cpython/pull/19780
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19780
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/python/cpython/pull/19780/files/fecd8e89615371813bd01440155ac47ff7342220
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Supporting type_comments=True https://github.com/we-like-parsers/cpython/issues/95
Please reload this pagehttps://github.com/python/cpython/pull/19780
https://github.com/gvanrossum
https://github.com/lysnikolaou
https://github.com/hauntsaninja
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.