Title: bpo-40334: Fix test_peg_parser to actually use the old parser by lysnikolaou · Pull Request #19778 · python/cpython · GitHub
Open Graph Title: bpo-40334: Fix test_peg_parser to actually use the old parser by lysnikolaou · Pull Request #19778 · python/cpython
X Title: bpo-40334: Fix test_peg_parser to actually use the old parser by lysnikolaou · Pull Request #19778 · python/cpython
Description: Now that the default parser is the new PEG parser, ast.parse uses it, which means that we don't actually test something in test_peg_parser. This PR introduces a new kwarg oldparser for _peg_parser.parse_string for specifying that a string needs to be parsed with the old parser. This kwarg is used in the tests to actually compare the ASTs the new parser generates with those generated by the old parser. Closes we-like-parsers/cpyhton#93. https://bugs.python.org/issue40334
Open Graph Description: Now that the default parser is the new PEG parser, ast.parse uses it, which means that we don't actually test something in test_peg_parser. This PR introduces a new kwarg oldparser for _peg_par...
X Description: Now that the default parser is the new PEG parser, ast.parse uses it, which means that we don't actually test something in test_peg_parser. This PR introduces a new kwarg oldparser for _peg...
Opengraph URL: https://github.com/python/cpython/pull/19778
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ae7d925f-ca97-ee51-4e16-09e7b610514a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F62:36DBB6:C35565:111FCFC:696A36E2 |
| html-safe-nonce | 80d907c359eb60fd353cf9997e37a87a446a59979f127d79fbe032344336cbd1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjYyOjM2REJCNjpDMzU1NjU6MTExRkNGQzo2OTZBMzZFMiIsInZpc2l0b3JfaWQiOiI1NjQ4NDYxNzAwNjI5NDExNTU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 108359c2180e45b62626e0ac45f83c66106e5a6ce76293f36f5a23d8f3fd2fe3 |
| hovercard-subject-tag | pull_request:410414217 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/19778/files |
| twitter:image | https://avatars.githubusercontent.com/u/20306270?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/20306270?s=400&v=4 |
| og:image:alt | Now that the default parser is the new PEG parser, ast.parse uses it, which means that we don't actually test something in test_peg_parser. This PR introduces a new kwarg oldparser for _peg_par... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width