| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6acddf0f-f9bd-fb51-da39-5b19633994d5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D64C:106C25:4385EA:5FB566:696A45E2 |
| html-safe-nonce | 98407edbcef0d9a804213cd477cf816c8b62f3c0da09e94202a6d8211b3a1e93 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjRDOjEwNkMyNTo0Mzg1RUE6NUZCNTY2OjY5NkE0NUUyIiwidmlzaXRvcl9pZCI6IjEwMDgyODYyMjM1Mjk4MjE2NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 145473e4efd5ffaf17a141dc87613397ac5418bb92f0120f880989bc2825241c |
| hovercard-subject-tag | pull_request:410410596 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19775/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/74df2b0921b12b4f8c3f38f982d9660b9c35a9295d23128eba395e4f259030b7/python/cpython/pull/19775 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/74df2b0921b12b4f8c3f38f982d9660b9c35a9295d23128eba395e4f259030b7/python/cpython/pull/19775 |
| og:image:alt | Improvements in this PR:
No more relying on the string names to deduce the types of local variables.
No more threading down the names of local variables from all functions and
visiting: now the co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pablogsal |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/19775#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19775 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19775 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/19775 |
| Reload | https://github.com/python/cpython/pull/19775 |
| Reload | https://github.com/python/cpython/pull/19775 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/19775#issue-comment-box |
| pablogsal | https://github.com/pablogsal |
| python:master | https://github.com/python/cpython/tree/master |
| pablogsal:better_generator | https://github.com/pablogsal/cpython/tree/better_generator |
|
bpo-40334: refactor and cleanup for the PEG generators
| https://github.com/python/cpython/pull/19775#top |
| pablogsal | https://github.com/pablogsal |
| python:master | https://github.com/python/cpython/tree/master |
| pablogsal:better_generator | https://github.com/pablogsal/cpython/tree/better_generator |
|
Conversation
16
| https://github.com/python/cpython/pull/19775 |
|
Commits
3
| https://github.com/python/cpython/pull/19775/commits |
|
Checks
0
| https://github.com/python/cpython/pull/19775/checks |
|
Files changed
| https://github.com/python/cpython/pull/19775/files |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 28, 2020 | https://github.com/python/cpython/pull/19775#issue-608676832 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| @lysnikolaou | https://github.com/lysnikolaou |
| bpo-40334: Refactor peg_generator to receive a Tokens file when building c code #19745 (comment) | https://github.com/python/cpython/pull/19745#discussion_r416517829 |
| https://bugs.python.org/issue40334 | https://bugs.python.org/issue40334 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| lysnikolaou | https://github.com/lysnikolaou |
| April 28, 2020 23:23 | https://github.com/python/cpython/pull/19775#event-3282486454 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Apr 28, 2020 | https://github.com/python/cpython/pull/19775#event-3282486524 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 28, 2020 | https://github.com/python/cpython/pull/19775#event-3282486645 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Apr 28, 2020 | https://github.com/python/cpython/pull/19775#event-3282490293 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/85427487aa6637160396a0e78dc3ffaf74620e3c..be64838a9060d47f5d962a9cf0c9bb3ccbd052f2 |
| 8542748 | https://github.com/python/cpython/commit/85427487aa6637160396a0e78dc3ffaf74620e3c |
| be64838 | https://github.com/python/cpython/commit/be64838a9060d47f5d962a9cf0c9bb3ccbd052f2 |
|
Compare
| https://github.com/python/cpython/compare/85427487aa6637160396a0e78dc3ffaf74620e3c..be64838a9060d47f5d962a9cf0c9bb3ccbd052f2 |
| April 28, 2020 23:28 | https://github.com/python/cpython/pull/19775#event-3282496023 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 28, 2020 | https://github.com/python/cpython/pull/19775#event-3282496314 |
|
| https://github.com/pablogsal |
| bpo-40334: refactor and cleanup for the PEG generators | https://github.com/python/cpython/pull/19775/commits/61cd349c35c2523e8d1b4a307e1a3916ce434484 |
| 61cd349 | https://github.com/python/cpython/pull/19775/commits/61cd349c35c2523e8d1b4a307e1a3916ce434484 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/be64838a9060d47f5d962a9cf0c9bb3ccbd052f2..61cd349c35c2523e8d1b4a307e1a3916ce434484 |
| be64838 | https://github.com/python/cpython/commit/be64838a9060d47f5d962a9cf0c9bb3ccbd052f2 |
| 61cd349 | https://github.com/python/cpython/commit/61cd349c35c2523e8d1b4a307e1a3916ce434484 |
|
Compare
| https://github.com/python/cpython/compare/be64838a9060d47f5d962a9cf0c9bb3ccbd052f2..61cd349c35c2523e8d1b4a307e1a3916ce434484 |
| April 28, 2020 23:29 | https://github.com/python/cpython/pull/19775#event-3282496810 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| gvanrossum | https://github.com/gvanrossum |
| April 29, 2020 00:20 | https://github.com/python/cpython/pull/19775#event-3282589303 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| Apr 29, 2020 | https://github.com/python/cpython/pull/19775#issuecomment-621054378 |
| @lysnikolaou | https://github.com/lysnikolaou |
| #19745 (comment) | https://github.com/python/cpython/pull/19745#discussion_r416517829 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
|
Apr 29, 2020
| https://github.com/python/cpython/pull/19775#pullrequestreview-402454796 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19775/files/61cd349c35c2523e8d1b4a307e1a3916ce434484 |
| lysnikolaou | https://github.com/lysnikolaou |
| https://github.com/python/cpython/pull/19775#pullrequestreview-402454796 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| Tools/peg_generator/pegen/c_generator.py | https://github.com/python/cpython/pull/19775/files/61cd349c35c2523e8d1b4a307e1a3916ce434484#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| Tools/peg_generator/pegen/c_generator.py | https://github.com/python/cpython/pull/19775/files/61cd349c35c2523e8d1b4a307e1a3916ce434484#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| Tools/peg_generator/pegen/c_generator.py | https://github.com/python/cpython/pull/19775/files/61cd349c35c2523e8d1b4a307e1a3916ce434484#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| Tools/peg_generator/pegen/c_generator.py | https://github.com/python/cpython/pull/19775/files/61cd349c35c2523e8d1b4a307e1a3916ce434484#diff-72bca3f9d3b81d7845baeb20190030d93e9630cb86ebba88854010f7142828a0 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| pablogsal | https://github.com/pablogsal |
| April 29, 2020 10:12 | https://github.com/python/cpython/pull/19775#commits-pushed-a87dff6 |
|
| https://github.com/pablogsal |
|
| https://github.com/lysnikolaou |
| Update Tools/peg_generator/pegen/c_generator.py | https://github.com/python/cpython/pull/19775/commits/a87dff647f37e9a5fec9b519a79100c15ba0dab7 |
| a87dff6 | https://github.com/python/cpython/pull/19775/commits/a87dff647f37e9a5fec9b519a79100c15ba0dab7 |
|
| https://github.com/pablogsal |
| Address feedback | https://github.com/python/cpython/pull/19775/commits/50c88b49f457944faa18c7404f68f6710c239ad1 |
| 50c88b4 | https://github.com/python/cpython/pull/19775/commits/50c88b49f457944faa18c7404f68f6710c239ad1 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| lysnikolaou | https://github.com/lysnikolaou |
| April 29, 2020 09:17 | https://github.com/python/cpython/pull/19775#event-3283718416 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
|
Apr 29, 2020
| https://github.com/python/cpython/pull/19775#pullrequestreview-402500301 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19775/files/50c88b49f457944faa18c7404f68f6710c239ad1 |
| lysnikolaou | https://github.com/lysnikolaou |
| https://github.com/python/cpython/pull/19775#pullrequestreview-402500301 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| 4db245e | https://github.com/python/cpython/commit/4db245ee9ddbe6c53d375de59a35ff59dea2a8e0 |
| Apr 29, 2020 | https://github.com/python/cpython/pull/19775#event-3283805127 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 29, 2020 | https://github.com/python/cpython/pull/19775#event-3283805313 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| April 29, 2020 09:42 | https://github.com/python/cpython/pull/19775#event-3283805413 |
| https://github.com/bedevere-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19775 |
| https://github.com/bedevere-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19775 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 29, 2020 | https://github.com/python/cpython/pull/19775#issuecomment-621134670 |
| #19791 | https://github.com/python/cpython/pull/19791 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| https://github.com/bedevere-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19775 |
| https://github.com/bedevere-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19775 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
|
Apr 30, 2020
| https://github.com/python/cpython/pull/19775#ref-pullrequest-608694881 |
|
bpo-40334: Support type comments
#19780
| https://github.com/python/cpython/pull/19780 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
Apr 30, 2020
| https://github.com/python/cpython/pull/19775#ref-pullrequest-610254236 |
|
bpo-40334: Simplify type handling in the PEG c_generator
#19818
| https://github.com/python/cpython/pull/19818 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Apr 30, 2020 | https://github.com/python/cpython/pull/19775#issuecomment-622050604 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19775 |
|
| https://github.com/lysnikolaou |
|
lysnikolaou
| https://github.com/lysnikolaou |
|
| https://github.com/python/cpython/pull/19775/files/50c88b49f457944faa18c7404f68f6710c239ad1 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/19775 |
|
| https://github.com/pablogsal |
|
| https://github.com/lysnikolaou |
|
| https://github.com/bedevere-bot |
|
| https://github.com/gvanrossum |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |