| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fd4e2c0f-d2c7-97aa-1539-f951d08f44d4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E92:291671:6C090F:93B19B:6969E491 |
| html-safe-nonce | 328a50239327e102da5e69a0487ebef5e731c704cb86e8f18edaeb8945e8fa4f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTkyOjI5MTY3MTo2QzA5MEY6OTNCMTlCOjY5NjlFNDkxIiwidmlzaXRvcl9pZCI6IjgzMzc0MTU0NjE5MzM4MDI2NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4648fb2ebcca3affe00b1a19eef918ed5a9d655e90e9c367d66fd8bd6c3cebb7 |
| hovercard-subject-tag | pull_request:409171214 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19723/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0342692041e7c973fc40453982cd41f68fa9e8dec88f2549f4b460c025a693ce/python/cpython/pull/19723 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0342692041e7c973fc40453982cd41f68fa9e8dec88f2549f4b460c025a693ce/python/cpython/pull/19723 |
| og:image:alt | We forgot to add the test/test_peg_generator folder to LIBSUBDIRS in the Makefile and the windows files.
https://bugs.python.org/issue40334 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pablogsal |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/19723#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19723 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19723 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/19723 |
| Reload | https://github.com/python/cpython/pull/19723 |
| Reload | https://github.com/python/cpython/pull/19723 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/19723#issue-comment-box |
| pablogsal | https://github.com/pablogsal |
| python:master | https://github.com/python/cpython/tree/master |
| pablogsal:bpo-40334-makefile | https://github.com/pablogsal/cpython/tree/bpo-40334-makefile |
|
bpo-40334: Add tests/test_peg_generator to the install files target
| https://github.com/python/cpython/pull/19723#top |
| pablogsal | https://github.com/pablogsal |
| python:master | https://github.com/python/cpython/tree/master |
| pablogsal:bpo-40334-makefile | https://github.com/pablogsal/cpython/tree/bpo-40334-makefile |
|
Conversation
3
| https://github.com/python/cpython/pull/19723 |
|
Commits
1
| https://github.com/python/cpython/pull/19723/commits |
|
Checks
0
| https://github.com/python/cpython/pull/19723/checks |
|
Files changed
| https://github.com/python/cpython/pull/19723/files |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 26, 2020 | https://github.com/python/cpython/pull/19723#issue-607131533 |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
| https://bugs.python.org/issue40334 | https://bugs.python.org/issue40334 |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Apr 26, 2020 | https://github.com/python/cpython/pull/19723#event-3273457377 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 26, 2020 | https://github.com/python/cpython/pull/19723#event-3273457424 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/1fb311b6e2b22ebfe5892c7336a1812af631b9e9..e3a152e44a197c6664a84d9568e4b5058c49c848 |
| 1fb311b | https://github.com/python/cpython/commit/1fb311b6e2b22ebfe5892c7336a1812af631b9e9 |
| e3a152e | https://github.com/python/cpython/commit/e3a152e44a197c6664a84d9568e4b5058c49c848 |
|
Compare
| https://github.com/python/cpython/compare/1fb311b6e2b22ebfe5892c7336a1812af631b9e9..e3a152e44a197c6664a84d9568e4b5058c49c848 |
| April 26, 2020 22:49 | https://github.com/python/cpython/pull/19723#event-3273462491 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Apr 26, 2020 | https://github.com/python/cpython/pull/19723#event-3273475642 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| gvanrossum | https://github.com/gvanrossum |
| lysnikolaou | https://github.com/lysnikolaou |
| April 27, 2020 00:38 | https://github.com/python/cpython/pull/19723#event-3273562363 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 27, 2020 | https://github.com/python/cpython/pull/19723#event-3273562604 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/18d00daaaf1f1ceb41cfb3e1f184a1c475e678d2..fb1d7a1f07ee32c0b868c260d4f5415b20c629fb |
| 18d00da | https://github.com/python/cpython/commit/18d00daaaf1f1ceb41cfb3e1f184a1c475e678d2 |
| fb1d7a1 | https://github.com/python/cpython/commit/fb1d7a1f07ee32c0b868c260d4f5415b20c629fb |
|
Compare
| https://github.com/python/cpython/compare/18d00daaaf1f1ceb41cfb3e1f184a1c475e678d2..fb1d7a1f07ee32c0b868c260d4f5415b20c629fb |
| April 27, 2020 00:44 | https://github.com/python/cpython/pull/19723#event-3273569434 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| code owner | https://github.com/python/cpython/blob/68b352a6982f51e19bf9b9f4ae61b34f5864d131/.github/CODEOWNERS#L90 |
| April 27, 2020 00:44 | https://github.com/python/cpython/pull/19723#event-3273569435 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/114dc734fa386c5c8e7648c97c72d6709e9b03dc..f41a09ca4dc4a6e5e820a077fd0040a626aec62d |
| 114dc73 | https://github.com/python/cpython/commit/114dc734fa386c5c8e7648c97c72d6709e9b03dc |
| f41a09c | https://github.com/python/cpython/commit/f41a09ca4dc4a6e5e820a077fd0040a626aec62d |
|
Compare
| https://github.com/python/cpython/compare/114dc734fa386c5c8e7648c97c72d6709e9b03dc..f41a09ca4dc4a6e5e820a077fd0040a626aec62d |
| April 27, 2020 00:49 | https://github.com/python/cpython/pull/19723#event-3273575426 |
|
| https://github.com/pablogsal |
| Add tests/test_peg_generator to the install files | https://github.com/python/cpython/pull/19723/commits/ef9d9335c71d093d8bb100bb0ef95da700634d77 |
| ef9d933 | https://github.com/python/cpython/pull/19723/commits/ef9d9335c71d093d8bb100bb0ef95da700634d77 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| force-pushed | https://github.com/python/cpython/compare/f41a09ca4dc4a6e5e820a077fd0040a626aec62d..ef9d9335c71d093d8bb100bb0ef95da700634d77 |
| f41a09c | https://github.com/python/cpython/commit/f41a09ca4dc4a6e5e820a077fd0040a626aec62d |
| ef9d933 | https://github.com/python/cpython/commit/ef9d9335c71d093d8bb100bb0ef95da700634d77 |
|
Compare
| https://github.com/python/cpython/compare/f41a09ca4dc4a6e5e820a077fd0040a626aec62d..ef9d9335c71d093d8bb100bb0ef95da700634d77 |
| April 27, 2020 00:50 | https://github.com/python/cpython/pull/19723#event-3273576234 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Apr 27, 2020
| https://github.com/python/cpython/pull/19723#pullrequestreview-400606413 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19723/files/ef9d9335c71d093d8bb100bb0ef95da700634d77 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/cpython/pull/19723#pullrequestreview-400606413 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 27, 2020 | https://github.com/python/cpython/pull/19723#event-3273825305 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 27, 2020 | https://github.com/python/cpython/pull/19723#event-3274996351 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| 4044c84 | https://github.com/python/cpython/commit/4044c843a5c6788b228d9aa38f51676f43b2ae94 |
| Apr 27, 2020 | https://github.com/python/cpython/pull/19723#event-3275051316 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Apr 27, 2020 | https://github.com/python/cpython/pull/19723#event-3275051451 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| April 27, 2020 10:18 | https://github.com/python/cpython/pull/19723#event-3275051950 |
| https://github.com/bedevere-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19723 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 27, 2020 | https://github.com/python/cpython/pull/19723#issuecomment-619910353 |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
| CuriousLearner | https://github.com/CuriousLearner |
|
Apr 27, 2020
| https://github.com/python/cpython/pull/19723#ref-commit-42c39a3 |
|
| https://github.com/CuriousLearner |
| Merge branch 'master' of github.com:python/cpython into fix-issue21914 | https://github.com/CuriousLearner/cpython/commit/42c39a33860569e8288479f92d66422ffd640e51 |
| 42c39a3 | https://github.com/CuriousLearner/cpython/commit/42c39a33860569e8288479f92d66422ffd640e51 |
| pythonGH-19723 | https://github.com/python/cpython/pull/19723 |
| pythonGH-19720 | https://github.com/python/cpython/pull/19720 |
| pythonGH-19729 | https://github.com/python/cpython/pull/19729 |
| pythonGH-16607 | https://github.com/python/cpython/pull/16607 |
| pythonGH-19725 | https://github.com/python/cpython/pull/19725 |
| pythonGH-19724 | https://github.com/python/cpython/pull/19724 |
| pythonGH-19718 | https://github.com/python/cpython/pull/19718 |
| pythonGH-19717 | https://github.com/python/cpython/pull/19717 |
| pythonGH-19504 | https://github.com/python/cpython/pull/19504 |
| pythonGH-19601 | https://github.com/python/cpython/pull/19601 |
| pythonGH-19603 | https://github.com/python/cpython/pull/19603 |
| pythonGH-19600 | https://github.com/python/cpython/pull/19600 |
| pythonGH-19705 | https://github.com/python/cpython/pull/19705 |
| pythonGH-19709 | https://github.com/python/cpython/pull/19709 |
| pythonGH-19704 | https://github.com/python/cpython/pull/19704 |
| pythonGH-19688 | https://github.com/python/cpython/pull/19688 |
| pythonGH-19663 | https://github.com/python/cpython/pull/19663 |
| pythonGH-19694 | https://github.com/python/cpython/pull/19694 |
| pythonGH-19697 | https://github.com/python/cpython/pull/19697 |
| pythonGH-19696 | https://github.com/python/cpython/pull/19696 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19723 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/cpython/pull/19723/files/ef9d9335c71d093d8bb100bb0ef95da700634d77 |
|
| https://github.com/lysnikolaou |
|
lysnikolaou
| https://github.com/lysnikolaou |
|
| https://github.com/pablogsal |
|
pablogsal
| https://github.com/pablogsal |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/19723 |
|
| https://github.com/pablogsal |
|
| https://github.com/bedevere-bot |
|
| https://github.com/gvanrossum |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |