| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d9d9cf3e-823b-4e90-f3d4-4b3b83dd5edf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C594:2C4B08:1208EEA:18C0A4C:6969FC02 |
| html-safe-nonce | 611f30952e67eac68bdc359240097602e78a69019c285c0e7dd7b6082489d70a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTk0OjJDNEIwODoxMjA4RUVBOjE4QzBBNEM6Njk2OUZDMDIiLCJ2aXNpdG9yX2lkIjoiMzA1ODIzMjQ5NTY3NzUwNDUxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6ec0a4050dc932b78cece71ba5bc7a580e4b7a55f380a1070376d5fb33553076 |
| hovercard-subject-tag | pull_request:407609184 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19669/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/66eb8f0e2ab2215f1adfa4daa9320b9766a4979c3b8536b0e15e6792dc7b8a3a/python/cpython/pull/19669 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/66eb8f0e2ab2215f1adfa4daa9320b9766a4979c3b8536b0e15e6792dc7b8a3a/python/cpython/pull/19669 |
| og:image:alt | These are all related to @vstinner's review of the PEP 617 PR.
The most important changes include moving pegen_interface.h
into Include/internal and refactoring some code in
Parser/pegen/pegen.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lysnikolaou |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/19669#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19669 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19669 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/19669 |
| Reload | https://github.com/python/cpython/pull/19669 |
| Reload | https://github.com/python/cpython/pull/19669 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/19669#issue-comment-box |
| pablogsal | https://github.com/pablogsal |
| python:master | https://github.com/python/cpython/tree/master |
| lysnikolaou:review | https://github.com/lysnikolaou/cpython/tree/review |
|
bpo-40334: Improve various PEG-Parser related stuff
| https://github.com/python/cpython/pull/19669#top |
| pablogsal | https://github.com/pablogsal |
| python:master | https://github.com/python/cpython/tree/master |
| lysnikolaou:review | https://github.com/lysnikolaou/cpython/tree/review |
|
Conversation
15
| https://github.com/python/cpython/pull/19669 |
|
Commits
7
| https://github.com/python/cpython/pull/19669/commits |
|
Checks
0
| https://github.com/python/cpython/pull/19669/checks |
|
Files changed
| https://github.com/python/cpython/pull/19669/files |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#issue-605149443 |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| @vstinner | https://github.com/vstinner |
| https://bugs.python.org/issue40334 | https://bugs.python.org/issue40334 |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
|
| https://github.com/lysnikolaou |
| bpo-40334: Improve various PEG-Parser related stuff | https://github.com/python/cpython/pull/19669/commits/70b9712056a4086a6968577c86c4afdfb326458a |
| 70b9712 | https://github.com/python/cpython/pull/19669/commits/70b9712056a4086a6968577c86c4afdfb326458a |
| @vstinner | https://github.com/vstinner |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| pablogsal | https://github.com/pablogsal |
| code owners | https://github.com/python/cpython/blob/ce0eacb19cdc7e35b62839649003edd6196dd70f/.github/CODEOWNERS#L90 |
| April 23, 2020 00:07 | https://github.com/python/cpython/pull/19669#event-3262879513 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#event-3262879635 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#event-3262879736 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#issuecomment-618102821 |
| #19670 | https://github.com/python/cpython/pull/19670 |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Apr 23, 2020
| https://github.com/python/cpython/pull/19669#ref-pullrequest-605149542 |
|
bpo-40334: Rename PyConfig.use_peg to _use_peg_parser
#19670
| https://github.com/python/cpython/pull/19670 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#issuecomment-618103124 |
| #19670 | https://github.com/python/cpython/pull/19670 |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Apr 23, 2020
| https://github.com/python/cpython/pull/19669#pullrequestreview-398675867 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19669/files/70b9712056a4086a6968577c86c4afdfb326458a |
| Parser/pegen/pegen.c | https://github.com/python/cpython/pull/19669/files/70b9712056a4086a6968577c86c4afdfb326458a#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| Parser/pegen/pegen.c | https://github.com/python/cpython/pull/19669/files/70b9712056a4086a6968577c86c4afdfb326458a#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| Include/internal/pegen_interface.h | https://github.com/python/cpython/pull/19669/files/70b9712056a4086a6968577c86c4afdfb326458a#diff-3bd1a564e290fb847cbdbd5f6bfd8dfac6e8dd6b16eb924ee4618acce6ce8bef |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| lysnikolaou | https://github.com/lysnikolaou |
| April 23, 2020 03:32 | https://github.com/python/cpython/pull/19669#commits-pushed-68a81f1 |
|
| https://github.com/lysnikolaou |
| Revert changes that conflict with another PR | https://github.com/python/cpython/pull/19669/commits/68a81f1a500178de0602eec789cfe988db1e2e22 |
| 68a81f1 | https://github.com/python/cpython/pull/19669/commits/68a81f1a500178de0602eec789cfe988db1e2e22 |
|
| https://github.com/lysnikolaou |
| Address feedback | https://github.com/python/cpython/pull/19669/commits/f020c0ae67542f11e525c84bb51c48e815ae9b7d |
| f020c0a | https://github.com/python/cpython/pull/19669/commits/f020c0ae67542f11e525c84bb51c48e815ae9b7d |
|
| https://github.com/lysnikolaou |
| Set p->size when memory allocation for a Token fails | https://github.com/python/cpython/pull/19669/commits/cb42515360bbc13ec914f95b153b9d1bb41b3255 |
| cb42515 | https://github.com/python/cpython/pull/19669/commits/cb42515360bbc13ec914f95b153b9d1bb41b3255 |
|
| https://github.com/lysnikolaou |
| Fix init_normalization | https://github.com/python/cpython/pull/19669/commits/39cf86b7baf7730bd503c21224ced3aeb3725bb2 |
| 39cf86b | https://github.com/python/cpython/pull/19669/commits/39cf86b7baf7730bd503c21224ced3aeb3725bb2 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#event-3262986461 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| vstinner | https://github.com/vstinner |
| April 23, 2020 01:37 | https://github.com/python/cpython/pull/19669#event-3263036109 |
|
| https://github.com/lysnikolaou |
| Fix refcount issue in raise_tokenizer_init_error | https://github.com/python/cpython/pull/19669/commits/62ae3f9b24f3279ade99e4a1ba6df5b9fbf1dd14 |
| 62ae3f9 | https://github.com/python/cpython/pull/19669/commits/62ae3f9b24f3279ade99e4a1ba6df5b9fbf1dd14 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Apr 23, 2020
| https://github.com/python/cpython/pull/19669#pullrequestreview-399148561 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19669/files/62ae3f9b24f3279ade99e4a1ba6df5b9fbf1dd14 |
| Parser/pegen/pegen.c | https://github.com/python/cpython/pull/19669/files/62ae3f9b24f3279ade99e4a1ba6df5b9fbf1dd14#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| Parser/pegen/pegen.c | https://github.com/python/cpython/pull/19669/files/62ae3f9b24f3279ade99e4a1ba6df5b9fbf1dd14#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| Parser/pegen/pegen.c | https://github.com/python/cpython/pull/19669/files/62ae3f9b24f3279ade99e4a1ba6df5b9fbf1dd14#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| Parser/pegen/pegen.c | https://github.com/python/cpython/pull/19669/files/62ae3f9b24f3279ade99e4a1ba6df5b9fbf1dd14#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
|
| https://github.com/lysnikolaou |
| Respond to latest feedback | https://github.com/python/cpython/pull/19669/commits/94c456c57215d03de28d49f131b842a6afa7e244 |
| 94c456c | https://github.com/python/cpython/pull/19669/commits/94c456c57215d03de28d49f131b842a6afa7e244 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Apr 23, 2020
| https://github.com/python/cpython/pull/19669#pullrequestreview-399208508 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19669/files/94c456c57215d03de28d49f131b842a6afa7e244 |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/19669#pullrequestreview-399208508 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#event-3265505973 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#issuecomment-618465312 |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| ebebb64 | https://github.com/python/cpython/commit/ebebb6429c224c713e1c63a0b05d4840f52c7415 |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#event-3265579963 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Apr 23, 2020 | https://github.com/python/cpython/pull/19669#event-3265580189 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| April 23, 2020 15:38 | https://github.com/python/cpython/pull/19669#event-3265590535 |
| https://github.com/imzhuhl |
| imzhuhl | https://github.com/imzhuhl |
|
Jul 28, 2022
| https://github.com/python/cpython/pull/19669#ref-issue-1320400335 |
|
Check tokens[0] after allocating memory
#95355
| https://github.com/python/cpython/issues/95355 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19669 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/19669/files/94c456c57215d03de28d49f131b842a6afa7e244 |
|
| https://github.com/pablogsal |
|
pablogsal
| https://github.com/pablogsal |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/19669 |
|
| https://github.com/lysnikolaou |
|
| https://github.com/vstinner |
|
| https://github.com/pablogsal |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |