| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3c75f264-552a-dbb7-7336-8f51f4edb2f0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 927C:16740E:49206D:62BD34:6A524CC6 |
| html-safe-nonce | c6720841826420f0d0636756b423df9eaaf9ea4c76640a52911de2b078853a7e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjdDOjE2NzQwRTo0OTIwNkQ6NjJCRDM0OjZBNTI0Q0M2IiwidmlzaXRvcl9pZCI6IjE1MjA2MzQ0NTcxMjc4MDAwMDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b87dff4550436b0184adfe2f256eaf54c265ca5b8abea02f9e6f145b28ef3245 |
| hovercard-subject-tag | pull_request:124084843 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/1963/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2148a7fc13f9d39d75ad2c056d80eadf593aa5999335d9d175144fef3e1afefe/python/cpython/pull/1963 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2148a7fc13f9d39d75ad2c056d80eadf593aa5999335d9d175144fef3e1afefe/python/cpython/pull/1963 |
| og:image:alt | I silenced the specific warnings we are getting and not all warnings from those external libraries that build with warnings.
Those are hand rolled msbuild files and I'm no msbuild expert. So I ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | segevfiner |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/1963#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1963 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1963 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/1963 |
| Reload | https://github.com/python/cpython/pull/1963 |
| Reload | https://github.com/python/cpython/pull/1963 |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.7k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| zware | https://github.com/zware |
| python:master | https://github.com/python/cpython/tree/master |
| segevfiner:fix-msvc-warnings | https://github.com/segevfiner/cpython/tree/fix-msvc-warnings |
| Conversation | https://github.com/python/cpython/pull/1963 |
| Commits8 (8) | https://github.com/python/cpython/pull/1963/commits |
| Checks | https://github.com/python/cpython/pull/1963/checks |
| Files changed | https://github.com/python/cpython/pull/1963/files |
| bpo-30631: Silence MSVC warnings (win32) | https://github.com/python/cpython/pull/1963#top |
| zware | https://github.com/zware |
| python:master | https://github.com/python/cpython/tree/master |
| segevfiner:fix-msvc-warnings | https://github.com/segevfiner/cpython/tree/fix-msvc-warnings |
|
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 5, 2017 | https://github.com/python/cpython/pull/1963#issue-233743398 |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| segevfiner | https://github.com/segevfiner |
| June 6, 2017 01:55 | https://github.com/python/cpython/pull/1963#commits-pushed-bd970bc |
|
| https://github.com/segevfiner |
| Silence liblzma warnings in MSVC | https://github.com/python/cpython/pull/1963/commits/bd970bc8308d6d5aeb51cbcfde173b118e824351 |
| bd970bc | https://github.com/python/cpython/pull/1963/commits/bd970bc8308d6d5aeb51cbcfde173b118e824351 |
|
| https://github.com/segevfiner |
| Silence socketmodule.c warnings in MSVC | https://github.com/python/cpython/pull/1963/commits/a678c74843b9deabc6a5a4401f209e467c41cf83 |
| a678c74 | https://github.com/python/cpython/pull/1963/commits/a678c74843b9deabc6a5a4401f209e467c41cf83 |
|
| https://github.com/segevfiner |
| Silence OpenSSL warnings in MSVC | https://github.com/python/cpython/pull/1963/commits/3bd1035ca3389dbcfa0054d4678cfe5a9790ecf0 |
| 3bd1035 | https://github.com/python/cpython/pull/1963/commits/3bd1035ca3389dbcfa0054d4678cfe5a9790ecf0 |
|
| https://github.com/segevfiner |
| Fix tix warnings in MSVC | https://github.com/python/cpython/pull/1963/commits/3575d2731593db795aefcb114cb684e8c3f204a5 |
| 3575d27 | https://github.com/python/cpython/pull/1963/commits/3575d2731593db795aefcb114cb684e8c3f204a5 |
|
| https://github.com/segevfiner |
| Fix validateUcrtbase failing due to missing _ctypes | https://github.com/python/cpython/pull/1963/commits/e61f333b82afbff1d6f3bf6c1486374e15fde102 |
| e61f333 | https://github.com/python/cpython/pull/1963/commits/e61f333b82afbff1d6f3bf6c1486374e15fde102 |
|
| https://github.com/segevfiner |
| Undo random whitespace differences due to editor | https://github.com/python/cpython/pull/1963/commits/0330a2df9e01403e37d42b8c632d1657e21c7326 |
| 0330a2d | https://github.com/python/cpython/pull/1963/commits/0330a2df9e01403e37d42b8c632d1657e21c7326 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jun 5, 2017 | https://github.com/python/cpython/pull/1963#event-1110891138 |
|
| https://github.com/segevfiner |
| Merge remote-tracking branch 'upstream/master' into fix-msvc-warnings | https://github.com/python/cpython/pull/1963/commits/f02f5c285034c7d3d672b72b35ddacdfdb9597d0 |
| f02f5c2 | https://github.com/python/cpython/pull/1963/commits/f02f5c285034c7d3d672b72b35ddacdfdb9597d0 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 11, 2017 | https://github.com/python/cpython/pull/1963#issuecomment-307647400 |
| @zooba | https://github.com/zooba |
| @zware | https://github.com/zware |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| https://github.com/zware |
| zware | https://github.com/zware |
| Jun 11, 2017 | https://github.com/python/cpython/pull/1963#issuecomment-307649497 |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 11, 2017 | https://github.com/python/cpython/pull/1963#event-1118663674 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 11, 2017 | https://github.com/python/cpython/pull/1963#issuecomment-307660552 |
| @zware | https://github.com/zware |
| bpo-9566 | https://bugs.python.org/issue9566 |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| https://github.com/zware |
| zware | https://github.com/zware |
|
Jun 11, 2017
| https://github.com/python/cpython/pull/1963#pullrequestreview-43330684 |
|
View reviewed changes
| https://github.com/python/cpython/pull/1963/files/f02f5c285034c7d3d672b72b35ddacdfdb9597d0 |
| zware | https://github.com/zware |
| https://github.com/python/cpython/pull/1963#pullrequestreview-43330684 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| PCbuild/pcbuild.sln | https://github.com/python/cpython/pull/1963/files/f02f5c285034c7d3d672b72b35ddacdfdb9597d0#diff-0ea7ec57310c8f7a74b3bb79e5cd3ee907d47909fb68b7b46e5d257793bdd3bc |
| zware | https://github.com/zware |
| Jun 11, 2017 | https://github.com/python/cpython/pull/1963#discussion_r121293370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| segevfiner | https://github.com/segevfiner |
| Jun 12, 2017 | https://github.com/python/cpython/pull/1963#discussion_r121306620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| zooba | https://github.com/zooba |
| Jun 12, 2017 | https://github.com/python/cpython/pull/1963#discussion_r121502504 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| PCbuild/_socket.vcxproj | https://github.com/python/cpython/pull/1963/files/f02f5c285034c7d3d672b72b35ddacdfdb9597d0#diff-cf98e7214712cabc8ce9423abcb08400c701874b6ee7579e6ce3e71c3840d91c |
| zware | https://github.com/zware |
| Jun 11, 2017 | https://github.com/python/cpython/pull/1963#discussion_r121293469 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| segevfiner | https://github.com/segevfiner |
| Jun 12, 2017 | https://github.com/python/cpython/pull/1963#discussion_r121306703 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| zooba | https://github.com/zooba |
| Jun 12, 2017 | https://github.com/python/cpython/pull/1963#discussion_r121502438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| Jun 12, 2017 | https://github.com/python/cpython/pull/1963#issuecomment-307892552 |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
|
| https://github.com/segevfiner |
| bpo-30631: Removed _WINSOCK_DEPRECATED_NO_WARNINGS from _socket.vcxproj | https://github.com/python/cpython/pull/1963/commits/220bc5fef167a048cb5e3ee0b70528333c03b107 |
| 220bc5f | https://github.com/python/cpython/pull/1963/commits/220bc5fef167a048cb5e3ee0b70528333c03b107 |
| https://github.com/zware |
| zware | https://github.com/zware |
|
Jun 13, 2017
| https://github.com/python/cpython/pull/1963#pullrequestreview-43782763 |
|
View reviewed changes
| https://github.com/python/cpython/pull/1963/files/220bc5fef167a048cb5e3ee0b70528333c03b107 |
| https://github.com/zware |
| zware | https://github.com/zware |
| c931885 | https://github.com/python/cpython/commit/c9318853bbe8d62cb72ed853b0ffb75311ea474c |
| Jun 16, 2017 | https://github.com/python/cpython/pull/1963#event-1126177343 |
| https://github.com/zware |
| zware | https://github.com/zware |
| Jun 16, 2017 | https://github.com/python/cpython/pull/1963#issuecomment-308921482 |
| @segevfiner | https://github.com/segevfiner |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| June 16, 2017 10:18 | https://github.com/python/cpython/pull/1963#event-1126590371 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1963 |
|
| https://github.com/zooba |
|
zooba
| https://github.com/zooba |
|
| https://github.com/python/cpython/pull/1963/files/f02f5c285034c7d3d672b72b35ddacdfdb9597d0 |
|
| https://github.com/zware |
|
zware
| https://github.com/zware |
|
| https://github.com/python/cpython/pull/1963/files/220bc5fef167a048cb5e3ee0b70528333c03b107 |
| Please reload this page | https://github.com/python/cpython/pull/1963 |
|
| https://github.com/segevfiner |
|
| https://github.com/zware |
|
| https://github.com/zooba |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |