| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cffc8446-a90c-173a-777c-72764f74d950 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BEC:9CC2A:AA876A:EDDD06:696A7B49 |
| html-safe-nonce | 899ac2bcbcbbedf29dab5381596232f59bf4f8f54f9a98c5e7a60c482c3791b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkVDOjlDQzJBOkFBODc2QTpFREREMDY6Njk2QTdCNDkiLCJ2aXNpdG9yX2lkIjoiNDUwMDUwNzQ5NzQ5OTA5NzkyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 58573ca96029c85e73468281ec87b0729f9f53e732093ccc6258c78910b2109d |
| hovercard-subject-tag | pull_request:404276928 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19551/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b4e8ffac8d08175d2bd71e47680c89e77b737c7e3d1226a9bd0a4ea1801ad092/python/cpython/pull/19551 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b4e8ffac8d08175d2bd71e47680c89e77b737c7e3d1226a9bd0a4ea1801ad092/python/cpython/pull/19551 |
| og:image:alt | I will add tests if this is an acceptable change.
https://bugs.python.org/issue40300 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | felixxm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5b774e44f85c14a75886edd04ddda4e5a25ddebbb241bcbb590b08a3048730e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cc5f4eee261b3601c1e98e217ceaf28508b9567e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/19551#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19551 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19551 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/19551 |
| Reload | https://github.com/python/cpython/pull/19551 |
| Reload | https://github.com/python/cpython/pull/19551 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/19551#issue-comment-box |
| vsajip | https://github.com/vsajip |
| python:master | https://github.com/python/cpython/tree/master |
| felixxm:fix-issue-40300 | https://github.com/felixxm/cpython/tree/fix-issue-40300 |
|
bpo-40300: Allow empty logging.Formatter.default_msec_format. (GH-19551)
| https://github.com/python/cpython/pull/19551#top |
| vsajip | https://github.com/vsajip |
| python:master | https://github.com/python/cpython/tree/master |
| felixxm:fix-issue-40300 | https://github.com/felixxm/cpython/tree/fix-issue-40300 |
|
Conversation
4
| https://github.com/python/cpython/pull/19551 |
|
Commits
1
| https://github.com/python/cpython/pull/19551/commits |
|
Checks
0
| https://github.com/python/cpython/pull/19551/checks |
|
Files changed
| https://github.com/python/cpython/pull/19551/files |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/felixxm |
| felixxm | https://github.com/felixxm |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#issue-600943270 |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
| https://bugs.python.org/issue40300 | https://bugs.python.org/issue40300 |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
| https://github.com/felixxm |
| felixxm | https://github.com/felixxm |
| vsajip | https://github.com/vsajip |
| code owner | https://github.com/python/cpython/blob/6a5bf15c71a1c101c28774ae714b58e8a65b130c/.github/CODEOWNERS#L27 |
| April 16, 2020 10:51 | https://github.com/python/cpython/pull/19551#event-3239331322 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#issuecomment-614574992 |
| PSF contributor agreement | https://www.python.org/psf/contrib/contrib-form/ |
| @felixxm | https://github.com/felixxm |
| the steps outlined in the CPython devguide | https://devguide.python.org/pullrequest/#licensing |
| check yourself | https://check-python-cla.herokuapp.com/ |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA not signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#event-3239331480 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#event-3239331601 |
|
| https://github.com/felixxm |
| bpo-40300: Allow empty logging.Formatter.default_msec_format. | https://github.com/python/cpython/pull/19551/commits/b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
| b873d4f | https://github.com/python/cpython/pull/19551/commits/b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
| https://github.com/felixxm |
| felixxm | https://github.com/felixxm |
| force-pushed | https://github.com/python/cpython/compare/d7ef65663d07dfacfd0a27639ca53e3109989962..b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
| d7ef656 | https://github.com/python/cpython/commit/d7ef65663d07dfacfd0a27639ca53e3109989962 |
| b873d4f | https://github.com/python/cpython/commit/b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
|
Compare
| https://github.com/python/cpython/compare/d7ef65663d07dfacfd0a27639ca53e3109989962..b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
| April 16, 2020 16:41 | https://github.com/python/cpython/pull/19551#event-3240818718 |
| https://github.com/felixxm |
| felixxm | https://github.com/felixxm |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#issuecomment-614766368 |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
|
CLA not signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#event-3241120116 |
| https://github.com/vsajip |
| vsajip | https://github.com/vsajip |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#event-3241710737 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#issuecomment-614879920 |
| @vsajip | https://github.com/vsajip |
| b873d4f | https://github.com/python/cpython/commit/b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Apr 16, 2020 | https://github.com/python/cpython/pull/19551#event-3241710918 |
| https://github.com/vsajip |
| vsajip | https://github.com/vsajip |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Apr 17, 2020 | https://github.com/python/cpython/pull/19551#event-3245019693 |
| https://github.com/vsajip |
| vsajip | https://github.com/vsajip |
|
Apr 17, 2020
| https://github.com/python/cpython/pull/19551#pullrequestreview-395580908 |
|
View reviewed changes
| https://github.com/python/cpython/pull/19551/files/b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Apr 17, 2020 | https://github.com/python/cpython/pull/19551#event-3245025057 |
| https://github.com/vsajip |
| vsajip | https://github.com/vsajip |
| Apr 17, 2020 | https://github.com/python/cpython/pull/19551#event-3245028930 |
| https://github.com/vsajip |
| vsajip | https://github.com/vsajip |
| 06a3554 | https://github.com/python/cpython/commit/06a35542aad15666cace307d841a95e33f3cbee6 |
| Apr 17, 2020 | https://github.com/python/cpython/pull/19551#event-3245028969 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Apr 17, 2020 | https://github.com/python/cpython/pull/19551#event-3245029147 |
| https://github.com/felixxm |
| felixxm | https://github.com/felixxm |
| April 17, 2020 16:25 | https://github.com/python/cpython/pull/19551#event-3245113638 |
| https://github.com/felixxm |
| felixxm | https://github.com/felixxm |
| Apr 17, 2020 | https://github.com/python/cpython/pull/19551#issuecomment-615340823 |
| @vsajip | https://github.com/vsajip |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
| CuriousLearner | https://github.com/CuriousLearner |
|
May 29, 2020
| https://github.com/python/cpython/pull/19551#ref-commit-e4d193d |
|
| https://github.com/CuriousLearner |
| Merge branch 'master' into bpo-26543 | https://github.com/CuriousLearner/cpython/commit/e4d193d495fd1d6e1694197258721a07f4666bcc |
| e4d193d | https://github.com/CuriousLearner/cpython/commit/e4d193d495fd1d6e1694197258721a07f4666bcc |
| pythonGH-19364 | https://github.com/python/cpython/pull/19364 |
| pythonGH-19577 | https://github.com/python/cpython/pull/19577 |
| pythonGH-19546 | https://github.com/python/cpython/pull/19546 |
| pythonGH-19571 | https://github.com/python/cpython/pull/19571 |
| pythonGH-19575 | https://github.com/python/cpython/pull/19575 |
| pythonGH-19574 | https://github.com/python/cpython/pull/19574 |
| pythonGH-18836 | https://github.com/python/cpython/pull/18836 |
| pythonGH-18839 | https://github.com/python/cpython/pull/18839 |
| pythonGH-19539 | https://github.com/python/cpython/pull/19539 |
| pythonGH-19572 | https://github.com/python/cpython/pull/19572 |
| pythonGH-19573 | https://github.com/python/cpython/pull/19573 |
| pythonGH-19527 | https://github.com/python/cpython/pull/19527 |
| pythonGH-18844 | https://github.com/python/cpython/pull/18844 |
| pythonGH-19551 | https://github.com/python/cpython/pull/19551 |
| pythonGH-19552 | https://github.com/python/cpython/pull/19552 |
| pythonGH-19540 | https://github.com/python/cpython/pull/19540 |
| pythonGH-19558 | https://github.com/python/cpython/pull/19558 |
| pythonGH-19542 | https://github.com/python/cpython/pull/19542 |
| pythonGH-18829 | https://github.com/python/cpython/pull/18829 |
| python#18698 | https://github.com/python/cpython/pull/18698 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19551 |
|
| https://github.com/vsajip |
|
vsajip
| https://github.com/vsajip |
|
| https://github.com/python/cpython/pull/19551/files/b873d4fc8dc1b9164e2039e664845042dbdf3cf4 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/19551 |
|
| https://github.com/felixxm |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com/vsajip |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |