René's URL Explorer Experiment


Title: bpo-30567: Fix refleak in sys.getwindowsversion by segevfiner · Pull Request #1940 · python/cpython · GitHub

Open Graph Title: bpo-30567: Fix refleak in sys.getwindowsversion by segevfiner · Pull Request #1940 · python/cpython

X Title: bpo-30567: Fix refleak in sys.getwindowsversion by segevfiner · Pull Request #1940 · python/cpython

Description: There is a ref leak in sys.getwindowsversion due to using PyTuple_Pack and forgetting that it increments the ref count of passed in objects. Found here: #1927 (comment). Clearly shows up in python ...

Open Graph Description: There is a ref leak in sys.getwindowsversion due to using PyTuple_Pack and forgetting that it increments the ref count of passed in objects. Found here: #1927 (comment). Clearly shows up in python ...

X Description: There is a ref leak in sys.getwindowsversion due to using PyTuple_Pack and forgetting that it increments the ref count of passed in objects. Found here: #1927 (comment). Clearly shows up in python ...

Opengraph URL: https://github.com/python/cpython/pull/1940

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:19fd90b2-9352-33f4-046b-183cdf504b68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB076:34E738:6FCD55:93D00B:696B4970
html-safe-nonce6bf336793d2183e3491784ec422897b89958eaf4cc1815eab283d88eb1fd51cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDc2OjM0RTczODo2RkNENTU6OTNEMDBCOjY5NkI0OTcwIiwidmlzaXRvcl9pZCI6IjQ4OTY4NTA5MjM1Njk3NjA2MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4a16309f4bf48e5900ff75eb2e40622809c78ba2ee1c483d35366ee5c7b4205f
hovercard-subject-tagpull_request:123885190
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/1940/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/691fc8ff406f8109c82e16c65ca59d038d07396000dcb5f6429d861af3438a3d/python/cpython/pull/1940
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/691fc8ff406f8109c82e16c65ca59d038d07396000dcb5f6429d861af3438a3d/python/cpython/pull/1940
og:image:altThere is a ref leak in sys.getwindowsversion due to using PyTuple_Pack and forgetting that it increments the ref count of passed in objects. Found here: #1927 (comment). Clearly shows up in python ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesegevfiner
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1940#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1940
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1940
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1940
Reloadhttps://github.com/python/cpython/pull/1940
Reloadhttps://github.com/python/cpython/pull/1940
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1940
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/1940
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/1940#issue-comment-box
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:bpo-30567https://github.com/segevfiner/cpython/tree/bpo-30567
bpo-30567: Fix refleak in sys.getwindowsversion https://github.com/python/cpython/pull/1940#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:bpo-30567https://github.com/segevfiner/cpython/tree/bpo-30567
Conversation 0 https://github.com/python/cpython/pull/1940
Commits 1 https://github.com/python/cpython/pull/1940/commits
Checks 0 https://github.com/python/cpython/pull/1940/checks
Files changed https://github.com/python/cpython/pull/1940/files
Please reload this pagehttps://github.com/python/cpython/pull/1940
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 4, 2017https://github.com/python/cpython/pull/1940#issue-233446992
#1927 (comment)https://github.com/python/cpython/pull/1927#issuecomment-306019512
@eryksunhttps://github.com/eryksun
Please reload this pagehttps://github.com/python/cpython/pull/1940
https://github.com/segevfiner
bpo-30567: Fix refleak in sys.getwindowsversionhttps://github.com/python/cpython/pull/1940/commits/80a15dc71cd309d9b319bd0a64bbd0db8d3d1227
80a15dchttps://github.com/python/cpython/pull/1940/commits/80a15dc71cd309d9b319bd0a64bbd0db8d3d1227
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jun 4, 2017https://github.com/python/cpython/pull/1940#event-1109183788
https://github.com/mention-bot
mention-bothttps://github.com/mention-bot
Jun 4, 2017https://github.com/python/cpython/pull/1940#issuecomment-306053973
@segevfinerhttps://github.com/segevfiner
@loewishttps://github.com/loewis
@tiranhttps://github.com/tiran
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/1940
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
needs backport to 3.5 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.5%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Jun 4, 2017https://github.com/python/cpython/pull/1940#event-1109189522
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 4, 2017 https://github.com/python/cpython/pull/1940#pullrequestreview-41946966
View reviewed changes https://github.com/python/cpython/pull/1940/files/80a15dc71cd309d9b319bd0a64bbd0db8d3d1227
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
48fb766https://github.com/python/cpython/commit/48fb766f70d9ca9d5934cbddbe8d8e7972cb6343
Jun 4, 2017https://github.com/python/cpython/pull/1940#event-1109190768
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 6, 2017 https://github.com/python/cpython/pull/1940#ref-commit-9eff723
https://github.com/segevfiner
https://github.com/serhiy-storchaka
[3.6] bpo-30567: Fix refleak in sys.getwindowsversion (https://github.com/serhiy-storchaka/cpython/commit/9eff723d0d1618628055b2806942a0488462768a
pythonGH-1940https://github.com/python/cpython/pull/1940
)https://github.com/serhiy-storchaka/cpython/commit/9eff723d0d1618628055b2806942a0488462768a
9eff723https://github.com/serhiy-storchaka/cpython/commit/9eff723d0d1618628055b2806942a0488462768a
48fb766https://github.com/serhiy-storchaka/cpython/commit/48fb766f70d9ca9d5934cbddbe8d8e7972cb6343
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 6, 2017 https://github.com/python/cpython/pull/1940#ref-commit-3dcd81d
https://github.com/segevfiner
https://github.com/serhiy-storchaka
[3.5] bpo-30567: Fix refleak in sys.getwindowsversion (https://github.com/serhiy-storchaka/cpython/commit/3dcd81d367fca11d422f55c4d13628a71a0b0b91
pythonGH-1940https://github.com/python/cpython/pull/1940
)https://github.com/serhiy-storchaka/cpython/commit/3dcd81d367fca11d422f55c4d13628a71a0b0b91
3dcd81dhttps://github.com/serhiy-storchaka/cpython/commit/3dcd81d367fca11d422f55c4d13628a71a0b0b91
48fb766https://github.com/serhiy-storchaka/cpython/commit/48fb766f70d9ca9d5934cbddbe8d8e7972cb6343
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 6, 2017 https://github.com/python/cpython/pull/1940#ref-commit-68e5af8
https://github.com/serhiy-storchaka
[3.6]https://github.com/python/cpython/commit/68e5af89d46db6250a0fa7fe4249c66f866faff8
bpo-30567https://bugs.python.org/issue?@action=redirect&bpo=30567
: Fix refleak in sys.getwindowsversion (https://github.com/python/cpython/commit/68e5af89d46db6250a0fa7fe4249c66f866faff8
GH-1940https://github.com/python/cpython/pull/1940
) (https://github.com/python/cpython/commit/68e5af89d46db6250a0fa7fe4249c66f866faff8
#1970https://github.com/python/cpython/pull/1970
)https://github.com/python/cpython/commit/68e5af89d46db6250a0fa7fe4249c66f866faff8
68e5af8https://github.com/python/cpython/commit/68e5af89d46db6250a0fa7fe4249c66f866faff8
48fb766https://github.com/python/cpython/commit/48fb766f70d9ca9d5934cbddbe8d8e7972cb6343
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 6, 2017 https://github.com/python/cpython/pull/1940#ref-commit-86f8f1f
https://github.com/serhiy-storchaka
[3.5]https://github.com/python/cpython/commit/86f8f1f05cd5822b4a4031b90cfdbe5fa1b1159e
bpo-30567https://bugs.python.org/issue?@action=redirect&bpo=30567
: Fix refleak in sys.getwindowsversion (https://github.com/python/cpython/commit/86f8f1f05cd5822b4a4031b90cfdbe5fa1b1159e
GH-1940https://github.com/python/cpython/pull/1940
) (https://github.com/python/cpython/commit/86f8f1f05cd5822b4a4031b90cfdbe5fa1b1159e
#1971https://github.com/python/cpython/pull/1971
)https://github.com/python/cpython/commit/86f8f1f05cd5822b4a4031b90cfdbe5fa1b1159e
86f8f1fhttps://github.com/python/cpython/commit/86f8f1f05cd5822b4a4031b90cfdbe5fa1b1159e
48fb766https://github.com/python/cpython/commit/48fb766f70d9ca9d5934cbddbe8d8e7972cb6343
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
June 6, 2017 16:43https://github.com/python/cpython/pull/1940#event-1112145574
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
needs backport to 3.5 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.5%22
Jun 19, 2017https://github.com/python/cpython/pull/1940#event-1128384384
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1940
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/1940/files/80a15dc71cd309d9b319bd0a64bbd0db8d3d1227
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/1940
https://github.com/segevfiner
https://github.com/mention-bot
https://github.com/serhiy-storchaka
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.