René's URL Explorer Experiment


Title: bpo-40115: Fix refleak in test_asyncio by aeros · Pull Request #19282 · python/cpython · GitHub

Open Graph Title: bpo-40115: Fix refleak in test_asyncio by aeros · Pull Request #19282 · python/cpython

X Title: bpo-40115: Fix refleak in test_asyncio by aeros · Pull Request #19282 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: My change to remove daemon threads in concurrent.futures (#19149) revealed a subtle issue in test_events.test_run_in_executor_cancel: it does not properly clean up the executor's resources. Thi...

X Description: My change to remove daemon threads in concurrent.futures (#19149) revealed a subtle issue in test_events.test_run_in_executor_cancel: it does not properly clean up the executor's resources....

Opengraph URL: https://github.com/python/cpython/pull/19282

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d3f645b9-2251-b09a-3530-0b9ece7f1242
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6FE:3C702D:1A9FF0:22F082:6A4D8715
html-safe-nonceb8c97be6019d63edca6485271d439a1a96ac71f874a43d8f70d858f99c5ebf67
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkZFOjNDNzAyRDoxQTlGRjA6MjJGMDgyOjZBNEQ4NzE1IiwidmlzaXRvcl9pZCI6Ijc4MTI5NTM3MDI2MDQzMTAyOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7997bbe6dfe680af118f152fa0c32ccc1ff23e2366b9cb97b6715e10d1107265
hovercard-subject-tagpull_request:397221224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19282/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d34843459e3937ef0f84f021430f29e97ec4f87f69a1e0114b2ae68a7452031c/python/cpython/pull/19282
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d34843459e3937ef0f84f021430f29e97ec4f87f69a1e0114b2ae68a7452031c/python/cpython/pull/19282
og:image:altMy change to remove daemon threads in concurrent.futures (#19149) revealed a subtle issue in test_events.test_run_in_executor_cancel: it does not properly clean up the executor's resources. Thi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaeros
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19282#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19282
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19282
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19282
Reloadhttps://github.com/python/cpython/pull/19282
Reloadhttps://github.com/python/cpython/pull/19282
Please reload this pagehttps://github.com/python/cpython/pull/19282
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19282
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
aeros:bpo40115-test_asyncio-run_in_executor_cancelhttps://github.com/aeros/cpython/tree/bpo40115-test_asyncio-run_in_executor_cancel
Conversationhttps://github.com/python/cpython/pull/19282
Commits1 (1)https://github.com/python/cpython/pull/19282/commits
Checkshttps://github.com/python/cpython/pull/19282/checks
Files changedhttps://github.com/python/cpython/pull/19282/files
bpo-40115: Fix refleak in test_asynciohttps://github.com/python/cpython/pull/19282#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
aeros:bpo40115-test_asyncio-run_in_executor_cancelhttps://github.com/aeros/cpython/tree/bpo40115-test_asyncio-run_in_executor_cancel
https://github.com/aeros
aeroshttps://github.com/aeros
Apr 1, 2020https://github.com/python/cpython/pull/19282#issue-592190567
Please reload this pagehttps://github.com/python/cpython/pull/19282
#19149https://github.com/python/cpython/pull/19149
@vstinnerhttps://github.com/vstinner
@pitrouhttps://github.com/pitrou
@1st1https://github.com/1st1
https://bugs.python.org/issue40115https://bugs.python.org/issue40115
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
aeroshttps://github.com/aeros
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/65a796e5272f61b42792d3a8c69686558c1872c5/.github/CODEOWNERS#L8
April 1, 2020 20:40https://github.com/python/cpython/pull/19282#event-3189599348
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 1, 2020https://github.com/python/cpython/pull/19282#event-3189599528
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 1, 2020https://github.com/python/cpython/pull/19282#event-3189599663
https://github.com/aeros
aeroshttps://github.com/aeros
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Apr 1, 2020https://github.com/python/cpython/pull/19282#event-3189600450
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 1, 2020https://github.com/python/cpython/pull/19282#issuecomment-607479655
@aeroshttps://github.com/aeros
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Apr 1, 2020https://github.com/python/cpython/pull/19282#event-3189607071
https://github.com/aeros
aeroshttps://github.com/aeros
Apr 1, 2020https://github.com/python/cpython/pull/19282#issuecomment-607481086
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
aeroshttps://github.com/aeros
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Apr 1, 2020https://github.com/python/cpython/pull/19282#event-3189617547
https://github.com/aeros
aeroshttps://github.com/aeros
pitrouhttps://github.com/pitrou
vstinnerhttps://github.com/vstinner
April 1, 2020 20:47https://github.com/python/cpython/pull/19282#event-3189622496
https://github.com/aeros
aeroshttps://github.com/aeros
Apr 1, 2020https://github.com/python/cpython/pull/19282#issuecomment-607495945
https://www.openssl.org/source/openssl-1.1.1d.tar.gzhttps://www.openssl.org/source/openssl-1.1.1d.tar.gz
build loghttps://dev.azure.com/Python/cpython/_build/results?buildId=60442&view=logs&j=256d7e09-002a-52d7-8661-29ee3960640e&t=2d52c08c-85ca-5e4d-e087-19deb92a2610
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 1, 2020 https://github.com/python/cpython/pull/19282#pullrequestreview-385968113
View reviewed changes https://github.com/python/cpython/pull/19282/files
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/19282#pullrequestreview-385968113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 1, 2020https://github.com/python/cpython/pull/19282#event-3189773030
https://github.com/aeros
aeroshttps://github.com/aeros
Apr 1, 2020https://github.com/python/cpython/pull/19282#issuecomment-607513378
Please reload this pagehttps://github.com/python/cpython/pull/19282
b61b818https://github.com/python/cpython/commit/b61b818d916942aad1f8f3e33181801c4a1ed14b
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
aeroshttps://github.com/aeros
Apr 2, 2020https://github.com/python/cpython/pull/19282#issuecomment-607572273
Please reload this pagehttps://github.com/python/cpython/pull/19282
@vstinnerhttps://github.com/vstinner
#19149https://github.com/python/cpython/pull/19149
b61b818https://github.com/python/cpython/commit/b61b818d916942aad1f8f3e33181801c4a1ed14b
b61b818https://github.com/python/cpython/commit/b61b818d916942aad1f8f3e33181801c4a1ed14b
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 2, 2020https://github.com/python/cpython/pull/19282#issuecomment-607573793
https://bugs.python.org/issue40115https://bugs.python.org/issue40115
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 2, 2020https://github.com/python/cpython/pull/19282#issuecomment-607574349
https://www.openssl.org/source/openssl-1.1.1d.tar.gzhttps://www.openssl.org/source/openssl-1.1.1d.tar.gz
224e1c3https://github.com/python/cpython/commit/224e1c34d677ef42fe665ac008a000d4dcec1398
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
Fix refleak in test_asynciohttps://github.com/python/cpython/pull/19282/commits/93fde8cbb48c3adc814012d22e5c3d7bb597d18e
93fde8chttps://github.com/python/cpython/pull/19282/commits/93fde8cbb48c3adc814012d22e5c3d7bb597d18e
https://github.com/aeros
aeroshttps://github.com/aeros
force-pushedhttps://github.com/python/cpython/compare/13fa9a966ccf1a9c996085483a3ea1d351dee409..93fde8cbb48c3adc814012d22e5c3d7bb597d18e
13fa9a9https://github.com/python/cpython/commit/13fa9a966ccf1a9c996085483a3ea1d351dee409
93fde8chttps://github.com/python/cpython/commit/93fde8cbb48c3adc814012d22e5c3d7bb597d18e
Compare https://github.com/python/cpython/compare/13fa9a966ccf1a9c996085483a3ea1d351dee409..93fde8cbb48c3adc814012d22e5c3d7bb597d18e
April 2, 2020 01:54https://github.com/python/cpython/pull/19282#event-3190275432
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 2, 2020https://github.com/python/cpython/pull/19282#issuecomment-607576639
https://bugs.python.org/issue40149https://bugs.python.org/issue40149
b61b818https://github.com/python/cpython/commit/b61b818d916942aad1f8f3e33181801c4a1ed14b
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
aeroshttps://github.com/aeros
Apr 2, 2020https://github.com/python/cpython/pull/19282#issuecomment-607578635
Please reload this pagehttps://github.com/python/cpython/pull/19282
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
aeroshttps://github.com/aeros
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Apr 2, 2020https://github.com/python/cpython/pull/19282#event-3190300700
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
8ec7cb5https://github.com/python/cpython/commit/8ec7cb53f0705509bac20c96d19fdbd9baec0cb2
Apr 2, 2020https://github.com/python/cpython/pull/19282#event-3190361812
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 2, 2020https://github.com/python/cpython/pull/19282#event-3190361891
https://github.com/aeros
aeroshttps://github.com/aeros
April 3, 2020 07:47https://github.com/python/cpython/pull/19282#event-3195240565
https://github.com/aeros
aeroshttps://github.com/aeros
May 21, 2020https://github.com/python/cpython/pull/19282#issuecomment-631932397
Please reload this pagehttps://github.com/python/cpython/pull/19282
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
aeroshttps://github.com/aeros
May 21, 2020 07:29https://github.com/python/cpython/pull/19282#event-3359583098
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 26, 2020https://github.com/python/cpython/pull/19282#issuecomment-634293326
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
aeroshttps://github.com/aeros
May 27, 2020https://github.com/python/cpython/pull/19282#issuecomment-634544603
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19282
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/19282/files/13fa9a966ccf1a9c996085483a3ea1d351dee409
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/pitrou
pitrou https://github.com/pitrou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/19282
https://github.com/aeros
https://github.com/bedevere-bot
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.