René's URL Explorer Experiment


Title: bpo-30555: Fix WindowsConsoleIO errors in the presence of fd redirection by segevfiner · Pull Request #1927 · python/cpython · GitHub

Open Graph Title: bpo-30555: Fix WindowsConsoleIO errors in the presence of fd redirection by segevfiner · Pull Request #1927 · python/cpython

X Title: bpo-30555: Fix WindowsConsoleIO errors in the presence of fd redirection by segevfiner · Pull Request #1927 · python/cpython

Description: This works by not caching the handle and instead getting the handle from the file descriptor each time, so that if the actual handle changes by fd redirection closing/opening the console handle ben...

Open Graph Description: This works by not caching the handle and instead getting the handle from the file descriptor each time, so that if the actual handle changes by fd redirection closing/opening the console handle ben...

X Description: This works by not caching the handle and instead getting the handle from the file descriptor each time, so that if the actual handle changes by fd redirection closing/opening the console handle ben...

Opengraph URL: https://github.com/python/cpython/pull/1927

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6390e567-dc83-2d74-5679-c2f82ec4dfcc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD914:2DE4E0:DF6E7A:1255CD1:696B6578
html-safe-nonce5352e12a790f74279d61100d3832bd9b9128bfdee88103efeb876522c752dc14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTE0OjJERTRFMDpERjZFN0E6MTI1NUNEMTo2OTZCNjU3OCIsInZpc2l0b3JfaWQiOiIxNjAyNjE1MTAwNjQxNjAwODg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf9a3204b26410639c556c363e90afa841d6bca7bf736cdee248ee05ebf5952b9
hovercard-subject-tagpull_request:123843340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/1927/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3572960b0c0cd79accbf682dffbceef81a8cfea140e76b32e54791dc5eb6965e/python/cpython/pull/1927
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3572960b0c0cd79accbf682dffbceef81a8cfea140e76b32e54791dc5eb6965e/python/cpython/pull/1927
og:image:altThis works by not caching the handle and instead getting the handle from the file descriptor each time, so that if the actual handle changes by fd redirection closing/opening the console handle ben...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesegevfiner
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1927#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1927
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1927
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1927
Reloadhttps://github.com/python/cpython/pull/1927
Reloadhttps://github.com/python/cpython/pull/1927
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1927
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/1927
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/1927#issue-comment-box
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:bpo-30555-windowsconsoleio-fd-redirectionhttps://github.com/segevfiner/cpython/tree/bpo-30555-windowsconsoleio-fd-redirection
bpo-30555: Fix WindowsConsoleIO errors in the presence of fd redirection https://github.com/python/cpython/pull/1927#top
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:bpo-30555-windowsconsoleio-fd-redirectionhttps://github.com/segevfiner/cpython/tree/bpo-30555-windowsconsoleio-fd-redirection
Conversation 28 https://github.com/python/cpython/pull/1927
Commits 22 https://github.com/python/cpython/pull/1927/commits
Checks 0 https://github.com/python/cpython/pull/1927/checks
Files changed https://github.com/python/cpython/pull/1927/files
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 3, 2017https://github.com/python/cpython/pull/1927#issue-233371300
Please reload this pagehttps://github.com/python/cpython/pull/1927
pytest-dev/py#103https://github.com/pytest-dev/py/issues/103
pytest-dev/pytest#2462https://github.com/pytest-dev/pytest/pull/2462
pytest-dev/pytest#2465https://github.com/pytest-dev/pytest/issues/2465
tartley/colorama#131https://github.com/tartley/colorama/pull/131
@zoobahttps://github.com/zooba
@eryksunhttps://github.com/eryksun
bpo-30555https://bugs.python.org/issue?@action=redirect&bpo=30555
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/mention-bot
mention-bothttps://github.com/mention-bot
Jun 3, 2017https://github.com/python/cpython/pull/1927#issuecomment-305976900
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
@benjaminphttps://github.com/benjaminp
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jun 3, 2017https://github.com/python/cpython/pull/1927#event-1108848396
https://github.com/nicoddemus
nicoddemushttps://github.com/nicoddemus
Jun 3, 2017 https://github.com/python/cpython/pull/1927#ref-pullrequest-233121585
[WIP] A workaround for Python 3.6 WindowsConsoleIO breaking with FDCapture pytest-dev/pytest#2462 https://github.com/pytest-dev/pytest/pull/2462
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Jun 4, 2017https://github.com/python/cpython/pull/1927#issuecomment-306010104
decodedname = Py_Nonehttps://github.com/segevfiner/cpython/blob/ac3af9ec5e4bf8c18243ab7c8bd6bacf2317a2b6/Modules/_io/winconsoleio.c#L311
test_conout_pathhttps://github.com/segevfiner/cpython/blob/ac3af9ec5e4bf8c18243ab7c8bd6bacf2317a2b6/Lib/test/test_winconsoleio.py#L112
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Jun 4, 2017 https://github.com/python/cpython/pull/1927#pullrequestreview-41930755
View reviewed changes https://github.com/python/cpython/pull/1927/files
Modules/_io/winconsoleio.chttps://github.com/python/cpython/pull/1927/files#diff-463599eb2f67c89107a6fc2431d387fef7fdbb8c860b2c424477ca9b9794282c
eryksunhttps://github.com/eryksun
Jun 4, 2017https://github.com/python/cpython/pull/1927#discussion_r119998273
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1927
segevfinerhttps://github.com/segevfiner
Jun 4, 2017https://github.com/python/cpython/pull/1927#discussion_r120000299
Please reload this pagehttps://github.com/python/cpython/pull/1927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1927
segevfinerhttps://github.com/segevfiner
Jun 4, 2017https://github.com/python/cpython/pull/1927#discussion_r120017370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 4, 2017https://github.com/python/cpython/pull/1927#issuecomment-306017485
Please reload this pagehttps://github.com/python/cpython/pull/1927
@eryksunhttps://github.com/eryksun
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Jun 4, 2017https://github.com/python/cpython/pull/1927#issuecomment-306019512
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 4, 2017 https://github.com/python/cpython/pull/1927#ref-pullrequest-233446992
bpo-30567: Fix refleak in sys.getwindowsversion #1940 https://github.com/python/cpython/pull/1940
segevfinerhttps://github.com/segevfiner
June 4, 2017 21:32https://github.com/python/cpython/pull/1927#commits-pushed-b02408d
https://github.com/segevfiner
bpo-30555: Fix WindowsConsoleIO failure in the presence of fd redirec…https://github.com/python/cpython/pull/1927/commits/b02408d5d930a765b2f32991a8468e5bc2c0b948
b02408dhttps://github.com/python/cpython/pull/1927/commits/b02408d5d930a765b2f32991a8468e5bc2c0b948
https://github.com/segevfiner
bpo-30555: Fixed the kludgey PC/_testconsole.c, grumble grumble...https://github.com/python/cpython/pull/1927/commits/ac242ebd35ebc8946c3f9bd67fab786266059661
ac242ebhttps://github.com/python/cpython/pull/1927/commits/ac242ebd35ebc8946c3f9bd67fab786266059661
https://github.com/segevfiner
bpo-30555: Fix refleakshttps://github.com/python/cpython/pull/1927/commits/645dfa33cc43640dc2a294a477a63f8175948190
645dfa3https://github.com/python/cpython/pull/1927/commits/645dfa33cc43640dc2a294a477a63f8175948190
https://github.com/segevfiner
bpo-30555: Add _Py_{get,open}_osfhandle{,_noraise} and use them insteadhttps://github.com/python/cpython/pull/1927/commits/013d8ea6aaf4643b99701aeda73590fbad42a926
013d8eahttps://github.com/python/cpython/pull/1927/commits/013d8ea6aaf4643b99701aeda73590fbad42a926
https://github.com/segevfiner
bpo-30555: Swapped the rest of the uses of _{get,open}_osfhandlehttps://github.com/python/cpython/pull/1927/commits/aaf6020ccbeb3b1e9cb1dc9299247d270e3ffa11
aaf6020https://github.com/python/cpython/pull/1927/commits/aaf6020ccbeb3b1e9cb1dc9299247d270e3ffa11
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
force-pushedhttps://github.com/python/cpython/compare/ac3af9ec5e4bf8c18243ab7c8bd6bacf2317a2b6..aaf6020ccbeb3b1e9cb1dc9299247d270e3ffa11
ac3af9ehttps://github.com/python/cpython/commit/ac3af9ec5e4bf8c18243ab7c8bd6bacf2317a2b6
aaf6020https://github.com/python/cpython/commit/aaf6020ccbeb3b1e9cb1dc9299247d270e3ffa11
Compare https://github.com/python/cpython/compare/ac3af9ec5e4bf8c18243ab7c8bd6bacf2317a2b6..aaf6020ccbeb3b1e9cb1dc9299247d270e3ffa11
June 4, 2017 18:35https://github.com/python/cpython/pull/1927#event-1109201648
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Jun 4, 2017 https://github.com/python/cpython/pull/1927#pullrequestreview-41953139
View reviewed changes https://github.com/python/cpython/pull/1927/files/aaf6020ccbeb3b1e9cb1dc9299247d270e3ffa11
Include/fileutils.hhttps://github.com/python/cpython/pull/1927/files/aaf6020ccbeb3b1e9cb1dc9299247d270e3ffa11#diff-5826aeacea8b599a708a1dd502aaba4f567f4db487f2e86a70b9ae2a5d791f0d
eryksunhttps://github.com/eryksun
Jun 4, 2017https://github.com/python/cpython/pull/1927#discussion_r120023325
Please reload this pagehttps://github.com/python/cpython/pull/1927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1927
segevfinerhttps://github.com/segevfiner
Jun 5, 2017https://github.com/python/cpython/pull/1927#discussion_r120046461
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1927
eryksunhttps://github.com/eryksun
Jun 5, 2017https://github.com/python/cpython/pull/1927#discussion_r120047718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
HANDLEhttps://msdn.microsoft.com/en-us/library/aa383751#HANDLE
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/segevfiner
bpo-30555: Swap intptr_t to void* in _Py_{get,open}_osfhandle{,_noraise}https://github.com/python/cpython/pull/1927/commits/7727bc558bf37047228271deb2ddf89f75ac4988
7727bc5https://github.com/python/cpython/pull/1927/commits/7727bc558bf37047228271deb2ddf89f75ac4988
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
force-pushedhttps://github.com/python/cpython/compare/50ff023fad2263239a164bf79028184cc50648c5..7727bc558bf37047228271deb2ddf89f75ac4988
50ff023https://github.com/python/cpython/commit/50ff023fad2263239a164bf79028184cc50648c5
7727bc5https://github.com/python/cpython/commit/7727bc558bf37047228271deb2ddf89f75ac4988
Compare https://github.com/python/cpython/compare/50ff023fad2263239a164bf79028184cc50648c5..7727bc558bf37047228271deb2ddf89f75ac4988
June 5, 2017 17:04https://github.com/python/cpython/pull/1927#event-1110325619
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Jun 5, 2017 https://github.com/python/cpython/pull/1927#pullrequestreview-42163223
View reviewed changes https://github.com/python/cpython/pull/1927/files/7727bc558bf37047228271deb2ddf89f75ac4988
PC/msvcrtmodule.chttps://github.com/python/cpython/pull/1927/files/7727bc558bf37047228271deb2ddf89f75ac4988#diff-37e4d6387c5c3bd0f6cedfda8b8d3d9771e1233e0d9d60ca0dc7a6f081b1fa90
eryksunhttps://github.com/eryksun
Jun 5, 2017https://github.com/python/cpython/pull/1927#discussion_r120218568
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1927
segevfinerhttps://github.com/segevfiner
June 6, 2017 01:47https://github.com/python/cpython/pull/1927#commits-pushed-0644634
https://github.com/segevfiner
bpo-30555: msvcrtmodule.c: Use an argument clinic convertor instead o…https://github.com/python/cpython/pull/1927/commits/06446349ccdb17a1ff4347a053435472987b4906
0644634https://github.com/python/cpython/pull/1927/commits/06446349ccdb17a1ff4347a053435472987b4906
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into bpo-30555-windows…https://github.com/python/cpython/pull/1927/commits/82a18bb77aa166a24e3afafa3c2e48677846e7b2
82a18bbhttps://github.com/python/cpython/pull/1927/commits/82a18bb77aa166a24e3afafa3c2e48677846e7b2
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 8, 2017https://github.com/python/cpython/pull/1927#issuecomment-307223497
@Haypohttps://github.com/Haypo
#2003https://github.com/python/cpython/pull/2003
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into bpo-30555-windows…https://github.com/python/cpython/pull/1927/commits/ad77cd3534fa4215e279c415410751cea1d74c06
ad77cd3https://github.com/python/cpython/pull/1927/commits/ad77cd3534fa4215e279c415410751cea1d74c06
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 10, 2017https://github.com/python/cpython/pull/1927#issuecomment-307549371
Please reload this pagehttps://github.com/python/cpython/pull/1927
segevfinerhttps://github.com/segevfiner
June 30, 2017 17:38https://github.com/python/cpython/pull/1927#commits-pushed-9dd4ea9
https://github.com/segevfiner
bpo-30555: Also consider NULL as a possible error in HANDLE_return_co…https://github.com/python/cpython/pull/1927/commits/9dd4ea958e91ddf92850cfbba49d0e38b52d57a5
9dd4ea9https://github.com/python/cpython/pull/1927/commits/9dd4ea958e91ddf92850cfbba49d0e38b52d57a5
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into bpo-30555-windows…https://github.com/python/cpython/pull/1927/commits/07a979ffb40f7c56da0731ba645c2afcbed32997
07a979fhttps://github.com/python/cpython/pull/1927/commits/07a979ffb40f7c56da0731ba645c2afcbed32997
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into bpo-30555-windows…https://github.com/python/cpython/pull/1927/commits/69b13f72ea08310985ecfd7ca8b3f4ba406810ed
69b13f7https://github.com/python/cpython/pull/1927/commits/69b13f72ea08310985ecfd7ca8b3f4ba406810ed
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into bpo-30555-windows…https://github.com/python/cpython/pull/1927/commits/e54f9c0f69e8b52f030b7e7e75fee01fa14c11d9
e54f9c0https://github.com/python/cpython/pull/1927/commits/e54f9c0f69e8b52f030b7e7e75fee01fa14c11d9
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
code ownerhttps://github.com/python/cpython/blob/45700fb757591a672e9d25b8252971c2a2caeaf2/.github/CODEOWNERS#L37
December 16, 2017 10:17https://github.com/python/cpython/pull/1927#event-1390692805
https://github.com/segevfiner
Add NEWS.d entry for bpo-30555https://github.com/python/cpython/pull/1927/commits/2d252aba6d61624e1d5f278e5d9a970bfc1442eb
2d252abhttps://github.com/python/cpython/pull/1927/commits/2d252aba6d61624e1d5f278e5d9a970bfc1442eb
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
force-pushedhttps://github.com/python/cpython/compare/c3953d545c2c4ca0aee13a0116647159136d3023..2d252aba6d61624e1d5f278e5d9a970bfc1442eb
c3953d5https://github.com/python/cpython/commit/c3953d545c2c4ca0aee13a0116647159136d3023
2d252abhttps://github.com/python/cpython/commit/2d252aba6d61624e1d5f278e5d9a970bfc1442eb
Compare https://github.com/python/cpython/compare/c3953d545c2c4ca0aee13a0116647159136d3023..2d252aba6d61624e1d5f278e5d9a970bfc1442eb
December 16, 2017 10:26https://github.com/python/cpython/pull/1927#event-1390695514
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into bpo-30555-windows…https://github.com/python/cpython/pull/1927/commits/7990e20542d657f342042e36d71d5ce0e40c36fe
7990e20https://github.com/python/cpython/pull/1927/commits/7990e20542d657f342042e36d71d5ce0e40c36fe
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
lysnikolaouhttps://github.com/lysnikolaou
pablogsalhttps://github.com/pablogsal
code ownershttps://github.com/python/cpython/blob/6086ae7fd4aeb4089282189673f9bd0cc33abf9b/.github/CODEOWNERS#L83
March 16, 2021 14:23https://github.com/python/cpython/pull/1927#event-4464871674
segevfinerhttps://github.com/segevfiner
March 16, 2021 16:24https://github.com/python/cpython/pull/1927#commits-pushed-bd8233e
https://github.com/segevfiner
https://github.com/eryksun
fileno should error when closedhttps://github.com/python/cpython/pull/1927/commits/bd8233ec9837e4179538e7a0596d8207f32f6e71
bd8233ehttps://github.com/python/cpython/pull/1927/commits/bd8233ec9837e4179538e7a0596d8207f32f6e71
https://github.com/segevfiner
Fix faulty call to IOBase.close introduced by automatic mergehttps://github.com/python/cpython/pull/1927/commits/b76da3ef759208ce431f851595701cb5da640d2d
b76da3ehttps://github.com/python/cpython/pull/1927/commits/b76da3ef759208ce431f851595701cb5da640d2d
https://github.com/zooba
zoobahttps://github.com/zooba
5e437fbhttps://github.com/python/cpython/commit/5e437fb872279960992c9a07f1a4c051b4948c53
Apr 23, 2021https://github.com/python/cpython/pull/1927#event-4639010414
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 23, 2021https://github.com/python/cpython/pull/1927#event-4639010531
https://github.com/zooba
zoobahttps://github.com/zooba
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946564
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/zooba
zoobahttps://github.com/zooba
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
Apr 23, 2021https://github.com/python/cpython/pull/1927#event-4639013270
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946778
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946780
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946804
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
zoobahttps://github.com/zooba
Apr 23, 2021https://github.com/python/cpython/pull/1927#event-4639013535
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946810
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/zooba
zoobahttps://github.com/zooba
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Apr 23, 2021https://github.com/python/cpython/pull/1927#event-4639014125
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946932
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946934
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946947
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 23, 2021https://github.com/python/cpython/pull/1927#issuecomment-825946955
@segevfinerhttps://github.com/segevfiner
@zoobahttps://github.com/zooba
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/zooba
zoobahttps://github.com/zooba
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Apr 23, 2021https://github.com/python/cpython/pull/1927#event-4639015377
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
February 21, 2022 09:38https://github.com/python/cpython/pull/1927#event-6110124964
https://github.com/python/cpython/pull/1927
segevfinerhttps://github.com/python/cpython/pull/1927
Apr 10, 2022 https://github.com/python/cpython/pull/1927#ref-issue-1198974307
_io._WindowsConsoleIO breaks in the face of fd redirection #74740 https://github.com/python/cpython/issues/74740
gh-77046: Pass the _O_NOINHERIT flag to _open_osfhandle() calls #13739 https://github.com/python/cpython/pull/13739
[os] pipe() creates inheritable FDs with a bad internal state in Windows #77046 https://github.com/python/cpython/issues/77046
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1927
https://github.com/eryksun
eryksun https://github.com/eryksun
https://github.com/python/cpython/pull/1927/files/116fe9cb4e25f4233121dcdc92c102954c2f2497
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/zooba
zooba https://github.com/zooba
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
Please reload this pagehttps://github.com/python/cpython/pull/1927
https://github.com/segevfiner
https://github.com/mention-bot
https://github.com/eryksun
https://github.com/csabella
https://github.com/zooba
https://github.com/miss-islington
https://github.com/brettcannon
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.