René's URL Explorer Experiment


Title: [3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385) by miss-islington · Pull Request #19176 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385) by miss-islington · Pull Request #19176 · python/cpython

X Title: [3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385) by miss-islington · Pull Request #19176 · python/cpython

Description: This pull request fixes the newline conversion bug originally reported in bpo-1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does, which makes the issue fix simpler, since the only code path that needs to be changed is the one in doctest._load_testfile where the file is loaded from a package whose loader has a get_data method. (cherry picked from commit e0b8101) Co-authored-by: Peter Donis peterdonis@alum.mit.edu https://bugs.python.org/issue1812

Open Graph Description: This pull request fixes the newline conversion bug originally reported in bpo-1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does...

X Description: This pull request fixes the newline conversion bug originally reported in bpo-1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does...

Opengraph URL: https://github.com/python/cpython/pull/19176

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b6ce8539-c523-96d5-1e55-f329f35c6ce5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B42:25F127:159B4D:1D87C0:6B006498
html-safe-nonce992fb8a6fd344117a0ad6ce99d3a855e9080fbf2c5bf8a4fbb6bb161be019484
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjQyOjI1RjEyNzoxNTlCNEQ6MUQ4N0MwOjZCMDA2NDk4IiwidmlzaXRvcl9pZCI6IjYxOTU4ODk3NDUzNDg4MTM5NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac81edf737d58078e48bbcd544f04fa877ccb84896b9d73d3bb569d48b1a0c5901
hovercard-subject-tagpull_request:394257327
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/19176/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altThis pull request fixes the newline conversion bug originally reported in bpo-1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19176/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19176%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19176%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19176/files
Reloadhttps://github.com/python/cpython/pull/19176/files
Reloadhttps://github.com/python/cpython/pull/19176/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-e0b8101-3.7https://github.com/miss-islington/cpython/tree/backport-e0b8101-3.7
Conversation 2 https://github.com/python/cpython/pull/19176
Commits 1 https://github.com/python/cpython/pull/19176/commits
Checks 0 https://github.com/python/cpython/pull/19176/checks
Files changed https://github.com/python/cpython/pull/19176/files
Please reload this pagehttps://github.com/python/cpython/pull/19176/files
[3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385) https://github.com/python/cpython/pull/19176/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/19176/files
a24ef3c bpo-1812: Fix newline conversion when doctest.testfile loads from a p… pdonis Mar 26, 2020 https://github.com/python/cpython/pull/19176/commits/a24ef3cac27c87d90ac10e794762c9ba50e95ac4
Clear filters https://github.com/python/cpython/pull/19176/files
Please reload this pagehttps://github.com/python/cpython/pull/19176/files
Please reload this pagehttps://github.com/python/cpython/pull/19176/files
doctest.py https://github.com/python/cpython/pull/19176/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
test_doctest.py https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
ACKS https://github.com/python/cpython/pull/19176/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2019-11-25-21-46-47.bpo-1812.sAbTbY.rst https://github.com/python/cpython/pull/19176/files#diff-e0293909b5c7f34da234c2997814db2ca08afe609438d1d94e3966da7b9c76db
Lib/doctest.pyhttps://github.com/python/cpython/pull/19176/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
View file https://github.com/miss-islington/cpython/blob/a24ef3cac27c87d90ac10e794762c9ba50e95ac4/Lib/doctest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19176/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19176/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com/python/cpython/pull/19176/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com/python/cpython/pull/19176/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
View file https://github.com/miss-islington/cpython/blob/a24ef3cac27c87d90ac10e794762c9ba50e95ac4/Lib/test/test_doctest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19176/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/19176/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
Misc/ACKShttps://github.com/python/cpython/pull/19176/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/miss-islington/cpython/blob/a24ef3cac27c87d90ac10e794762c9ba50e95ac4/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19176/{{ revealButtonHref }}
https://github.com/python/cpython/pull/19176/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/19176/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Tests/2019-11-25-21-46-47.bpo-1812.sAbTbY.rsthttps://github.com/python/cpython/pull/19176/files#diff-e0293909b5c7f34da234c2997814db2ca08afe609438d1d94e3966da7b9c76db
View file https://github.com/miss-islington/cpython/blob/a24ef3cac27c87d90ac10e794762c9ba50e95ac4/Misc/NEWS.d/next/Tests/2019-11-25-21-46-47.bpo-1812.sAbTbY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/19176/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.