René's URL Explorer Experiment


Title: [3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385) by miss-islington · Pull Request #19176 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385) by miss-islington · Pull Request #19176 · python/cpython

X Title: [3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385) by miss-islington · Pull Request #19176 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This pull request fixes the newline conversion bug originally reported in bpo-1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does...

X Description: This pull request fixes the newline conversion bug originally reported in bpo-1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does...

Mail addresses
peterdonis@alum.mit.edu

Opengraph URL: https://github.com/python/cpython/pull/19176

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8ab2f4e0-1aaa-045c-8b52-192c4fed69b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA474:39DC4B:78DBB:A9B87:6B0061BD
html-safe-nonce997de3660b9c9316228115613c338dc80cac0e2700cf176868db18c1be5127af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDc0OjM5REM0Qjo3OERCQjpBOUI4Nzo2QjAwNjFCRCIsInZpc2l0b3JfaWQiOiI2NDMyNzMxNTgwODMzMjI3MTk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1f9b649a8626c7f0edf4efa62802bc149089d08a7a4a1fbf509dee1414f55410
hovercard-subject-tagpull_request:394257327
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19176/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03fc3b1aaae93faa9372ed028157d2c80b7180a93f4b3b138e21d67f57e4e36a/python/cpython/pull/19176
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03fc3b1aaae93faa9372ed028157d2c80b7180a93f4b3b138e21d67f57e4e36a/python/cpython/pull/19176
og:image:altThis pull request fixes the newline conversion bug originally reported in bpo-1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/19176#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19176
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19176
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19176
Reloadhttps://github.com/python/cpython/pull/19176
Reloadhttps://github.com/python/cpython/pull/19176
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-e0b8101-3.7https://github.com/miss-islington/cpython/tree/backport-e0b8101-3.7
Conversationhttps://github.com/python/cpython/pull/19176
Commits1 (1)https://github.com/python/cpython/pull/19176/commits
Checkshttps://github.com/python/cpython/pull/19176/checks
Files changedhttps://github.com/python/cpython/pull/19176/files
[3.7] bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method (GH-17385)https://github.com/python/cpython/pull/19176#top
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-e0b8101-3.7https://github.com/miss-islington/cpython/tree/backport-e0b8101-3.7
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020https://github.com/python/cpython/pull/19176#issue-588527578
Please reload this pagehttps://github.com/python/cpython/pull/19176
bpo-1812https://bugs.python.org/issue1812
e0b8101https://github.com/python/cpython/commit/e0b8101492f6c61dee831425b4d3dae39a953599
https://bugs.python.org/issue1812https://bugs.python.org/issue1812
Please reload this pagehttps://github.com/python/cpython/pull/19176
https://github.com/pdonis
https://github.com/miss-islington
bpo-1812: Fix newline conversion when doctest.testfile loads from a p…https://github.com/python/cpython/pull/19176/commits/a24ef3cac27c87d90ac10e794762c9ba50e95ac4
a24ef3chttps://github.com/python/cpython/pull/19176/commits/a24ef3cac27c87d90ac10e794762c9ba50e95ac4
pythonGH-17385https://github.com/python/cpython/pull/17385
e0b8101https://github.com/miss-islington/cpython/commit/e0b8101492f6c61dee831425b4d3dae39a953599
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 26, 2020https://github.com/python/cpython/pull/19176#event-3168896166
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 26, 2020 https://github.com/python/cpython/pull/19176#ref-pullrequest-528418649
bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. #17385 https://github.com/python/cpython/pull/17385
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 26, 2020https://github.com/python/cpython/pull/19176#event-3168896283
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020https://github.com/python/cpython/pull/19176#issuecomment-604521608
@pdonishttps://github.com/pdonis
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/19176
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020https://github.com/python/cpython/pull/19176#issuecomment-604523424
@pdonishttps://github.com/pdonis
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/19176
https://github.com/zware
zwarehttps://github.com/zware
Mar 26, 2020 https://github.com/python/cpython/pull/19176#pullrequestreview-382175975
View reviewed changes https://github.com/python/cpython/pull/19176/files/a24ef3cac27c87d90ac10e794762c9ba50e95ac4
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 26, 2020https://github.com/python/cpython/pull/19176#event-3169010891
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
9387678https://github.com/python/cpython/commit/9387678f8a580726aca5f836b2c50456f236ecbb
Mar 26, 2020https://github.com/python/cpython/pull/19176#event-3169011121
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 26, 2020https://github.com/python/cpython/pull/19176#event-3169011288
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
March 26, 2020 16:19https://github.com/python/cpython/pull/19176#event-3169011394
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19176
https://github.com/zware
zware https://github.com/zware
https://github.com/python/cpython/pull/19176/files/a24ef3cac27c87d90ac10e794762c9ba50e95ac4
Please reload this pagehttps://github.com/python/cpython/pull/19176
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/19176
https://github.com/miss-islington
https://github.com/zware
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/pdonis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.