René's URL Explorer Experiment


Title: [3.7] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) by miss-islington · Pull Request #19001 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) by miss-islington · Pull Request #19001 · python/cpython

X Title: [3.7] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) by miss-islington · Pull Request #19001 · python/cpython

Description: Add host validation for control characters for more CVE-2019-18348 protection. (cherry picked from commit 9165add) Co-authored-by: Ashwin Ramaswami aramaswamis@gmail.com https://bugs.python.org/is...

Open Graph Description: Add host validation for control characters for more CVE-2019-18348 protection. (cherry picked from commit 9165add) Co-authored-by: Ashwin Ramaswami aramaswamis@gmail.com https://bugs.python.org/is...

X Description: Add host validation for control characters for more CVE-2019-18348 protection. (cherry picked from commit 9165add) Co-authored-by: Ashwin Ramaswami aramaswamis@gmail.com https://bugs.python.org/is...

Mail addresses
aramaswamis@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/19001

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:80cd5fd2-ff8c-79f0-2d8e-dce06690e982
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD12:A7972:2657FF7:346C11A:696ACBC1
html-safe-nonce4dfb7ccaf362b0f02e31528639f2c7ae8a68443a534b4add166f50c9848264be
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDEyOkE3OTcyOjI2NTdGRjc6MzQ2QzExQTo2OTZBQ0JDMSIsInZpc2l0b3JfaWQiOiIyNDg1MDI5NDg4OTUzMDUyMDk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac188fa559e79572e8f720b78e30e30e2b037fd119723d74df054e63b5d842f71f
hovercard-subject-tagpull_request:388401380
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/19001/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ad417492c9cdf98e62fbdf6761790731f44ee248a7111e6ec7a74c42d280770a/python/cpython/pull/19001
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad417492c9cdf98e62fbdf6761790731f44ee248a7111e6ec7a74c42d280770a/python/cpython/pull/19001
og:image:altAdd host validation for control characters for more CVE-2019-18348 protection. (cherry picked from commit 9165add) Co-authored-by: Ashwin Ramaswami aramaswamis@gmail.com https://bugs.python.org/is...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/19001#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19001
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19001
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/19001
Reloadhttps://github.com/python/cpython/pull/19001
Reloadhttps://github.com/python/cpython/pull/19001
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/19001
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/19001
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/19001#issue-comment-box
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-9165add-3.7https://github.com/miss-islington/cpython/tree/backport-9165add-3.7
[3.7] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) https://github.com/python/cpython/pull/19001#top
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-9165add-3.7https://github.com/miss-islington/cpython/tree/backport-9165add-3.7
Conversation 2 https://github.com/python/cpython/pull/19001
Commits 1 https://github.com/python/cpython/pull/19001/commits
Checks 0 https://github.com/python/cpython/pull/19001/checks
Files changed https://github.com/python/cpython/pull/19001/files
Please reload this pagehttps://github.com/python/cpython/pull/19001
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020https://github.com/python/cpython/pull/19001#issue-581327946
Please reload this pagehttps://github.com/python/cpython/pull/19001
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/python/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
https://bugs.python.org/issue38576https://bugs.python.org/issue38576
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/19001
https://github.com/epicfaace
https://github.com/miss-islington
bpo-38576: Disallow control characters in hostnames in http.client (https://github.com/python/cpython/pull/19001/commits/66627bac6801704a43bf219b289641d975a24ca0
p…https://github.com/python/cpython/pull/18995
66627bahttps://github.com/python/cpython/pull/19001/commits/66627bac6801704a43bf219b289641d975a24ca0
…ythonGH-18995https://github.com/python/cpython/pull/18995
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/miss-islington/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 14, 2020https://github.com/python/cpython/pull/19001#event-3129699674
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 14, 2020 https://github.com/python/cpython/pull/19001#ref-pullrequest-581240402
bpo-38576: Disallow control characters in hostnames in http.client #18995 https://github.com/python/cpython/pull/18995
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 14, 2020https://github.com/python/cpython/pull/19001#event-3129699682
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
Mar 14, 2020https://github.com/python/cpython/pull/19001#event-3129700840
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 14, 2020 https://github.com/python/cpython/pull/19001#pullrequestreview-374746878
View reviewed changes https://github.com/python/cpython/pull/19001/files/66627bac6801704a43bf219b289641d975a24ca0
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 14, 2020https://github.com/python/cpython/pull/19001#event-3129701362
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020https://github.com/python/cpython/pull/19001#issuecomment-599123175
@epicfaacehttps://github.com/epicfaace
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/19001
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
34f85afhttps://github.com/python/cpython/commit/34f85af3229f86c004a954c3f261ceea1f5e9f95
Mar 14, 2020https://github.com/python/cpython/pull/19001#event-3129714553
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 14, 2020https://github.com/python/cpython/pull/19001#event-3129714588
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
March 14, 2020 19:13https://github.com/python/cpython/pull/19001#event-3129714609
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020https://github.com/python/cpython/pull/19001#issuecomment-599123933
@epicfaacehttps://github.com/epicfaace
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/19001
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F19001
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/19001/files/66627bac6801704a43bf219b289641d975a24ca0
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Please reload this pagehttps://github.com/python/cpython/pull/19001
https://github.com/miss-islington
https://github.com/gpshead
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/epicfaace
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.