René's URL Explorer Experiment


Title: bpo-38576: Disallow control characters in hostnames in http.client by epicfaace · Pull Request #18995 · python/cpython · GitHub

Open Graph Title: bpo-38576: Disallow control characters in hostnames in http.client by epicfaace · Pull Request #18995 · python/cpython

X Title: bpo-38576: Disallow control characters in hostnames in http.client by epicfaace · Pull Request #18995 · python/cpython

Description: Extends #12755 to apply to hostnames. https://bugs.python.org/issue38576

Open Graph Description: Extends #12755 to apply to hostnames. https://bugs.python.org/issue38576

X Description: Extends #12755 to apply to hostnames. https://bugs.python.org/issue38576

Opengraph URL: https://github.com/python/cpython/pull/18995

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:93eb768b-b38d-a57e-6ac5-baf494dc3ecf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE204:367724:E1AC0D:127F00B:696B6587
html-safe-nonce0a822fb9ccd3dded9769cc0b2533de6f509bafd0500be7b51a14db82152d347c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjA0OjM2NzcyNDpFMUFDMEQ6MTI3RjAwQjo2OTZCNjU4NyIsInZpc2l0b3JfaWQiOiI1NzU0NTMxNjQ3NDkwNTgxODk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca1802cd4ddbc14e0e83c03a08d94398266ad30fbf8cf90e9ebbae70abac26577
hovercard-subject-tagpull_request:388329511
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18995/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/35caf58ed22d69e57440b765ee23f85e4129b72b31c100e75ed918ab55cc447e/python/cpython/pull/18995
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/35caf58ed22d69e57440b765ee23f85e4129b72b31c100e75ed918ab55cc447e/python/cpython/pull/18995
og:image:altExtends #12755 to apply to hostnames. https://bugs.python.org/issue38576
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameepicfaace
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18995#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18995
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18995
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18995
Reloadhttps://github.com/python/cpython/pull/18995
Reloadhttps://github.com/python/cpython/pull/18995
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18995
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/18995
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/18995#issue-comment-box
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
epicfaace:urlhttps://github.com/epicfaace/cpython/tree/url
bpo-38576: Disallow control characters in hostnames in http.client https://github.com/python/cpython/pull/18995#top
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
epicfaace:urlhttps://github.com/epicfaace/cpython/tree/url
Conversation 6 https://github.com/python/cpython/pull/18995
Commits 2 https://github.com/python/cpython/pull/18995/commits
Checks 0 https://github.com/python/cpython/pull/18995/checks
Files changed https://github.com/python/cpython/pull/18995/files
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/epicfaace
epicfaacehttps://github.com/epicfaace
Mar 14, 2020https://github.com/python/cpython/pull/18995#issue-581240402
Please reload this pagehttps://github.com/python/cpython/pull/18995
#12755https://github.com/python/cpython/pull/12755
https://bugs.python.org/issue38576https://bugs.python.org/issue38576
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.com/epicfaace
add host validation for control charactershttps://github.com/python/cpython/pull/18995/commits/e3ad9a9ec2ab2d7c063a20a3e5de44f558af5873
e3ad9a9https://github.com/python/cpython/pull/18995/commits/e3ad9a9ec2ab2d7c063a20a3e5de44f558af5873
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129456652
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129456684
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/18995/commits/54df435b86c01f23f040083abcf3773b3f404407
54df435https://github.com/python/cpython/pull/18995/commits/54df435b86c01f23f040083abcf3773b3f404407
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129694425
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 14, 2020 https://github.com/python/cpython/pull/18995#pullrequestreview-374746356
View reviewed changes https://github.com/python/cpython/pull/18995/files/54df435b86c01f23f040083abcf3773b3f404407
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129694550
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129695303
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 14, 2020https://github.com/python/cpython/pull/18995#issuecomment-599121163
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
9165addhttps://github.com/python/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129699345
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020https://github.com/python/cpython/pull/18995#issuecomment-599121240
@epicfaacehttps://github.com/epicfaace
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129699375
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020 https://github.com/python/cpython/pull/18995#ref-commit-f8213f0
https://github.com/epicfaace
https://github.com/miss-islington
bpo-38576: Disallow control characters in hostnames in http.client (https://github.com/miss-islington/cpython/commit/f8213f0bf7c10e2d574c08e53530f06f9e78730b
p…https://github.com/python/cpython/pull/18995
f8213f0https://github.com/miss-islington/cpython/commit/f8213f0bf7c10e2d574c08e53530f06f9e78730b
…ythonGH-18995https://github.com/python/cpython/pull/18995
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/miss-islington/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 14, 2020https://github.com/python/cpython/pull/18995#issuecomment-599121263
GH-19000https://github.com/python/cpython/pull/19000
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129699566
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 14, 2020https://github.com/python/cpython/pull/18995#issuecomment-599121275
GH-19001https://github.com/python/cpython/pull/19001
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129699665
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020 https://github.com/python/cpython/pull/18995#ref-commit-1e24df6
https://github.com/epicfaace
https://github.com/miss-islington
bpo-38576: Disallow control characters in hostnames in http.client (https://github.com/miss-islington/cpython/commit/1e24df641580ae952a922f90c69b146041006257
p…https://github.com/python/cpython/pull/18995
1e24df6https://github.com/miss-islington/cpython/commit/1e24df641580ae952a922f90c69b146041006257
…ythonGH-18995https://github.com/python/cpython/pull/18995
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/miss-islington/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Mar 14, 2020https://github.com/python/cpython/pull/18995#event-3129699763
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 14, 2020https://github.com/python/cpython/pull/18995#issuecomment-599121288
GH-19002https://github.com/python/cpython/pull/19002
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/18995
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020 https://github.com/python/cpython/pull/18995#ref-commit-66627ba
https://github.com/epicfaace
https://github.com/miss-islington
bpo-38576: Disallow control characters in hostnames in http.client (https://github.com/miss-islington/cpython/commit/66627bac6801704a43bf219b289641d975a24ca0
p…https://github.com/python/cpython/pull/18995
66627bahttps://github.com/miss-islington/cpython/commit/66627bac6801704a43bf219b289641d975a24ca0
…ythonGH-18995https://github.com/python/cpython/pull/18995
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/miss-islington/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020 https://github.com/python/cpython/pull/18995#ref-commit-34f85af
https://github.com/miss-islington
https://github.com/epicfaace
bpo-38576https://bugs.python.org/issue?@action=redirect&bpo=38576
: Disallow control characters in hostnames in http.client (https://github.com/python/cpython/commit/34f85af3229f86c004a954c3f261ceea1f5e9f95
G…https://github.com/python/cpython/pull/18995
34f85afhttps://github.com/python/cpython/commit/34f85af3229f86c004a954c3f261ceea1f5e9f95
…H-18995https://github.com/python/cpython/pull/18995
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/python/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
miss-islingtonhttps://github.com/miss-islington
Mar 14, 2020 https://github.com/python/cpython/pull/18995#ref-commit-ff69c9d
https://github.com/miss-islington
https://github.com/epicfaace
bpo-38576https://bugs.python.org/issue?@action=redirect&bpo=38576
: Disallow control characters in hostnames in http.client (https://github.com/python/cpython/commit/ff69c9d12c1b06af58e5eae5db4630cedd94740e
G…https://github.com/python/cpython/pull/18995
ff69c9dhttps://github.com/python/cpython/commit/ff69c9d12c1b06af58e5eae5db4630cedd94740e
…H-18995https://github.com/python/cpython/pull/18995
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/python/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
https://github.com/epicfaace
epicfaacehttps://github.com/epicfaace
March 14, 2020 20:09https://github.com/python/cpython/pull/18995#event-3129761592
ned-deilyhttps://github.com/ned-deily
Mar 14, 2020 https://github.com/python/cpython/pull/18995#ref-commit-83fc701
https://github.com/miss-islington
https://github.com/epicfaace
bpo-38576https://bugs.python.org/issue?@action=redirect&bpo=38576
: Disallow control characters in hostnames in http.client (https://github.com/python/cpython/commit/83fc70159b24f5b11a5ef87c9b05c2cf4c7faeba
G…https://github.com/python/cpython/pull/18995
83fc701https://github.com/python/cpython/commit/83fc70159b24f5b11a5ef87c9b05c2cf4c7faeba
…H-18995https://github.com/python/cpython/pull/18995
GH-19002https://github.com/python/cpython/pull/19002
CVE-2019-18348https://github.com/advisories/GHSA-v3f8-6665-x7rx
9165addhttps://github.com/python/cpython/commit/9165addc22d05e776a54319a8531ebd0b2fe01ef
https://github.com/tapakund
tapakundhttps://github.com/tapakund
Mar 31, 2020https://github.com/python/cpython/pull/18995#issuecomment-606388023
#19231https://github.com/python/cpython/pull/19231
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.com/tim-one
tim-onehttps://github.com/tim-one
Feb 28, 2022 https://github.com/python/cpython/pull/18995#ref-pullrequest-1153403882
Non-uniform random floats (_randommodule.c) #31606 https://github.com/python/cpython/pull/31606
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18995
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/18995/files/54df435b86c01f23f040083abcf3773b3f404407
https://github.com/gpshead
gpshead https://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Please reload this pagehttps://github.com/python/cpython/pull/18995
https://github.com/epicfaace
https://github.com/gpshead
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/tapakund
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.