René's URL Explorer Experiment


Title: bpo-39689: _struct: Avoid undefined behavior when loading native _Bool by encukou · Pull Request #18925 · python/cpython · GitHub

Open Graph Title: bpo-39689: _struct: Avoid undefined behavior when loading native _Bool by encukou · Pull Request #18925 · python/cpython

X Title: bpo-39689: _struct: Avoid undefined behavior when loading native _Bool by encukou · Pull Request #18925 · python/cpython

Description: To avoid undefined behavior in the C code, we assume that in every mode, the size is 1, \x00 is false, and \x01 is true. With that assumption we can cast from char to _Bool, and avoid UB. https://bugs.python.org/issue39689

Open Graph Description: To avoid undefined behavior in the C code, we assume that in every mode, the size is 1, \x00 is false, and \x01 is true. With that assumption we can cast from char to _Bool, and avoid UB. https://...

X Description: To avoid undefined behavior in the C code, we assume that in every mode, the size is 1, \x00 is false, and \x01 is true. With that assumption we can cast from char to _Bool, and avoid UB. https://...

Opengraph URL: https://github.com/python/cpython/pull/18925

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5ad4e208-a2a3-b85f-c6f1-9b026952aaf0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBA4:2E3FEE:4DCB858:622CDC0:6B025D90
html-safe-noncedfaf5cbf3b4c6438f448d0e9df509a9050c2fca062e6fc014b657bc90a3b8faa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkE0OjJFM0ZFRTo0RENCODU4OjYyMkNEQzA6NkIwMjVEOTAiLCJ2aXNpdG9yX2lkIjoiMjEzNDk4Nzk4MzYxMzQ4NDQzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac83e22496c63a9a5b682bebf15a93a777b8eda4a73ad1c816f48e4139e622e0ca
hovercard-subject-tagpull_request:386737358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/18925/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altTo avoid undefined behavior in the C code, we assume that in every mode, the size is 1, \x00 is false, and \x01 is true. With that assumption we can cast from char to _Bool, and avoid UB. https://...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18925/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18925%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18925%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18925/files
Reloadhttps://github.com/python/cpython/pull/18925/files
Reloadhttps://github.com/python/cpython/pull/18925/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:bpo-39689https://github.com/encukou/cpython/tree/bpo-39689
Conversation 4 https://github.com/python/cpython/pull/18925
Commits 3 https://github.com/python/cpython/pull/18925/commits
Checks 0 https://github.com/python/cpython/pull/18925/checks
Files changed https://github.com/python/cpython/pull/18925/files
Please reload this pagehttps://github.com/python/cpython/pull/18925/files
bpo-39689: _struct: Avoid undefined behavior when loading native _Bool https://github.com/python/cpython/pull/18925/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/18925/files
0ab0be8 bpo-39689: _struct: Avoid undefined behavior when loading native _Bool encukou Mar 11, 2020 https://github.com/python/cpython/pull/18925/commits/0ab0be811fc96acc7a12c0b9a269a6595b888f4d
92b0e84 test_buffer: Use subTest() to help debug a failure encukou Mar 11, 2020 https://github.com/python/cpython/pull/18925/commits/92b0e84c0d1a7f1a1db700621fbeb7ff00283804
38c78c8 Use the same strategy also for memoryview encukou Mar 11, 2020 https://github.com/python/cpython/pull/18925/commits/38c78c851eebbb0852d9efdd84f5c415a8761a9f
Clear filters https://github.com/python/cpython/pull/18925/files
Please reload this pagehttps://github.com/python/cpython/pull/18925/files
Please reload this pagehttps://github.com/python/cpython/pull/18925/files
test_buffer.py https://github.com/python/cpython/pull/18925/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
test_struct.py https://github.com/python/cpython/pull/18925/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
2020-03-11-15-46-59.bpo-39689.uzQhJX.rst https://github.com/python/cpython/pull/18925/files#diff-15ef2ceec819343605c298112ab7b0150472279272d369a259d8d6ca98f85e61
_struct.c https://github.com/python/cpython/pull/18925/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
memoryobject.c https://github.com/python/cpython/pull/18925/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
Lib/test/test_buffer.pyhttps://github.com/python/cpython/pull/18925/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
View file https://github.com/encukou/cpython/blob/38c78c851eebbb0852d9efdd84f5c415a8761a9f/Lib/test/test_buffer.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18925/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18925/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
https://github.com/python/cpython/pull/18925/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
Lib/test/test_struct.pyhttps://github.com/python/cpython/pull/18925/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
View file https://github.com/encukou/cpython/blob/38c78c851eebbb0852d9efdd84f5c415a8761a9f/Lib/test/test_struct.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18925/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18925/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
https://github.com/python/cpython/pull/18925/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
Misc/NEWS.d/next/Library/2020-03-11-15-46-59.bpo-39689.uzQhJX.rsthttps://github.com/python/cpython/pull/18925/files#diff-15ef2ceec819343605c298112ab7b0150472279272d369a259d8d6ca98f85e61
View file https://github.com/encukou/cpython/blob/38c78c851eebbb0852d9efdd84f5c415a8761a9f/Misc/NEWS.d/next/Library/2020-03-11-15-46-59.bpo-39689.uzQhJX.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18925/{{ revealButtonHref }}
Modules/_struct.chttps://github.com/python/cpython/pull/18925/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
View file https://github.com/encukou/cpython/blob/38c78c851eebbb0852d9efdd84f5c415a8761a9f/Modules/_struct.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18925/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18925/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
https://github.com/python/cpython/pull/18925/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
Objects/memoryobject.chttps://github.com/python/cpython/pull/18925/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
View file https://github.com/encukou/cpython/blob/38c78c851eebbb0852d9efdd84f5c415a8761a9f/Objects/memoryobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18925/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18925/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
skrahhttps://github.com/skrah
Mar 11, 2020https://github.com/python/cpython/pull/18925/files#r391304330
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18925/files
encukouhttps://github.com/encukou
Mar 12, 2020https://github.com/python/cpython/pull/18925/files#r391531136
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18925/files
skrahhttps://github.com/skrah
Mar 12, 2020https://github.com/python/cpython/pull/18925/files#r391707385
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18925/files
encukouhttps://github.com/encukou
Mar 12, 2020https://github.com/python/cpython/pull/18925/files#r391726011
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18925/files
https://github.com/python/cpython/pull/18925/files#diff-7d1cb11da20dc3738b65b0f7381bf02df53132562a9749ba8a22d67a0f05f106
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.