René's URL Explorer Experiment


Title: bpo-39877: take_gil() now exits the thread if finalizing by vstinner · Pull Request #18854 · python/cpython · GitHub

Open Graph Title: bpo-39877: take_gil() now exits the thread if finalizing by vstinner · Pull Request #18854 · python/cpython

X Title: bpo-39877: take_gil() now exits the thread if finalizing by vstinner · Pull Request #18854 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: take_gil() is now responsible to exit the thread if Python is finalizing. Not only exit before trying to acquire the GIL, but exit also once the GIL is succesfully acquired. https://bugs.python.o...

X Description: take_gil() is now responsible to exit the thread if Python is finalizing. Not only exit before trying to acquire the GIL, but exit also once the GIL is succesfully acquired. https://bugs.python.o...

Opengraph URL: https://github.com/python/cpython/pull/18854

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:734d87a2-8daa-04d4-d4d3-aa86eba26e84
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9636:514A5:508C16:6D7E30:6A4DA5DD
html-safe-nonce2ac1a47e95444e3cac853ff5fca8b27330bf7e8e9314512ab9c44e2dc00c4f1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjM2OjUxNEE1OjUwOEMxNjo2RDdFMzA6NkE0REE1REQiLCJ2aXNpdG9yX2lkIjoiNjM5MTU1Mzg4NjgxMzc5MTcwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac31b44abade3c9196f0ab60526fa2d7db8eed9948f32e37e5bad1297f6a2c3ef8
hovercard-subject-tagpull_request:385291390
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18854/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/717308a44e681f78864c1e01e3cd767a60e618b507ff369cf1f2fcf74dab8376/python/cpython/pull/18854
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/717308a44e681f78864c1e01e3cd767a60e618b507ff369cf1f2fcf74dab8376/python/cpython/pull/18854
og:image:alttake_gil() is now responsible to exit the thread if Python is finalizing. Not only exit before trying to acquire the GIL, but exit also once the GIL is succesfully acquired. https://bugs.python.o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7f13faa65cccc9b729d674da83335d5dcfdfd193
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18854#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18854
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18854
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18854
Reloadhttps://github.com/python/cpython/pull/18854
Reloadhttps://github.com/python/cpython/pull/18854
Please reload this pagehttps://github.com/python/cpython/pull/18854
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18854
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/18854
Commits2 (2)https://github.com/python/cpython/pull/18854/commits
Checkshttps://github.com/python/cpython/pull/18854/checks
Files changedhttps://github.com/python/cpython/pull/18854/files
bpo-39877: take_gil() now exits the thread if finalizinghttps://github.com/python/cpython/pull/18854#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 8, 2020https://github.com/python/cpython/pull/18854#issue-577534918
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://bugs.python.org/issue39877https://bugs.python.org/issue39877
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/vstinner
bpo-39877https://bugs.python.org/issue?@action=redirect&bpo=39877
: take_gil() now exits the thread if finalizinghttps://github.com/python/cpython/pull/18854/commits/9ac0b252ab77694a216c27a5622a2dd1359aa3f5
9ac0b25https://github.com/python/cpython/pull/18854/commits/9ac0b252ab77694a216c27a5622a2dd1359aa3f5
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 8, 2020https://github.com/python/cpython/pull/18854#event-3108569877
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 8, 2020https://github.com/python/cpython/pull/18854#event-3108569922
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 8, 2020https://github.com/python/cpython/pull/18854#issuecomment-596229534
@pitrouhttps://github.com/pitrou
https://bugs.python.org/issue39877#msg363667https://bugs.python.org/issue39877#msg363667
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 8, 2020https://github.com/python/cpython/pull/18854#issuecomment-596229738
Please reload this pagehttps://github.com/python/cpython/pull/18854
#18848https://github.com/python/cpython/pull/18848
bpo-19466https://bugs.python.org/issue19466
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Mar 8, 2020 https://github.com/python/cpython/pull/18854#pullrequestreview-370847023
View reviewed changes https://github.com/python/cpython/pull/18854/files/9ac0b252ab77694a216c27a5622a2dd1359aa3f5
pitrouhttps://github.com/pitrou
https://github.com/python/cpython/pull/18854#pullrequestreview-370847023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18854
Python/ceval_gil.hhttps://github.com/python/cpython/pull/18854/files/9ac0b252ab77694a216c27a5622a2dd1359aa3f5#diff-a752fe0b500ba9e2a169c27f43c58c1e354039fffa5ad64852e0978006f45660
pitrouhttps://github.com/pitrou
Mar 8, 2020https://github.com/python/cpython/pull/18854#discussion_r389390957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18854
vstinnerhttps://github.com/vstinner
Mar 8, 2020https://github.com/python/cpython/pull/18854#discussion_r389406349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://bugs.python.org/issue39877#msg363667https://bugs.python.org/issue39877#msg363667
https://bugs.python.org/issue39877#msg363512https://bugs.python.org/issue39877#msg363512
Please reload this pagehttps://github.com/python/cpython/pull/18854
Python/ceval_gil.hhttps://github.com/python/cpython/pull/18854/files/9ac0b252ab77694a216c27a5622a2dd1359aa3f5#diff-a752fe0b500ba9e2a169c27f43c58c1e354039fffa5ad64852e0978006f45660
pitrouhttps://github.com/pitrou
Mar 8, 2020https://github.com/python/cpython/pull/18854#discussion_r389392079
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 8, 2020https://github.com/python/cpython/pull/18854#event-3108595767
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 8, 2020https://github.com/python/cpython/pull/18854#issuecomment-596233803
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/vstinner
take_gil() exit after COND_TIMED_WAIT()https://github.com/python/cpython/pull/18854/commits/4f379aa1ffcd2101eff284ea83b660373701e6cb
4f379aahttps://github.com/python/cpython/pull/18854/commits/4f379aa1ffcd2101eff284ea83b660373701e6cb
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 8, 2020 https://github.com/python/cpython/pull/18854#pullrequestreview-370866902
View reviewed changes https://github.com/python/cpython/pull/18854/files/4f379aa1ffcd2101eff284ea83b660373701e6cb
Python/ceval_gil.hhttps://github.com/python/cpython/pull/18854/files/4f379aa1ffcd2101eff284ea83b660373701e6cb#diff-a752fe0b500ba9e2a169c27f43c58c1e354039fffa5ad64852e0978006f45660
vstinnerhttps://github.com/vstinner
Mar 8, 2020https://github.com/python/cpython/pull/18854#discussion_r389417927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18854
vstinnerhttps://github.com/vstinner
Mar 9, 2020https://github.com/python/cpython/pull/18854#discussion_r389501604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 9, 2020https://github.com/python/cpython/pull/18854#issuecomment-596376122
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Mar 9, 2020https://github.com/python/cpython/pull/18854#event-3109473553
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 9, 2020https://github.com/python/cpython/pull/18854#issuecomment-596376134
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
pitrouhttps://github.com/pitrou
March 9, 2020 07:44https://github.com/python/cpython/pull/18854#event-3109473629
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 9, 2020 https://github.com/python/cpython/pull/18854#ref-pullrequest-577484934
bpo-19466: Py_Finalize() clears daemon threads earlier #18848 https://github.com/python/cpython/pull/18848
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 9, 2020https://github.com/python/cpython/pull/18854#issuecomment-596804546
#18890https://github.com/python/cpython/pull/18890
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 9, 2020https://github.com/python/cpython/pull/18854#event-3112581013
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
March 9, 2020 22:13https://github.com/python/cpython/pull/18854#event-3112581155
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18854
https://github.com/pitrou
pitrou https://github.com/pitrou
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/18854
https://github.com/vstinner
https://github.com/bedevere-bot
https://github.com/pitrou
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.