René's URL Explorer Experiment


Title: [3.7] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) (GH-18718) by gpshead · Pull Request #18725 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) (GH-18718) by gpshead · Pull Request #18725 · python/cpython

X Title: [3.7] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) (GH-18718) by gpshead · Pull Request #18725 · python/cpython

Description: Fix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the generated pyc file for submodules beneath the root of the directory tree being compiled. This fixes a regression introduced with Python 3.5. Tests backported from GH 0267335, the implementation is different due to intervening code changes. But still quiet simple. Why was the bug ever introduced? The refactoring to add parallel execution kept the ddir -> dfile computations but discarded the results instead of sending them to compile_file(). This fixes that. Lack of tests meant this went unnoticed.. (cherry picked from commit ce720d3) Co-authored-by: Gregory P. Smith greg@krypto.org https://bugs.python.org/issue39769 Automerge-Triggered-By: @gpshead

Open Graph Description: Fix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the gener...

X Description: Fix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the g...

Opengraph URL: https://github.com/python/cpython/pull/18725

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8b4e3202-71f2-fe64-ea7e-3b68c32b39ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA826:2786B7:2729C8:345CDD:6969CC45
html-safe-nonce711a5b02ae041556a91b88582ad8989b53dd22fec2ede09547fbfc2c98b14a10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODI2OjI3ODZCNzoyNzI5Qzg6MzQ1Q0REOjY5NjlDQzQ1IiwidmlzaXRvcl9pZCI6IjU4Njk3NDY5MzI2Mzk0NTIyMjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb930909d72f63f2bb4c569b2cab4e0db343f3e243061673717d50684e747f70e
hovercard-subject-tagpull_request:382079502
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/18725/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altFix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the gener...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18725/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18725%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18725%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18725/files
Reloadhttps://github.com/python/cpython/pull/18725/files
Reloadhttps://github.com/python/cpython/pull/18725/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18725/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/18725/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:3.7https://github.com/python/cpython/tree/3.7
gpshead:backport-ce720d3-3.7https://github.com/gpshead/cpython/tree/backport-ce720d3-3.7
Conversation 0 https://github.com/python/cpython/pull/18725
Commits 1 https://github.com/python/cpython/pull/18725/commits
Checks 0 https://github.com/python/cpython/pull/18725/checks
Files changed https://github.com/python/cpython/pull/18725/files
Please reload this pagehttps://github.com/python/cpython/pull/18725/files
[3.7] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) (GH-18718) https://github.com/python/cpython/pull/18725/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/18725/files
8c205a6 [3.7] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) (GH-18718) gpshead Mar 1, 2020 https://github.com/python/cpython/pull/18725/commits/8c205a684a3a525ed0f9e0068c00786c6f1d84ca
Clear filters https://github.com/python/cpython/pull/18725/files
Please reload this pagehttps://github.com/python/cpython/pull/18725/files
Please reload this pagehttps://github.com/python/cpython/pull/18725/files
compileall.py https://github.com/python/cpython/pull/18725/files#diff-7f83ae2963b722cbb1e930575d550798f87d957d4223d4628652edbde508ebe3
test_compileall.py https://github.com/python/cpython/pull/18725/files#diff-c46628248d6fef53e3b17bf2150d2e17e82da74725236cfdcd6de094f9f09737
util.py https://github.com/python/cpython/pull/18725/files#diff-cf049d6640b726c9ac283091e9c41e52434c770bcd2efb92eb64bdd6e2816d5a
2020-02-29-13-20-33.bpo-39769.hJmxu4.rst https://github.com/python/cpython/pull/18725/files#diff-3feddef0d96468303df72889583e9e75abc38795ddf66ca2c4cfb9bafa8290c3
Lib/compileall.pyhttps://github.com/python/cpython/pull/18725/files#diff-7f83ae2963b722cbb1e930575d550798f87d957d4223d4628652edbde508ebe3
View file https://github.com/gpshead/cpython/blob/8c205a684a3a525ed0f9e0068c00786c6f1d84ca/Lib/compileall.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18725/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18725/files#diff-7f83ae2963b722cbb1e930575d550798f87d957d4223d4628652edbde508ebe3
https://github.com/python/cpython/pull/18725/files#diff-7f83ae2963b722cbb1e930575d550798f87d957d4223d4628652edbde508ebe3
https://github.com/python/cpython/pull/18725/files#diff-7f83ae2963b722cbb1e930575d550798f87d957d4223d4628652edbde508ebe3
https://github.com/python/cpython/pull/18725/files#diff-7f83ae2963b722cbb1e930575d550798f87d957d4223d4628652edbde508ebe3
Lib/test/test_compileall.pyhttps://github.com/python/cpython/pull/18725/files#diff-c46628248d6fef53e3b17bf2150d2e17e82da74725236cfdcd6de094f9f09737
View file https://github.com/gpshead/cpython/blob/8c205a684a3a525ed0f9e0068c00786c6f1d84ca/Lib/test/test_compileall.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18725/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18725/files#diff-c46628248d6fef53e3b17bf2150d2e17e82da74725236cfdcd6de094f9f09737
https://github.com/python/cpython/pull/18725/files#diff-c46628248d6fef53e3b17bf2150d2e17e82da74725236cfdcd6de094f9f09737
Lib/test/test_importlib/util.pyhttps://github.com/python/cpython/pull/18725/files#diff-cf049d6640b726c9ac283091e9c41e52434c770bcd2efb92eb64bdd6e2816d5a
View file https://github.com/gpshead/cpython/blob/8c205a684a3a525ed0f9e0068c00786c6f1d84ca/Lib/test/test_importlib/util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18725/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18725/files#diff-cf049d6640b726c9ac283091e9c41e52434c770bcd2efb92eb64bdd6e2816d5a
https://github.com/python/cpython/pull/18725/files#diff-cf049d6640b726c9ac283091e9c41e52434c770bcd2efb92eb64bdd6e2816d5a
https://github.com/python/cpython/pull/18725/files#diff-cf049d6640b726c9ac283091e9c41e52434c770bcd2efb92eb64bdd6e2816d5a
https://github.com/python/cpython/pull/18725/files#diff-cf049d6640b726c9ac283091e9c41e52434c770bcd2efb92eb64bdd6e2816d5a
Misc/NEWS.d/next/Library/2020-02-29-13-20-33.bpo-39769.hJmxu4.rsthttps://github.com/python/cpython/pull/18725/files#diff-3feddef0d96468303df72889583e9e75abc38795ddf66ca2c4cfb9bafa8290c3
View file https://github.com/gpshead/cpython/blob/8c205a684a3a525ed0f9e0068c00786c6f1d84ca/Misc/NEWS.d/next/Library/2020-02-29-13-20-33.bpo-39769.hJmxu4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18725/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.