René's URL Explorer Experiment


Title: [3.8] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) by gpshead · Pull Request #18718 · python/cpython · GitHub

Open Graph Title: [3.8] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) by gpshead · Pull Request #18718 · python/cpython

X Title: [3.8] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) by gpshead · Pull Request #18718 · python/cpython

Description: Fix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the generated...

Open Graph Description: Fix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the gener...

X Description: Fix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the g...

Opengraph URL: https://github.com/python/cpython/pull/18718

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3e3e2606-daa0-11ce-efda-f72a317b51fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8470:26B7B1:551106:74560F:6969E084
html-safe-noncecce66504518d514776b3cc1ff30da94a940bf38a6c73d375601617e71248234e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDcwOjI2QjdCMTo1NTExMDY6NzQ1NjBGOjY5NjlFMDg0IiwidmlzaXRvcl9pZCI6IjM3NjU3Nzk1NTgyNzUwODAzMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac89b9bedcf3bcb06fae4a35a73d1ed8c01bd1dd54e8bf9a406d13fc4f5c96a39d
hovercard-subject-tagpull_request:381949404
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18718/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f6b25bfb260dd5d629dae69765deb9f44f5410c10a4670654013b28a58bb75cd/python/cpython/pull/18718
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6b25bfb260dd5d629dae69765deb9f44f5410c10a4670654013b28a58bb75cd/python/cpython/pull/18718
og:image:altFix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag -d to no longer write the wrong pathname to the gener...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18718#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18718
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18718
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18718
Reloadhttps://github.com/python/cpython/pull/18718
Reloadhttps://github.com/python/cpython/pull/18718
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18718
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/18718
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/18718#issue-comment-box
gpsheadhttps://github.com/gpshead
python:3.8https://github.com/python/cpython/tree/3.8
gpshead:compall_ddir_3.8https://github.com/gpshead/cpython/tree/compall_ddir_3.8
[3.8] bpo-39769: Fix compileall ddir for subpkgs. (GH-18676) https://github.com/python/cpython/pull/18718#top
gpsheadhttps://github.com/gpshead
python:3.8https://github.com/python/cpython/tree/3.8
gpshead:compall_ddir_3.8https://github.com/gpshead/cpython/tree/compall_ddir_3.8
Conversation 4 https://github.com/python/cpython/pull/18718
Commits 1 https://github.com/python/cpython/pull/18718/commits
Checks 0 https://github.com/python/cpython/pull/18718/checks
Files changed https://github.com/python/cpython/pull/18718/files
Please reload this pagehttps://github.com/python/cpython/pull/18718
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 29, 2020https://github.com/python/cpython/pull/18718#issue-573418747
Please reload this pagehttps://github.com/python/cpython/pull/18718
#18676https://github.com/python/cpython/pull/18676
0267335https://github.com/python/cpython/commit/02673352b5db6ca4d3dc804965facbedfe66425d
https://bugs.python.org/issue39769https://bugs.python.org/issue39769
Please reload this pagehttps://github.com/python/cpython/pull/18718
https://github.com/gpshead
bpo-39769: Fix compileall ddir for subpkgs. (https://github.com/python/cpython/pull/18718/commits/a9297547e0e598ed4be4b7e08d5beff992496def
pythonGH-18676https://github.com/python/cpython/pull/18676
)https://github.com/python/cpython/pull/18718/commits/a9297547e0e598ed4be4b7e08d5beff992496def
a929754https://github.com/python/cpython/pull/18718/commits/a9297547e0e598ed4be4b7e08d5beff992496def
0267335https://github.com/gpshead/cpython/commit/02673352b5db6ca4d3dc804965facbedfe66425d
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Feb 29, 2020https://github.com/python/cpython/pull/18718#event-3085085266
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Feb 29, 2020https://github.com/python/cpython/pull/18718#event-3085085308
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 29, 2020https://github.com/python/cpython/pull/18718#event-3085085340
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 29, 2020https://github.com/python/cpython/pull/18718#event-3085086185
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 29, 2020https://github.com/python/cpython/pull/18718#event-3085086617
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Feb 29, 2020https://github.com/python/cpython/pull/18718#issuecomment-593001035
Please reload this pagehttps://github.com/python/cpython/pull/18718
Codecovhttps://codecov.io/gh/python/cpython/pull/18718?src=pr&el=h1
#18718https://codecov.io/gh/python/cpython/pull/18718?src=pr&el=desc
3.8https://codecov.io/gh/python/cpython/commit/45c4112b7250cb600aa2f3a42b4e6b5bfd2919c4&el=desc
https://codecov.io/gh/python/cpython/pull/18718?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/python/cpython/pull/18718?src=pr&el=tree
Lib/distutils/tests/test_bdist_rpm.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TGliL2Rpc3R1dGlscy90ZXN0cy90ZXN0X2JkaXN0X3JwbS5weQ==
Lib/distutils/command/bdist_rpm.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TGliL2Rpc3R1dGlscy9jb21tYW5kL2JkaXN0X3JwbS5weQ==
Modules/_decimal/libmpdec/umodarith.hhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TW9kdWxlcy9fZGVjaW1hbC9saWJtcGRlYy91bW9kYXJpdGguaA==
Lib/test/test_urllib2net.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF91cmxsaWIybmV0LnB5
Lib/test/test_smtpnet.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9zbXRwbmV0LnB5
Lib/ftplib.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TGliL2Z0cGxpYi5weQ==
Lib/test/test_ftplib.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9mdHBsaWIucHk=
Tools/scripts/db2pickle.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-VG9vbHMvc2NyaXB0cy9kYjJwaWNrbGUucHk=
Lib/test/test_socket.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9zb2NrZXQucHk=
Tools/scripts/pickle2db.pyhttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree#diff-VG9vbHMvc2NyaXB0cy9waWNrbGUyZGIucHk=
335 morehttps://codecov.io/gh/python/cpython/pull/18718/diff?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/python/cpython/pull/18718?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/python/cpython/pull/18718?src=pr&el=footer
45c4112...a929754https://codecov.io/gh/python/cpython/pull/18718?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/python/cpython/pull/18718
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
ce720d3https://github.com/python/cpython/commit/ce720d3e0674d6ac6f1b950c20a89be4cfde7853
Mar 1, 2020https://github.com/python/cpython/pull/18718#event-3085781102
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 1, 2020https://github.com/python/cpython/pull/18718#issuecomment-593130161
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/18718
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 1, 2020https://github.com/python/cpython/pull/18718#event-3085781130
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 1, 2020https://github.com/python/cpython/pull/18718#issuecomment-593130203
@gpsheadhttps://github.com/gpshead
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/18718
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
gpsheadhttps://github.com/gpshead
Mar 1, 2020https://github.com/python/cpython/pull/18718#event-3085781417
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
March 1, 2020 18:43https://github.com/python/cpython/pull/18718#event-3085781494
gpsheadhttps://github.com/gpshead
Mar 1, 2020 https://github.com/python/cpython/pull/18718#ref-commit-8c205a6
https://github.com/gpshead
[3.7] bpo-39769: Fix compileall ddir for subpkgs. (https://github.com/gpshead/cpython/commit/8c205a684a3a525ed0f9e0068c00786c6f1d84ca
pythonGH-18676https://github.com/python/cpython/pull/18676
) (https://github.com/gpshead/cpython/commit/8c205a684a3a525ed0f9e0068c00786c6f1d84ca
p…https://github.com/python/cpython/pull/18718
8c205a6https://github.com/gpshead/cpython/commit/8c205a684a3a525ed0f9e0068c00786c6f1d84ca
…ythonGH-18718https://github.com/python/cpython/pull/18718
0267335https://github.com/gpshead/cpython/commit/02673352b5db6ca4d3dc804965facbedfe66425d
ce720d3https://github.com/gpshead/cpython/commit/ce720d3e0674d6ac6f1b950c20a89be4cfde7853
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Mar 1, 2020https://github.com/python/cpython/pull/18718#event-3085783907
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 1, 2020https://github.com/python/cpython/pull/18718#issuecomment-593130541
GH-18725https://github.com/python/cpython/pull/18725
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/18718
gpsheadhttps://github.com/gpshead
Mar 1, 2020 https://github.com/python/cpython/pull/18718#ref-commit-7c64726
https://github.com/gpshead
[3.7]https://github.com/python/cpython/commit/7c64726ced3d6b5d04537386d6a9ca6d179c3be4
bpo-39769https://bugs.python.org/issue?@action=redirect&bpo=39769
: Fix compileall ddir for subpkgs. (https://github.com/python/cpython/commit/7c64726ced3d6b5d04537386d6a9ca6d179c3be4
GH-18676https://github.com/python/cpython/pull/18676
) (https://github.com/python/cpython/commit/7c64726ced3d6b5d04537386d6a9ca6d179c3be4
GH-18718https://github.com/python/cpython/pull/18718
)…https://github.com/python/cpython/commit/7c64726ced3d6b5d04537386d6a9ca6d179c3be4
7c64726https://github.com/python/cpython/commit/7c64726ced3d6b5d04537386d6a9ca6d179c3be4
GH-18725https://github.com/python/cpython/pull/18725
0267335https://github.com/python/cpython/commit/02673352b5db6ca4d3dc804965facbedfe66425d
ce720d3https://github.com/python/cpython/commit/ce720d3e0674d6ac6f1b950c20a89be4cfde7853
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18718
https://github.com/gpshead
gpshead https://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/18718
https://github.com/gpshead
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.