| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:20607918-fbca-c7f8-d983-051ca1287545 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E118:26204A:17AC4BB:1FBDDE8:6969BD62 |
| html-safe-nonce | 8331399b36fa8058e2f7dcfaff4ade7101d606ae1dfe1806c2625ebdc661e758 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTE4OjI2MjA0QToxN0FDNEJCOjFGQkRERTg6Njk2OUJENjIiLCJ2aXNpdG9yX2lkIjoiNjkwNDYyMTc2MzYyNjkwOTAyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a15dc1235756438cc7a2ad7bafe742d8e5468ec93cb7002127de0888b8656614 |
| hovercard-subject-tag | pull_request:371231299 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18358/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a7301773ca4e366e814c8e6291f6755e2f648ad95bde8e10c7031885c04f9a11/python/cpython/pull/18358 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a7301773ca4e366e814c8e6291f6755e2f648ad95bde8e10c7031885c04f9a11/python/cpython/pull/18358 |
| og:image:alt | https://bugs.python.org/issue1635741 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shihai1991 |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/18358#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18358 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18358 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/18358 |
| Reload | https://github.com/python/cpython/pull/18358 |
| Reload | https://github.com/python/cpython/pull/18358 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/18358#issue-comment-box |
| vstinner | https://github.com/vstinner |
| python:master | https://github.com/python/cpython/tree/master |
| shihai1991:bpo_1635741_9 | https://github.com/shihai1991/cpython/tree/bpo_1635741_9 |
|
bpo-1635741: Port _locale extension module to multiphase initialization (PEP 489)
| https://github.com/python/cpython/pull/18358#top |
| vstinner | https://github.com/vstinner |
| python:master | https://github.com/python/cpython/tree/master |
| shihai1991:bpo_1635741_9 | https://github.com/shihai1991/cpython/tree/bpo_1635741_9 |
|
Conversation
26
| https://github.com/python/cpython/pull/18358 |
|
Commits
7
| https://github.com/python/cpython/pull/18358/commits |
|
Checks
0
| https://github.com/python/cpython/pull/18358/checks |
|
Files changed
| https://github.com/python/cpython/pull/18358/files |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 5, 2020 | https://github.com/python/cpython/pull/18358#issue-560199767 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://bugs.python.org/issue1635741 | https://bugs.python.org/issue1635741 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
|
| https://github.com/shihai1991 |
| Port _locale extension module to multiphase initialization (PEP 489) | https://github.com/python/cpython/pull/18358/commits/4ce0c7c825b3ab010e46ad4b863f7a82b3e2ce34 |
| 4ce0c7c | https://github.com/python/cpython/pull/18358/commits/4ce0c7c825b3ab010e46ad4b863f7a82b3e2ce34 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Feb 5, 2020 | https://github.com/python/cpython/pull/18358#event-3008956594 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 5, 2020 | https://github.com/python/cpython/pull/18358#event-3008956718 |
|
| https://github.com/apps/blurb-it |
| 📜🤖 Added by blurb_it. | https://github.com/python/cpython/pull/18358/commits/c0e0174f5e8bc0733ea37eb5424cb56e5f255592 |
| c0e0174 | https://github.com/python/cpython/pull/18358/commits/c0e0174f5e8bc0733ea37eb5424cb56e5f255592 |
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| encukou | https://github.com/encukou |
| ncoghlan | https://github.com/ncoghlan |
| February 5, 2020 07:57 | https://github.com/python/cpython/pull/18358#event-3008964417 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Feb 5, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-582295830 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| Codecov | https://codecov.io/gh/python/cpython/pull/18358?src=pr&el=h1 |
| #18358 | https://codecov.io/gh/python/cpython/pull/18358?src=pr&el=desc |
| master | https://codecov.io/gh/python/cpython/commit/850a4bd839ca11b59439e21dda2a3ebe917a9a16&el=desc |
| https://codecov.io/gh/python/cpython/pull/18358?src=pr&el=tree |
| Impacted Files | https://codecov.io/gh/python/cpython/pull/18358?src=pr&el=tree |
| Lib/distutils/tests/test_bdist_rpm.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TGliL2Rpc3R1dGlscy90ZXN0cy90ZXN0X2JkaXN0X3JwbS5weQ== |
| Lib/distutils/command/bdist_rpm.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TGliL2Rpc3R1dGlscy9jb21tYW5kL2JkaXN0X3JwbS5weQ== |
| Modules/_decimal/libmpdec/umodarith.h | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TW9kdWxlcy9fZGVjaW1hbC9saWJtcGRlYy91bW9kYXJpdGguaA== |
| Lib/test/test_urllib2net.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF91cmxsaWIybmV0LnB5 |
| Lib/test/test_smtpnet.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9zbXRwbmV0LnB5 |
| Lib/ftplib.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TGliL2Z0cGxpYi5weQ== |
| Lib/test/test_ftplib.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9mdHBsaWIucHk= |
| Tools/scripts/db2pickle.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-VG9vbHMvc2NyaXB0cy9kYjJwaWNrbGUucHk= |
| Tools/scripts/pickle2db.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-VG9vbHMvc2NyaXB0cy9waWNrbGUyZGIucHk= |
| Lib/test/test_socket.py | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9zb2NrZXQucHk= |
| 399 more | https://codecov.io/gh/python/cpython/pull/18358/diff?src=pr&el=tree-more |
| Continue to review full report at Codecov | https://codecov.io/gh/python/cpython/pull/18358?src=pr&el=continue |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta |
| Codecov | https://codecov.io/gh/python/cpython/pull/18358?src=pr&el=footer |
| 850a4bd...f3a1d08 | https://codecov.io/gh/python/cpython/pull/18358?src=pr&el=lastupdated |
| comment docs | https://docs.codecov.io/docs/pull-request-comments |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| vstinner | https://github.com/vstinner |
| February 17, 2020 12:32 | https://github.com/python/cpython/pull/18358#event-3043539667 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Feb 17, 2020
| https://github.com/python/cpython/pull/18358#pullrequestreview-359745622 |
|
View reviewed changes
| https://github.com/python/cpython/pull/18358/files/c0e0174f5e8bc0733ea37eb5424cb56e5f255592 |
| Modules/_localemodule.c | https://github.com/python/cpython/pull/18358/files/c0e0174f5e8bc0733ea37eb5424cb56e5f255592#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0 |
| vstinner | https://github.com/vstinner |
| Feb 17, 2020 | https://github.com/python/cpython/pull/18358#discussion_r380191031 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 17, 2020 | https://github.com/python/cpython/pull/18358#discussion_r380240648 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/python/cpython/blob/master/Modules/_hashopenssl.c#L55 | https://github.com/python/cpython/blob/master/Modules/_hashopenssl.c#L55 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| encukou | https://github.com/encukou |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#discussion_r380611658 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#discussion_r380737853 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| shihai1991 | https://github.com/shihai1991 |
| February 17, 2020 23:05 | https://github.com/python/cpython/pull/18358#commits-pushed-3aaf488 |
|
| https://github.com/shihai1991 |
| add get_locale_state() | https://github.com/python/cpython/pull/18358/commits/3aaf4881148600747055e06d9c268f9bb2e740d9 |
| 3aaf488 | https://github.com/python/cpython/pull/18358/commits/3aaf4881148600747055e06d9c268f9bb2e740d9 |
|
| https://github.com/shihai1991 |
| Merge branch 'bpo_1635741_9' of | https://github.com/python/cpython/pull/18358/commits/8e0e2bfc767aee6012aace095b3676356e6fbf00 |
| https://github.com/shihai1991/cpython | https://github.com/shihai1991/cpython |
| … | https://github.com/python/cpython/pull/18358/commits/8e0e2bfc767aee6012aace095b3676356e6fbf00 |
| 8e0e2bf | https://github.com/python/cpython/pull/18358/commits/8e0e2bfc767aee6012aace095b3676356e6fbf00 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Feb 17, 2020
| https://github.com/python/cpython/pull/18358#pullrequestreview-359845783 |
|
View reviewed changes
| https://github.com/python/cpython/pull/18358/files/8e0e2bfc767aee6012aace095b3676356e6fbf00 |
| Modules/_localemodule.c | https://github.com/python/cpython/pull/18358/files/8e0e2bfc767aee6012aace095b3676356e6fbf00#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Feb 17, 2020
| https://github.com/python/cpython/pull/18358#pullrequestreview-359846490 |
|
View reviewed changes
| https://github.com/python/cpython/pull/18358/files/8e0e2bfc767aee6012aace095b3676356e6fbf00 |
| Modules/_localemodule.c | https://github.com/python/cpython/pull/18358/files/8e0e2bfc767aee6012aace095b3676356e6fbf00#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
|
| https://github.com/shihai1991 |
| fix format bug | https://github.com/python/cpython/pull/18358/commits/2a4ac1b0b56eec2f1050499c876491e4cabefd1c |
| 2a4ac1b | https://github.com/python/cpython/pull/18358/commits/2a4ac1b0b56eec2f1050499c876491e4cabefd1c |
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-587215177 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Feb 18, 2020
| https://github.com/python/cpython/pull/18358#pullrequestreview-360267953 |
|
View reviewed changes
| https://github.com/python/cpython/pull/18358/files/2a4ac1b0b56eec2f1050499c876491e4cabefd1c |
| Modules/_localemodule.c | https://github.com/python/cpython/pull/18358/files/2a4ac1b0b56eec2f1050499c876491e4cabefd1c#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#event-3046782505 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-587418708 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#event-3046782522 |
|
| https://github.com/shihai1991 |
| locale extension module add clean slots | https://github.com/python/cpython/pull/18358/commits/70fddf4c8eab7b0418573e270accfa5de25c97eb |
| 70fddf4 | https://github.com/python/cpython/pull/18358/commits/70fddf4c8eab7b0418573e270accfa5de25c97eb |
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-587509562 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-587523063 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#event-3047661003 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Feb 18, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-587523099 |
| @encukou | https://github.com/encukou |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| encukou | https://github.com/encukou |
| February 18, 2020 15:38 | https://github.com/python/cpython/pull/18358#event-3047661220 |
|
| https://github.com/encukou |
| Add back assertion in get_locale_state | https://github.com/python/cpython/pull/18358/commits/f3a1d08ac4192d83b35391bb11127132dc8ea1d7 |
| f3a1d08 | https://github.com/python/cpython/pull/18358/commits/f3a1d08ac4192d83b35391bb11127132dc8ea1d7 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Feb 25, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-590914976 |
| traverse/clear/free | https://docs.python.org/3/c-api/module.html#c.PyModuleDef.m_traverse |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 25, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-590917421 |
| traverse/clear/free | https://docs.python.org/3/c-api/module.html#c.PyModuleDef.m_traverse |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/shihai1991 |
| shihai1991 | https://github.com/shihai1991 |
| Feb 25, 2020 | https://github.com/python/cpython/pull/18358#issuecomment-590920175 |
| traverse/clear/free | https://docs.python.org/3/c-api/module.html#c.PyModuleDef.m_traverse |
| #18608 | https://github.com/python/cpython/pull/18608 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Feb 25, 2020
| https://github.com/python/cpython/pull/18358#pullrequestreview-364271229 |
|
View reviewed changes
| https://github.com/python/cpython/pull/18358/files/f3a1d08ac4192d83b35391bb11127132dc8ea1d7 |
| encukou | https://github.com/encukou |
| https://github.com/python/cpython/pull/18358#pullrequestreview-364271229 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
| Feb 25, 2020 | https://github.com/python/cpython/pull/18358#event-3070111209 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Feb 29, 2020
| https://github.com/python/cpython/pull/18358#pullrequestreview-366825943 |
|
View reviewed changes
| https://github.com/python/cpython/pull/18358/files/f3a1d08ac4192d83b35391bb11127132dc8ea1d7 |
| Modules/_localemodule.c | https://github.com/python/cpython/pull/18358/files/f3a1d08ac4192d83b35391bb11127132dc8ea1d7#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0 |
| vstinner | https://github.com/vstinner |
| Feb 29, 2020 | https://github.com/python/cpython/pull/18358#discussion_r386063679 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| shihai1991 | https://github.com/shihai1991 |
| Mar 1, 2020 | https://github.com/python/cpython/pull/18358#discussion_r386066991 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://docs.python.org/3/c-api/module.html?highlight=pymoduledef#c.PyModuleDef | https://docs.python.org/3/c-api/module.html?highlight=pymoduledef#c.PyModuleDef |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| vstinner | https://github.com/vstinner |
| Mar 2, 2020 | https://github.com/python/cpython/pull/18358#discussion_r386329463 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://bugs.python.org/issue39824 | https://bugs.python.org/issue39824 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| encukou | https://github.com/encukou |
| Mar 11, 2020 | https://github.com/python/cpython/pull/18358#discussion_r391030425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| bpo-39824 | https://bugs.python.org/issue?@action=redirect&bpo=39824 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| vstinner | https://github.com/vstinner |
| Mar 11, 2020 | https://github.com/python/cpython/pull/18358#discussion_r391113214 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://bugs.python.org/issue39824 | https://bugs.python.org/issue39824 |
| @shihai1991 | https://github.com/shihai1991 |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| a158168 | https://github.com/python/cpython/commit/a158168a787e82c4b7b18f6833153188e93627a5 |
| Mar 11, 2020 | https://github.com/python/cpython/pull/18358#event-3119653819 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Mar 11, 2020 | https://github.com/python/cpython/pull/18358#event-3119653989 |
| https://github.com/python/cpython/pull/18358 |
| kylotan | https://github.com/python/cpython/pull/18358 |
|
Sep 19, 2022
| https://github.com/python/cpython/pull/18358#ref-issue-1198820210 |
|
Py_Finalize() doesn't clear all Python objects at exit
#44470
| https://github.com/python/cpython/issues/44470 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18358 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/18358/files/f3a1d08ac4192d83b35391bb11127132dc8ea1d7 |
|
| https://github.com/encukou |
|
encukou
| https://github.com/encukou |
|
| https://github.com/python/cpython/pull/18358/files/f3a1d08ac4192d83b35391bb11127132dc8ea1d7 |
|
| https://github.com/ncoghlan |
|
ncoghlan
| https://github.com/ncoghlan |
| Please reload this page | https://github.com/python/cpython/pull/18358 |
|
| https://github.com/shihai1991 |
|
| https://github.com/bedevere-bot |
|
| https://github.com/encukou |
|
| https://github.com/vstinner |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |