René's URL Explorer Experiment


Title: bpo-39485: fix corner-case in method-detection of mock by cfbolz · Pull Request #18252 · python/cpython · GitHub

Open Graph Title: bpo-39485: fix corner-case in method-detection of mock by cfbolz · Pull Request #18252 · python/cpython

X Title: bpo-39485: fix corner-case in method-detection of mock by cfbolz · Pull Request #18252 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: As described in the issue, replace check for whether something is a method in the mock module. The previous version fails on PyPy, because there no method wrappers exist (everything looks like a re...

X Description: As described in the issue, replace check for whether something is a method in the mock module. The previous version fails on PyPy, because there no method wrappers exist (everything looks like a re...

Opengraph URL: https://github.com/python/cpython/pull/18252

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ada57075-1684-1cb8-787d-603524f8df98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF64:179C7:34BC85:47AC42:6A568F28
html-safe-nonce65447ed24c96eec649c9245c3b11f4fa30d9b1a5e218863eb4ee7a811f94dc43
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjY0OjE3OUM3OjM0QkM4NTo0N0FDNDI6NkE1NjhGMjgiLCJ2aXNpdG9yX2lkIjoiNTQ0MzU2MDYxMzUyMjg3MDA1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac047490f99cd7d258c36908eebddb3da512d7fa212b2f2ebe36a5a0e655304d89
hovercard-subject-tagpull_request:368576739
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18252/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/07132c3550f236e687a32ddeafb79704e4c8c5178fdb0adbcf1dc59221bf32d9/python/cpython/pull/18252
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/07132c3550f236e687a32ddeafb79704e4c8c5178fdb0adbcf1dc59221bf32d9/python/cpython/pull/18252
og:image:altAs described in the issue, replace check for whether something is a method in the mock module. The previous version fails on PyPy, because there no method wrappers exist (everything looks like a re...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecfbolz
hostnamegithub.com
expected-hostnamegithub.com
None8f21be8503ba8fe6154df415b855c03af52eae3f285bd6ae1fef041dc053da38
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release78af172a48a2056810bb627ffa684003e4f9a5ca
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18252#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18252
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18252
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18252
Reloadhttps://github.com/python/cpython/pull/18252
Reloadhttps://github.com/python/cpython/pull/18252
Please reload this pagehttps://github.com/python/cpython/pull/18252
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18252
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
cjw296https://github.com/cjw296
python:masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/18252
Commits1 (1)https://github.com/python/cpython/pull/18252/commits
Checkshttps://github.com/python/cpython/pull/18252/checks
Files changedhttps://github.com/python/cpython/pull/18252/files
bpo-39485: fix corner-case in method-detection of mockhttps://github.com/python/cpython/pull/18252#top
cjw296https://github.com/cjw296
python:masterhttps://github.com/python/cpython/tree/master
https://github.com/cfbolz
cfbolzhttps://github.com/cfbolz
Jan 29, 2020https://github.com/python/cpython/pull/18252#issue-556886195
Please reload this pagehttps://github.com/python/cpython/pull/18252
@cjw296https://github.com/cjw296
https://bugs.python.org/issue39485https://bugs.python.org/issue39485
Please reload this pagehttps://github.com/python/cpython/pull/18252
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2989640855
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2989640978
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 29, 2020https://github.com/python/cpython/pull/18252#issuecomment-579776645
@tirkarthihttps://github.com/tirkarthi
@mariocj89https://github.com/mariocj89
Please reload this pagehttps://github.com/python/cpython/pull/18252
https://github.com/cfbolz
cfbolzhttps://github.com/cfbolz
Jan 29, 2020https://github.com/python/cpython/pull/18252#issuecomment-579778316
Please reload this pagehttps://github.com/python/cpython/pull/18252
https://github.com/cfbolz
bpo-39485https://bugs.python.org/issue?@action=redirect&bpo=39485
: fix corner-case in method-detection of mockhttps://github.com/python/cpython/pull/18252/commits/321f848cbb84153e3ef548b08868216488e0e417
321f848https://github.com/python/cpython/pull/18252/commits/321f848cbb84153e3ef548b08868216488e0e417
https://github.com/cfbolz
cfbolzhttps://github.com/cfbolz
Jan 29, 2020https://github.com/python/cpython/pull/18252#issuecomment-579779993
Please reload this pagehttps://github.com/python/cpython/pull/18252
https://github.com/cjw296
cjw296https://github.com/cjw296
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2989993356
https://github.com/cjw296
cjw296https://github.com/cjw296
January 29, 2020 15:37https://github.com/python/cpython/pull/18252#event-2989993868
https://github.com/cjw296
cjw296https://github.com/cjw296
Jan 29, 2020 https://github.com/python/cpython/pull/18252#pullrequestreview-350206648
View reviewed changes https://github.com/python/cpython/pull/18252/files/321f848cbb84153e3ef548b08868216488e0e417
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2990010278
https://github.com/cjw296
cjw296https://github.com/cjw296
a327677https://github.com/python/cpython/commit/a327677905956ae0b239ff430a1346dfe265709e
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2990018857
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2990019017
https://github.com/cjw296
cjw296https://github.com/cjw296
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2990020799
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jan 29, 2020https://github.com/python/cpython/pull/18252#issuecomment-579819181
@cfbolzhttps://github.com/cfbolz
@cjw296https://github.com/cjw296
Please reload this pagehttps://github.com/python/cpython/pull/18252
miss-islingtonhttps://github.com/miss-islington
Jan 29, 2020 https://github.com/python/cpython/pull/18252#ref-commit-c54872b
https://github.com/cfbolz
https://github.com/miss-islington
bpo-39485: fix corner-case in method-detection of mock (https://github.com/miss-islington/cpython/commit/c54872be3446f3792877439cdf01da5d9ffe18e4
pythonGH-18252https://github.com/python/cpython/pull/18252
)https://github.com/miss-islington/cpython/commit/c54872be3446f3792877439cdf01da5d9ffe18e4
c54872bhttps://github.com/miss-islington/cpython/commit/c54872be3446f3792877439cdf01da5d9ffe18e4
a327677https://github.com/miss-islington/cpython/commit/a327677905956ae0b239ff430a1346dfe265709e
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2990021673
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 29, 2020https://github.com/python/cpython/pull/18252#issuecomment-579819259
GH-18255https://github.com/python/cpython/pull/18255
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/18252
https://github.com/cjw296
cjw296https://github.com/cjw296
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2990022016
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jan 29, 2020https://github.com/python/cpython/pull/18252#issuecomment-579819325
@cfbolzhttps://github.com/cfbolz
@cjw296https://github.com/cjw296
Please reload this pagehttps://github.com/python/cpython/pull/18252
miss-islingtonhttps://github.com/miss-islington
Jan 29, 2020 https://github.com/python/cpython/pull/18252#ref-commit-82ab521
https://github.com/cfbolz
https://github.com/miss-islington
bpo-39485: fix corner-case in method-detection of mock (https://github.com/miss-islington/cpython/commit/82ab5217d3b711e7c56ff0dc6ad97496185bef42
pythonGH-18252https://github.com/python/cpython/pull/18252
)https://github.com/miss-islington/cpython/commit/82ab5217d3b711e7c56ff0dc6ad97496185bef42
82ab521https://github.com/miss-islington/cpython/commit/82ab5217d3b711e7c56ff0dc6ad97496185bef42
a327677https://github.com/miss-islington/cpython/commit/a327677905956ae0b239ff430a1346dfe265709e
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Jan 29, 2020https://github.com/python/cpython/pull/18252#event-2990022743
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 29, 2020https://github.com/python/cpython/pull/18252#issuecomment-579819386
GH-18256https://github.com/python/cpython/pull/18256
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/18252
shihai1991https://github.com/shihai1991
Jan 31, 2020 https://github.com/python/cpython/pull/18252#ref-commit-c4a3e54
https://github.com/cfbolz
https://github.com/shihai1991
bpo-39485: fix corner-case in method-detection of mock (https://github.com/shihai1991/cpython/commit/c4a3e54a6426211620cbb4feb250560c4f66e455
pythonGH-18252https://github.com/python/cpython/pull/18252
)https://github.com/shihai1991/cpython/commit/c4a3e54a6426211620cbb4feb250560c4f66e455
c4a3e54https://github.com/shihai1991/cpython/commit/c4a3e54a6426211620cbb4feb250560c4f66e455
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18252
https://github.com/cjw296
cjw296 https://github.com/cjw296
https://github.com/python/cpython/pull/18252/files/321f848cbb84153e3ef548b08868216488e0e417
https://github.com/cjw296
cjw296 https://github.com/cjw296
Please reload this pagehttps://github.com/python/cpython/pull/18252
https://github.com/cfbolz
https://github.com/vstinner
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/cjw296
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.