René's URL Explorer Experiment


Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython · GitHub

Open Graph Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython

X Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython

Description: I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this should be backported to 3.8 or 3.7, however I would like to land this soon as possible so we can get mock 4.0 out and get a lot more feedback on all the AsyncMock stuff :-)

Open Graph Description: I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this should be...

X Description: I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this s...

Opengraph URL: https://github.com/python/cpython/pull/18228

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17b338df-3dce-6919-0d57-02a9bf22b39a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDAE:30934D:B85F51:FDBA35:6A55B792
html-safe-noncea08fbcb12cd264108561573004673d0d323c06a3570a1667d5b2baa3ed13b9e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREFFOjMwOTM0RDpCODVGNTE6RkRCQTM1OjZBNTVCNzkyIiwidmlzaXRvcl9pZCI6IjY0NDY3Njk0NDk1MDA3ODQ1MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac60c345eec5f5005a5be89d62d9e43ad78870685b28100b2f3ae7361a812c6e90
hovercard-subject-tagpull_request:367885583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/18228/files
twitter:imagehttps://avatars.githubusercontent.com/u/632049?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/632049?s=400&v=4
og:image:altI wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this should be...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release64b9ae238e18eb87ead1f9fe37a7cc81d67d85aa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18228/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18228%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18228%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18228/files
Reloadhttps://github.com/python/cpython/pull/18228/files
Reloadhttps://github.com/python/cpython/pull/18228/files
Please reload this pagehttps://github.com/python/cpython/pull/18228/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18228/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
cjw296https://github.com/cjw296
python:masterhttps://github.com/python/cpython/tree/master
cjw296:mock_coveragehttps://github.com/cjw296/cpython/tree/mock_coverage
Conversation 6 https://github.com/python/cpython/pull/18228
Commits 7 https://github.com/python/cpython/pull/18228/commits
Checks 0 https://github.com/python/cpython/pull/18228/checks
Files changed https://github.com/python/cpython/pull/18228/files
Please reload this pagehttps://github.com/python/cpython/pull/18228/files
Get mock coverage back to 100% https://github.com/python/cpython/pull/18228/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/18228/files
eb702b2 use the `: pass` and `: yield` patterns for code that isn't expected … cjw296 Jan 28, 2020 https://github.com/python/cpython/pull/18228/commits/eb702b20d5ccc41d0661f319dd7beb0bb28c5fca
e4f8647 These items are only ever of length two. cjw296 Jan 28, 2020 https://github.com/python/cpython/pull/18228/commits/e4f8647eddd953c79d6a0e6cba77e0a7fe79f86d
8e63139 fix typo cjw296 Jan 28, 2020 https://github.com/python/cpython/pull/18228/commits/8e6313989aad067a0335dd48deb0eee0352fcec2
cc8d3c1 Fix bug highlighted by lack of coverage of an except branch. cjw296 Jan 28, 2020 https://github.com/python/cpython/pull/18228/commits/cc8d3c10bc698269ea779b01ffd248be3ffb5466
9130b16 The fix for bpo-37972 means _Call.count and _Call.index are no longer… cjw296 Jan 28, 2020 https://github.com/python/cpython/pull/18228/commits/9130b1658256045457c912f4cdcdd159d7e4bda2
7812d7b add coverage for calling next() on a mock_open with readline.return_v… cjw296 Jan 28, 2020 https://github.com/python/cpython/pull/18228/commits/7812d7b43bcf8160bc8254d8244e46c7708cf28d
576fd3e __aiter__ is defined on the Mock so this is never called. cjw296 Jan 28, 2020 https://github.com/python/cpython/pull/18228/commits/576fd3ea7d944549b37fb57410830400eb1e2c39
Clear filters https://github.com/python/cpython/pull/18228/files
Please reload this pagehttps://github.com/python/cpython/pull/18228/files
Please reload this pagehttps://github.com/python/cpython/pull/18228/files
mock.py https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
testasync.py https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
testmock.py https://github.com/python/cpython/pull/18228/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
testpatch.py https://github.com/python/cpython/pull/18228/files#diff-dcd0b5de9d01782451a153daca6b4ac8da777f793eae0cd0a8ad7f7af56aaa80
Lib/unittest/mock.pyhttps://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
View file https://github.com/cjw296/cpython/blob/576fd3ea7d944549b37fb57410830400eb1e2c39/Lib/unittest/mock.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18228/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/18228/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
Lib/unittest/test/testmock/testasync.pyhttps://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
View file https://github.com/cjw296/cpython/blob/576fd3ea7d944549b37fb57410830400eb1e2c39/Lib/unittest/test/testmock/testasync.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18228/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/18228/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
Lib/unittest/test/testmock/testmock.pyhttps://github.com/python/cpython/pull/18228/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
View file https://github.com/cjw296/cpython/blob/576fd3ea7d944549b37fb57410830400eb1e2c39/Lib/unittest/test/testmock/testmock.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18228/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18228/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
https://github.com/python/cpython/pull/18228/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
Lib/unittest/test/testmock/testpatch.pyhttps://github.com/python/cpython/pull/18228/files#diff-dcd0b5de9d01782451a153daca6b4ac8da777f793eae0cd0a8ad7f7af56aaa80
View file https://github.com/cjw296/cpython/blob/576fd3ea7d944549b37fb57410830400eb1e2c39/Lib/unittest/test/testmock/testpatch.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/18228/{{ revealButtonHref }}
https://github.com/python/cpython/pull/18228/files#diff-dcd0b5de9d01782451a153daca6b4ac8da777f793eae0cd0a8ad7f7af56aaa80
https://github.com/python/cpython/pull/18228/files#diff-dcd0b5de9d01782451a153daca6b4ac8da777f793eae0cd0a8ad7f7af56aaa80
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.