René's URL Explorer Experiment


Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython · GitHub

Open Graph Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython

X Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this should be...

X Description: I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this s...

Opengraph URL: https://github.com/python/cpython/pull/18228

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:092b96fc-9c84-45a5-b6ba-fa67d91ea32e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB916:30DD43:15A654:1F1CFC:6A55E084
html-safe-nonce7ed7b86310a157f8fe3e424786a21083bd6cb2a9061ec77368e59c4e1cd70630
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTE2OjMwREQ0MzoxNUE2NTQ6MUYxQ0ZDOjZBNTVFMDg0IiwidmlzaXRvcl9pZCI6Ijc5MjA1MTExMDgzMDk3MDQ4MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac445428d176d79c440809f3e274d3da6f5f1b788b1d8df0d38ab31a3338acc3e1
hovercard-subject-tagpull_request:367885583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/18228/commits
twitter:imagehttps://opengraph.githubassets.com/2ae0e673c1609c08ffd50d466677d3cec1ac123816acdb3f236dc8e9c3390ac5/python/cpython/pull/18228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2ae0e673c1609c08ffd50d466677d3cec1ac123816acdb3f236dc8e9c3390ac5/python/cpython/pull/18228
og:image:altI wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this should be...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjw296
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3725c7f9b2a6e3a27ef57c5aed13428c0f65e045
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18228/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18228%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18228%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18228/commits
Reloadhttps://github.com/python/cpython/pull/18228/commits
Reloadhttps://github.com/python/cpython/pull/18228/commits
Please reload this pagehttps://github.com/python/cpython/pull/18228/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18228/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
cjw296https://github.com/cjw296
python:masterhttps://github.com/python/cpython/tree/master
cjw296:mock_coveragehttps://github.com/cjw296/cpython/tree/mock_coverage
Conversationhttps://github.com/python/cpython/pull/18228
Commits7 (7)https://github.com/python/cpython/pull/18228/commits
Checkshttps://github.com/python/cpython/pull/18228/checks
Files changedhttps://github.com/python/cpython/pull/18228/files
Get mock coverage back to 100%https://github.com/python/cpython/pull/18228/commits#top
cjw296https://github.com/cjw296
python:masterhttps://github.com/python/cpython/tree/master
cjw296:mock_coveragehttps://github.com/cjw296/cpython/tree/mock_coverage
use the `: pass` and `: yield` patterns for code that isn't expected to ever be exectuted.https://github.com/python/cpython/pull/18228/commits/eb702b20d5ccc41d0661f319dd7beb0bb28c5fca
https://github.com/cjw296
cjw296https://github.com/python/cpython/commits?author=cjw296
eb702b2https://github.com/python/cpython/pull/18228/commits/eb702b20d5ccc41d0661f319dd7beb0bb28c5fca
https://github.com/python/cpython/tree/eb702b20d5ccc41d0661f319dd7beb0bb28c5fca
These items are only ever of length two.https://github.com/python/cpython/pull/18228/commits/e4f8647eddd953c79d6a0e6cba77e0a7fe79f86d
https://github.com/cjw296
cjw296https://github.com/python/cpython/commits?author=cjw296
e4f8647https://github.com/python/cpython/pull/18228/commits/e4f8647eddd953c79d6a0e6cba77e0a7fe79f86d
https://github.com/python/cpython/tree/e4f8647eddd953c79d6a0e6cba77e0a7fe79f86d
fix typohttps://github.com/python/cpython/pull/18228/commits/8e6313989aad067a0335dd48deb0eee0352fcec2
https://github.com/cjw296
cjw296https://github.com/python/cpython/commits?author=cjw296
8e63139https://github.com/python/cpython/pull/18228/commits/8e6313989aad067a0335dd48deb0eee0352fcec2
https://github.com/python/cpython/tree/8e6313989aad067a0335dd48deb0eee0352fcec2
Fix bug highlighted by lack of coverage of an except branch.https://github.com/python/cpython/pull/18228/commits/cc8d3c10bc698269ea779b01ffd248be3ffb5466
https://github.com/cjw296
cjw296https://github.com/python/cpython/commits?author=cjw296
cc8d3c1https://github.com/python/cpython/pull/18228/commits/cc8d3c10bc698269ea779b01ffd248be3ffb5466
https://github.com/python/cpython/tree/cc8d3c10bc698269ea779b01ffd248be3ffb5466
The fix for bpo-37972 means _Call.count and _Call.index are no longer needed.https://github.com/python/cpython/pull/18228/commits/9130b1658256045457c912f4cdcdd159d7e4bda2
https://github.com/cjw296
cjw296https://github.com/python/cpython/commits?author=cjw296
9130b16https://github.com/python/cpython/pull/18228/commits/9130b1658256045457c912f4cdcdd159d7e4bda2
https://github.com/python/cpython/tree/9130b1658256045457c912f4cdcdd159d7e4bda2
add coverage for calling next() on a mock_open with readline.return_value set.https://github.com/python/cpython/pull/18228/commits/7812d7b43bcf8160bc8254d8244e46c7708cf28d
https://github.com/cjw296
cjw296https://github.com/python/cpython/commits?author=cjw296
7812d7bhttps://github.com/python/cpython/pull/18228/commits/7812d7b43bcf8160bc8254d8244e46c7708cf28d
https://github.com/python/cpython/tree/7812d7b43bcf8160bc8254d8244e46c7708cf28d
__aiter__ is defined on the Mock so this is never called.https://github.com/python/cpython/pull/18228/commits/576fd3ea7d944549b37fb57410830400eb1e2c39
https://github.com/cjw296
cjw296https://github.com/python/cpython/commits?author=cjw296
576fd3ehttps://github.com/python/cpython/pull/18228/commits/576fd3ea7d944549b37fb57410830400eb1e2c39
https://github.com/python/cpython/tree/576fd3ea7d944549b37fb57410830400eb1e2c39
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.