René's URL Explorer Experiment


Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython · GitHub

Open Graph Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython

X Title: Get mock coverage back to 100% by cjw296 · Pull Request #18228 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this should be...

X Description: I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this s...

Opengraph URL: https://github.com/python/cpython/pull/18228

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:addddcf1-3510-c6ea-d80e-02ee404138f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE32:34AE79:2B4ABC:395FAF:6A554EBF
html-safe-noncedca70ef6d2da3bdda7f45e020be5af77f0c6e1daceb4a6b29771ac3539ca7876
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTMyOjM0QUU3OToyQjRBQkM6Mzk1RkFGOjZBNTU0RUJGIiwidmlzaXRvcl9pZCI6IjQ1NDI1NDgzODk3NTQzOTIyNTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4f1494f99759d3a9938c0b0abc8023cd4552854bc5610f540a29eb8c8022b9f0
hovercard-subject-tagpull_request:367885583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18228/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2ae0e673c1609c08ffd50d466677d3cec1ac123816acdb3f236dc8e9c3390ac5/python/cpython/pull/18228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2ae0e673c1609c08ffd50d466677d3cec1ac123816acdb3f236dc8e9c3390ac5/python/cpython/pull/18228
og:image:altI wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst. I'm neutral on whether or not this should be...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjw296
hostnamegithub.com
expected-hostnamegithub.com
Nonecd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18228#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18228
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18228
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18228
Reloadhttps://github.com/python/cpython/pull/18228
Reloadhttps://github.com/python/cpython/pull/18228
Please reload this pagehttps://github.com/python/cpython/pull/18228
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18228
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
cjw296https://github.com/cjw296
python:masterhttps://github.com/python/cpython/tree/master
cjw296:mock_coveragehttps://github.com/cjw296/cpython/tree/mock_coverage
Conversationhttps://github.com/python/cpython/pull/18228
Commits7 (7)https://github.com/python/cpython/pull/18228/commits
Checkshttps://github.com/python/cpython/pull/18228/checks
Files changedhttps://github.com/python/cpython/pull/18228/files
Get mock coverage back to 100%https://github.com/python/cpython/pull/18228#top
cjw296https://github.com/cjw296
python:masterhttps://github.com/python/cpython/tree/master
cjw296:mock_coveragehttps://github.com/cjw296/cpython/tree/mock_coverage
https://github.com/cjw296
cjw296https://github.com/cjw296
Jan 28, 2020https://github.com/python/cpython/pull/18228#issue-556055239
Please reload this pagehttps://github.com/python/cpython/pull/18228
https://github.com/cjw296
use the : pass and : yield patterns for code that isn't expected …https://github.com/python/cpython/pull/18228/commits/eb702b20d5ccc41d0661f319dd7beb0bb28c5fca
eb702b2https://github.com/python/cpython/pull/18228/commits/eb702b20d5ccc41d0661f319dd7beb0bb28c5fca
https://github.com/cjw296
cjw296https://github.com/cjw296
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 28, 2020https://github.com/python/cpython/pull/18228#event-2984687730
https://github.com/cjw296
cjw296https://github.com/cjw296
lisroachhttps://github.com/lisroach
tirkarthihttps://github.com/tirkarthi
January 28, 2020 08:30https://github.com/python/cpython/pull/18228#event-2984687742
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 28, 2020https://github.com/python/cpython/pull/18228#event-2984687856
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 28, 2020https://github.com/python/cpython/pull/18228#event-2984687900
cjw296https://github.com/cjw296
January 28, 2020 08:41https://github.com/python/cpython/pull/18228#commits-pushed-e4f8647
https://github.com/cjw296
These items are only ever of length two.https://github.com/python/cpython/pull/18228/commits/e4f8647eddd953c79d6a0e6cba77e0a7fe79f86d
e4f8647https://github.com/python/cpython/pull/18228/commits/e4f8647eddd953c79d6a0e6cba77e0a7fe79f86d
https://github.com/cjw296
fix typohttps://github.com/python/cpython/pull/18228/commits/8e6313989aad067a0335dd48deb0eee0352fcec2
8e63139https://github.com/python/cpython/pull/18228/commits/8e6313989aad067a0335dd48deb0eee0352fcec2
https://github.com/cjw296
Fix bug highlighted by lack of coverage of an except branch.https://github.com/python/cpython/pull/18228/commits/cc8d3c10bc698269ea779b01ffd248be3ffb5466
cc8d3c1https://github.com/python/cpython/pull/18228/commits/cc8d3c10bc698269ea779b01ffd248be3ffb5466
https://github.com/cjw296
The fix for bpo-37972 means _Call.count and _Call.index are no longer…https://github.com/python/cpython/pull/18228/commits/9130b1658256045457c912f4cdcdd159d7e4bda2
9130b16https://github.com/python/cpython/pull/18228/commits/9130b1658256045457c912f4cdcdd159d7e4bda2
https://github.com/cjw296
add coverage for calling next() on a mock_open with readline.return_v…https://github.com/python/cpython/pull/18228/commits/7812d7b43bcf8160bc8254d8244e46c7708cf28d
7812d7bhttps://github.com/python/cpython/pull/18228/commits/7812d7b43bcf8160bc8254d8244e46c7708cf28d
https://github.com/cjw296
__aiter__ is defined on the Mock so this is never called.https://github.com/python/cpython/pull/18228/commits/576fd3ea7d944549b37fb57410830400eb1e2c39
576fd3ehttps://github.com/python/cpython/pull/18228/commits/576fd3ea7d944549b37fb57410830400eb1e2c39
https://github.com/cjw296
cjw296https://github.com/cjw296
force-pushedhttps://github.com/python/cpython/compare/efe5efb042bd0ab7935aac42f02d320c1d8df7a2..576fd3ea7d944549b37fb57410830400eb1e2c39
efe5efbhttps://github.com/python/cpython/commit/efe5efb042bd0ab7935aac42f02d320c1d8df7a2
576fd3ehttps://github.com/python/cpython/commit/576fd3ea7d944549b37fb57410830400eb1e2c39
Compare https://github.com/python/cpython/compare/efe5efb042bd0ab7935aac42f02d320c1d8df7a2..576fd3ea7d944549b37fb57410830400eb1e2c39
January 28, 2020 08:41https://github.com/python/cpython/pull/18228#event-2984717565
https://github.com/cjw296
cjw296https://github.com/cjw296
Jan 29, 2020https://github.com/python/cpython/pull/18228#issuecomment-579837733
https://bugs.python.org/issue39485https://bugs.python.org/issue39485
Please reload this pagehttps://github.com/python/cpython/pull/18228
https://github.com/cjw296
cjw296https://github.com/cjw296
db5e86ahttps://github.com/python/cpython/commit/db5e86adbce12350c26e7ffc2c6673369971a2dc
Jan 29, 2020https://github.com/python/cpython/pull/18228#event-2990183094
https://github.com/cjw296
cjw296https://github.com/cjw296
January 29, 2020 16:24https://github.com/python/cpython/pull/18228#event-2990183174
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 29, 2020https://github.com/python/cpython/pull/18228#event-2990183295
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 29, 2020https://github.com/python/cpython/pull/18228#issuecomment-579892771
db5e86ahttps://github.com/python/cpython/commit/db5e86adbce12350c26e7ffc2c6673369971a2dc
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/all/#builders/152/builds/259https://buildbot.python.org/all/#builders/152/builds/259
db5e86ahttps://github.com/python/cpython/commit/db5e86adbce12350c26e7ffc2c6673369971a2dc
https://buildbot.python.org/all/#builders/152/builds/259https://buildbot.python.org/all/#builders/152/builds/259
Please reload this pagehttps://github.com/python/cpython/pull/18228
https://github.com/cjw296
cjw296https://github.com/cjw296
Jan 29, 2020https://github.com/python/cpython/pull/18228#issuecomment-579895677
Please reload this pagehttps://github.com/python/cpython/pull/18228
shihai1991https://github.com/shihai1991
Jan 31, 2020 https://github.com/python/cpython/pull/18228#ref-commit-86593b9
https://github.com/cjw296
https://github.com/shihai1991
Get mock coverage back to 100% (https://github.com/shihai1991/cpython/commit/86593b9dc5a63621d909adde9992c3cb2bb742b1
pythonGH-18228https://github.com/python/cpython/pull/18228
)https://github.com/shihai1991/cpython/commit/86593b9dc5a63621d909adde9992c3cb2bb742b1
86593b9https://github.com/shihai1991/cpython/commit/86593b9dc5a63621d909adde9992c3cb2bb742b1
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 3, 2020https://github.com/python/cpython/pull/18228#issuecomment-581308906
@cjw296https://github.com/cjw296
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/18228
https://github.com/cjw296
cjw296https://github.com/cjw296
Feb 3, 2020https://github.com/python/cpython/pull/18228#issuecomment-581338105
https://buildbot.python.org/all/#/builders/152/builds/259https://buildbot.python.org/all/#/builders/152/builds/259
Please reload this pagehttps://github.com/python/cpython/pull/18228
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 3, 2020https://github.com/python/cpython/pull/18228#issuecomment-581441413
https://bugs.python.org/issue39088https://bugs.python.org/issue39088
Please reload this pagehttps://github.com/python/cpython/pull/18228
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18228
https://github.com/tirkarthi
tirkarthi https://github.com/tirkarthi
https://github.com/lisroach
lisroach https://github.com/lisroach
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/18228
https://github.com/cjw296
https://github.com/bedevere-bot
https://github.com/aeros
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.