Title: bpo-15786: IDLE: Fix behavior when mouse click at autocompletetion window by mlouielu · Pull Request #1811 · python/cpython · GitHub
Open Graph Title: bpo-15786: IDLE: Fix behavior when mouse click at autocompletetion window by mlouielu · Pull Request #1811 · python/cpython
X Title: bpo-15786: IDLE: Fix behavior when mouse click at autocompletetion window by mlouielu · Pull Request #1811 · python/cpython
Description: This fix behavior on Windows, MacOS and Linux platform. The root problem is caused by non-check for hide_event. When user click at acw, root widget will get focusOut event, then trigger hide_window to close the acw. It should only be hide when acw is active, and acw didn't get focus at FocusOut event (this event bind on acw and widget), or when widget get a ButtonPress event (this event only bind on the widget). MacOS will freeze after double click on acw, this because when doubleclick_event try to hide window at the end, hide_window function destroy the whole acw, but tkinter didn't get focus back to widget. So it should set focus on widget first, then destroy acw. Windows can not response to double click event because the misbehavior of Configure event, when acw is showed, tkinter will call winconfig event multiple time, that cause tkinter can not response to double click event. When on Windows, it will unbind Configure event when first time get into winconfig_event to prevent multiple calls of this event. Previous PR: #1517
Open Graph Description: This fix behavior on Windows, MacOS and Linux platform. The root problem is caused by non-check for hide_event. When user click at acw, root widget will get focusOut event, then trigger hide_window...
X Description: This fix behavior on Windows, MacOS and Linux platform. The root problem is caused by non-check for hide_event. When user click at acw, root widget will get focusOut event, then trigger hide_window...
Opengraph URL: https://github.com/python/cpython/pull/1811
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f3c31904-4a41-b153-01bf-1588d7d3956f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD70:50919:8D11BFA:C4B1D16:6A502B8B |
| html-safe-nonce | 6f6e55bbbba2addedaae85b2c6fddd8015a192074baf8115a2588a7a3262dde6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDcwOjUwOTE5OjhEMTFCRkE6QzRCMUQxNjo2QTUwMkI4QiIsInZpc2l0b3JfaWQiOiI0MjczMjQ2Njc3NTA1MTU4MDI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | de1b8e7f23830defd3ec2908444e4fd3982aad3d87e8e4a1dbcfeeedbf06eb9e |
| hovercard-subject-tag | pull_request:122406996 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/1811/files |
| twitter:image | https://avatars.githubusercontent.com/u/28770408?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/28770408?s=400&v=4 |
| og:image:alt | This fix behavior on Windows, MacOS and Linux platform. The root problem is caused by non-check for hide_event. When user click at acw, root widget will get focusOut event, then trigger hide_window... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d90666eaf032b7eb8975a378efe38e37f4ebb96c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width