René's URL Explorer Experiment


Title: bpo-27321 Fix email.generator.py to not replace a non-existent header. by msapiro · Pull Request #18074 · python/cpython · GitHub

Open Graph Title: bpo-27321 Fix email.generator.py to not replace a non-existent header. by msapiro · Pull Request #18074 · python/cpython

X Title: bpo-27321 Fix email.generator.py to not replace a non-existent header. by msapiro · Pull Request #18074 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This PR replaces #1977. The reason for the replacement is two-fold. The fix itself is different is that if the CTE header doesn't exist in the original message, it is inserted. This is importan...

X Description: This PR replaces #1977. The reason for the replacement is two-fold. The fix itself is different is that if the CTE header doesn't exist in the original message, it is inserted. This is impo...

Opengraph URL: https://github.com/python/cpython/pull/18074

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:453d5c0f-dd1a-4be6-99fe-d7f6baf50147
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC3E:5105D:368FDF8:4B3A735:6A4F36BB
html-safe-noncebf01b717a18f02549d29c3d337466f0c36f53f05780c412d56376c221571d333
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzNFOjUxMDVEOjM2OEZERjg6NEIzQTczNTo2QTRGMzZCQiIsInZpc2l0b3JfaWQiOiIzMDYxNjEzMzIyMTQ5MjQ2NjUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd2c938c048e22526edb483325f29f84b8906ebd7befd1b759630f39aa77ccffc
hovercard-subject-tagpull_request:364620841
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18074/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ef2fb2f074cf76c4d00ba155c565ee3db3e4b11b2b748c5add630d607ea7c25e/python/cpython/pull/18074
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ef2fb2f074cf76c4d00ba155c565ee3db3e4b11b2b748c5add630d607ea7c25e/python/cpython/pull/18074
og:image:altThis PR replaces #1977. The reason for the replacement is two-fold. The fix itself is different is that if the CTE header doesn't exist in the original message, it is inserted. This is importan...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsapiro
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18074#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18074
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18074
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18074
Reloadhttps://github.com/python/cpython/pull/18074
Reloadhttps://github.com/python/cpython/pull/18074
Please reload this pagehttps://github.com/python/cpython/pull/18074
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18074
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
msapiro:27321https://github.com/msapiro/cpython/tree/27321
Conversationhttps://github.com/python/cpython/pull/18074
Commits3 (3)https://github.com/python/cpython/pull/18074/commits
Checkshttps://github.com/python/cpython/pull/18074/checks
Files changedhttps://github.com/python/cpython/pull/18074/files
bpo-27321 Fix email.generator.py to not replace a non-existent header.https://github.com/python/cpython/pull/18074#top
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
msapiro:27321https://github.com/msapiro/cpython/tree/27321
https://github.com/msapiro
msapirohttps://github.com/msapiro
Jan 20, 2020https://github.com/python/cpython/pull/18074#issue-552039930
Please reload this pagehttps://github.com/python/cpython/pull/18074
#1977https://github.com/python/cpython/pull/1977
#1977https://github.com/python/cpython/pull/1977
https://bugs.python.org/issue27321https://bugs.python.org/issue27321
@warsawhttps://github.com/warsaw
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/msapiro
bpo-27321 Fix email.generator.py to not attempt to replace a non-exis…https://github.com/python/cpython/pull/18074/commits/84fb618ceee5c912ce563034186987c0cfc673e7
84fb618https://github.com/python/cpython/pull/18074/commits/84fb618ceee5c912ce563034186987c0cfc673e7
https://github.com/msapiro
msapirohttps://github.com/msapiro
code ownerhttps://github.com/python/cpython/blob/d8ef64422a75f40cecdb1a7ee43492607d3daaf6/.github/CODEOWNERS#L65
January 20, 2020 03:02https://github.com/python/cpython/pull/18074#event-2961436641
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 20, 2020https://github.com/python/cpython/pull/18074#event-2961436707
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 20, 2020https://github.com/python/cpython/pull/18074#event-2961436765
https://github.com/peteroupc
peteroupchttps://github.com/peteroupc
Jan 20, 2020https://github.com/python/cpython/pull/18074#issuecomment-576093151
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/msapiro
msapirohttps://github.com/msapiro
Jan 20, 2020https://github.com/python/cpython/pull/18074#issuecomment-576097911
Please reload this pagehttps://github.com/python/cpython/pull/18074
@peteroupchttps://github.com/peteroupc
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/msapiro
Added a MIME-Version: header to the test.https://github.com/python/cpython/pull/18074/commits/cf284919184b3cd7a18d4bf5a44f1e604f17f1ac
cf28491https://github.com/python/cpython/pull/18074/commits/cf284919184b3cd7a18d4bf5a44f1e604f17f1ac
https://github.com/peteroupc
peteroupchttps://github.com/peteroupc
Jan 20, 2020https://github.com/python/cpython/pull/18074#issuecomment-576110634
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/msapiro
msapirohttps://github.com/msapiro
Jan 26, 2020 https://github.com/python/cpython/pull/18074#ref-pullrequest-234047203
bpo-27321: email: don't try to replace headers that aren't set #1977 https://github.com/python/cpython/pull/1977
https://github.com/warsaw
warsawhttps://github.com/warsaw
Oct 19, 2020 https://github.com/python/cpython/pull/18074#pullrequestreview-512190347
View reviewed changes https://github.com/python/cpython/pull/18074/files/cf284919184b3cd7a18d4bf5a44f1e604f17f1ac
Lib/email/generator.pyhttps://github.com/python/cpython/pull/18074/files/cf284919184b3cd7a18d4bf5a44f1e604f17f1ac#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
warsawhttps://github.com/warsaw
Oct 19, 2020https://github.com/python/cpython/pull/18074#discussion_r508087545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@msapirohttps://github.com/msapiro
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/warsaw
warsawhttps://github.com/warsaw
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895698884
https://github.com/warsaw
warsawhttps://github.com/warsaw
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895700226
https://github.com/warsaw
warsawhttps://github.com/warsaw
Oct 19, 2020https://github.com/python/cpython/pull/18074#issuecomment-712467554
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/warsaw
Avoid a "double negative" conditionalhttps://github.com/python/cpython/pull/18074/commits/b3f3157c18b524c2e104550eec5998eea56aae56
b3f3157https://github.com/python/cpython/pull/18074/commits/b3f3157c18b524c2e104550eec5998eea56aae56
https://github.com/warsaw
warsawhttps://github.com/warsaw
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895748920
https://github.com/warsaw
warsawhttps://github.com/warsaw
Oct 19, 2020 https://github.com/python/cpython/pull/18074#pullrequestreview-512200450
View reviewed changes https://github.com/python/cpython/pull/18074/files/b3f3157c18b524c2e104550eec5998eea56aae56
warsawhttps://github.com/warsaw
https://github.com/python/cpython/pull/18074#pullrequestreview-512200450
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895750317
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2020https://github.com/python/cpython/pull/18074#issuecomment-712483767
@msapirohttps://github.com/msapiro
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
bf83822https://github.com/python/cpython/commit/bf838227c35212709dc43b3c3c57f8e1655c1d24
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895823776
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2020https://github.com/python/cpython/pull/18074#issuecomment-712483790
@msapirohttps://github.com/msapiro
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895823855
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2020 https://github.com/python/cpython/pull/18074#ref-commit-cab7a18
https://github.com/msapiro
https://github.com/miss-islington
bpo-27321 Fix email.generator.py to not replace a non-existent header. (https://github.com/miss-islington/cpython/commit/cab7a18c3c3fdef8bcb37d4c7f48a43fbff0b45a
cab7a18https://github.com/miss-islington/cpython/commit/cab7a18c3c3fdef8bcb37d4c7f48a43fbff0b45a
pythonGH-18074https://github.com/python/cpython/pull/18074
pythonGH-1977https://github.com/python/cpython/pull/1977
pythonGH-1977https://github.com/python/cpython/pull/1977
@warsawhttps://github.com/warsaw
bf83822https://github.com/miss-islington/cpython/commit/bf838227c35212709dc43b3c3c57f8e1655c1d24
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895824348
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 19, 2020https://github.com/python/cpython/pull/18074#issuecomment-712483858
GH-22796https://github.com/python/cpython/pull/22796
3.9 branchhttps://github.com/python/cpython/tree/3.9
Please reload this pagehttps://github.com/python/cpython/pull/18074
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2020 https://github.com/python/cpython/pull/18074#ref-commit-789f96e
https://github.com/msapiro
https://github.com/miss-islington
bpo-27321 Fix email.generator.py to not replace a non-existent header. (https://github.com/miss-islington/cpython/commit/789f96e9fd806bd14269bb3510cc0cf1df65b08c
789f96ehttps://github.com/miss-islington/cpython/commit/789f96e9fd806bd14269bb3510cc0cf1df65b08c
pythonGH-18074https://github.com/python/cpython/pull/18074
pythonGH-1977https://github.com/python/cpython/pull/1977
pythonGH-1977https://github.com/python/cpython/pull/1977
@warsawhttps://github.com/warsaw
bf83822https://github.com/miss-islington/cpython/commit/bf838227c35212709dc43b3c3c57f8e1655c1d24
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 19, 2020https://github.com/python/cpython/pull/18074#issuecomment-712483909
GH-22797https://github.com/python/cpython/pull/22797
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Oct 19, 2020https://github.com/python/cpython/pull/18074#event-3895824587
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2020 https://github.com/python/cpython/pull/18074#ref-commit-371146a
https://github.com/miss-islington
https://github.com/msapiro
bpo-27321https://bugs.python.org/issue?@action=redirect&bpo=27321
Fix email.generator.py to not replace a non-existent header. (https://github.com/python/cpython/commit/371146a3f8a989964e2a9c0efc7d776815410fac
371146ahttps://github.com/python/cpython/commit/371146a3f8a989964e2a9c0efc7d776815410fac
GH-18074https://github.com/python/cpython/pull/18074
GH-1977https://github.com/python/cpython/pull/1977
GH-1977https://github.com/python/cpython/pull/1977
@warsawhttps://github.com/warsaw
bf83822https://github.com/python/cpython/commit/bf838227c35212709dc43b3c3c57f8e1655c1d24
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2020 https://github.com/python/cpython/pull/18074#ref-commit-72ce82a
https://github.com/miss-islington
https://github.com/msapiro
bpo-27321https://bugs.python.org/issue?@action=redirect&bpo=27321
Fix email.generator.py to not replace a non-existent header. (https://github.com/python/cpython/commit/72ce82abcf9051b18a05350936de7ecab7306662
72ce82ahttps://github.com/python/cpython/commit/72ce82abcf9051b18a05350936de7ecab7306662
GH-18074https://github.com/python/cpython/pull/18074
GH-1977https://github.com/python/cpython/pull/1977
GH-1977https://github.com/python/cpython/pull/1977
@warsawhttps://github.com/warsaw
bf83822https://github.com/python/cpython/commit/bf838227c35212709dc43b3c3c57f8e1655c1d24
adorilsonhttps://github.com/adorilson
Mar 13, 2021 https://github.com/python/cpython/pull/18074#ref-commit-42e935d
https://github.com/msapiro
https://github.com/adorilson
bpo-27321 Fix email.generator.py to not replace a non-existent header. (https://github.com/adorilson/cpython/commit/42e935d5ca3d15684d05827d8afb6756e1d7f6e9
42e935dhttps://github.com/adorilson/cpython/commit/42e935d5ca3d15684d05827d8afb6756e1d7f6e9
pythonGH-18074https://github.com/python/cpython/pull/18074
python#1977https://github.com/python/cpython/pull/1977
python#1977https://github.com/python/cpython/pull/1977
@warsawhttps://github.com/warsaw
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18074
https://github.com/warsaw
warsaw https://github.com/warsaw
https://github.com/python/cpython/pull/18074/files/b3f3157c18b524c2e104550eec5998eea56aae56
https://github.com/warsaw
warsaw https://github.com/warsaw
Please reload this pagehttps://github.com/python/cpython/pull/18074
https://github.com/msapiro
https://github.com/peteroupc
https://github.com/warsaw
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.