René's URL Explorer Experiment


Title: bpo-39388: IDLE: Fix bug when cancelling out of configdialog by csabella · Pull Request #18068 · python/cpython · GitHub

Open Graph Title: bpo-39388: IDLE: Fix bug when cancelling out of configdialog by csabella · Pull Request #18068 · python/cpython

X Title: bpo-39388: IDLE: Fix bug when cancelling out of configdialog by csabella · Pull Request #18068 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Changes to keybindings were being remembered even when cancelling out of the Config Dialog. https://bugs.python.org/issue39388

X Description: Changes to keybindings were being remembered even when cancelling out of the Config Dialog. https://bugs.python.org/issue39388

Opengraph URL: https://github.com/python/cpython/pull/18068

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a39e2ab9-6052-8651-eb61-c47dad6810ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FC8:446DE:806E49:B96FEA:6A4F8641
html-safe-noncea4dbfeabdeeff4a422f504b453325bcb1ad0971fb2b20e870925fde362804ad1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkM4OjQ0NkRFOjgwNkU0OTpCOTZGRUE6NkE0Rjg2NDEiLCJ2aXNpdG9yX2lkIjoiODk0ODI5NzA3NDI5OTg2NDY0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac96511407aa419b81b2a5096435191d79dc5c880c1891c9a1d20a1f8d842f8c85
hovercard-subject-tagpull_request:364557806
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18068/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/66c661960d8ac78b0da38737d552c5172fe89071b8bbe5e3a9e07aa7a788f178/python/cpython/pull/18068
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/66c661960d8ac78b0da38737d552c5172fe89071b8bbe5e3a9e07aa7a788f178/python/cpython/pull/18068
og:image:altChanges to keybindings were being remembered even when cancelling out of the Config Dialog. https://bugs.python.org/issue39388
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecsabella
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18068#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18068
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18068
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18068
Reloadhttps://github.com/python/cpython/pull/18068
Reloadhttps://github.com/python/cpython/pull/18068
Please reload this pagehttps://github.com/python/cpython/pull/18068
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18068
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
terryjreedyhttps://github.com/terryjreedy
python:masterhttps://github.com/python/cpython/tree/master
csabella:cancelconfighttps://github.com/csabella/cpython/tree/cancelconfig
Conversationhttps://github.com/python/cpython/pull/18068
Commits5 (5)https://github.com/python/cpython/pull/18068/commits
Checkshttps://github.com/python/cpython/pull/18068/checks
Files changedhttps://github.com/python/cpython/pull/18068/files
bpo-39388: IDLE: Fix bug when cancelling out of configdialoghttps://github.com/python/cpython/pull/18068#top
terryjreedyhttps://github.com/terryjreedy
python:masterhttps://github.com/python/cpython/tree/master
csabella:cancelconfighttps://github.com/csabella/cpython/tree/cancelconfig
https://github.com/csabella
csabellahttps://github.com/csabella
Jan 19, 2020https://github.com/python/cpython/pull/18068#issue-551954915
Please reload this pagehttps://github.com/python/cpython/pull/18068
https://bugs.python.org/issue39388https://bugs.python.org/issue39388
Please reload this pagehttps://github.com/python/cpython/pull/18068
https://github.com/csabella
bpo-39388: Fix bug when cancelling out of configdialoghttps://github.com/python/cpython/pull/18068/commits/6f0e12bdedac9fb09f0ef15c573d705a9e1422c2
6f0e12bhttps://github.com/python/cpython/pull/18068/commits/6f0e12bdedac9fb09f0ef15c573d705a9e1422c2
https://github.com/csabella
csabellahttps://github.com/csabella
terryjreedyhttps://github.com/terryjreedy
code ownerhttps://github.com/python/cpython/blob/558f07891170fe5173f277d3749e92d844de0a27/.github/CODEOWNERS#L109
January 19, 2020 17:29https://github.com/python/cpython/pull/18068#event-2961031339
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 19, 2020https://github.com/python/cpython/pull/18068#event-2961031372
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 19, 2020https://github.com/python/cpython/pull/18068#event-2961031388
https://github.com/csabella
csabellahttps://github.com/csabella
Jan 19, 2020https://github.com/python/cpython/pull/18068#event-2961031449
https://github.com/terryjreedy
terryjreedyhttps://github.com/terryjreedy
Jan 25, 2020 https://github.com/python/cpython/pull/18068#pullrequestreview-348304182
View reviewed changes https://github.com/python/cpython/pull/18068/files/6f0e12bdedac9fb09f0ef15c573d705a9e1422c2
terryjreedyhttps://github.com/terryjreedy
https://github.com/python/cpython/pull/18068#pullrequestreview-348304182
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/18068
terryjreedyhttps://github.com/terryjreedy
January 25, 2020 01:43https://github.com/python/cpython/pull/18068#commits-pushed-93196de
https://github.com/terryjreedy
Merge remote-tracking branch 'origin/master' into pr_18068https://github.com/python/cpython/pull/18068/commits/93196de481c714c0037a55853569cf33d831484f
93196dehttps://github.com/python/cpython/pull/18068/commits/93196de481c714c0037a55853569cf33d831484f
https://github.com/terryjreedy
Add new test.https://github.com/python/cpython/pull/18068/commits/80dc438c98f339c96b1327825e64999e455e7639
80dc438https://github.com/python/cpython/pull/18068/commits/80dc438c98f339c96b1327825e64999e455e7639
https://github.com/terryjreedy
News items.https://github.com/python/cpython/pull/18068/commits/a9a182157afdab98a1f522a6b7a7f1aa2fa6c926
a9a1821https://github.com/python/cpython/pull/18068/commits/a9a182157afdab98a1f522a6b7a7f1aa2fa6c926
https://github.com/terryjreedy
terryjreedyhttps://github.com/terryjreedy
Jan 25, 2020 https://github.com/python/cpython/pull/18068#pullrequestreview-348314841
View reviewed changes https://github.com/python/cpython/pull/18068/files/a9a182157afdab98a1f522a6b7a7f1aa2fa6c926
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 25, 2020https://github.com/python/cpython/pull/18068#event-2979173231
https://github.com/terryjreedy
terryjreedyhttps://github.com/terryjreedy
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Jan 25, 2020https://github.com/python/cpython/pull/18068#event-2979173575
https://github.com/terryjreedy
Change '__main__' to __name__ to work on all systems.https://github.com/python/cpython/pull/18068/commits/1ff8739dff2a26e29a104b6ac1efa0528b9e92d7
1ff8739https://github.com/python/cpython/pull/18068/commits/1ff8739dff2a26e29a104b6ac1efa0528b9e92d7
https://github.com/terryjreedy
terryjreedyhttps://github.com/terryjreedy
d0d9fa8https://github.com/python/cpython/commit/d0d9fa8c5e30aff71b6d5e8b2673396622f33270
Jan 25, 2020https://github.com/python/cpython/pull/18068#event-2979204272
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jan 25, 2020https://github.com/python/cpython/pull/18068#issuecomment-578389606
@csabellahttps://github.com/csabella
@terryjreedyhttps://github.com/terryjreedy
Please reload this pagehttps://github.com/python/cpython/pull/18068
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 25, 2020https://github.com/python/cpython/pull/18068#event-2979204284
miss-islingtonhttps://github.com/miss-islington
Jan 25, 2020 https://github.com/python/cpython/pull/18068#ref-commit-6cb1d80
https://github.com/csabella
https://github.com/miss-islington
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (https://github.com/miss-islington/cpython/commit/6cb1d80f502d13ff3f995919a092d0e3be39b1a1
pythonG…https://github.com/python/cpython/pull/18068
6cb1d80https://github.com/miss-islington/cpython/commit/6cb1d80f502d13ff3f995919a092d0e3be39b1a1
…H-18068https://github.com/python/cpython/pull/18068
d0d9fa8https://github.com/miss-islington/cpython/commit/d0d9fa8c5e30aff71b6d5e8b2673396622f33270
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 25, 2020https://github.com/python/cpython/pull/18068#issuecomment-578389622
GH-18178https://github.com/python/cpython/pull/18178
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/18068
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Jan 25, 2020https://github.com/python/cpython/pull/18068#event-2979204390
miss-islingtonhttps://github.com/miss-islington
Jan 25, 2020 https://github.com/python/cpython/pull/18068#ref-commit-6065b6e
https://github.com/csabella
https://github.com/miss-islington
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (https://github.com/miss-islington/cpython/commit/6065b6e7d5cd099532bfa80ff014f002565f070f
pythonG…https://github.com/python/cpython/pull/18068
6065b6ehttps://github.com/miss-islington/cpython/commit/6065b6e7d5cd099532bfa80ff014f002565f070f
…H-18068https://github.com/python/cpython/pull/18068
d0d9fa8https://github.com/miss-islington/cpython/commit/d0d9fa8c5e30aff71b6d5e8b2673396622f33270
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Jan 25, 2020https://github.com/python/cpython/pull/18068#event-2979204426
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 25, 2020https://github.com/python/cpython/pull/18068#issuecomment-578389626
GH-18179https://github.com/python/cpython/pull/18179
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/18068
sthagenhttps://github.com/sthagen
Jan 25, 2020 https://github.com/python/cpython/pull/18068#ref-commit-21dc636
https://github.com/sthagen
Merge pull requesthttps://github.com/sthagen/python-cpython/commit/21dc6360dfd197242e5080adbe80a6a26c1b9451
#207https://github.com/sthagen/python-cpython/pull/207
from python/masterhttps://github.com/sthagen/python-cpython/commit/21dc6360dfd197242e5080adbe80a6a26c1b9451
21dc636https://github.com/sthagen/python-cpython/commit/21dc6360dfd197242e5080adbe80a6a26c1b9451
pythonGH-18068https://github.com/python/cpython/pull/18068
miss-islingtonhttps://github.com/miss-islington
Jan 25, 2020 https://github.com/python/cpython/pull/18068#ref-commit-a234492
https://github.com/miss-islington
https://github.com/csabella
bpo-39388https://bugs.python.org/issue?@action=redirect&bpo=39388
: IDLE: Fix bug when cancelling out of configdialog (https://github.com/python/cpython/commit/a23449285430081ea317cc1f203c80c410bbd8b9
GH-18068https://github.com/python/cpython/pull/18068
)https://github.com/python/cpython/commit/a23449285430081ea317cc1f203c80c410bbd8b9
a234492https://github.com/python/cpython/commit/a23449285430081ea317cc1f203c80c410bbd8b9
d0d9fa8https://github.com/python/cpython/commit/d0d9fa8c5e30aff71b6d5e8b2673396622f33270
miss-islingtonhttps://github.com/miss-islington
Jan 25, 2020 https://github.com/python/cpython/pull/18068#ref-commit-fd9ce2b
https://github.com/miss-islington
https://github.com/csabella
bpo-39388https://bugs.python.org/issue?@action=redirect&bpo=39388
: IDLE: Fix bug when cancelling out of configdialog (https://github.com/python/cpython/commit/fd9ce2b924263c1f5c5a2f3f3095fe6ae97c1432
GH-18068https://github.com/python/cpython/pull/18068
)https://github.com/python/cpython/commit/fd9ce2b924263c1f5c5a2f3f3095fe6ae97c1432
fd9ce2bhttps://github.com/python/cpython/commit/fd9ce2b924263c1f5c5a2f3f3095fe6ae97c1432
d0d9fa8https://github.com/python/cpython/commit/d0d9fa8c5e30aff71b6d5e8b2673396622f33270
https://github.com/csabella
csabellahttps://github.com/csabella
Jan 25, 2020https://github.com/python/cpython/pull/18068#issuecomment-578401808
GH-3592https://github.com/python/cpython/pull/3592
Please reload this pagehttps://github.com/python/cpython/pull/18068
https://github.com/csabella
csabellahttps://github.com/csabella
January 25, 2020 12:19https://github.com/python/cpython/pull/18068#event-2979281910
shihai1991https://github.com/shihai1991
Jan 31, 2020 https://github.com/python/cpython/pull/18068#ref-commit-f837254
https://github.com/csabella
https://github.com/terryjreedy
https://github.com/shihai1991
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (https://github.com/shihai1991/cpython/commit/f8372541cb8720ff749b628f263d6268c620b620
pythonG…https://github.com/python/cpython/pull/18068
f837254https://github.com/shihai1991/cpython/commit/f8372541cb8720ff749b628f263d6268c620b620
…H-18068https://github.com/python/cpython/pull/18068
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18068
https://github.com/terryjreedy
terryjreedy https://github.com/terryjreedy
https://github.com/python/cpython/pull/18068/files/a9a182157afdab98a1f522a6b7a7f1aa2fa6c926
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/18068
https://github.com/csabella
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/terryjreedy
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.