| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:79e9c74d-0535-fddf-8e01-dd5e6466861f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B680:2FA5EC:1169B14:180CF88:6A4DDB38 |
| html-safe-nonce | 359726f9ab4ca409a108ab7b82bb45d13662d1a1abff5b56e308065ca034de09 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjgwOjJGQTVFQzoxMTY5QjE0OjE4MENGODg6NkE0RERCMzgiLCJ2aXNpdG9yX2lkIjoiNTE5MDAzODg5NDU4Njc0NzcwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f9d0854e0a23530527adf4e2a13da88b30de3f40c74f50431acd7c06028943d2 |
| hovercard-subject-tag | pull_request:364493506 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/18057/files |
| twitter:image | https://avatars.githubusercontent.com/u/44193521?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/44193521?s=400&v=4 |
| og:image:alt | https://bugs.python.org/issue39349 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/18057/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18057%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18057%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/18057/files |
| Reload | https://github.com/python/cpython/pull/18057/files |
| Reload | https://github.com/python/cpython/pull/18057/files |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| pitrou | https://github.com/pitrou |
| python:master | https://github.com/python/cpython/tree/master |
| aeros:bpo39349-add-cancel_futures-to-Executor.shutdown | https://github.com/aeros/cpython/tree/bpo39349-add-cancel_futures-to-Executor.shutdown |
|
Conversation
51
| https://github.com/python/cpython/pull/18057 |
|
Commits
16
| https://github.com/python/cpython/pull/18057/commits |
|
Checks
0
| https://github.com/python/cpython/pull/18057/checks |
|
Files changed
| https://github.com/python/cpython/pull/18057/files |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
bpo-39349: Add *cancel_futures* to Executor.shutdown()
| https://github.com/python/cpython/pull/18057/files#top |
|
Show all changes
16 commits
| https://github.com/python/cpython/pull/18057/files |
|
f736292
Add *cancel_futures* to Executor.shutdown()
aeros Jan 17, 2020
| https://github.com/python/cpython/pull/18057/commits/f7362927039cc6170e4b168b0efae038632b3f0f |
|
6267950
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 19, 2020
| https://github.com/python/cpython/pull/18057/commits/62679509fbb1a9253275e86bb5f6a07e8e4d9754 |
|
b047099
Make *cancel_futures* keyword-only
aeros Jan 23, 2020
| https://github.com/python/cpython/pull/18057/commits/b04709943a7dea7a8013351421141385b9e20737 |
|
f9b6b33
Add comments to explain *cancel_futures* in TPE
aeros Jan 23, 2020
| https://github.com/python/cpython/pull/18057/commits/f9b6b3376ceadec91dab9a459c32696cbf8920a7 |
|
5804e41
Merge branch 'bpo39349-add-cancel_futures-to-Executor.shutdown' of ht…
aeros Jan 23, 2020
| https://github.com/python/cpython/pull/18057/commits/5804e41a6468b5cd9c9f180772b6ab8070d57bf0 |
|
25376d7
Improve docs and grammar fix
aeros Jan 24, 2020
| https://github.com/python/cpython/pull/18057/commits/25376d746a3754acedddcd1c3a779b6f26bc941d |
|
9a168e4
Address review feedback
aeros Jan 25, 2020
| https://github.com/python/cpython/pull/18057/commits/9a168e43755056ccced8159eed066df1ab2fe34c |
|
7bd8134
Add kw-only asterisk to executor.shutdown() docs
aeros Jan 25, 2020
| https://github.com/python/cpython/pull/18057/commits/7bd8134d4bcf8ad6562299b8da9701eed86c56c5 |
|
8b08b2f
Update code comments
aeros Jan 25, 2020
| https://github.com/python/cpython/pull/18057/commits/8b08b2fa8e518012c85ad80497c98f741e836c50 |
|
f706c5f
Improve future cancellation for PPE
aeros Jan 29, 2020
| https://github.com/python/cpython/pull/18057/commits/f706c5f70e65a1570028fa5f8b285747160cd535 |
|
bdbc8e3
Fix race condition and improve tests
aeros Jan 29, 2020
| https://github.com/python/cpython/pull/18057/commits/bdbc8e399de2d1a82c80f3d16413fe236f03ce78 |
|
41baf76
Add TPE test for interpreter exit
aeros Jan 29, 2020
| https://github.com/python/cpython/pull/18057/commits/41baf767ed0ca76e0e1990ffe2bb0af8863602d0 |
|
bee0e68
Fix whitespace
aeros Jan 29, 2020
| https://github.com/python/cpython/pull/18057/commits/bee0e6817f4f9dbc131f199191098c2991103c8e |
|
52c9087
Merge branch 'master' into bpo39349-add-cancel_futures-to-Executor.sh…
aeros Jan 29, 2020
| https://github.com/python/cpython/pull/18057/commits/52c90878f5a3c071337c47d3843a517e4974a994 |
|
bf75a3e
Set _cancel_pending_futures before _shutdown_thread
aeros Feb 1, 2020
| https://github.com/python/cpython/pull/18057/commits/bf75a3e6e021615104e542c69a1b753efa686807 |
|
d756264
Set max_workers to 3 in test_cancel_futures
aeros Feb 1, 2020
| https://github.com/python/cpython/pull/18057/commits/d756264135053661dde9a9fb7de8579e238d9b9b |
|
Clear filters
| https://github.com/python/cpython/pull/18057/files |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
concurrent.futures.rst
| https://github.com/python/cpython/pull/18057/files#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf |
|
3.9.rst
| https://github.com/python/cpython/pull/18057/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36 |
|
process.py
| https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
|
thread.py
| https://github.com/python/cpython/pull/18057/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75 |
|
test_concurrent_futures.py
| https://github.com/python/cpython/pull/18057/files#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41 |
|
2020-01-19-04-12-34.bpo-39349.7CV-LC.rst
| https://github.com/python/cpython/pull/18057/files#diff-0dc0861037ac41675ccd7283b1a2f7e610fc889c4f3298d81b9f0e914f428da8 |
| Doc/library/concurrent.futures.rst | https://github.com/python/cpython/pull/18057/files#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf |
|
View file
| https://github.com/aeros/cpython/blob/d756264135053661dde9a9fb7de8579e238d9b9b/Doc/library/concurrent.futures.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/18057/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/18057/files#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf |
|
| https://github.com/python/cpython/pull/18057/files#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
| https://github.com/python/cpython/pull/18057/files#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf |
|
| https://github.com/python/cpython/pull/18057/files#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf |
| Doc/whatsnew/3.9.rst | https://github.com/python/cpython/pull/18057/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36 |
|
View file
| https://github.com/aeros/cpython/blob/d756264135053661dde9a9fb7de8579e238d9b9b/Doc/whatsnew/3.9.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/18057/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/18057/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36 |
|
| https://github.com/python/cpython/pull/18057/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36 |
| Lib/concurrent/futures/process.py | https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
|
View file
| https://github.com/aeros/cpython/blob/d756264135053661dde9a9fb7de8579e238d9b9b/Lib/concurrent/futures/process.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/18057/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
|
| https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
|
| https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
|
| https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
|
| https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
| https://github.com/python/cpython/pull/18057/files#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1 |
| Lib/concurrent/futures/thread.py | https://github.com/python/cpython/pull/18057/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75 |
|
View file
| https://github.com/aeros/cpython/blob/d756264135053661dde9a9fb7de8579e238d9b9b/Lib/concurrent/futures/thread.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/18057/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/18057/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75 |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
| https://github.com/python/cpython/pull/18057/files#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75 |
| Lib/test/test_concurrent_futures.py | https://github.com/python/cpython/pull/18057/files#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41 |
|
View file
| https://github.com/aeros/cpython/blob/d756264135053661dde9a9fb7de8579e238d9b9b/Lib/test/test_concurrent_futures.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/18057/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/18057/files#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41 |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
| Please reload this page | https://github.com/python/cpython/pull/18057/files |
|
| https://github.com/python/cpython/pull/18057/files#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41 |
|
| https://github.com/python/cpython/pull/18057/files#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41 |
|
| https://github.com/python/cpython/pull/18057/files#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41 |
| Misc/NEWS.d/next/Library/2020-01-19-04-12-34.bpo-39349.7CV-LC.rst | https://github.com/python/cpython/pull/18057/files#diff-0dc0861037ac41675ccd7283b1a2f7e610fc889c4f3298d81b9f0e914f428da8 |
|
View file
| https://github.com/aeros/cpython/blob/d756264135053661dde9a9fb7de8579e238d9b9b/Misc/NEWS.d/next/Library/2020-01-19-04-12-34.bpo-39349.7CV-LC.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/18057/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |