René's URL Explorer Experiment


Title: bpo-39349: Add *cancel_futures* to Executor.shutdown() by aeros · Pull Request #18057 · python/cpython · GitHub

Open Graph Title: bpo-39349: Add *cancel_futures* to Executor.shutdown() by aeros · Pull Request #18057 · python/cpython

X Title: bpo-39349: Add *cancel_futures* to Executor.shutdown() by aeros · Pull Request #18057 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: https://bugs.python.org/issue39349

X Description: https://bugs.python.org/issue39349

Opengraph URL: https://github.com/python/cpython/pull/18057

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bc578961-b8f4-99f4-09c9-3254f327b838
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD486:3D0120:536E33:722E47:6A4DA8CD
html-safe-nonce36d719e7c1afa8534ebf72fcb1577cc41e35e9718bdece6d2af9f2163c2ae4b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDg2OjNEMDEyMDo1MzZFMzM6NzIyRTQ3OjZBNERBOENEIiwidmlzaXRvcl9pZCI6IjQ1NjQ1Mzk1ODg2NzcwNTI2MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac76b9a2a8f723e41245b45ab81b58350c3a3b1add20e0c1c236b18606a4ca572f
hovercard-subject-tagpull_request:364493506
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/18057/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4adeee42e6bcc71029c4fb9e85132b9ff6c1c3f78c8e3c1df8618f7260660c74/python/cpython/pull/18057
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4adeee42e6bcc71029c4fb9e85132b9ff6c1c3f78c8e3c1df8618f7260660c74/python/cpython/pull/18057
og:image:althttps://bugs.python.org/issue39349
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaeros
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release47723578ce6819210724ef064c858fce6d3115a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/18057#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18057
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18057
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/18057
Reloadhttps://github.com/python/cpython/pull/18057
Reloadhttps://github.com/python/cpython/pull/18057
Please reload this pagehttps://github.com/python/cpython/pull/18057
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/18057
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
pitrouhttps://github.com/pitrou
python:masterhttps://github.com/python/cpython/tree/master
aeros:bpo39349-add-cancel_futures-to-Executor.shutdownhttps://github.com/aeros/cpython/tree/bpo39349-add-cancel_futures-to-Executor.shutdown
Conversationhttps://github.com/python/cpython/pull/18057
Commits16 (16)https://github.com/python/cpython/pull/18057/commits
Checkshttps://github.com/python/cpython/pull/18057/checks
Files changedhttps://github.com/python/cpython/pull/18057/files
bpo-39349: Add *cancel_futures* to Executor.shutdown()https://github.com/python/cpython/pull/18057#top
pitrouhttps://github.com/pitrou
python:masterhttps://github.com/python/cpython/tree/master
aeros:bpo39349-add-cancel_futures-to-Executor.shutdownhttps://github.com/aeros/cpython/tree/bpo39349-add-cancel_futures-to-Executor.shutdown
https://github.com/aeros
aeroshttps://github.com/aeros
Jan 19, 2020https://github.com/python/cpython/pull/18057#issue-551863745
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://bugs.python.org/issue39349https://bugs.python.org/issue39349
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
Add *cancel_futures* to Executor.shutdown()https://github.com/python/cpython/pull/18057/commits/f7362927039cc6170e4b168b0efae038632b3f0f
f736292https://github.com/python/cpython/pull/18057/commits/f7362927039cc6170e4b168b0efae038632b3f0f
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 19, 2020https://github.com/python/cpython/pull/18057#event-2960628982
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 19, 2020https://github.com/python/cpython/pull/18057#event-2960628998
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/18057/commits/62679509fbb1a9253275e86bb5f6a07e8e4d9754
6267950https://github.com/python/cpython/pull/18057/commits/62679509fbb1a9253275e86bb5f6a07e8e4d9754
https://github.com/aeros
aeroshttps://github.com/aeros
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Jan 19, 2020https://github.com/python/cpython/pull/18057#event-2960629575
https://github.com/aeros
aeroshttps://github.com/aeros
gvanrossumhttps://github.com/gvanrossum
January 19, 2020 04:13https://github.com/python/cpython/pull/18057#event-2960629652
https://github.com/brianquinlan
brianquinlanhttps://github.com/brianquinlan
Jan 21, 2020 https://github.com/python/cpython/pull/18057#pullrequestreview-346242111
View reviewed changes https://github.com/python/cpython/pull/18057/files/62679509fbb1a9253275e86bb5f6a07e8e4d9754
Doc/library/concurrent.futures.rsthttps://github.com/python/cpython/pull/18057/files/62679509fbb1a9253275e86bb5f6a07e8e4d9754#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf
Please reload this pagehttps://github.com/python/cpython/pull/18057
Lib/concurrent/futures/thread.pyhttps://github.com/python/cpython/pull/18057/files/62679509fbb1a9253275e86bb5f6a07e8e4d9754#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75
Please reload this pagehttps://github.com/python/cpython/pull/18057
Lib/test/test_concurrent_futures.pyhttps://github.com/python/cpython/pull/18057/files/62679509fbb1a9253275e86bb5f6a07e8e4d9754#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/brianquinlan
brianquinlanhttps://github.com/brianquinlan
Jan 22, 2020 https://github.com/python/cpython/pull/18057#pullrequestreview-346287644
View reviewed changes https://github.com/python/cpython/pull/18057/files/62679509fbb1a9253275e86bb5f6a07e8e4d9754
Lib/concurrent/futures/process.pyhttps://github.com/python/cpython/pull/18057/files/62679509fbb1a9253275e86bb5f6a07e8e4d9754#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
aeroshttps://github.com/aeros
Jan 22, 2020https://github.com/python/cpython/pull/18057#issuecomment-577011294
Please reload this pagehttps://github.com/python/cpython/pull/18057
@brianquinlanhttps://github.com/brianquinlan
@pitrouhttps://github.com/pitrou
https://gist.github.com/aeros/2e73c8d6dccc94fd863967715826c78dhttps://gist.github.com/aeros/2e73c8d6dccc94fd863967715826c78d
https://gist.github.com/aeros/d1ff62b730426584413bca0c8f2ed99dhttps://gist.github.com/aeros/d1ff62b730426584413bca0c8f2ed99d
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
aeroshttps://github.com/aeros
Jan 22, 2020https://github.com/python/cpython/pull/18057#issuecomment-577012712
@brianquinlanhttps://github.com/brianquinlan
Please reload this pagehttps://github.com/python/cpython/pull/18057
aeroshttps://github.com/aeros
January 22, 2020 22:44https://github.com/python/cpython/pull/18057#commits-pushed-b047099
https://github.com/aeros
Make *cancel_futures* keyword-onlyhttps://github.com/python/cpython/pull/18057/commits/b04709943a7dea7a8013351421141385b9e20737
b047099https://github.com/python/cpython/pull/18057/commits/b04709943a7dea7a8013351421141385b9e20737
https://github.com/aeros
Add comments to explain *cancel_futures* in TPEhttps://github.com/python/cpython/pull/18057/commits/f9b6b3376ceadec91dab9a459c32696cbf8920a7
f9b6b33https://github.com/python/cpython/pull/18057/commits/f9b6b3376ceadec91dab9a459c32696cbf8920a7
https://github.com/aeros
Merge branch 'bpo39349-add-cancel_futures-to-Executor.shutdown' ofhttps://github.com/python/cpython/pull/18057/commits/5804e41a6468b5cd9c9f180772b6ab8070d57bf0
ht…https://github.com/aeros/cpython
5804e41https://github.com/python/cpython/pull/18057/commits/5804e41a6468b5cd9c9f180772b6ab8070d57bf0
…tps://github.com/aeros/cpythonhttps://github.com/aeros/cpython
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 23, 2020https://github.com/python/cpython/pull/18057#issuecomment-577892188
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
Improve docs and grammar fixhttps://github.com/python/cpython/pull/18057/commits/25376d746a3754acedddcd1c3a779b6f26bc941d
25376d7https://github.com/python/cpython/pull/18057/commits/25376d746a3754acedddcd1c3a779b6f26bc941d
https://github.com/aeros
aeroshttps://github.com/aeros
brianquinlanhttps://github.com/brianquinlan
January 24, 2020 22:35https://github.com/python/cpython/pull/18057#event-2978800642
https://github.com/brianquinlan
brianquinlanhttps://github.com/brianquinlan
Jan 25, 2020 https://github.com/python/cpython/pull/18057#pullrequestreview-348267772
View reviewed changes https://github.com/python/cpython/pull/18057/files/25376d746a3754acedddcd1c3a779b6f26bc941d
Doc/library/concurrent.futures.rsthttps://github.com/python/cpython/pull/18057/files/25376d746a3754acedddcd1c3a779b6f26bc941d#diff-eb5cd13d65d2f215d8dc0d95eb1a1341ff69b226ac56ec6099e39582edecc8cf
Please reload this pagehttps://github.com/python/cpython/pull/18057
Lib/concurrent/futures/thread.pyhttps://github.com/python/cpython/pull/18057/files/25376d746a3754acedddcd1c3a779b6f26bc941d#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75
Please reload this pagehttps://github.com/python/cpython/pull/18057
Lib/test/test_concurrent_futures.pyhttps://github.com/python/cpython/pull/18057/files/62679509fbb1a9253275e86bb5f6a07e8e4d9754#diff-4123e7430fd434e48220681097a0e5ddd00fe6f44ede7c096ee256704db0cb41
Please reload this pagehttps://github.com/python/cpython/pull/18057
Lib/concurrent/futures/thread.pyhttps://github.com/python/cpython/pull/18057/files/25376d746a3754acedddcd1c3a779b6f26bc941d#diff-692c518556397eee9681b886c6c7e85af5defbd0759a01f0f39c355d48d1fd75
Please reload this pagehttps://github.com/python/cpython/pull/18057
Lib/concurrent/futures/process.pyhttps://github.com/python/cpython/pull/18057/files/25376d746a3754acedddcd1c3a779b6f26bc941d#diff-84a955ea642d41d9f164e9f94499d8eb33c357ec7f4362a341951f6f67ab21a1
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 25, 2020https://github.com/python/cpython/pull/18057#event-2978998339
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 25, 2020https://github.com/python/cpython/pull/18057#issuecomment-578357947
Please reload this pagehttps://github.com/python/cpython/pull/18057
aeroshttps://github.com/aeros
January 24, 2020 21:38https://github.com/python/cpython/pull/18057#commits-pushed-9a168e4
https://github.com/aeros
Address review feedbackhttps://github.com/python/cpython/pull/18057/commits/9a168e43755056ccced8159eed066df1ab2fe34c
9a168e4https://github.com/python/cpython/pull/18057/commits/9a168e43755056ccced8159eed066df1ab2fe34c
https://github.com/aeros
Add kw-only asterisk to executor.shutdown() docshttps://github.com/python/cpython/pull/18057/commits/7bd8134d4bcf8ad6562299b8da9701eed86c56c5
7bd8134https://github.com/python/cpython/pull/18057/commits/7bd8134d4bcf8ad6562299b8da9701eed86c56c5
https://github.com/aeros
Update code commentshttps://github.com/python/cpython/pull/18057/commits/8b08b2fa8e518012c85ad80497c98f741e836c50
8b08b2fhttps://github.com/python/cpython/pull/18057/commits/8b08b2fa8e518012c85ad80497c98f741e836c50
https://github.com/aeros
Improve future cancellation for PPEhttps://github.com/python/cpython/pull/18057/commits/f706c5f70e65a1570028fa5f8b285747160cd535
f706c5fhttps://github.com/python/cpython/pull/18057/commits/f706c5f70e65a1570028fa5f8b285747160cd535
https://github.com/aeros
Fix race condition and improve testshttps://github.com/python/cpython/pull/18057/commits/bdbc8e399de2d1a82c80f3d16413fe236f03ce78
bdbc8e3https://github.com/python/cpython/pull/18057/commits/bdbc8e399de2d1a82c80f3d16413fe236f03ce78
https://github.com/aeros
https://github.com/brianquinlan
Add TPE test for interpreter exithttps://github.com/python/cpython/pull/18057/commits/41baf767ed0ca76e0e1990ffe2bb0af8863602d0
41baf76https://github.com/python/cpython/pull/18057/commits/41baf767ed0ca76e0e1990ffe2bb0af8863602d0
https://github.com/aeros
Fix whitespacehttps://github.com/python/cpython/pull/18057/commits/bee0e6817f4f9dbc131f199191098c2991103c8e
bee0e68https://github.com/python/cpython/pull/18057/commits/bee0e6817f4f9dbc131f199191098c2991103c8e
https://github.com/aeros
Merge branch 'master' into bpo39349-add-cancel_futures-to-Executor.sh…https://github.com/python/cpython/pull/18057/commits/52c90878f5a3c071337c47d3843a517e4974a994
52c9087https://github.com/python/cpython/pull/18057/commits/52c90878f5a3c071337c47d3843a517e4974a994
https://github.com/aeros
aeroshttps://github.com/aeros
Jan 29, 2020https://github.com/python/cpython/pull/18057#issuecomment-579736841
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Jan 29, 2020https://github.com/python/cpython/pull/18057#event-2989336877
https://github.com/aeros
aeroshttps://github.com/aeros
Jan 31, 2020https://github.com/python/cpython/pull/18057#issuecomment-580915957
Please reload this pagehttps://github.com/python/cpython/pull/18057
@brianquinlanhttps://github.com/brianquinlan
@gvanrossumhttps://github.com/gvanrossum
some attentionhttps://mail.python.org/archives/list/python-ideas@python.org/message/WSE2KMKFMPG2RYSJSGMRZPDJLM7DZKSG/
@pitrouhttps://github.com/pitrou
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/18057
aeroshttps://github.com/aeros
February 1, 2020 00:21https://github.com/python/cpython/pull/18057#commits-pushed-bf75a3e
https://github.com/aeros
Set _cancel_pending_futures before _shutdown_threadhttps://github.com/python/cpython/pull/18057/commits/bf75a3e6e021615104e542c69a1b753efa686807
bf75a3ehttps://github.com/python/cpython/pull/18057/commits/bf75a3e6e021615104e542c69a1b753efa686807
https://github.com/aeros
Set max_workers to 3 in test_cancel_futureshttps://github.com/python/cpython/pull/18057/commits/d756264135053661dde9a9fb7de8579e238d9b9b
d756264https://github.com/python/cpython/pull/18057/commits/d756264135053661dde9a9fb7de8579e238d9b9b
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 1, 2020https://github.com/python/cpython/pull/18057#issuecomment-580998352
Please reload this pagehttps://github.com/python/cpython/pull/18057
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
aeroshttps://github.com/aeros
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Feb 1, 2020https://github.com/python/cpython/pull/18057#event-2999141722
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 1, 2020https://github.com/python/cpython/pull/18057#issuecomment-580998382
@aeroshttps://github.com/aeros
d756264https://github.com/python/cpython/commit/d756264135053661dde9a9fb7de8579e238d9b9b
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Feb 1, 2020https://github.com/python/cpython/pull/18057#event-2999141736
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 1, 2020https://github.com/python/cpython/pull/18057#issuecomment-581060363
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 1, 2020 https://github.com/python/cpython/pull/18057#pullrequestreview-351899671
View reviewed changes https://github.com/python/cpython/pull/18057/files/d756264135053661dde9a9fb7de8579e238d9b9b
pitrouhttps://github.com/pitrou
https://github.com/python/cpython/pull/18057#pullrequestreview-351899671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@aeroshttps://github.com/aeros
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 1, 2020https://github.com/python/cpython/pull/18057#issuecomment-581060638
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 1, 2020https://github.com/python/cpython/pull/18057#issuecomment-581080003
Please reload this pagehttps://github.com/python/cpython/pull/18057
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 1, 2020https://github.com/python/cpython/pull/18057#event-2999664912
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 1, 2020https://github.com/python/cpython/pull/18057#event-2999664920
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 1, 2020https://github.com/python/cpython/pull/18057#issuecomment-581080495
@aeroshttps://github.com/aeros
@brianquinlanhttps://github.com/brianquinlan
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 2, 2020https://github.com/python/cpython/pull/18057#issuecomment-581084338
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 2, 2020 https://github.com/python/cpython/pull/18057#ref-pullrequest-551385874
Inquisitive Investigators python-discord/code-jam-6#5 https://github.com/python-discord/code-jam-6/pull/5
https://github.com/pitrou
pitrouhttps://github.com/pitrou
339fd46https://github.com/python/cpython/commit/339fd46cb764277cbbdc3e78dcc5b45b156bb6ae
Feb 2, 2020https://github.com/python/cpython/pull/18057#event-3000004149
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 2, 2020https://github.com/python/cpython/pull/18057#event-3000004169
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 11, 2020 https://github.com/python/cpython/pull/18057#ref-pullrequest-561963918
bpo-32309: Implement asyncio.ThreadPool #18410 https://github.com/python/cpython/pull/18410
aeroshttps://github.com/aeros
Sep 1, 2020 https://github.com/python/cpython/pull/18057#ref-commit-17dc1b7
https://github.com/hauntsaninja
bpo-39349https://bugs.python.org/issue?@action=redirect&bpo=39349
: Add cancel_futures to Executor.shutdown base class (https://github.com/python/cpython/commit/17dc1b789ecc33b4a254eb3b799085f4b3624ca5
GH-22023https://github.com/python/cpython/pull/22023
)https://github.com/python/cpython/commit/17dc1b789ecc33b4a254eb3b799085f4b3624ca5
17dc1b7https://github.com/python/cpython/commit/17dc1b789ecc33b4a254eb3b799085f4b3624ca5
#18057https://github.com/python/cpython/pull/18057
hauntsaninjahttps://github.com/hauntsaninja
Sep 1, 2020 https://github.com/python/cpython/pull/18057#ref-commit-f6d7427
https://github.com/hauntsaninja
[3.9] bpo-39349: Add cancel_futures to Executor.shutdown base class (https://github.com/hauntsaninja/cpython/commit/f6d74278ec460e70b47bc2719fabc78f76d1151f
p…https://github.com/python/cpython/pull/22023
f6d7427https://github.com/hauntsaninja/cpython/commit/f6d74278ec460e70b47bc2719fabc78f76d1151f
…ythonGH-22023https://github.com/python/cpython/pull/22023
python#18057https://github.com/python/cpython/pull/18057
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Sep 1, 2020 https://github.com/python/cpython/pull/18057#ref-pullrequest-690461289
[3.9] bpo-39349: Add cancel_futures to Executor.shutdown base class (GH-22023) #22048 https://github.com/python/cpython/pull/22048
aeroshttps://github.com/aeros
Sep 2, 2020 https://github.com/python/cpython/pull/18057#ref-commit-a763ee3
https://github.com/hauntsaninja
[3.9]https://github.com/python/cpython/commit/a763ee3c583e6a2dfe1b1ac0600a48e8a978ed50
bpo-39349https://bugs.python.org/issue?@action=redirect&bpo=39349
: Add cancel_futures to Executor.shutdown base class (https://github.com/python/cpython/commit/a763ee3c583e6a2dfe1b1ac0600a48e8a978ed50
G…https://github.com/python/cpython/pull/22023
a763ee3https://github.com/python/cpython/commit/a763ee3c583e6a2dfe1b1ac0600a48e8a978ed50
…H-22023https://github.com/python/cpython/pull/22023
GH-22048https://github.com/python/cpython/pull/22048
#18057https://github.com/python/cpython/pull/18057
xzy3https://github.com/xzy3
Oct 18, 2020 https://github.com/python/cpython/pull/18057#ref-commit-2e88380
https://github.com/hauntsaninja
https://github.com/xzy3-cdc
bpo-39349: Add cancel_futures to Executor.shutdown base class (https://github.com/xzy3/cpython/commit/2e88380a40d8d8292ba0e4b9f32be9fa8465ac0d
python…https://github.com/python/cpython/pull/22023
2e88380https://github.com/xzy3/cpython/commit/2e88380a40d8d8292ba0e4b9f32be9fa8465ac0d
…GH-22023https://github.com/python/cpython/pull/22023
python#18057https://github.com/python/cpython/pull/18057
https://github.com/The-Compiler
The-Compilerhttps://github.com/The-Compiler
May 23, 2022 https://github.com/python/cpython/pull/18057#ref-pullrequest-1245297473
test_concurrent_futures: Remove unneeded/confusing format call #93119 https://github.com/python/cpython/pull/93119
jessecomeau87https://github.com/jessecomeau87
May 20, 2024 https://github.com/python/cpython/pull/18057#ref-commit-97241b5
https://github.com/hauntsaninja
https://github.com/adorilson
bpo-39349: Add cancel_futures to Executor.shutdown base class (GH-22023)https://github.com/jessecomeau87/Python/commit/97241b53c22c1685e287d36384a8af5c7df4633d
97241b5https://github.com/jessecomeau87/Python/commit/97241b53c22c1685e287d36384a8af5c7df4633d
python/cpython#18057https://github.com/python/cpython/pull/18057
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
Mar 8, 2025 https://github.com/python/cpython/pull/18057#ref-issue-2904733598
Cancel futures if concurrent.futures.Executor is used as a context manager and there is an exception? #130975 https://github.com/python/cpython/issues/130975
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F18057
https://github.com/pitrou
pitrou https://github.com/pitrou
https://github.com/python/cpython/pull/18057/files/d756264135053661dde9a9fb7de8579e238d9b9b
https://github.com/brianquinlan
brianquinlan https://github.com/brianquinlan
https://github.com/python/cpython/pull/18057/files/52c90878f5a3c071337c47d3843a517e4974a994
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Please reload this pagehttps://github.com/python/cpython/pull/18057
https://github.com/aeros
https://github.com/gvanrossum
https://github.com/bedevere-bot
https://github.com/brianquinlan
https://github.com/pitrou
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.