Title: bpo-38076: Fix crash on shutdown caused by PEP-384ification of _struct by DinoV · Pull Request #18038 · python/cpython · GitHub
Open Graph Title: bpo-38076: Fix crash on shutdown caused by PEP-384ification of _struct by DinoV · Pull Request #18038 · python/cpython
X Title: bpo-38076: Fix crash on shutdown caused by PEP-384ification of _struct by DinoV · Pull Request #18038 · python/cpython
Description: I think this is a partial fix for _struct crashing on shutdown after the PEP-384ification of it when using the multi-processing class with a finalizer: from multiprocessing.pool import Pool class A(object): def init(self): self.pool = Pool() def del(self): self.pool.close() self.pool.join() a = A() Although I still see this hanging on Linux instead of cleaning shutting down. There are still some other issues related to shutdown that this doesn't yet fix. Fixing other cases will likely require storing the module object off of the struct type object so that it can be retrieved later. Feedback welcome, it might be better to fix this in a global manner by changing the finalization code to not clear the module list so early, but that seems like a much more significant change. https://bugs.python.org/issue38076
Open Graph Description: I think this is a partial fix for _struct crashing on shutdown after the PEP-384ification of it when using the multi-processing class with a finalizer: from multiprocessing.pool import Pool class A...
X Description: I think this is a partial fix for _struct crashing on shutdown after the PEP-384ification of it when using the multi-processing class with a finalizer: from multiprocessing.pool import Pool class A...
Opengraph URL: https://github.com/python/cpython/pull/18038
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5166aa2b-6347-cad9-78c5-addda194cdf7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 85E6:31622E:615065:8A345B:696A53B1 |
| html-safe-nonce | 425c074964795f7fad66e9d03c5538df6550f2ad11095828a24af9d26488d420 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUU2OjMxNjIyRTo2MTUwNjU6OEEzNDVCOjY5NkE1M0IxIiwidmlzaXRvcl9pZCI6IjQ2MjMwNDQxMTcwNDQ4MTA2NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 92635e9b2e2627c1af28ab9c33d327d1c246e505400d029257451a4def122b7c |
| hovercard-subject-tag | pull_request:364258996 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/18038/files |
| twitter:image | https://avatars.githubusercontent.com/u/320265?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/320265?s=400&v=4 |
| og:image:alt | I think this is a partial fix for _struct crashing on shutdown after the PEP-384ification of it when using the multi-processing class with a finalizer: from multiprocessing.pool import Pool class A... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width