René's URL Explorer Experiment


Title: bpo-30465: Fix lineno and col_offset in fstring AST nodes by ambv · Pull Request #1800 · python/cpython · GitHub

Open Graph Title: bpo-30465: Fix lineno and col_offset in fstring AST nodes by ambv · Pull Request #1800 · python/cpython

X Title: bpo-30465: Fix lineno and col_offset in fstring AST nodes by ambv · Pull Request #1800 · python/cpython

Description: f-strings are computed in a separate compiler step. This makes their lineno and col_offset information wrong. This is problematic for flake8 which reports problems inside f-strings on the wrong line (typically the first one in the file). Attached patch fixes the issue. https://bugs.python.org/issue30465

Open Graph Description: f-strings are computed in a separate compiler step. This makes their lineno and col_offset information wrong. This is problematic for flake8 which reports problems inside f-strings on the wrong lin...

X Description: f-strings are computed in a separate compiler step. This makes their lineno and col_offset information wrong. This is problematic for flake8 which reports problems inside f-strings on the wrong lin...

Opengraph URL: https://github.com/python/cpython/pull/1800

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a1b3c97f-251e-6485-20f6-1243993bf54a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE98A:2BEEEA:12C510E:1960A4C:6A557942
html-safe-nonce0c93bf648128bea88e27f3a14e480955db4d89f1b3f5b2da6ef05d86fa1e857f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOThBOjJCRUVFQToxMkM1MTBFOjE5NjBBNEM6NkE1NTc5NDIiLCJ2aXNpdG9yX2lkIjoiNDI4MDQ1NDU0NzQ1NjIyNzY1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb44eda91ab48c44a5781b76ee3441611a82dc3b971f2b0687ab65e320e503bc1
hovercard-subject-tagpull_request:122340810
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/1800/files
twitter:imagehttps://avatars.githubusercontent.com/u/55281?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55281?s=400&v=4
og:image:altf-strings are computed in a separate compiler step. This makes their lineno and col_offset information wrong. This is problematic for flake8 which reports problems inside f-strings on the wrong lin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release617ea94e2807dc3052601c560530bb3f8259bc9a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1800/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1800%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1800%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1800/files
Reloadhttps://github.com/python/cpython/pull/1800/files
Reloadhttps://github.com/python/cpython/pull/1800/files
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericvsmithhttps://github.com/ericvsmith
python:masterhttps://github.com/python/cpython/tree/master
ambv:fstring_linenohttps://github.com/ambv/cpython/tree/fstring_lineno
Conversation 28 https://github.com/python/cpython/pull/1800
Commits 1 https://github.com/python/cpython/pull/1800/commits
Checks 0 https://github.com/python/cpython/pull/1800/checks
Files changed https://github.com/python/cpython/pull/1800/files
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
bpo-30465: Fix lineno and col_offset in fstring AST nodes https://github.com/python/cpython/pull/1800/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/1800/files
412b119 bpo-30465: Fix lineno and col_offset in fstring AST nodes May 24, 2017 https://github.com/python/cpython/pull/1800/commits/412b1199d5455b759731d4971d261b3d202fbc3b
Clear filters https://github.com/python/cpython/pull/1800/files
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
test_fstring.py https://github.com/python/cpython/pull/1800/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
2017-09-06-10-47-29.bpo-30465.oe-3GD.rst https://github.com/python/cpython/pull/1800/files#diff-aa64424a48e1762f05172a7830912187a315ee2ed0cc337a489f28190d4b231c
ast.c https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
Lib/test/test_fstring.pyhttps://github.com/python/cpython/pull/1800/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
View file https://github.com/ambv/cpython/blob/412b1199d5455b759731d4971d261b3d202fbc3b/Lib/test/test_fstring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1800/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1800/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
ericvsmithhttps://github.com/ericvsmith
Sep 6, 2017https://github.com/python/cpython/pull/1800/files#r137402282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
ericvsmithhttps://github.com/ericvsmith
Sep 6, 2017https://github.com/python/cpython/pull/1800/files#r137406159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
bpo-31140https://bugs.python.org/issue?@action=redirect&bpo=31140
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
https://github.com/python/cpython/pull/1800/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
https://github.com/python/cpython/pull/1800/files#diff-8c1fe2af639c01d0d8e2368a8ab4ed407b1df4a3411e273b3fd5d0278ceb7393
Misc/NEWS.d/next/Core and Builtins/2017-09-06-10-47-29.bpo-30465.oe-3GD.rsthttps://github.com/python/cpython/pull/1800/files#diff-aa64424a48e1762f05172a7830912187a315ee2ed0cc337a489f28190d4b231c
View file https://github.com/ambv/cpython/blob/412b1199d5455b759731d4971d261b3d202fbc3b/Misc/NEWS.d/next/Core%20and%20Builtins/2017-09-06-10-47-29.bpo-30465.oe-3GD.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1800/{{ revealButtonHref }}
Python/ast.chttps://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
View file https://github.com/ambv/cpython/blob/412b1199d5455b759731d4971d261b3d202fbc3b/Python/ast.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1800/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
serhiy-storchakahttps://github.com/serhiy-storchaka
May 30, 2017https://github.com/python/cpython/pull/1800/files#r119179030
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
ambvhttps://github.com/ambv
Jun 1, 2017https://github.com/python/cpython/pull/1800/files#r119736258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 5, 2017https://github.com/python/cpython/pull/1800/files#r120188772
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
ambvhttps://github.com/ambv
Sep 5, 2017https://github.com/python/cpython/pull/1800/files#r137085646
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
serhiy-storchakahttps://github.com/serhiy-storchaka
May 30, 2017https://github.com/python/cpython/pull/1800/files#r119175438
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
ambvhttps://github.com/ambv
Jun 1, 2017https://github.com/python/cpython/pull/1800/files#r119735985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 6, 2017https://github.com/python/cpython/pull/1800/files#r120283625
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
ambvhttps://github.com/ambv
Sep 6, 2017https://github.com/python/cpython/pull/1800/files#r137327060
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
ericvsmithhttps://github.com/ericvsmith
Sep 6, 2017https://github.com/python/cpython/pull/1800/files#r137403086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
serhiy-storchakahttps://github.com/serhiy-storchaka
May 30, 2017https://github.com/python/cpython/pull/1800/files#r119170026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
ambvhttps://github.com/ambv
Jun 1, 2017https://github.com/python/cpython/pull/1800/files#r119734886
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1800/files
https://github.com/python/cpython/pull/1800/files#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.