René's URL Explorer Experiment


Title: bpo-39235: Fix end location for genexp in call args by gvanrossum · Pull Request #17925 · python/cpython · GitHub

Open Graph Title: bpo-39235: Fix end location for genexp in call args by gvanrossum · Pull Request #17925 · python/cpython

X Title: bpo-39235: Fix end location for genexp in call args by gvanrossum · Pull Request #17925 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The fix changes copy_location() to require an extra node from which to extract the end location, and fixing all 5 call sites. https://bugs.python.org/issue39235 Automerge-Triggered-By: @gvanrossum

X Description: The fix changes copy_location() to require an extra node from which to extract the end location, and fixing all 5 call sites. https://bugs.python.org/issue39235 Automerge-Triggered-By: @gvanrossum

Opengraph URL: https://github.com/python/cpython/pull/17925

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b236f1eb-11eb-e494-bd23-ecae8818eba2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEE0A:3B4DC0:2B7E09:3A2682:6A558DBC
html-safe-nonce5858db63f4e01a66b28af138f13ae9678d6ea4192693563f7a4fabc419567220
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTBBOjNCNERDMDoyQjdFMDk6M0EyNjgyOjZBNTU4REJDIiwidmlzaXRvcl9pZCI6IjQ2NTU0NjYxNDY1NzI4OTc3MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5598da2c293b751d0377cc8b1008054c7dea5324eb80d10d40f58a45e0ef096
hovercard-subject-tagpull_request:361085063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/17925/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5cdcc616eac6edcb286aa13012c422094d070a8167957b519fbe1df1c0a12b76/python/cpython/pull/17925
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5cdcc616eac6edcb286aa13012c422094d070a8167957b519fbe1df1c0a12b76/python/cpython/pull/17925
og:image:altThe fix changes copy_location() to require an extra node from which to extract the end location, and fixing all 5 call sites. https://bugs.python.org/issue39235 Automerge-Triggered-By: @gvanrossum
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegvanrossum
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaa21baa44893467b0b640d0300538f84ca8c475b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/17925#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17925
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17925
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/17925
Reloadhttps://github.com/python/cpython/pull/17925
Reloadhttps://github.com/python/cpython/pull/17925
Please reload this pagehttps://github.com/python/cpython/pull/17925
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/17925
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
miss-islingtonhttps://github.com/miss-islington
masterhttps://github.com/python/cpython/tree/master
bpo-39235-genexp-endlochttps://github.com/python/cpython/tree/bpo-39235-genexp-endloc
Conversationhttps://github.com/python/cpython/pull/17925
Commits2 (2)https://github.com/python/cpython/pull/17925/commits
Checkshttps://github.com/python/cpython/pull/17925/checks
Files changedhttps://github.com/python/cpython/pull/17925/files
bpo-39235: Fix end location for genexp in call argshttps://github.com/python/cpython/pull/17925#top
miss-islingtonhttps://github.com/miss-islington
masterhttps://github.com/python/cpython/tree/master
bpo-39235-genexp-endlochttps://github.com/python/cpython/tree/bpo-39235-genexp-endloc
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 9, 2020https://github.com/python/cpython/pull/17925#issue-547631347
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://bugs.python.org/issue39235https://bugs.python.org/issue39235
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/gvanrossum
bpo-39235https://bugs.python.org/issue?@action=redirect&bpo=39235
: fix end location for genexp in call argshttps://github.com/python/cpython/pull/17925/commits/47298c89e83d7563b668598b1ceeee4f9e4ec648
47298c8https://github.com/python/cpython/pull/17925/commits/47298c89e83d7563b668598b1ceeee4f9e4ec648
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2935895566
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2935895676
https://github.com/gvanrossum
Add blurbhttps://github.com/python/cpython/pull/17925/commits/7c7861bfafbc1f2fd6af26e95480ac3c80212c14
7c7861bhttps://github.com/python/cpython/pull/17925/commits/7c7861bfafbc1f2fd6af26e95480ac3c80212c14
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
pablogsalhttps://github.com/pablogsal
January 9, 2020 18:02https://github.com/python/cpython/pull/17925#event-2935914643
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2935916060
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Jan 9, 2020 https://github.com/python/cpython/pull/17925#pullrequestreview-340713354
View reviewed changes https://github.com/python/cpython/pull/17925/files/7c7861bfafbc1f2fd6af26e95480ac3c80212c14
Python/ast.chttps://github.com/python/cpython/pull/17925/files/7c7861bfafbc1f2fd6af26e95480ac3c80212c14#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
lysnikolaouhttps://github.com/lysnikolaou
Jan 9, 2020https://github.com/python/cpython/pull/17925#discussion_r364884857
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17925
gvanrossumhttps://github.com/gvanrossum
Jan 9, 2020https://github.com/python/cpython/pull/17925#discussion_r364903232
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
bpo-31241https://bugs.python.org/issue?@action=redirect&bpo=31241
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Jan 9, 2020https://github.com/python/cpython/pull/17925#issuecomment-572685911
Please reload this pagehttps://github.com/python/cpython/pull/17925
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2020 https://github.com/python/cpython/pull/17925#pullrequestreview-340741878
View reviewed changes https://github.com/python/cpython/pull/17925/files/7c7861bfafbc1f2fd6af26e95480ac3c80212c14
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/17925#pullrequestreview-340741878
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2936067582
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jan 9, 2020https://github.com/python/cpython/pull/17925#issuecomment-572707855
#17926https://github.com/python/cpython/pull/17926
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2936107650
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 9, 2020 https://github.com/python/cpython/pull/17925#ref-pullrequest-547662673
bpo-39235: Check end_lineno and end_col_offset of AST nodes. #17926 https://github.com/python/cpython/pull/17926
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 9, 2020https://github.com/python/cpython/pull/17925#issuecomment-572711269
@pablogsalhttps://github.com/pablogsal
GH-17926https://github.com/python/cpython/pull/17926
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Jan 9, 2020https://github.com/python/cpython/pull/17925#issuecomment-572711415
Please reload this pagehttps://github.com/python/cpython/pull/17925
@asottilehttps://github.com/asottile
#17582https://github.com/python/cpython/pull/17582
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2936141010
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
a796d8ehttps://github.com/python/cpython/commit/a796d8ef9dd1af65f7e4d7a857b56f35b7cb6e78
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2936141265
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
January 9, 2020 19:18https://github.com/python/cpython/pull/17925#event-2936141352
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jan 9, 2020https://github.com/python/cpython/pull/17925#issuecomment-572712474
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2936141439
miss-islingtonhttps://github.com/miss-islington
Jan 9, 2020 https://github.com/python/cpython/pull/17925#ref-commit-26bf99a
https://github.com/gvanrossum
https://github.com/miss-islington
bpo-39235: Fix end location for genexp in call args (https://github.com/miss-islington/cpython/commit/26bf99a2b0f4a12f62e51fb95af79736ee894a5c
pythonGH-17925https://github.com/python/cpython/pull/17925
)https://github.com/miss-islington/cpython/commit/26bf99a2b0f4a12f62e51fb95af79736ee894a5c
26bf99ahttps://github.com/miss-islington/cpython/commit/26bf99a2b0f4a12f62e51fb95af79736ee894a5c
https://bugs.python.org/issue39235https://bugs.python.org/issue39235
a796d8ehttps://github.com/miss-islington/cpython/commit/a796d8ef9dd1af65f7e4d7a857b56f35b7cb6e78
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 9, 2020https://github.com/python/cpython/pull/17925#issuecomment-572712565
GH-17927https://github.com/python/cpython/pull/17927
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Jan 9, 2020https://github.com/python/cpython/pull/17925#event-2936142082
miss-islingtonhttps://github.com/miss-islington
Jan 9, 2020 https://github.com/python/cpython/pull/17925#ref-commit-33e033d
https://github.com/miss-islington
https://github.com/gvanrossum
bpo-39235https://bugs.python.org/issue?@action=redirect&bpo=39235
: Fix end location for genexp in call args (https://github.com/python/cpython/commit/33e033da3c1472b0aa2ae3cff06649a1ae4aa37f
GH-17925https://github.com/python/cpython/pull/17925
)https://github.com/python/cpython/commit/33e033da3c1472b0aa2ae3cff06649a1ae4aa37f
33e033dhttps://github.com/python/cpython/commit/33e033da3c1472b0aa2ae3cff06649a1ae4aa37f
https://bugs.python.org/issue39235https://bugs.python.org/issue39235
a796d8ehttps://github.com/python/cpython/commit/a796d8ef9dd1af65f7e4d7a857b56f35b7cb6e78
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Jan 9, 2020https://github.com/python/cpython/pull/17925#issuecomment-572731422
@pablogsalhttps://github.com/pablogsal
GH-17926https://github.com/python/cpython/pull/17926
GH-17926https://github.com/python/cpython/pull/17926
Please reload this pagehttps://github.com/python/cpython/pull/17925
sthagenhttps://github.com/sthagen
Jan 10, 2020 https://github.com/python/cpython/pull/17925#ref-commit-57f7679
https://github.com/sthagen
Merge pull requesthttps://github.com/sthagen/python-cpython/commit/57f76798fe1b06a8c516afc1a5c79e9f1bf9391a
#158https://github.com/sthagen/python-cpython/pull/158
from python/masterhttps://github.com/sthagen/python-cpython/commit/57f76798fe1b06a8c516afc1a5c79e9f1bf9391a
57f7679https://github.com/sthagen/python-cpython/commit/57f76798fe1b06a8c516afc1a5c79e9f1bf9391a
pythonGH-17925https://github.com/python/cpython/pull/17925
shihai1991https://github.com/shihai1991
Jan 31, 2020 https://github.com/python/cpython/pull/17925#ref-commit-926e087
https://github.com/gvanrossum
https://github.com/shihai1991
bpo-39235: Fix end location for genexp in call args (https://github.com/shihai1991/cpython/commit/926e087940d3d99b8eefddfdb37dbd1676425f7f
pythonGH-17925https://github.com/python/cpython/pull/17925
)https://github.com/shihai1991/cpython/commit/926e087940d3d99b8eefddfdb37dbd1676425f7f
926e087https://github.com/shihai1991/cpython/commit/926e087940d3d99b8eefddfdb37dbd1676425f7f
https://bugs.python.org/issue39235https://bugs.python.org/issue39235
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17925
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/python/cpython/pull/17925/files/7c7861bfafbc1f2fd6af26e95480ac3c80212c14
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/17925/files/7c7861bfafbc1f2fd6af26e95480ac3c80212c14
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/17925
https://github.com/gvanrossum
https://github.com/pablogsal
https://github.com/serhiy-storchaka
https://github.com/lysnikolaou
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.