René's URL Explorer Experiment


Title: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. by pdonis · Pull Request #17385 · python/cpython · GitHub

Open Graph Title: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. by pdonis · Pull Request #17385 · python/cpython

X Title: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. by pdonis · Pull Request #17385 · python/cpython

Description: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. This pull request fixes the newline conversion bug originally reported in issue 1812. When that issue was originally submitted, the open builtin did not default to universal newline mode; now it does, which makes the issue fix simpler, since the only code path that needs to be changed is the one in doctest._load_testfile where the file is loaded from a package whose loader has a get_data method. Commit b6ad8ee contains the change that implements the fix. This pull request also adds a test that verifies that doctest.testfile does the newline conversion correctly when loading from a package whose loader has a get_data method. This test fails (a ValueError is raised for inconsistent whitespace) unless the change in commit b6ad8ee is applied. Commit dd02845 contains the changes that add the test; the test is added to the test_lineendings docstring along with supporting comments. Also, the test_lineendings docstring is missing a test to check for correct handling of the old-style Mac newline \r. This pull request adds that case to the original test_lineendings docstring. Commit da35562 contains the changes that add this test and edit the surrounding comments accordingly. Finally, this pull request contains commit 22094c8 that adds my name to the MISC/Acks file. https://bugs.python.org/issue1812

Open Graph Description: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. This pull request fixes the newline conversion bug originally reported in issue 1812....

X Description: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. This pull request fixes the newline conversion bug originally reported in issue 1812....

Opengraph URL: https://github.com/python/cpython/pull/17385

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ba5015b3-f62c-62dc-a9a2-a184aa496638
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A40:37C36E:119DA8:1896C6:6B006493
html-safe-nonceff0db975f3502b2f1a3fcad49a1dfe35d13ff521b86633663536c66c10c922ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTQwOjM3QzM2RToxMTlEQTg6MTg5NkM2OjZCMDA2NDkzIiwidmlzaXRvcl9pZCI6IjY2MDQ5Mjc2ODE3MDIxNTk1MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdfa422f7861ae84ecd3f95dc0d2b05e823774d9089c79b2a245d9a1dbcb6d634
hovercard-subject-tagpull_request:345484931
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/17385/files
twitter:imagehttps://avatars.githubusercontent.com/u/1264258?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1264258?s=400&v=4
og:image:altbpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. This pull request fixes the newline conversion bug originally reported in issue 1812....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/17385/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17385%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17385%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/17385/files
Reloadhttps://github.com/python/cpython/pull/17385/files
Reloadhttps://github.com/python/cpython/pull/17385/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zwarehttps://github.com/zware
python:masterhttps://github.com/python/cpython/tree/master
pdonis:fix-issue-1812https://github.com/pdonis/cpython/tree/fix-issue-1812
Conversation 31 https://github.com/python/cpython/pull/17385
Commits 14 https://github.com/python/cpython/pull/17385/commits
Checks 0 https://github.com/python/cpython/pull/17385/checks
Files changed https://github.com/python/cpython/pull/17385/files
Please reload this pagehttps://github.com/python/cpython/pull/17385/files
bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. https://github.com/python/cpython/pull/17385/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/17385/files
da35562 bpo-1812: Add old-style Mac newline test to test_doctest.test_lineend… pdonis Nov 24, 2019 https://github.com/python/cpython/pull/17385/commits/da35562119feb1cf064bbc4aa47bfc69109d6a5f
dd02845 bpo-1812: Add test to test_doctest.test_lineendings that loads testfi… pdonis Nov 24, 2019 https://github.com/python/cpython/pull/17385/commits/dd0284510a0c7e67cfad407593b955399f8ca990
59370c5 Merge branch 'master' into fix-issue-1812 pdonis Nov 24, 2019 https://github.com/python/cpython/pull/17385/commits/59370c51eaf78d384414e731c78d8e2cca5b25ed
b6ad8ee bpo-1812: Fix newline conversion when loading doctest testfile from p… pdonis Nov 24, 2019 https://github.com/python/cpython/pull/17385/commits/b6ad8ee30fc3d1596d06b8ec49a1c0bf00cf1208
22094c8 Add Peter Donis to Misc/ACKS. pdonis Nov 24, 2019 https://github.com/python/cpython/pull/17385/commits/22094c8e6a372ccf4eded8cf27009ead183278ed
80977d7 Merge branch 'master' into fix-issue-1812 pdonis Nov 24, 2019 https://github.com/python/cpython/pull/17385/commits/80977d7dd6aa05a5b572b3121c6e930933282a6b
74471ec Merge branch 'master' into fix-issue-1812 pdonis Nov 26, 2019 https://github.com/python/cpython/pull/17385/commits/74471ec3d36adcbb374e63e16634109a8ecf1da2
83c03d8 Add MISC/NEWS.d blurb. pdonis Nov 26, 2019 https://github.com/python/cpython/pull/17385/commits/83c03d8d09edc13c4901f534b9bb9c2915c4f02d
efabd42 Update Lib/test/test_doctest.py pdonis Feb 13, 2020 https://github.com/python/cpython/pull/17385/commits/efabd422baabefdabde4e10bddb9def221967f2f
1d56c05 Fix typo in commit efabd422. pdonis Feb 13, 2020 https://github.com/python/cpython/pull/17385/commits/1d56c0561080cffd1f32f009000f9c6ac803aa0b
e1f0a2f bpo-1812: Wrap package hook test in context manager. pdonis Feb 13, 2020 https://github.com/python/cpython/pull/17385/commits/e1f0a2fa466138febe2f807ee63afd1cd7915e34
4664f1e Merge branch 'master' into fix-issue-1812 pdonis Feb 22, 2020 https://github.com/python/cpython/pull/17385/commits/4664f1ee68d3ea812f38c5b17ba8918467626c4c
860f835 Merge branch 'master' into fix-issue-1812 pdonis Mar 16, 2020 https://github.com/python/cpython/pull/17385/commits/860f835e8df6309e676f16b505914caade30b66a
bb836d7 bpo-1812: Change TestLoader to TestImporter. pdonis Mar 16, 2020 https://github.com/python/cpython/pull/17385/commits/bb836d71b3743e8d00812f2535ad69b37080461b
Clear filters https://github.com/python/cpython/pull/17385/files
Please reload this pagehttps://github.com/python/cpython/pull/17385/files
Please reload this pagehttps://github.com/python/cpython/pull/17385/files
doctest.py https://github.com/python/cpython/pull/17385/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
test_doctest.py https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
ACKS https://github.com/python/cpython/pull/17385/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2019-11-25-21-46-47.bpo-1812.sAbTbY.rst https://github.com/python/cpython/pull/17385/files#diff-e0293909b5c7f34da234c2997814db2ca08afe609438d1d94e3966da7b9c76db
Lib/doctest.pyhttps://github.com/python/cpython/pull/17385/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
View file https://github.com/pdonis/cpython/blob/bb836d71b3743e8d00812f2535ad69b37080461b/Lib/doctest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/17385/{{ revealButtonHref }}
https://github.com/python/cpython/pull/17385/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com/python/cpython/pull/17385/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
Please reload this pagehttps://github.com/python/cpython/pull/17385/files
https://github.com/python/cpython/pull/17385/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
View file https://github.com/pdonis/cpython/blob/bb836d71b3743e8d00812f2535ad69b37080461b/Lib/test/test_doctest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/17385/{{ revealButtonHref }}
https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
Please reload this pagehttps://github.com/python/cpython/pull/17385/files
ammaraskarhttps://github.com/ammaraskar
Feb 21, 2020https://github.com/python/cpython/pull/17385/files#r382774736
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/master/Lib/test/test_importlib/fixtures.pyhttps://github.com/python/cpython/blob/master/Lib/test/test_importlib/fixtures.py
cpython/Lib/test/test_importlib/fixtures.pyhttps://github.com/python/cpython/blob/fd5116c0e77aec05f67fb24f10562ac920648035/Lib/test/test_importlib/fixtures.py#L71-L83
fd5116chttps://github.com/python/cpython/commit/fd5116c0e77aec05f67fb24f10562ac920648035
cpython/Lib/test/test_importlib/fixtures.pyhttps://github.com/python/cpython/blob/fd5116c0e77aec05f67fb24f10562ac920648035/Lib/test/test_importlib/fixtures.py#L50-L56
fd5116chttps://github.com/python/cpython/commit/fd5116c0e77aec05f67fb24f10562ac920648035
Please reload this pagehttps://github.com/python/cpython/pull/17385/files
pdonishttps://github.com/pdonis
Feb 22, 2020https://github.com/python/cpython/pull/17385/files#r382895629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17385/files
https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
https://github.com/python/cpython/pull/17385/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
Misc/ACKShttps://github.com/python/cpython/pull/17385/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/pdonis/cpython/blob/bb836d71b3743e8d00812f2535ad69b37080461b/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/17385/{{ revealButtonHref }}
https://github.com/python/cpython/pull/17385/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/17385/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Tests/2019-11-25-21-46-47.bpo-1812.sAbTbY.rsthttps://github.com/python/cpython/pull/17385/files#diff-e0293909b5c7f34da234c2997814db2ca08afe609438d1d94e3966da7b9c76db
View file https://github.com/pdonis/cpython/blob/bb836d71b3743e8d00812f2535ad69b37080461b/Misc/NEWS.d/next/Tests/2019-11-25-21-46-47.bpo-1812.sAbTbY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/17385/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.