René's URL Explorer Experiment


Title: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. by pdonis · Pull Request #17385 · python/cpython · GitHub

Open Graph Title: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. by pdonis · Pull Request #17385 · python/cpython

X Title: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. by pdonis · Pull Request #17385 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. This pull request fixes the newline conversion bug originally reported in issue 1812....

X Description: bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. This pull request fixes the newline conversion bug originally reported in issue 1812....

Opengraph URL: https://github.com/python/cpython/pull/17385

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f1267f40-e6b8-6794-1b28-23aa35356221
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA45C:11842E:6FF44:9B368:6B0061BD
html-safe-noncef4255a24a2f15797baea70de6e22c06133d3afff05edc7e6b48ebd17fb0723c5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDVDOjExODQyRTo2RkY0NDo5QjM2ODo2QjAwNjFCRCIsInZpc2l0b3JfaWQiOiI0ODQzMTI2Mjc3MjAyMjcyNzAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6052ee1fd1922f30b4ae56e0fd0e2f3a61bf56d186519d238128b6eb3476fa03
hovercard-subject-tagpull_request:345484931
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/17385/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6378d26de3e403e10ab127595a8e5e6ef2073248ba90df6e32431c179c9deece/python/cpython/pull/17385
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6378d26de3e403e10ab127595a8e5e6ef2073248ba90df6e32431c179c9deece/python/cpython/pull/17385
og:image:altbpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method. This pull request fixes the newline conversion bug originally reported in issue 1812....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepdonis
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/17385#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17385
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17385
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/17385
Reloadhttps://github.com/python/cpython/pull/17385
Reloadhttps://github.com/python/cpython/pull/17385
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
zwarehttps://github.com/zware
python:masterhttps://github.com/python/cpython/tree/master
pdonis:fix-issue-1812https://github.com/pdonis/cpython/tree/fix-issue-1812
Conversationhttps://github.com/python/cpython/pull/17385
Commits14 (14)https://github.com/python/cpython/pull/17385/commits
Checkshttps://github.com/python/cpython/pull/17385/checks
Files changedhttps://github.com/python/cpython/pull/17385/files
bpo-1812: Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method.https://github.com/python/cpython/pull/17385#top
zwarehttps://github.com/zware
python:masterhttps://github.com/python/cpython/tree/master
pdonis:fix-issue-1812https://github.com/pdonis/cpython/tree/fix-issue-1812
https://github.com/pdonis
pdonishttps://github.com/pdonis
Nov 26, 2019https://github.com/python/cpython/pull/17385#issue-528418649
Please reload this pagehttps://github.com/python/cpython/pull/17385
bpo-1812https://bugs.python.org/issue1812
https://bugs.python.org/issue1812https://bugs.python.org/issue1812
Please reload this pagehttps://github.com/python/cpython/pull/17385
pdonishttps://github.com/pdonis
November 23, 2019 23:35https://github.com/python/cpython/pull/17385#commits-pushed-da35562
https://github.com/pdonis
bpo-1812: Add old-style Mac newline test to test_doctest.test_lineend…https://github.com/python/cpython/pull/17385/commits/da35562119feb1cf064bbc4aa47bfc69109d6a5f
da35562https://github.com/python/cpython/pull/17385/commits/da35562119feb1cf064bbc4aa47bfc69109d6a5f
https://github.com/pdonis
bpo-1812: Add test to test_doctest.test_lineendings that loads testfi…https://github.com/python/cpython/pull/17385/commits/dd0284510a0c7e67cfad407593b955399f8ca990
dd02845https://github.com/python/cpython/pull/17385/commits/dd0284510a0c7e67cfad407593b955399f8ca990
https://github.com/pdonis
Merge branch 'master' into fix-issue-1812https://github.com/python/cpython/pull/17385/commits/59370c51eaf78d384414e731c78d8e2cca5b25ed
59370c5https://github.com/python/cpython/pull/17385/commits/59370c51eaf78d384414e731c78d8e2cca5b25ed
https://github.com/pdonis
bpo-1812: Fix newline conversion when loading doctest testfile from p…https://github.com/python/cpython/pull/17385/commits/b6ad8ee30fc3d1596d06b8ec49a1c0bf00cf1208
b6ad8eehttps://github.com/python/cpython/pull/17385/commits/b6ad8ee30fc3d1596d06b8ec49a1c0bf00cf1208
https://github.com/pdonis
Add Peter Donis to Misc/ACKS.https://github.com/python/cpython/pull/17385/commits/22094c8e6a372ccf4eded8cf27009ead183278ed
22094c8https://github.com/python/cpython/pull/17385/commits/22094c8e6a372ccf4eded8cf27009ead183278ed
https://github.com/pdonis
Merge branch 'master' into fix-issue-1812https://github.com/python/cpython/pull/17385/commits/80977d7dd6aa05a5b572b3121c6e930933282a6b
80977d7https://github.com/python/cpython/pull/17385/commits/80977d7dd6aa05a5b572b3121c6e930933282a6b
https://github.com/pdonis
Merge branch 'master' into fix-issue-1812https://github.com/python/cpython/pull/17385/commits/74471ec3d36adcbb374e63e16634109a8ecf1da2
74471echttps://github.com/python/cpython/pull/17385/commits/74471ec3d36adcbb374e63e16634109a8ecf1da2
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Nov 26, 2019https://github.com/python/cpython/pull/17385#event-2830121395
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 26, 2019https://github.com/python/cpython/pull/17385#event-2830121441
https://github.com/pdonis
pdonishttps://github.com/pdonis
Nov 26, 2019https://github.com/python/cpython/pull/17385#event-2830123811
https://github.com/pdonis
Add MISC/NEWS.d blurb.https://github.com/python/cpython/pull/17385/commits/83c03d8d09edc13c4901f534b9bb9c2915c4f02d
83c03d8https://github.com/python/cpython/pull/17385/commits/83c03d8d09edc13c4901f534b9bb9c2915c4f02d
https://github.com/zware
zwarehttps://github.com/zware
Feb 12, 2020 https://github.com/python/cpython/pull/17385#pullrequestreview-357174607
View reviewed changes https://github.com/python/cpython/pull/17385/files/83c03d8d09edc13c4901f534b9bb9c2915c4f02d
zwarehttps://github.com/zware
https://github.com/python/cpython/pull/17385#pullrequestreview-357174607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17385
Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/17385/files/83c03d8d09edc13c4901f534b9bb9c2915c4f02d#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
Please reload this pagehttps://github.com/python/cpython/pull/17385
Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/17385/files/83c03d8d09edc13c4901f534b9bb9c2915c4f02d#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Feb 12, 2020https://github.com/python/cpython/pull/17385#event-3029411386
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 12, 2020https://github.com/python/cpython/pull/17385#issuecomment-585055440
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/aeros
aeroshttps://github.com/aeros
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Feb 12, 2020https://github.com/python/cpython/pull/17385#event-3029544319
https://github.com/zware
zwarehttps://github.com/zware
Feb 12, 2020https://github.com/python/cpython/pull/17385#issuecomment-585060167
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/zware
zwarehttps://github.com/zware
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Feb 12, 2020https://github.com/python/cpython/pull/17385#event-3029580695
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 12, 2020https://github.com/python/cpython/pull/17385#issuecomment-585093578
Please reload this pagehttps://github.com/python/cpython/pull/17385
Please reload this pagehttps://github.com/python/cpython/pull/17385
pdonishttps://github.com/pdonis
February 12, 2020 19:51https://github.com/python/cpython/pull/17385#commits-pushed-efabd42
https://github.com/pdonis
https://github.com/zware
Update Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/17385/commits/efabd422baabefdabde4e10bddb9def221967f2f
efabd42https://github.com/python/cpython/pull/17385/commits/efabd422baabefdabde4e10bddb9def221967f2f
https://github.com/pdonis
Fix typo in commithttps://github.com/python/cpython/pull/17385/commits/1d56c0561080cffd1f32f009000f9c6ac803aa0b
efabd42https://github.com/pdonis/cpython/commit/efabd422baabefdabde4e10bddb9def221967f2f
.https://github.com/python/cpython/pull/17385/commits/1d56c0561080cffd1f32f009000f9c6ac803aa0b
1d56c05https://github.com/python/cpython/pull/17385/commits/1d56c0561080cffd1f32f009000f9c6ac803aa0b
https://github.com/pdonis
bpo-1812: Wrap package hook test in context manager.https://github.com/python/cpython/pull/17385/commits/e1f0a2fa466138febe2f807ee63afd1cd7915e34
e1f0a2fhttps://github.com/python/cpython/pull/17385/commits/e1f0a2fa466138febe2f807ee63afd1cd7915e34
https://github.com/pdonis
pdonishttps://github.com/pdonis
Feb 21, 2020https://github.com/python/cpython/pull/17385#issuecomment-589494119
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/aeros
aeroshttps://github.com/aeros
Feb 21, 2020https://github.com/python/cpython/pull/17385#issuecomment-589518596
@zwarehttps://github.com/zware
@miss-islingtonhttps://github.com/miss-islington
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Feb 21, 2020 https://github.com/python/cpython/pull/17385#pullrequestreview-362853785
View reviewed changes https://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34
Lib/doctest.pyhttps://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Feb 21, 2020 https://github.com/python/cpython/pull/17385#pullrequestreview-362877010
View reviewed changes https://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34
Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
ammaraskarhttps://github.com/ammaraskar
Feb 21, 2020https://github.com/python/cpython/pull/17385#discussion_r382774736
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/master/Lib/test/test_importlib/fixtures.pyhttps://github.com/python/cpython/blob/master/Lib/test/test_importlib/fixtures.py
cpython/Lib/test/test_importlib/fixtures.pyhttps://github.com/python/cpython/blob/fd5116c0e77aec05f67fb24f10562ac920648035/Lib/test/test_importlib/fixtures.py#L71-L83
fd5116chttps://github.com/python/cpython/commit/fd5116c0e77aec05f67fb24f10562ac920648035
cpython/Lib/test/test_importlib/fixtures.pyhttps://github.com/python/cpython/blob/fd5116c0e77aec05f67fb24f10562ac920648035/Lib/test/test_importlib/fixtures.py#L50-L56
fd5116chttps://github.com/python/cpython/commit/fd5116c0e77aec05f67fb24f10562ac920648035
Please reload this pagehttps://github.com/python/cpython/pull/17385
pdonishttps://github.com/pdonis
Feb 22, 2020https://github.com/python/cpython/pull/17385#discussion_r382895629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/pdonis
Merge branch 'master' into fix-issue-1812https://github.com/python/cpython/pull/17385/commits/4664f1ee68d3ea812f38c5b17ba8918467626c4c
4664f1ehttps://github.com/python/cpython/pull/17385/commits/4664f1ee68d3ea812f38c5b17ba8918467626c4c
https://github.com/pdonis
pdonishttps://github.com/pdonis
Feb 22, 2020https://github.com/python/cpython/pull/17385#issuecomment-589931009
@aeroshttps://github.com/aeros
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/pdonis
pdonishttps://github.com/pdonis
Mar 1, 2020https://github.com/python/cpython/pull/17385#issuecomment-593025656
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Mar 13, 2020 https://github.com/python/cpython/pull/17385#pullrequestreview-374603576
View reviewed changes https://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34
Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
brettcannonhttps://github.com/brettcannon
Mar 13, 2020https://github.com/python/cpython/pull/17385#discussion_r392456822
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17385
pdonishttps://github.com/pdonis
Mar 16, 2020https://github.com/python/cpython/pull/17385#discussion_r393226321
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17385
pdonishttps://github.com/pdonis
Mar 16, 2020https://github.com/python/cpython/pull/17385#discussion_r393228600
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
bb836d7https://github.com/python/cpython/commit/bb836d71b3743e8d00812f2535ad69b37080461b
Please reload this pagehttps://github.com/python/cpython/pull/17385
pdonishttps://github.com/pdonis
March 16, 2020 14:17https://github.com/python/cpython/pull/17385#commits-pushed-860f835
https://github.com/pdonis
Merge branch 'master' into fix-issue-1812https://github.com/python/cpython/pull/17385/commits/860f835e8df6309e676f16b505914caade30b66a
860f835https://github.com/python/cpython/pull/17385/commits/860f835e8df6309e676f16b505914caade30b66a
https://github.com/pdonis
bpo-1812: Change TestLoader to TestImporter.https://github.com/python/cpython/pull/17385/commits/bb836d71b3743e8d00812f2535ad69b37080461b
bb836d7https://github.com/python/cpython/pull/17385/commits/bb836d71b3743e8d00812f2535ad69b37080461b
https://github.com/pdonis
pdonishttps://github.com/pdonis
Mar 24, 2020https://github.com/python/cpython/pull/17385#issuecomment-602985698
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
zwarehttps://github.com/zware
March 24, 2020 19:06https://github.com/python/cpython/pull/17385#event-3161172877
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Mar 24, 2020https://github.com/python/cpython/pull/17385#issuecomment-603450210
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/zware
zwarehttps://github.com/zware
Mar 26, 2020 https://github.com/python/cpython/pull/17385#pullrequestreview-382110806
View reviewed changes https://github.com/python/cpython/pull/17385/files/bb836d71b3743e8d00812f2535ad69b37080461b
zwarehttps://github.com/zware
https://github.com/python/cpython/pull/17385#pullrequestreview-382110806
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/17385
Lib/doctest.pyhttps://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
Please reload this pagehttps://github.com/python/cpython/pull/17385
Lib/test/test_doctest.pyhttps://github.com/python/cpython/pull/17385/files/83c03d8d09edc13c4901f534b9bb9c2915c4f02d#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 26, 2020https://github.com/python/cpython/pull/17385#event-3168878924
https://github.com/zware
zwarehttps://github.com/zware
e0b8101https://github.com/python/cpython/commit/e0b8101492f6c61dee831425b4d3dae39a953599
Mar 26, 2020https://github.com/python/cpython/pull/17385#event-3168894493
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020https://github.com/python/cpython/pull/17385#issuecomment-604510878
@pdonishttps://github.com/pdonis
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 26, 2020https://github.com/python/cpython/pull/17385#event-3168894700
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020 https://github.com/python/cpython/pull/17385#ref-commit-c98f1f5
https://github.com/pdonis
https://github.com/miss-islington
bpo-1812: Fix newline conversion when doctest.testfile loads from a p…https://github.com/miss-islington/cpython/commit/c98f1f51cf5ce63218bf67387fc191e999bb5d18
c98f1f5https://github.com/miss-islington/cpython/commit/c98f1f51cf5ce63218bf67387fc191e999bb5d18
pythonGH-17385https://github.com/python/cpython/pull/17385
e0b8101https://github.com/miss-islington/cpython/commit/e0b8101492f6c61dee831425b4d3dae39a953599
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Mar 26, 2020https://github.com/python/cpython/pull/17385#event-3168895588
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 26, 2020https://github.com/python/cpython/pull/17385#issuecomment-604511010
GH-19175https://github.com/python/cpython/pull/19175
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/17385
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020 https://github.com/python/cpython/pull/17385#ref-commit-a24ef3c
https://github.com/pdonis
https://github.com/miss-islington
bpo-1812: Fix newline conversion when doctest.testfile loads from a p…https://github.com/miss-islington/cpython/commit/a24ef3cac27c87d90ac10e794762c9ba50e95ac4
a24ef3chttps://github.com/miss-islington/cpython/commit/a24ef3cac27c87d90ac10e794762c9ba50e95ac4
pythonGH-17385https://github.com/python/cpython/pull/17385
e0b8101https://github.com/miss-islington/cpython/commit/e0b8101492f6c61dee831425b4d3dae39a953599
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 26, 2020https://github.com/python/cpython/pull/17385#issuecomment-604511085
GH-19176https://github.com/python/cpython/pull/19176
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Mar 26, 2020https://github.com/python/cpython/pull/17385#event-3168896138
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020 https://github.com/python/cpython/pull/17385#ref-commit-b05fbe9
https://github.com/miss-islington
https://github.com/pdonis
bpo-1812https://bugs.python.org/issue?@action=redirect&bpo=1812
: Fix newline conversion when doctest.testfile loads from a p…https://github.com/python/cpython/commit/b05fbe9f374bc660af3c589a1146b2026606d442
b05fbe9https://github.com/python/cpython/commit/b05fbe9f374bc660af3c589a1146b2026606d442
GH-17385https://github.com/python/cpython/pull/17385
bpo-1812https://bugs.python.org/issue?@action=redirect&bpo=1812
e0b8101https://github.com/python/cpython/commit/e0b8101492f6c61dee831425b4d3dae39a953599
miss-islingtonhttps://github.com/miss-islington
Mar 26, 2020 https://github.com/python/cpython/pull/17385#ref-commit-9387678
https://github.com/miss-islington
https://github.com/pdonis
bpo-1812https://bugs.python.org/issue?@action=redirect&bpo=1812
: Fix newline conversion when doctest.testfile loads from a p…https://github.com/python/cpython/commit/9387678f8a580726aca5f836b2c50456f236ecbb
9387678https://github.com/python/cpython/commit/9387678f8a580726aca5f836b2c50456f236ecbb
GH-17385https://github.com/python/cpython/pull/17385
bpo-1812https://bugs.python.org/issue?@action=redirect&bpo=1812
e0b8101https://github.com/python/cpython/commit/e0b8101492f6c61dee831425b4d3dae39a953599
https://github.com/pdonis
pdonishttps://github.com/pdonis
Mar 26, 2020https://github.com/python/cpython/pull/17385#issuecomment-604656184
@zwarehttps://github.com/zware
@brettcannonhttps://github.com/brettcannon
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/pdonis
pdonishttps://github.com/pdonis
March 28, 2020 03:11https://github.com/python/cpython/pull/17385#event-3174590134
https://github.com/merwok
merwokhttps://github.com/merwok
Jan 28, 2021 https://github.com/python/cpython/pull/17385#ref-pullrequest-795604897
bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion #24359 https://github.com/python/cpython/pull/24359
zwarehttps://github.com/zware
Mar 2, 2021 https://github.com/python/cpython/pull/17385#ref-commit-b36349a
https://github.com/pdonis
bpo-43049https://bugs.python.org/issue?@action=redirect&bpo=43049
: Use io.IncrementalNewlineDecoder for doctest newline conve…https://github.com/python/cpython/commit/b36349a647b2bf8174f0e736a4fc347e92ae204e
b36349ahttps://github.com/python/cpython/commit/b36349a647b2bf8174f0e736a4fc347e92ae204e
GH-24359https://github.com/python/cpython/pull/24359
bpo-1812https://bugs.python.org/issue?@action=redirect&bpo=1812
GH-17385https://github.com/python/cpython/pull/17385
https://github.com/sthagen
sthagenhttps://github.com/sthagen
Mar 2, 2021 https://github.com/python/cpython/pull/17385#ref-pullrequest-820378647
bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conve… sthagen/python-cpython#412 https://github.com/sthagen/python-cpython/pull/412
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F17385
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34
https://github.com/ammaraskar
ammaraskar https://github.com/ammaraskar
https://github.com/python/cpython/pull/17385/files/e1f0a2fa466138febe2f807ee63afd1cd7915e34
https://github.com/zware
zware https://github.com/zware
https://github.com/python/cpython/pull/17385/files/bb836d71b3743e8d00812f2535ad69b37080461b
Please reload this pagehttps://github.com/python/cpython/pull/17385
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/17385
https://github.com/pdonis
https://github.com/aeros
https://github.com/zware
https://github.com/bedevere-bot
https://github.com/brettcannon
https://github.com/miss-islington
https://github.com/ammaraskar
https://github.com/gpshead
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.