René's URL Explorer Experiment


Title: bpo-25532: Protect against infinite loops in inspect.unwrap() by takluyver · Pull Request #1717 · python/cpython · GitHub

Open Graph Title: bpo-25532: Protect against infinite loops in inspect.unwrap() by takluyver · Pull Request #1717 · python/cpython

X Title: bpo-25532: Protect against infinite loops in inspect.unwrap() by takluyver · Pull Request #1717 · python/cpython

Description: Some objects, such as unittest.mock.call, generate a new similar object every time you access obj.__wrapped__. This isn't caught by the memoise loop protection, because each object has a different ID. So a call like inspect.getsourcelines(unittest.mock.call) goes into an infinite loop, using ever more memory as it creates new objects. This implements @ncoghlan's suggestion in issue 22532: if we've unwrapped something sys.getrecursionlimit() times, assume it's an infinite chain and give up. Things like getsourcelines() will fail, but an exception is better than using up all the memory. IPython's inspection machinery already has a similar check, with an arbitrary limit of 100 unwraps. That returns the original object if the limit is exceeded, rather than throwing an error. https://github.com/ipython/ipython/blob/6.0.0/IPython/core/oinspect.py#L279

Open Graph Description: Some objects, such as unittest.mock.call, generate a new similar object every time you access obj.__wrapped__. This isn't caught by the memoise loop protection, because each object has a differ...

X Description: Some objects, such as unittest.mock.call, generate a new similar object every time you access obj.__wrapped__. This isn't caught by the memoise loop protection, because each object has a di...

Opengraph URL: https://github.com/python/cpython/pull/1717

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8c2ad416-ef6a-f8fd-84ed-743516352092
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id824A:102136:B2E127:EE041D:6B004A2D
html-safe-nonce17166dfbb71b0da2137a8bbae1a7ae40afb2c59ccb32a8c8a2b11a484340272b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjRBOjEwMjEzNjpCMkUxMjc6RUUwNDFEOjZCMDA0QTJEIiwidmlzaXRvcl9pZCI6IjQ1MTI2NjA5OTIyNTI5ODc5NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1abe5fb97e349eff5917ede59d3c100d94db97a52b825d9ff56378229efc7d1e
hovercard-subject-tagpull_request:121763688
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/1717/files
twitter:imagehttps://avatars.githubusercontent.com/u/327925?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/327925?s=400&v=4
og:image:altSome objects, such as unittest.mock.call, generate a new similar object every time you access obj.__wrapped__. This isn't caught by the memoise loop protection, because each object has a differ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1717/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1717%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1717%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1717/files
Reloadhttps://github.com/python/cpython/pull/1717/files
Reloadhttps://github.com/python/cpython/pull/1717/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ncoghlanhttps://github.com/ncoghlan
python:masterhttps://github.com/python/cpython/tree/master
takluyver:unwrap-finitehttps://github.com/takluyver/cpython/tree/unwrap-finite
Conversation 13 https://github.com/python/cpython/pull/1717
Commits 5 https://github.com/python/cpython/pull/1717/commits
Checks 0 https://github.com/python/cpython/pull/1717/checks
Files changed https://github.com/python/cpython/pull/1717/files
Please reload this pagehttps://github.com/python/cpython/pull/1717/files
bpo-25532: Protect against infinite loops in inspect.unwrap() https://github.com/python/cpython/pull/1717/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/1717/files
e0d4789 Protect against infinite loops in inspect.unwrap() takluyver May 22, 2017 https://github.com/python/cpython/pull/1717/commits/e0d478936c2288957e004bf2853e24f78502a867
87c0c0e Add note about bpo-25532 in NEWS takluyver May 22, 2017 https://github.com/python/cpython/pull/1717/commits/87c0c0e4a93c6cc284f8295a690f58b925461d8a
2cb0a18 Add test for infinite loop protection in inspect.unwrap() takluyver May 22, 2017 https://github.com/python/cpython/pull/1717/commits/2cb0a18450ef5e634123eb4539cc24961a1e02e7
b12a0ac Change memo set to a dict takluyver May 22, 2017 https://github.com/python/cpython/pull/1717/commits/b12a0ac8e640c63b5a52a8319a4064743935d198
553df25 Use len(memo) instead of a separate unwrap_count takluyver May 22, 2017 https://github.com/python/cpython/pull/1717/commits/553df2589559645a617faeeb2364cfa6aab8f6ef
Clear filters https://github.com/python/cpython/pull/1717/files
Please reload this pagehttps://github.com/python/cpython/pull/1717/files
Please reload this pagehttps://github.com/python/cpython/pull/1717/files
inspect.py https://github.com/python/cpython/pull/1717/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
test_inspect.py https://github.com/python/cpython/pull/1717/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
NEWS https://github.com/python/cpython/pull/1717/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
Lib/inspect.pyhttps://github.com/python/cpython/pull/1717/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
View file https://github.com/takluyver/cpython/blob/553df2589559645a617faeeb2364cfa6aab8f6ef/Lib/inspect.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1717/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1717/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
https://github.com/python/cpython/pull/1717/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
Lib/test/test_inspect.pyhttps://github.com/python/cpython/pull/1717/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
View file https://github.com/takluyver/cpython/blob/553df2589559645a617faeeb2364cfa6aab8f6ef/Lib/test/test_inspect.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1717/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1717/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com/python/cpython/pull/1717/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com/python/cpython/pull/1717/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com/python/cpython/pull/1717/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
Misc/NEWShttps://github.com/python/cpython/pull/1717/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
View file https://github.com/takluyver/cpython/blob/553df2589559645a617faeeb2364cfa6aab8f6ef/Misc/NEWS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1717/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1717/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
https://github.com/python/cpython/pull/1717/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.