| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b2f70e08-c4ef-11a7-94a8-bc7669f9d536 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D82C:C07BE:198264:21D94D:6969BDC4 |
| html-safe-nonce | 31794704ec6d26843343649d487ffc1460f58bf36d9fc2b72c6859f407f2f21a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODJDOkMwN0JFOjE5ODI2NDoyMUQ5NEQ6Njk2OUJEQzQiLCJ2aXNpdG9yX2lkIjoiODk4MjY1NjcxODE2MzUyNTA2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4c87538fc0b8da99aa947114f4bd70eff303a13c2e5032680c4f9246960db85f |
| hovercard-subject-tag | pull_request:334121175 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/16991/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5b2c5ec15bc0191ca6549270fd63c2b311f6127c7b05a283a1a92c04ec3db5c1/python/cpython/pull/16991 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b2c5ec15bc0191ca6549270fd63c2b311f6127c7b05a283a1a92c04ec3db5c1/python/cpython/pull/16991 |
| og:image:alt | https://bugs.python.org/issue38639 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | serhiy-storchaka |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/16991#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16991 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16991 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/16991 |
| Reload | https://github.com/python/cpython/pull/16991 |
| Reload | https://github.com/python/cpython/pull/16991 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/16991#issue-comment-box |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:master | https://github.com/python/cpython/tree/master |
| serhiy-storchaka:math-floor-float | https://github.com/serhiy-storchaka/cpython/tree/math-floor-float |
|
bpo-38639: Optimize floor(), ceil() and trunc() for floats.
| https://github.com/python/cpython/pull/16991#top |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:master | https://github.com/python/cpython/tree/master |
| serhiy-storchaka:math-floor-float | https://github.com/serhiy-storchaka/cpython/tree/math-floor-float |
|
Conversation
8
| https://github.com/python/cpython/pull/16991 |
|
Commits
3
| https://github.com/python/cpython/pull/16991/commits |
|
Checks
0
| https://github.com/python/cpython/pull/16991/checks |
|
Files changed
| https://github.com/python/cpython/pull/16991/files |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Oct 30, 2019 | https://github.com/python/cpython/pull/16991#issue-514516998 |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
| https://bugs.python.org/issue38639 | https://bugs.python.org/issue38639 |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
|
| https://github.com/serhiy-storchaka |
| bpo-38639: Optimize floor(), ceil() and trunc() for floats. | https://github.com/python/cpython/pull/16991/commits/d80f7bdc8de2a32f1d31b85ca2aaf95df91b49ff |
| d80f7bd | https://github.com/python/cpython/pull/16991/commits/d80f7bdc8de2a32f1d31b85ca2aaf95df91b49ff |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Oct 30, 2019 | https://github.com/python/cpython/pull/16991#event-2755211486 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 30, 2019 | https://github.com/python/cpython/pull/16991#event-2755211572 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
|
Oct 30, 2019
| https://github.com/python/cpython/pull/16991#pullrequestreview-309454653 |
|
View reviewed changes
| https://github.com/python/cpython/pull/16991/files/d80f7bdc8de2a32f1d31b85ca2aaf95df91b49ff |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/16991/files/d80f7bdc8de2a32f1d31b85ca2aaf95df91b49ff#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
|
Oct 30, 2019
| https://github.com/python/cpython/pull/16991#pullrequestreview-309458990 |
|
View reviewed changes
| https://github.com/python/cpython/pull/16991/files/d80f7bdc8de2a32f1d31b85ca2aaf95df91b49ff |
| mdickinson | https://github.com/mdickinson |
| https://github.com/python/cpython/pull/16991#pullrequestreview-309458990 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 30, 2019 | https://github.com/python/cpython/pull/16991#event-2757324848 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
| Oct 30, 2019 | https://github.com/python/cpython/pull/16991#issuecomment-548075779 |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Oct 30, 2019
| https://github.com/python/cpython/pull/16991#ref-pullrequest-513966176 |
|
bpo-38629: implement __floor__ and __ceil__ for float
#16985
| https://github.com/python/cpython/pull/16985 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| October 30, 2019 22:23 | https://github.com/python/cpython/pull/16991#commits-pushed-265271a |
|
| https://github.com/serhiy-storchaka |
| Get rid of math_1_to_int. | https://github.com/python/cpython/pull/16991/commits/265271aaaa44443682e633eb0be3950bbe3d20cb |
| 265271a | https://github.com/python/cpython/pull/16991/commits/265271aaaa44443682e633eb0be3950bbe3d20cb |
|
| https://github.com/serhiy-storchaka |
| Add tests. | https://github.com/python/cpython/pull/16991/commits/864845af6ff17a5e43a0844f0079410eba6d6a4a |
| 864845a | https://github.com/python/cpython/pull/16991/commits/864845af6ff17a5e43a0844f0079410eba6d6a4a |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Nov 7, 2019 | https://github.com/python/cpython/pull/16991#issuecomment-551252774 |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Nov 7, 2019 | https://github.com/python/cpython/pull/16991#issuecomment-551253215 |
| @mdickinson | https://github.com/mdickinson |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| 5fd5cb8 | https://github.com/python/cpython/commit/5fd5cb8d85fab3393dd76c7f3de1cdeb8ecf7203 |
| Nov 16, 2019 | https://github.com/python/cpython/pull/16991#event-2804847994 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| November 16, 2019 16:00 | https://github.com/python/cpython/pull/16991#event-2804848005 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Nov 16, 2019 | https://github.com/python/cpython/pull/16991#event-2804848026 |
| jacobneiltaylor | https://github.com/jacobneiltaylor |
|
Dec 5, 2019
| https://github.com/python/cpython/pull/16991#ref-commit-cd75b1f |
|
| https://github.com/serhiy-storchaka |
| bpo-38639: Optimize floor(), ceil() and trunc() for floats. ( | https://github.com/jacobneiltaylor/cpython/commit/cd75b1f9db6e32975ea4d6853b848984cee6fd31 |
| pythonGH… | https://github.com/python/cpython/pull/16991 |
| cd75b1f | https://github.com/jacobneiltaylor/cpython/commit/cd75b1f9db6e32975ea4d6853b848984cee6fd31 |
| …-16991 | https://github.com/python/cpython/pull/16991 |
| shihai1991 | https://github.com/shihai1991 |
|
Jan 31, 2020
| https://github.com/python/cpython/pull/16991#ref-commit-0166988 |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/shihai1991 |
| bpo-38639: Optimize floor(), ceil() and trunc() for floats. ( | https://github.com/shihai1991/cpython/commit/01669882e6ebdd51c7c7323e0b26934b56198272 |
| pythonGH… | https://github.com/python/cpython/pull/16991 |
| 0166988 | https://github.com/shihai1991/cpython/commit/01669882e6ebdd51c7c7323e0b26934b56198272 |
| …-16991 | https://github.com/python/cpython/pull/16991 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
|
Feb 9, 2023
| https://github.com/python/cpython/pull/16991#ref-pullrequest-1577452691 |
|
gh-101678: Merge math_1_to_whatever() and math_1()
#101730
| https://github.com/python/cpython/pull/101730 |
| mdickinson | https://github.com/mdickinson |
|
Feb 9, 2023
| https://github.com/python/cpython/pull/16991#ref-commit-45fa12a |
|
| https://github.com/skirpichev |
| gh-101678 | https://github.com/python/cpython/issues/101678 |
| : Merge math_1_to_whatever() and math_1() ( | https://github.com/python/cpython/commit/45fa12aec8f508c224a1521cfe3ae597f1026264 |
| #101730 | https://github.com/python/cpython/pull/101730 |
| ) | https://github.com/python/cpython/commit/45fa12aec8f508c224a1521cfe3ae597f1026264 |
| 45fa12a | https://github.com/python/cpython/commit/45fa12aec8f508c224a1521cfe3ae597f1026264 |
| gh-16991 | https://github.com/python/cpython/pull/16991 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16991 |
|
| https://github.com/mdickinson |
|
mdickinson
| https://github.com/mdickinson |
|
| https://github.com/python/cpython/pull/16991/files/d80f7bdc8de2a32f1d31b85ca2aaf95df91b49ff |
| Please reload this page | https://github.com/python/cpython/pull/16991 |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/mdickinson |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |