René's URL Explorer Experiment

Title: bpo-38603: Inherit docstrings in dynamically generated subclasses if possible by anntzer · Pull Request #16957 · python/cpython · GitHub

Open Graph Title: bpo-38603: Inherit docstrings in dynamically generated subclasses if possible by anntzer · Pull Request #16957 · python/cpython

X Title: bpo-38603: Inherit docstrings in dynamically generated subclasses if possible by anntzer · Pull Request #16957 · python/cpython

Description: Currently, inspect.getdoc() fails to inherit docstrings in dynamically generated subclasses, such as class Base: def method(self): "some docstring" def make_subclass(): class subclass(Base): def method(self): return super().method() return subclass subclass = make_subclass() inspect.getdoc(subclass.method) # => returns None because inspect._findclass() tries to find the base class by parsing subclass.method.__qualname__ which is "make_subclass..subclass.method" and chokes over ... In the case where the method does rely on super(), there is another way we can go back to the "owning" class of the method: by looking up the contents of the __class__ cell (which is set up to make 0-arg super()). This approach is implemented by this PR. Perhaps a __class__ cell could even be set up (in a separate patch) for all methods defined in dynamically created subclasses (i.e. whose __qualname__ includes ..), to help with introspection? https://bugs.python.org/issue38603

Open Graph Description: Currently, inspect.getdoc() fails to inherit docstrings in dynamically generated subclasses, such as class Base: def method(self): "some docstring" def make_subclass(): class sub...

X Description: Currently, inspect.getdoc() fails to inherit docstrings in dynamically generated subclasses, such as class Base: def method(self): "some docstring" def make_subclass(): c...

Opengraph URL: https://github.com/python/cpython/pull/16957

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width